Page MenuHomePhabricator
Feed All Stories

Feb 25 2016

ianvkoeppe closed Q321: Diffusion Setup Mac OSX as resolved.
Feb 25 2016, 3:30 PM · Diffusion
nickz added a comment to T10447: When the push phase of "Land Revision" fails, show the error in the UI.

When I put var_dump() in other parts of the code, I can see the output from /var/log/apache/error.log, but just can't see any output for the ones I mentioned above.

Feb 25 2016, 3:26 PM · Drydock (v3)
epriestley renamed T10449: Almanac v2 (Unprototype) from Almanac v1 (Unprototype) to Almanac v2 (Unprototype).
Feb 25 2016, 2:06 PM · Almanac (v2), Phacility
epriestley added a revision to T10449: Almanac v2 (Unprototype): Unknown Object (Differential Revision).
Feb 25 2016, 2:05 PM · Almanac (v2), Phacility
epriestley created T10449: Almanac v2 (Unprototype).
Feb 25 2016, 1:40 PM · Almanac (v2), Phacility
epriestley added a comment to T9762: Removing devices from Almanac services.

Er, almanac.service.search, rather.

Feb 25 2016, 1:00 PM · Almanac (v2)
epriestley added a comment to T9762: Removing devices from Almanac services.

D15345 adds these capabilities:

Feb 25 2016, 1:00 PM · Almanac (v2)
epriestley added a revision to T9762: Removing devices from Almanac services: Unknown Object (Differential Revision).
Feb 25 2016, 12:56 PM · Almanac (v2)
epriestley added a revision to T10246: Deploy Drydock in the Phacility cluster: Unknown Object (Differential Revision).
Feb 25 2016, 12:56 PM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley closed T6741: Lock Almanac networks, and allow Almanac domain namespaces to be locked as Resolved by committing Restricted Diffusion Commit.
Feb 25 2016, 11:38 AM · Almanac (v2), Security, Phacility
epriestley closed T6741: Lock Almanac networks, and allow Almanac domain namespaces to be locked, a subtask of T5833: Build "Almanac", a service/host/device directory, as Resolved.
Feb 25 2016, 11:38 AM · Phacility, Almanac
epriestley closed T6741: Lock Almanac networks, and allow Almanac domain namespaces to be locked, a subtask of T10246: Deploy Drydock in the Phacility cluster, as Resolved.
Feb 25 2016, 11:38 AM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
clemvangelis added a project to T5229: Fixing up invalid encoding confuses archanists utf8-check: Bug Report.

I can confirm this behavior. Is there any way to fix that ?

Feb 25 2016, 11:34 AM · Bug Report, Arcanist
epriestley added a comment to T10447: When the push phase of "Land Revision" fails, show the error in the UI.

I think var_dump() will normally be hard to observe, since it will go to stdout but that isn't connected to anything by default so it will just vanish (we don't write stdout to the daemon log). My guess is that the code is running, you just aren't seeing the var_dump() output.

Feb 25 2016, 11:20 AM · Drydock (v3)
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Feb 25 2016, 11:09 AM · Prioritized, Diffusion (v3), KDE, Restricted Project
• sevendays added a comment to T4181: Document (the lack of) init scripts for phd, and be more explicit about `phd launch`.

@sinayion don't start the phd service before mysql. The daemons need the database to be active.
I'd start phd after http and mysql are up and running.

Feb 25 2016, 10:58 AM · Phabricator
wschroo awarded T4900: Workboards updating in real time a Like token.
Feb 25 2016, 10:43 AM · Workboards (v3), User Delight, Wikimedia
wschroo awarded T5051: Burn down charts for Milestones a Like token.
Feb 25 2016, 10:42 AM · Restricted Project, Projects, Wikimedia
wschroo awarded T4863: Allow Workboard Cards to be customized for display a Like token.
Feb 25 2016, 10:42 AM · Projects, Wikimedia, Workboards
thetorpedodog awarded T9001: test a Baby Tequila token.
Feb 25 2016, 4:01 AM · Conpherence

Feb 24 2016

nickz added a comment to T10447: When the push phase of "Land Revision" fails, show the error in the UI.

It looks like "git push" in DrydockLandRepositoryOperation.php doesn't get executed.
I put some var_dump as the following, and click "Land Revision", but no related log printed out.

Feb 24 2016, 11:51 PM · Drydock (v3)
ipatrol added a comment to T9720: Provide a way to link to Diffusion files.

I think the most natural syntax (and the one I tried before discovering it didn't work!) would be to allow one to basically copy-paste the existing path at the top of file pages (the one inside the phui-header-header element), so that for example, a link to Diffusion's readme file on here would be: rP/README.md
And to link to, say, a specific line of a specific revision: rPbe0e84a81abc/README.md$17
And likewise for ranges: rPbe0e84a81abc/README.md$5-13

Feb 24 2016, 9:42 PM · Restricted Project, Remarkup
epriestley added a comment to T4427: Add formal task points.

Let me know if you hit issues -- it should just be better in every way than maniphest.query was, but I might have missed some data or something like that.

Feb 24 2016, 9:02 PM · Wikimedia, Maniphest, Workboards
rfreebern added a comment to T4427: Add formal task points.

Ah, thank you. I'll update to use that.

Feb 24 2016, 8:59 PM · Wikimedia, Maniphest, Workboards
epriestley added a comment to T4427: Add formal task points.

Broadly, *.search and *.edit endpoint are replacing older *.query and *.variousnameslikeupdate endpoints, see:

Feb 24 2016, 8:58 PM · Wikimedia, Maniphest, Workboards
Firehed closed T10420: Code coverage reports from `arc unit` are sometimes inaccurate as Resolved by committing Restricted Diffusion Commit.
Feb 24 2016, 8:58 PM · Arcanist, Bug Report
epriestley added a comment to T4427: Add formal task points.

It's present in maniphest.search.

Feb 24 2016, 8:57 PM · Wikimedia, Maniphest, Workboards
epriestley added a member for Blessed Committers: Firehed.
Feb 24 2016, 8:56 PM
rfreebern added a comment to T4427: Add formal task points.

I noticed today that the maniphest.points field doesn't appear in the Conduit output for e.g. maniphest.query. I can't find a task addressing this, but it would be very helpful (I have several scripts that used our auxiliary points field, but since migrating that to maniphest.points they don't work any more).

Feb 24 2016, 8:55 PM · Wikimedia, Maniphest, Workboards
Firehed added a revision to T10420: Code coverage reports from `arc unit` are sometimes inaccurate: Unknown Object (Differential Revision).
Feb 24 2016, 8:55 PM · Arcanist, Bug Report
AndreasSchumacher added a comment to T10436: Enhance the API (project.query) to find parent- and/or subprojects.

My overall goal is to create a changelog automatically from the resolved tasks in Maniphest and I want to sort the changelog entries by category (like "GUI", "I/O", "Setup", "Documentation" etc.)

Feb 24 2016, 8:53 PM · Restricted Project, Projects, Feature Request
epriestley added a comment to T10420: Code coverage reports from `arc unit` are sometimes inaccurate.

Sure, happy to bring those both upstream.

Feb 24 2016, 8:42 PM · Arcanist, Bug Report
Firehed added a comment to T10420: Code coverage reports from `arc unit` are sometimes inaccurate.

Implementation of what's described above - also seems to provide the expected results in my case, and limits impact to PHPUnit results. If a file is executed at all, it should show up normally; when completely untouched (which tends to show up with phpunit whitelisting, now necessary in the newest versions).

Feb 24 2016, 8:40 PM · Arcanist, Bug Report
jonathanrseawright awarded T4103: Implement "Role Profiles" to provide search, homepage and application defaults a Love token.
Feb 24 2016, 8:17 PM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
tflink edited the content of Community Resources.
Feb 24 2016, 8:06 PM
Luke081515.2 created T10448: Modularize mail tags.
Feb 24 2016, 7:38 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
urzds added a comment to T10412: Change Milestone sort options.

Our use-case: We usually plan our tasks max. 3-4 milestones in advance and the one currently being worked on is the most important / most looked at. We archive milestones that belong to the past (after moving all tasks to current / future milestones).

Feb 24 2016, 5:53 PM · Feature Request
Firehed added a comment to T10420: Code coverage reports from `arc unit` are sometimes inaccurate.

That seems totally reasonable. It seems like a bit of a stretch for PHP code specifically, but sane as a general-purpose answer.

Feb 24 2016, 5:36 PM · Arcanist, Bug Report
epriestley updated subscribers of T7829: PhabricatorBotFeedNotificationHandler is completely broken and unusable.
Feb 24 2016, 5:25 PM · Conpherence, Phabot
epriestley merged task T10404: Ignore list for PhabricatorBotObjectNameHandler into T7829: PhabricatorBotFeedNotificationHandler is completely broken and unusable.
Feb 24 2016, 5:25 PM · Phabot
epriestley added a comment to T10447: When the push phase of "Land Revision" fails, show the error in the UI.

Oh, this is probably actually $operation->setWorkingCopyVCSError(...);

Feb 24 2016, 5:23 PM · Drydock (v3)
epriestley updated subscribers of T10447: When the push phase of "Land Revision" fails, show the error in the UI.

To fix this:

Feb 24 2016, 5:22 PM · Drydock (v3)
quailman38 added a comment to T10412: Change Milestone sort options.

Makes sense. Don't change it on my behalf then, I can see how this would benefit teams that plan sprints/milestones way far out.

Feb 24 2016, 5:16 PM · Feature Request
epriestley added a comment to T10412: Change Milestone sort options.

See T8227 for discussion of why adding an option is a measure of last resort.

Feb 24 2016, 5:13 PM · Feature Request
quailman38 added a comment to T10412: Change Milestone sort options.

Could it be a config option for projects for milestone sort order, newest -> oldest or oldest -> newest? It would be nice to customize it.

Feb 24 2016, 5:12 PM · Feature Request
epriestley added a comment to T10446: Unable to simply mark a Diffusion comment as Done.

Ah, I missed "In Diffusion". Let me see if I can reproduce there.

Feb 24 2016, 4:58 PM · Audit, Bug Report
joshkel added a comment to T10446: Unable to simply mark a Diffusion comment as Done.

Your steps match mine. However, I'm not getting an "Action With No Effect" prompt; instead, the server acts like it's processing, and redisplays the page, but doesn't actually make any changes.

Feb 24 2016, 4:57 PM · Audit, Bug Report
epriestley added a comment to T10412: Change Milestone sort options.

I'm not strongly attached to this behavior and don't mind swapping it and seeing how much pushback we get, it just seemed like the much better behavior at scale, and seeing it use on the Trello meta-board suggested to me that it was reasonable and possibly familiar to users coming from Trello:

Feb 24 2016, 4:51 PM · Feature Request
chad added a comment to T10444: Ever make a mistake? Catch it before its too late.??.

oh! sorry.

Feb 24 2016, 4:50 PM
• wuup added a comment to T10444: Ever make a mistake? Catch it before its too late.??.

:( I was just trying to help with the clear up of nonsense. I was looking for a way to close the task, but I thought at least I could remove one by merging.

Feb 24 2016, 4:45 PM
chad added a comment to T9897: Unbeta Feedback on Phame.

Looks like maybe Macros aren't visible to outside people. Found https://phabricator.wikimedia.org/phame/post/view/1/what_s_new_lots_of_improvements_on_phabricator.wikimedia.org/

Feb 24 2016, 4:43 PM · Phame
cburroughs added a comment to T10412: Change Milestone sort options.

Change milestoneNumber in phabricator_project.project to reorder milestones.

Feb 24 2016, 4:43 PM · Feature Request
epriestley added a comment to T10444: Ever make a mistake? Catch it before its too late.??.

@wuup, I undisabled you since I think you weren't part of the "click shiny buttons" activity this morning.

Feb 24 2016, 4:43 PM
epriestley updated subscribers of T10444: Ever make a mistake? Catch it before its too late.??.
Feb 24 2016, 4:41 PM
epriestley added a comment to T10444: Ever make a mistake? Catch it before its too late.??.

I think @wuup might have been an innocent bystander who was caught in the crossfire. Poor guy!

Feb 24 2016, 4:41 PM
epriestley added a comment to T10436: Enhance the API (project.query) to find parent- and/or subprojects.

Can you walk us through what broad, overall goal you're trying to accomplish more generally? See Contributing Feature Requests and Describing Root Problems for help describing root problems. As those documents repeatedly emphasize, it's really important for us to understand root problems.

Feb 24 2016, 4:36 PM · Restricted Project, Projects, Feature Request
epriestley added a comment to T2226: Include a setup test for gzip enabled on the server.

T4854 is also related.

Feb 24 2016, 4:32 PM · Setup
chad added a comment to T4854: Detect mod_pagespeed and warn the user, or don't break when it is enabled.

I dug this up: https://github.com/websharks/comet-cache/issues/234#issuecomment-49382000

Feb 24 2016, 4:31 PM · Setup
epriestley created T10447: When the push phase of "Land Revision" fails, show the error in the UI.
Feb 24 2016, 4:26 PM · Drydock (v3)
quailman38 added a comment to T10412: Change Milestone sort options.

Here is also the subproject order, I had to archive some projects because the board was too large/cumbersome with them activated. We usually plan 2-3 sprints out, with some tasks moving further out if something blocks them. This ordering really hurts us being able to effectively move or change tasks as needed:

Feb 24 2016, 4:25 PM · Feature Request
ftdysa added a comment to T10412: Change Milestone sort options.

The logic is that if you have 50 milestones, you are probably much more interested in milestones 50, 49 and 48 (this week / next week / last week) than milestone 1 (a year ago).

Feb 24 2016, 4:23 PM · Feature Request
epriestley added a comment to T10446: Unable to simply mark a Diffusion comment as Done.

I'm having trouble reproducing this -- I attempted to follow your steps, but didn't experience the issue. Here's what I did:

Feb 24 2016, 4:22 PM · Audit, Bug Report
quailman38 added a comment to T10412: Change Milestone sort options.

Here's how our main project board looks after the recent change:

Feb 24 2016, 4:19 PM · Feature Request
chad added a comment to T10412: Change Milestone sort options.

I'm not sure I'd be more interested in Milestone 50 vs. Milestone 1. My assumption is the next milestone up is the most immediately on the left. And the furthest one out time wise, is the furthest one away.

Feb 24 2016, 4:18 PM · Feature Request
quailman38 added a comment to T10412: Change Milestone sort options.

We archive milestones so they don't appear on the board anymore.

Feb 24 2016, 4:16 PM · Feature Request
epriestley added a comment to T10412: Change Milestone sort options.

The logic is that if you have 50 milestones, you are probably much more interested in milestones 50, 49 and 48 (this week / next week / last week) than milestone 1 (a year ago).

Feb 24 2016, 4:14 PM · Feature Request
epriestley added a comment to T10215: Provide tools to combat and recover from abuse.

One specific thing we're starting to see more of is test users signing up and bulk-associating or bulk-merging large numbers of tasks. There doesn't seem to be any specific intent behind this, but I think these UIs are shiny and make it easy to click a lot of buttons and have a large effect. Here's one such user on this install, who has registered three accounts just because they like clicking buttons so much:

Feb 24 2016, 4:13 PM · Abuse
joshkel created T10446: Unable to simply mark a Diffusion comment as Done.
Feb 24 2016, 4:11 PM · Audit, Bug Report
chad changed the visibility for T4854: Detect mod_pagespeed and warn the user, or don't break when it is enabled.
Feb 24 2016, 4:01 PM · Setup
epriestley added a comment to T10428: Behavior definitions not registered in some project dialogs.

See also T4854 -- mod_pagespeed is known to be incompatible with Phabricator, and should not be used.

Feb 24 2016, 3:53 PM · Bug Report (Needs Information)
tycho.tatitscheff awarded T10444: Ever make a mistake? Catch it before its too late.?? a The World Burns token.
Feb 24 2016, 3:42 PM
yelirekim awarded T10444: Ever make a mistake? Catch it before its too late.?? a The World Burns token.
Feb 24 2016, 3:25 PM
chad closed T10428: Behavior definitions not registered in some project dialogs as Invalid.

I am using the recent Bitnami Phabricator stack

Feb 24 2016, 3:09 PM · Bug Report (Needs Information)
chad closed T10445: Triggering Repository Updates as Invalid.
Feb 24 2016, 2:50 PM
chad closed T10444: Ever make a mistake? Catch it before its too late.?? as Invalid.
Feb 24 2016, 2:50 PM
chad closed T10442: What should code review look like to the reviewer? as Invalid.
Feb 24 2016, 2:49 PM
chad closed T10442: What should code review look like to the reviewer?, a subtask of T10440: Sample Process, as Invalid.
Feb 24 2016, 2:49 PM
chad closed T10441: What should code review look as Invalid.
Feb 24 2016, 2:49 PM
chad closed T10440: Sample Process as Invalid.
Feb 24 2016, 2:49 PM
tycho.tatitscheff removed projects from T10445: Triggering Repository Updates: Paste, Phacility Keystore Access, Diffusion.
Feb 24 2016, 2:49 PM
chad closed T10439: Persona as Invalid.
Feb 24 2016, 2:48 PM
chad closed T10438: Persona as Invalid.
Feb 24 2016, 2:47 PM
chad closed T10437: This Privacy Policy explains our practices regarding the collection, use and disclosure of information that we receive in connection with the phacility.com website or any of the applications, services, or support we make available (collectively, the "Service"). This Privacy Policy applies only to our Service and doesn't apply to any third-party websites, applications, services or tools, even if they are accessible through our Service. as Invalid.
Feb 24 2016, 2:47 PM · Arcanist
mavit added a comment to T10300: On branch "xyz", "arc land --onto xyz abc" does not result in update to "xyz" even when "xyz" is not ahead of the remote.

This has tripped me up a few times (maybe since arc was made great again?) and I think it happens when you do arc land foo instead of arc land in foo.

Feb 24 2016, 2:41 PM · Arcanist
ftdysa added a comment to T10412: Change Milestone sort options.

I'm also a bit confused why it is ordered Milestone 3 > Milestone 2 > Milestone 1. I would assume that the third milestone is the furthest target to hit and should be displayed on the right?

Feb 24 2016, 2:33 PM · Feature Request
stevex updated Q322: Do someone knows a tool that convert from Remarkup (Phabricator) wiki syntax to Mediawiki (Wikipedia) syntax? from to Do someone knows a tool that convert from Remarkup (Phabricator) wiki syntax to Mediawiki (Wikipedia) syntax?.
Feb 24 2016, 2:25 PM · Wikimedia, Phriction
• wuup awarded T10444: Ever make a mistake? Catch it before its too late.?? a The World Burns token.
Feb 24 2016, 1:53 PM
• wuup updated subscribers of T10444: Ever make a mistake? Catch it before its too late.??.
Feb 24 2016, 1:52 PM
• wuup merged task T10443: Ever make a mistake? Catch it before its too late.!! into T10444: Ever make a mistake? Catch it before its too late.??.
Feb 24 2016, 1:52 PM
• Persona created T10445: Triggering Repository Updates.
Feb 24 2016, 1:28 PM
tycho.tatitscheff removed 7 mock(s) for T9175: XHPAST doesn't build automatically: M1433: Global Search, M1443: bob, M1442: "onmouseover="while(1){alert(1)};", M1440: Trying to carry over inline comments to new revision, M1453: <--`<img/src=` onerror=alert(1)> --!>, M1455: Hovercard Explorations, M1460: Project - Grey Background.
Feb 24 2016, 12:33 PM · XHPAST, Arcanist
tycho.tatitscheff removed 1 task(s) for M1442: "onmouseover="while(1){alert(1)};": T9175: XHPAST doesn't build automatically.
Feb 24 2016, 12:33 PM
tycho.tatitscheff removed 1 task(s) for M1440: Trying to carry over inline comments to new revision: T9175: XHPAST doesn't build automatically.
Feb 24 2016, 12:33 PM
tycho.tatitscheff removed 1 task(s) for M1433: Global Search: T9175: XHPAST doesn't build automatically.
Feb 24 2016, 12:33 PM · Search
tycho.tatitscheff removed 1 task(s) for M1453: <--`<img/src=` onerror=alert(1)> --!>: T9175: XHPAST doesn't build automatically.
Feb 24 2016, 12:33 PM
tycho.tatitscheff removed 1 task(s) for M1455: Hovercard Explorations: T9175: XHPAST doesn't build automatically.
Feb 24 2016, 12:33 PM · Projects, Hovercards
tycho.tatitscheff removed 1 task(s) for M1460: Project - Grey Background: T9175: XHPAST doesn't build automatically.
Feb 24 2016, 12:33 PM · Projects (v3)
tycho.tatitscheff removed 1 task(s) for M1443: bob: T9175: XHPAST doesn't build automatically.
Feb 24 2016, 12:33 PM
tycho.tatitscheff removed a subtask for T9175: XHPAST doesn't build automatically: T10437: This Privacy Policy explains our practices regarding the collection, use and disclosure of information that we receive in connection with the phacility.com website or any of the applications, services, or support we make available (collectively, the "Service"). This Privacy Policy applies only to our Service and doesn't apply to any third-party websites, applications, services or tools, even if they are accessible through our Service..
Feb 24 2016, 12:32 PM · XHPAST, Arcanist
tycho.tatitscheff removed a parent task for T10437: This Privacy Policy explains our practices regarding the collection, use and disclosure of information that we receive in connection with the phacility.com website or any of the applications, services, or support we make available (collectively, the "Service"). This Privacy Policy applies only to our Service and doesn't apply to any third-party websites, applications, services or tools, even if they are accessible through our Service.: T9175: XHPAST doesn't build automatically.
Feb 24 2016, 12:32 PM · Arcanist