Page MenuHomePhabricator
Create Task
Maniphest T4854

Detect mod_pagespeed and warn the user, or don't break when it is enabled
Closed, ResolvedPublic
Actions

Description

I have installed my self hosted copy of Phabricator and I'm just starting to play around with it. I faced a strange behavior with editing tasks:

When inside a task and you use any of the following options:

  • Edit Dependencies
  • Edit Differential Revisions
  • Edit Pholio Mocks

these dialogues behave all in the way in that you cannot make any typing to their fields. Everything entered to them is instantly removed again, just as somebody keeps the backspace key pressed while you are trying to enter something.

I have tried this with Chrome and Firefox (both latest) on a Windows 7 machine and recorded it to a short screencast, you find at Youtube. In one of the callouts within that recording, I write that this is a task with a Phrequent tracker running on it. This is not of any importance, since it behaves the same without any tracking activated.

There's nothing printed to my PHP or Apache error logs. If you need any additional information, please let me know and I will deliver them as best as I can.

I'm on commit 28696d08ac424116e02c21ab071d0d6005184eb3 of phabricator, 6e597b292ad142be7840c523001eb897b1b05b6c of arcanist and 3ca028dec2e77ec8780c644f453b5700b606ab60 of libphutil, if this is of any importance.

PS: I somehow cannot reproduce it with the same browsers on this instance at secure.phabricator.com ... :/

Revisions and Commits

rP Phabricator
D12622rPffdc082852fe Add a wide range of HTTP-request-based setup checks

Related Objects
Search...

Event Timeline

Judge created this task.Apr 21 2014, 6:27 PM
Judge raised the priority of this task from to Needs Triage.
Judge updated the task description. (Show Details)
Judge changed the visibility from "Public (No Login Required)" to "All Users".
Judge updated the task description. (Show Details)
Judge added a subscriber: Judge.
chad added a subscriber: chad.Apr 21 2014, 6:30 PM

Are you able to repro on here the same problem?

chad added a comment.Apr 21 2014, 6:30 PM

(awesome video btw)

chad added a comment.Apr 21 2014, 6:31 PM

(oh I see the PS, nevermind).

chad added a subscriber: epriestley.Apr 21 2014, 6:42 PM

So my only rough guess at this is something is not connecting / being served on your static resources (js/css). We don't have other reports of this and can't reproduce (I tried with my Win7 copy) - obviously this is a well used interface.

Can you dig into a JS console and see if there are errors firing?

Judge added a comment.Apr 27 2014, 2:34 PM

I'm very sorry to answer this late!

I'd be glad to provide further information, but I do not know how to do JS debuging :( Would it help if you had access to the install? If so, please look at the issue at https://review.zoosau.de/T13 and use the following credentials:

User: demo
Pass: demo0815

If I can be of service with any logs or such, please let me know.

epriestley added a comment.Apr 27 2014, 2:40 PM

This is a Javascript error:

Screen_Shot_2014-04-27_at_7.36.36_AM.png (962×1 px, 128 KB)

It's not immediately obvious why that's happening, but I see something called "mod_pagespeed" being injected into the page source. My guess is that this software is interacting poorly with Phabricator and causing Javascript problems. Can you try disabling "mod_pagespeed"? It should be in your apache config, I think.

This page suggests you can turn it off by adding "ModPagespeed off" to the relevant vhost:

https://developers.google.com/speed/pagespeed/module/configuration

Judge added a comment.Apr 27 2014, 2:48 PM

Awesome! You are right - pagespeed is now disabled and all is working as expected!
I never had issues with it with other applications - so I did not suspect this. Thank you a lot! :)

epriestley renamed this task from Strange behavior when working with tasks to Detect mod_pagespeed and warn the user, or don't break when it is enabled.Apr 27 2014, 2:49 PM
epriestley triaged this task as Wishlist priority.

Cool. I'll leave this open since we should try to either detect this and warn users about it or fix whatever's breaking, but we probably won't get to it for a while. Thanks for setting up an account so we could look at the issue!

chad added a project: Setup.Dec 30 2014, 5:13 PM
epriestley mentioned this in T10120: Uncaught Error: JX.initBehavior(map): behavior(s) not registered: phabricator-object-selector.Jan 11 2016, 5:02 PM
epriestley mentioned this in T10428: Behavior definitions not registered in some project dialogs.Feb 24 2016, 3:53 PM
chad changed the visibility from "All Users" to "Public (No Login Required)".Feb 24 2016, 4:01 PM
chad added a comment.Feb 24 2016, 4:31 PM

I dug this up: https://github.com/websharks/comet-cache/issues/234#issuecomment-49382000

epriestley mentioned this in T2226: Include a setup test for gzip enabled on the server.Feb 24 2016, 4:32 PM
epriestley mentioned this in T11553: Add various "make an HTTP call" setup checks, and run them in parallel.Aug 29 2016, 4:21 PM
epriestley added a parent task: T11553: Add various "make an HTTP call" setup checks, and run them in parallel.
epriestley added a revision: D12622: Add a wide range of HTTP-request-based setup checks.Dec 8 2016, 11:37 PM
epriestley closed this task as Resolved by committing rPffdc082852fe: Add a wide range of HTTP-request-based setup checks.Dec 8 2016, 11:46 PM
epriestley added a commit: rPffdc082852fe: Add a wide range of HTTP-request-based setup checks.
Phabricator · Built by Phacility