Page MenuHomePhabricator

What should code review look
Closed, InvalidPublic

Description

For reviewing code, a given engineer should consider this their top time-wasting priority at any given moment. This is to say, when not actively producing and looking to take a break - say when one might check email or social networking sites before getting back to it - engineers should check their code review queue and seek to clear it. Further, in general, engineers should strive to give feedback within 24 hours, if not sooner as local work convention dictates.