Page MenuHomePhabricator
Feed All Stories

Feb 20 2016

thuffir added a comment to P1853 InsecureRemarkupGraphvizBlockInterpreter.php.

@epriestley I see. Thanks anyways. Nevertheless I am hoping that some hints are available at buddy rates :)

Feb 20 2016, 11:47 PM
epriestley added a comment to T10264: git clone using http hangs after update.

I think this is now resolved for PHP 5.6 at HEAD of master.

Feb 20 2016, 10:58 PM · Bug Report, Diffusion
chad added a comment to F1005563: profile.xhprof.

well ok then

Feb 20 2016, 8:26 PM
epriestley merged T10403: Unable to change default column in workboard into T5523: Make bulk moves easier on Workboards.
Feb 20 2016, 8:17 PM · Restricted Project, Workboards
epriestley merged task T10403: Unable to change default column in workboard into T5523: Make bulk moves easier on Workboards.
Feb 20 2016, 8:17 PM · Projects, Bug Report
epriestley added a comment to T10403: Unable to change default column in workboard.

I don't believe we've ever supported this.

Feb 20 2016, 8:14 PM · Projects, Bug Report
jasonfsmitty added a comment to T10403: Unable to change default column in workboard.

For context, I'm trying to convert some projects over to use milestones. Previously we were just using several independent projects. What I'm trying to do is change the default column in the milestone, so I can bulk move tasks from a workboard column in the 'old' project, and have them land in the right place.

Feb 20 2016, 8:10 PM · Projects, Bug Report
jasonfsmitty created T10403: Unable to change default column in workboard.
Feb 20 2016, 8:01 PM · Projects, Bug Report
• nagya added a comment to F1005563: profile.xhprof.

phabricator / $ git checkout stabil
Arcanist / $ git checkout stabil
libphutil / $ git checkout stabil

Feb 20 2016, 7:57 PM
• nagya awarded F1005563: profile.xhprof a The World Burns token.
Feb 20 2016, 7:56 PM
• nagya added a comment to F1005563: profile.xhprof.

When filing a bug report, you MUST include reproduction instructions. We can not help fix bugs we can not reproduce, and will not accept reports which omit reproduction instructions. See below for details.

Feb 20 2016, 7:55 PM
• nagya added a comment to F1005563: profile.xhprof.

When filing a bug report, you MUST include reproduction instructions. We can not help fix bugs we can not reproduce, and will not accept reports which omit reproduction instructions. See below for details.

Feb 20 2016, 7:55 PM
epriestley added a revision to T10264: git clone using http hangs after update: Unknown Object (Differential Revision).
Feb 20 2016, 7:55 PM · Bug Report, Diffusion
• nagya added a comment to F1005563: profile.xhprof.

When filing a bug report, you MUST include reproduction instructions. We can not help fix bugs we can not reproduce, and will not accept reports which omit reproduction instructions. See below for details.

Feb 20 2016, 7:55 PM
epriestley added a comment to T10264: git clone using http hangs after update.

Never mind, that patch doesn't work.

Feb 20 2016, 7:44 PM · Bug Report, Diffusion
epriestley added a comment to T10264: git clone using http hangs after update.
Edit: don't bother with this.
Feb 20 2016, 7:24 PM · Bug Report, Diffusion
epriestley added a comment to T10264: git clone using http hangs after update.

Yeah, I'd like to avoid that "simple workaround" of 200 lines of spaghetti if I can, since I'd guess this task is going to go through 50 more rounds if I have to implement that.

Feb 20 2016, 4:52 PM · Bug Report, Diffusion
dpatou added a comment to T10264: git clone using http hangs after update.

This comment seem to indicate 5.6 indeed broke file_get_contents("compress.zlib://php://input"). I didn't delve much into the proposed workaround yet but it might give a hint of what's going on.

Feb 20 2016, 4:23 PM · Bug Report, Diffusion
epriestley added a comment to T10264: git clone using http hangs after update.

Alright, thanks. Both you and @ppggff have PHP 5.6, I'll see if I can reproduce with 5.6.

Feb 20 2016, 3:34 PM · Bug Report, Diffusion
dpatou added a comment to T10264: git clone using http hangs after update.

@epriestley yes, pretty much the same ones :

[Sat Feb 20 09:04:56.337247 2016] [:error] [pid 5801] [client 86.219.113.93:56185] PHP Warning:  file_get_contents(): cannot represent a stream of type Input as a File Descriptor in /home/w4w/domains/REDACTED/phabricator/support/PhabricatorStartup.php on line 144
[Sat Feb 20 09:04:56.350142 2016] [:error] [pid 5801] [client 86.219.113.93:56185] PHP Warning:  file_get_contents(compress.zlib://php://input): failed to open stream: operation failed in /home/w4w/domains/REDACTED/phabricator/support/PhabricatorStartup.php on line 144

Ubuntu 14.04
Apache : 2.4.16
Php : 5.6.12-1
Php being through mod_php

Feb 20 2016, 3:29 PM · Bug Report, Diffusion
ProfFan added a comment to T6609: Support math (LaTeX) equation in Remarkup.

This looks awesome @ProfFan !

Feb 20 2016, 1:47 PM · Restricted Project, Remarkup
epriestley moved T10240: Copy Comment from Backlog to Needs Information on the Feature Request board.
Feb 20 2016, 12:38 PM · Feature Request (Needs Information)
epriestley moved T10131: Wiki pages are not completely print friendly from Backlog to Future on the Feature Request board.
Feb 20 2016, 12:38 PM · Feature Request, Phriction
epriestley removed a project from T10324: Make Columns Draggable: Feature Request.
Feb 20 2016, 12:37 PM · Workboards (v3)
epriestley moved T10354: Remarkup block elements may not contain other block elements (like lists and tables inside tables) from Backlog to Far Future on the Feature Request board.
Feb 20 2016, 12:37 PM · Feature Request, Remarkup
epriestley moved T10365: Support passing generated annotation to ArcanistGeneratedLinter from Backlog to Needs Information on the Feature Request board.
Feb 20 2016, 12:37 PM · Feature Request (Needs Information), Lint
epriestley moved T10387: Create UI for visual (drag and drop) rearranging of task hierarchy from Backlog to Far Future on the Feature Request board.
Feb 20 2016, 12:36 PM · Feature Request
epriestley moved T10392: Verify that VCS Password does not match LDAP Password from Backlog to Future on the Feature Request board.
Feb 20 2016, 12:36 PM · Auth, Feature Request
epriestley moved T10388: Additional remarkup assistance buttons for decriptions from Backlog to Needs Information on the Feature Request board.
Feb 20 2016, 12:36 PM · Feature Request (Needs Information), Design, Remarkup
epriestley moved T10395: Deploy SSH keys associated with a repository from Backlog to Needs Information on the Feature Request board.
Feb 20 2016, 12:36 PM · Feature Request (Needs Information), Diffusion
epriestley moved T10401: Set global Background Color for each Workboard from Backlog to Needs Information on the Feature Request board.
Feb 20 2016, 12:36 PM · Feature Request (Needs Information), Workboards
epriestley created Feature Request (Needs Information).
Feb 20 2016, 12:35 PM
epriestley added a comment to T10401: Set global Background Color for each Workboard.

Why do you want to set a global default background? What is the root problem you're currently encountering?

Feb 20 2016, 12:35 PM · Feature Request (Needs Information), Workboards
epriestley renamed T10402: Add a client setup check to detect that the browser is using HTTPS but Phabricator does not recognize it from notification websockerURI should use wss protocol when use nginx to Add a client setup check to detect that the browser is using HTTPS but Phabricator does not recognize it.
Feb 20 2016, 12:33 PM · Setup
epriestley reopened T10264: git clone using http hangs after update as "Open".

@dpatou Do you have errors in your error log similar to the ones @ppggff describes?

Feb 20 2016, 12:32 PM · Bug Report, Diffusion
Luke081515.2 added a comment to Q317: Guidelines to add Github repo to Diffusion (Answer 334).

Yeah.

Feb 20 2016, 12:06 PM
subicura added a comment to T10402: Add a client setup check to detect that the browser is using HTTPS but Phabricator does not recognize it.

Oh, thanks for advise. I'll try to fix!

Feb 20 2016, 10:51 AM · Setup
epriestley added a comment to T10402: Add a client setup check to detect that the browser is using HTTPS but Phabricator does not recognize it.

So your client is sending an HTTPS request, but $request->isHTTPS() is false?

Feb 20 2016, 10:49 AM · Setup
subicura added a comment to T10402: Add a client setup check to detect that the browser is using HTTPS but Phabricator does not recognize it.

I use nginx for reverse proxy in front.

Feb 20 2016, 10:48 AM · Setup
epriestley added a comment to T10402: Add a client setup check to detect that the browser is using HTTPS but Phabricator does not recognize it.

To clarify, you are using HTTP for Phabricator but HTTPS for the notification server? If so, why have you made this (unusual) configuration choice?

Feb 20 2016, 10:42 AM · Setup
ablekh added a comment to T10387: Create UI for visual (drag and drop) rearranging of task hierarchy.

@epriestley Thank you for clarifications and links. By the way, does current version of Phabricator support arbitrary depth for wiki pages hierarchy? Could you refer me to the relevant information? Thank you in advance.

Feb 20 2016, 10:02 AM · Feature Request
kislinsk awarded T3980: Support "Bind to External Thing" to define project membership a Like token.
Feb 20 2016, 9:10 AM · Restricted Project, Restricted Project, KDE, Restricted Project, FreeBSD, Wikimedia, Projects
johnny-bit added a comment to T6609: Support math (LaTeX) equation in Remarkup.

This looks awesome @ProfFan !

Feb 20 2016, 8:28 AM · Restricted Project, Remarkup
dpatou added a comment to T10264: git clone using http hangs after update.

@epriestley Reverting both 5e375482 and 8269fd6e make me able to clone normally again.

Feb 20 2016, 8:21 AM · Bug Report, Diffusion
kislinsk edited the content of Organizations Using Phabricator.
Feb 20 2016, 8:14 AM
subicura created T10402: Add a client setup check to detect that the browser is using HTTPS but Phabricator does not recognize it.
Feb 20 2016, 7:40 AM · Setup
ProfFan added a comment to T6609: Support math (LaTeX) equation in Remarkup.

Now updated the parsing mechanism to make it able to handle multiline inline LaTeX.

Feb 20 2016, 7:17 AM · Restricted Project, Remarkup
chad added a comment to Blog Post: Development Notes (2016 Week 8).

Glorious.

Feb 20 2016, 4:33 AM
20after4 added a comment to T10350: Scripts to migrate old "points" fields and move projects beneath other projects.

I had to add an explicit cast to int when I ran the conversion script, but other than the 3 or 4 tasks which lost their points value, everything else worked nicely.

Feb 20 2016, 1:35 AM · Projects (v3)
chad added a comment to T10401: Set global Background Color for each Workboard.

ehhhhh, this is probably better solved with T7190. I don't think there is much (any?) benefit to a global color, as teams usually want visual indication of which workboard they are on (so differentiation matters).

Feb 20 2016, 12:51 AM · Feature Request (Needs Information), Workboards
rphl created T10401: Set global Background Color for each Workboard.
Feb 20 2016, 12:15 AM · Feature Request (Needs Information), Workboards
ftdysa added a comment to T10396: Remarkup toolbar actions always cause comment box to scroll to bottom.

Ah cool, good to know. Thanks for the quick fix!

Feb 20 2016, 12:15 AM · Remarkup, Google Chrome, Bug Report
urzds added a comment to T6171: Transaction abort on first push via SSH to empty Mercurial repository.

This implies a question: Could it be Phabricator which modifies the stream between the client and the server in an illegal way? Or is this some bug in Mercurial itself?

Feb 20 2016, 12:13 AM · Mercurial, Diffusion
urzds added a comment to T6171: Transaction abort on first push via SSH to empty Mercurial repository.

Reading the code around /usr/lib/python2.7/dist-packages/mercurial/sshserver.py:32:

def getargs(self, args):
    data = {}
    keys = args.split()
    for n in xrange(len(keys)):
        argline = self.fin.readline()[:-1]
        arg, l = argline.split()
        if arg not in keys:
            raise util.Abort("unexpected parameter %r" % arg)
        if arg == '*':
            star = {}
            for k in xrange(int(l)):
                argline = self.fin.readline()[:-1]
                arg, l = argline.split()
                val = self.fin.read(int(l))
                star[arg] = val
            data['*'] = star
        else:
            val = self.fin.read(int(l))
            data[arg] = val
    return [data[k] for k in keys]
Feb 20 2016, 12:08 AM · Mercurial, Diffusion
chad updated the post content for Blog Post: Development Notes (2016 Week 8).
Feb 20 2016, 12:04 AM

Feb 19 2016

epriestley edited the content of Changelog.
Feb 19 2016, 11:58 PM
epriestley published Blog Post: Development Notes (2016 Week 8).
Feb 19 2016, 11:58 PM
epriestley created 2016 Week 8 (Late February).
Feb 19 2016, 11:50 PM
epriestley closed T10396: Remarkup toolbar actions always cause comment box to scroll to bottom as Resolved by committing Restricted Diffusion Commit.
Feb 19 2016, 10:55 PM · Remarkup, Google Chrome, Bug Report
epriestley added a comment to T10396: Remarkup toolbar actions always cause comment box to scroll to bottom.

Yeah, I came to approximately the same conclusion. Save + restore on the scroll position appears to be a complete fix as far as I can tell.

Feb 19 2016, 10:55 PM · Remarkup, Google Chrome, Bug Report
epriestley added a revision to T10396: Remarkup toolbar actions always cause comment box to scroll to bottom: Unknown Object (Differential Revision).
Feb 19 2016, 10:49 PM · Remarkup, Google Chrome, Bug Report
chad triaged T10398: Phabricator UI uses deprecated <tt> tag as Wishlist priority.
Feb 19 2016, 10:48 PM · Remarkup, Bug Report
epriestley added a comment to T10398: Phabricator UI uses deprecated <tt> tag .

Invalidating the cache is trivial, but I think <code> is used to style code blocks and has a bunch of different rules (e.g., block formatting) already associated with it.

Feb 19 2016, 10:46 PM · Remarkup, Bug Report
joshuaspence added a comment to T10400: Dropdown menus can overlap.

Yeah, either closing other open menus or allowing menus to be stacked on top of each other.

Feb 19 2016, 10:41 PM · PHUI, Bug Report
joshuaspence updated the task description for T10400: Dropdown menus can overlap.
Feb 19 2016, 10:41 PM · PHUI, Bug Report
chad added a comment to T10400: Dropdown menus can overlap.

Yeah closing anything else open seems to be what most other applications do.

Feb 19 2016, 10:39 PM · PHUI, Bug Report
chad added a comment to T10400: Dropdown menus can overlap.

Here's an example in Maniphest where menus will overlap if you open them all (up to three in this case):

Feb 19 2016, 10:36 PM · PHUI, Bug Report
chad renamed T10400: Dropdown menus can overlap from Worknoard z-index issue to Dropdown menus can overlap.
Feb 19 2016, 10:34 PM · PHUI, Bug Report
chad added a comment to T10400: Dropdown menus can overlap.

What is your expectation of what should happen here? This doesn't seem like a Workboard issue, just an issue with menus in general. Should we just automatically close any open ones if you change your mind and open a different one?

Feb 19 2016, 10:31 PM · PHUI, Bug Report
joshuaspence created T10400: Dropdown menus can overlap.
Feb 19 2016, 10:23 PM · PHUI, Bug Report
ftdysa added a comment to T10396: Remarkup toolbar actions always cause comment box to scroll to bottom.

So I looked into this and it is the call to area.focus() in the setSelectionRange method in https://secure.phabricator.com/diffusion/P/browse/master/webroot/rsrc/js/core/TextAreaUtils.js (unsure what line, my view of this file is plaintext here) that causes the scrolling. I removed this line and it seemed to have the expected behavior but who knows what other problems removing it may cause.

Feb 19 2016, 10:19 PM · Remarkup, Google Chrome, Bug Report
chad closed T10399: Web developer as Spite.

cando

Feb 19 2016, 10:02 PM
chad removed a parent task for T10399: Web developer: T10398: Phabricator UI uses deprecated <tt> tag .
Feb 19 2016, 10:00 PM
chad removed a subtask for T10398: Phabricator UI uses deprecated <tt> tag : T10399: Web developer.
Feb 19 2016, 10:00 PM · Remarkup, Bug Report
• khalfaoui created T10399: Web developer.
Feb 19 2016, 9:59 PM
chad added a project to T10398: Phabricator UI uses deprecated <tt> tag : Remarkup.
Feb 19 2016, 9:58 PM · Remarkup, Bug Report
chad added a comment to T10398: Phabricator UI uses deprecated <tt> tag .

I'd be cool with moving to <code> semantically anyways, but imagine this is a bit harder since we'd have to invalidate all Remarkup cache?

Feb 19 2016, 9:57 PM · Remarkup, Bug Report
• unruthless added a comment to T10398: Phabricator UI uses deprecated <tt> tag .

Not that I'm aware of today. (Caveat: I've only used Phabricator in desktop webkit-based browsers.)

Feb 19 2016, 9:54 PM · Remarkup, Bug Report
chrisportela awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Feb 19 2016, 9:44 PM · Workboards (v3), Restricted Project
epriestley added a comment to T10398: Phabricator UI uses deprecated <tt> tag .

Does this cause any concrete problems in any user agent?

Feb 19 2016, 9:42 PM · Remarkup, Bug Report
chad updated images of M1461: Timeline / Remarkup Cleanup.
Feb 19 2016, 9:41 PM
• unruthless updated the task description for T10398: Phabricator UI uses deprecated <tt> tag .
Feb 19 2016, 9:38 PM · Remarkup, Bug Report
• unruthless created T10398: Phabricator UI uses deprecated <tt> tag .
Feb 19 2016, 9:36 PM · Remarkup, Bug Report
epriestley added a comment to T9897: Unbeta Feedback on Phame.

Although I guess that sort of doesn't really solve many/any problems. But we could embrace that by allowing a blog to be "unlisted" or something, maybe.

Feb 19 2016, 9:35 PM · Phame
epriestley added a comment to T9897: Unbeta Feedback on Phame.

A possible workaround is to create two blogs (review, production), and use "Move Post" as a "Super Publish".

Feb 19 2016, 9:33 PM · Phame
chad added projects to T10396: Remarkup toolbar actions always cause comment box to scroll to bottom: Google Chrome, Remarkup.
Feb 19 2016, 9:25 PM · Remarkup, Google Chrome, Bug Report
chad added a comment to T9897: Unbeta Feedback on Phame.

There may be "document review" built into Phriction at some point. I don't know if maybe we could generalize that to Legalpad and Phame as well.

Feb 19 2016, 9:25 PM · Phame
epriestley added a comment to T10396: Remarkup toolbar actions always cause comment box to scroll to bottom.

Thanks, I'll see if I can figure out what's going on in Chrome.

Feb 19 2016, 9:17 PM · Remarkup, Google Chrome, Bug Report
chad added a comment to T9897: Unbeta Feedback on Phame.

My expectation is that if your company has significant process around posting a blog post, they likely are using a different product to manage that (ie, Google Docs). Wordpress doesn't even offer such a feature without a third party plugin.

Feb 19 2016, 9:11 PM · Phame
cburroughs added a comment to T9897: Unbeta Feedback on Phame.
In T9897#155081, @chad wrote:

If they can post to the blog, they can read the draft.

Feb 19 2016, 8:59 PM · Phame
chad added a comment to M1461: Timeline / Remarkup Cleanup.

Yeah the icons are still probably useful for the minor events. It feels weird without them.

Feb 19 2016, 8:55 PM
chad created M1461: Timeline / Remarkup Cleanup.
Feb 19 2016, 8:47 PM
cburroughs created T10397: twitter links on phacility.com do not link to individual tweets.
Feb 19 2016, 8:30 PM · Phacility, Bug Report
ftdysa added a comment to T10396: Remarkup toolbar actions always cause comment box to scroll to bottom.

Yep, Chrome on Kubuntu.

Feb 19 2016, 8:24 PM · Remarkup, Google Chrome, Bug Report
Krinkle added a comment to T10380: Editing subscribers list should allow selection of exact or closest matched username.

@epriestley Thank you, sir!

Feb 19 2016, 8:23 PM · Wikimedia, Maniphest, Bug Report
amartin33 awarded T182: Commit into repository directly from differential a Like token.
Feb 19 2016, 8:20 PM · Haskell.org, Restricted Project, Differential
epriestley added a comment to T10396: Remarkup toolbar actions always cause comment box to scroll to bottom.

On OSX, I can't reproduce this in Safari or Firefox, but it does reproduce in Chrome. Are you also using Chrome?

Feb 19 2016, 8:09 PM · Remarkup, Google Chrome, Bug Report
ftdysa created T10396: Remarkup toolbar actions always cause comment box to scroll to bottom.
Feb 19 2016, 7:56 PM · Remarkup, Google Chrome, Bug Report
epriestley updated subscribers of T10395: Deploy SSH keys associated with a repository.

The expectation is that you create a "Bot" account, and add keys to that account.

Feb 19 2016, 7:55 PM · Feature Request (Needs Information), Diffusion
epriestley closed T10394: Font awesome icons not rendering in remarkup on Phacility as Resolved.

Presuming resolved, but yell if I missed anything.

Feb 19 2016, 7:53 PM · Macros, Remarkup, Bug Report