Page MenuHomePhabricator
Feed All Stories

Nov 16 2015

tolbrino created T9797: Add unit testing support for Elixir.
Nov 16 2015, 8:13 AM · Unit, Arcanist
tolbrino created T9796: Add linting support for Elixir.
Nov 16 2015, 8:10 AM · Lint, Arcanist
Mnkras added a comment to T9770: It is possible to use the same 2FA token more than once.

I for-see what @revi stated above as a pretty plausible scenario, even the looking over someones shoulder is a plausible scenario.

Nov 16 2015, 4:50 AM · Security, Auth
joshuaspence added a comment to T9794: You Shall Not Pass: Unknown Object (VOID).

Ah sorry, I thought Almanac wasn't a prototype but Drydock was. I was mistaken though.

Nov 16 2015, 1:01 AM · Almanac
avivey added Q222: Integration with Jira (Answer 256).
Nov 16 2015, 1:00 AM
louislu updated Q222: Integration with Jira from to Integration with Jira.
Nov 16 2015, 12:42 AM · Doorkeeper
michaeljs1990 created T9795: Enforce Minimum Required Lint Version.
Nov 16 2015, 12:30 AM · Lint

Nov 15 2015

chad closed T9794: You Shall Not Pass: Unknown Object (VOID) as Invalid.

Prototype

Nov 15 2015, 10:44 PM · Almanac
michaeljs1990 updated the task description for T9785: Add ESLint Linter.
Nov 15 2015, 10:24 PM · Lint
joshuaspence added a comment to T9794: You Shall Not Pass: Unknown Object (VOID).

On another note, why doesn't Almanac use Passphrase for key storage?

Nov 15 2015, 10:21 PM · Almanac
joshuaspence created T9794: You Shall Not Pass: Unknown Object (VOID).
Nov 15 2015, 10:20 PM · Almanac
DheerendraRathor edited P1887 Arcanist Installation Shell Script for Linux.
Nov 15 2015, 9:51 PM · libphutil, Arcanist
avivey added Q221: Is that possible to host several phabricators in one single server? (Answer 255).
Nov 15 2015, 9:45 PM
avivey closed Q189: Author was changed after arc land as resolved.
Nov 15 2015, 9:40 PM · Arcanist
avivey updated the answer details for Q189: Author was changed after arc land (Answer 222).
Nov 15 2015, 9:40 PM
avivey updated the question details for Q220: How to create and deploy custom linters?.
Nov 15 2015, 9:37 PM · Lint
avivey added Q220: How to create and deploy custom linters? (Answer 254).
Nov 15 2015, 9:36 PM
joshuaspence added a comment to Q221: Is that possible to host several phabricators in one single server?.

Why do you want completely separate installations? From your description, it sounds like you want Spaces instead. Spaces allows you to namespace different parts of Phabricator such that things within the Engineering namespace wouldn't necessarily be accessible to the HR namespace.

Nov 15 2015, 9:06 PM
joshuaspence closed T9131: `arc unit` doesn't output progressive results as Resolved.

Fixed in rARC66ab1c955d27ff7875f62eb51a0bd6c4770a7ae3.

Nov 15 2015, 8:53 PM · Unit, Arcanist
joshuaspence closed T9131: `arc unit` doesn't output progressive results, a subtask of T5568: Support `.arcunit`, similar to `.arclint`, as Resolved.
Nov 15 2015, 8:53 PM · Unit, Arcanist
qinchao updated Q221: Is that possible to host several phabricators in one single server? from to Is that possible to host several phabricators in one single server?.
Nov 15 2015, 8:51 PM
michaeljs1990 edited the content of Organizations Not Using Phabricator.
Nov 15 2015, 6:14 PM
epriestley awarded T6049: Implement Phurl, a URL shortener/bookmarking application a Piece of Eight token.
Nov 15 2015, 4:51 PM · Phurl
epriestley created T9793: Remarkup tables have uneven top and bottom margins.
Nov 15 2015, 4:14 PM · Remarkup
tetsuok added a comment to T9792: Download raw diff from Differential weirdness regarding diff including binary files additions/deletions.

Here is the version of phabricator and libphutil I use:

Nov 15 2015, 12:48 PM · Differential
tetsuok created T9792: Download raw diff from Differential weirdness regarding diff including binary files additions/deletions.
Nov 15 2015, 11:50 AM · Differential
joshuaspence added a revision to T9131: `arc unit` doesn't output progressive results: Unknown Object (Differential Revision).
Nov 15 2015, 8:26 AM · Unit, Arcanist
joshuaspence added a revision to T9131: `arc unit` doesn't output progressive results: Unknown Object (Differential Revision).
Nov 15 2015, 8:23 AM · Unit, Arcanist
dereckson created T9791: Upgrade PhabricatorMailImplementationSendGridAdapter to use SendGrid v3 API.
Nov 15 2015, 3:47 AM · Mail
joshuaspence added a revision to T9575: Make Passphrase policies clearer: Unknown Object (Differential Revision).
Nov 15 2015, 2:25 AM · Policy, Passphrase
avivey renamed T9788: config/versions page - also show dates of commits from config/versions page - also so dates of commits to config/versions page - also show dates of commits.
Nov 15 2015, 1:26 AM · Config
dereckson renamed T8482: PhabricatorPasteTestDataGenerator: Call to a member function getPHID() on null from Lipsum generator is broken to PhabricatorPasteTestDataGenerator: Call to a member function getPHID() on null.
Nov 15 2015, 12:56 AM · Paste, Infrastructure
ox added a comment to T9786: Creating Hosted Repo leads to Almanac Exception.

I definitely get that it's a prototype and I know not to file bugs against prototypes, but this interaction wasn't directly with Almanac but with a core Diffusion feature. Diffusion shouldn't use Almanac unless explicitly set to use it. 

Nov 15 2015, 12:54 AM
joshuaspence added a subtask for T992: Send rich HTML mail bodies without impacting reply handling functionality: T9593: Counterexample header is incorrectly colored in email.
Nov 15 2015, 12:20 AM · Differential, Mail
joshuaspence added a parent task for T9593: Counterexample header is incorrectly colored in email: T992: Send rich HTML mail bodies without impacting reply handling functionality.
Nov 15 2015, 12:20 AM · Remarkup, Mail
joshuaspence added a subtask for T992: Send rich HTML mail bodies without impacting reply handling functionality: T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments.
Nov 15 2015, 12:17 AM · Differential, Mail
joshuaspence added a parent task for T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments: T992: Send rich HTML mail bodies without impacting reply handling functionality.
Nov 15 2015, 12:17 AM · Prioritized, Restricted Project, Remarkup, Mail
joshuaspence created T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments.
Nov 15 2015, 12:12 AM · Prioritized, Restricted Project, Remarkup, Mail
joshuaspence created T9789: Make it easier to write custom transaction types.
Nov 15 2015, 12:05 AM · Modernization, Transactions

Nov 14 2015

epriestley added a comment to T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.

I'm partly just guessing here but I think It's almost certainly my fault.

Nov 14 2015, 11:46 PM · ApplicationEditor, Paste
joshuaspence added a comment to T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.

Thanks, I spent ~10 minutes on it but couldn't figure it out.

Nov 14 2015, 11:45 PM · ApplicationEditor, Paste
epriestley added a comment to T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.

File should be getting attached to the paste, but isn't. I think I accidentally caused a side effect here when changing how the transaction works.

Nov 14 2015, 11:44 PM · ApplicationEditor, Paste
epriestley claimed T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.
Nov 14 2015, 11:44 PM · ApplicationEditor, Paste
avivey created T9788: config/versions page - also show dates of commits.
Nov 14 2015, 11:42 PM · Config
joshuaspence added a comment to T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.

Actually something weird is going on... I can't edit pastes either, even if the Edit Policy is set to "All Users".

Nov 14 2015, 11:35 PM · ApplicationEditor, Paste
joshuaspence added a comment to T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.

I'm not sure how to fix this without adding pastePHID to PhabricatorFile, which doesn't feel like the best approach.

Nov 14 2015, 11:33 PM · ApplicationEditor, Paste
joshuaspence added a comment to T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.

I started looking at this. It seems like the file attached to the Paste has a view policy of no-one, whereas it should probably inherit the view policy of the parent Paste.

Nov 14 2015, 11:28 PM · ApplicationEditor, Paste
joshuaspence created T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.
Nov 14 2015, 11:26 PM · ApplicationEditor, Paste
epriestley closed T9786: Creating Hosted Repo leads to Almanac Exception as Invalid.

User Guide: Prototype Applications

Nov 14 2015, 10:53 PM
avivey added a revision to T9785: Add ESLint Linter: Unknown Object (Differential Revision).
Nov 14 2015, 10:51 PM · Lint
chad updated subscribers of T9786: Creating Hosted Repo leads to Almanac Exception.

In general, I'd like better error messages for these kinds of situations. Even better would be some prescriptive text like "Go here, add this, click that".

Nov 14 2015, 10:41 PM
chad added a comment to T9786: Creating Hosted Repo leads to Almanac Exception.

Are you at HEAD? I don't expect Almanac to be needed during repo creation.

Nov 14 2015, 10:22 PM
ox created T9786: Creating Hosted Repo leads to Almanac Exception.
Nov 14 2015, 10:02 PM
joshuaspence updated the task description for T4245: Make repository URIs slightly prettier.
Nov 14 2015, 9:44 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
michaeljs1990 created T9785: Add ESLint Linter.
Nov 14 2015, 9:09 PM · Lint
avivey renamed T9784: `arc patch`: Directory move in SVN patch workflow is implemented erroneously from Directory move in SVN patch workflow is implemented erroneously to `arc patch`: Directory move in SVN patch workflow is implemented erroneously.
Nov 14 2015, 9:05 PM · Subversion, Arcanist
avivey added a comment to T4245: Make repository URIs slightly prettier.

This is the only thing that is blocking me from migrating all of our repositories from Gitlab to Phabricator. Is there a clear path forward here? If so, I could potentially work on this.

Nov 14 2015, 8:31 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
stevenjt awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Nov 14 2015, 5:41 PM · Workboards (v3), Restricted Project
• frans.kasper awarded T4207: Implement (tree) subtasks, as distinct from (graph) task dependencies a Like token.
Nov 14 2015, 3:05 PM · Maniphest
chad added Q54: What is phlux? (Answer 253).
Nov 14 2015, 2:54 PM
chad marked Q54: What is phlux? (Answer 181) as hidden.
Nov 14 2015, 1:53 PM
• andrask added a revision to T9784: `arc patch`: Directory move in SVN patch workflow is implemented erroneously: Unknown Object (Differential Revision).
Nov 14 2015, 1:19 PM · Subversion, Arcanist
• andrask edited projects for T9784: `arc patch`: Directory move in SVN patch workflow is implemented erroneously, added: Arcanist; removed Differential.
Nov 14 2015, 12:43 PM · Subversion, Arcanist
• andrask created T9784: `arc patch`: Directory move in SVN patch workflow is implemented erroneously.
Nov 14 2015, 12:42 PM · Subversion, Arcanist
revi added a comment to T9770: It is possible to use the same 2FA token more than once.

Not sure if this is a possible/practical scenario... but

Nov 14 2015, 12:34 PM · Security, Auth
joshuaspence added a revision to T9762: Removing devices from Almanac services: Unknown Object (Differential Revision).
Nov 14 2015, 10:46 AM · Almanac (v2)
joshuaspence added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Nov 14 2015, 10:38 AM · Prioritized, Diffusion (v3), KDE, Restricted Project
angie added a project to T8971: Auto-fix patch is wrong when multiple issue affect the same line: Restricted Project.
Nov 14 2015, 4:31 AM · Restricted Project, Arcanist
chad placed T9117: Remove unused edges after Ponder comes out of beta up for grabs.
Nov 14 2015, 3:41 AM · Contributor Onboarding, Ponder
chad added a comment to T1931: Add keyboard shortcuts for Maniphest.

It's generally better for us to understand why you want such a feature. For example if you're a triager, Nuance will be a better fit for optimizing incoming bugs and tasks. T5815 may also be of interest.

Nov 14 2015, 1:15 AM · Maniphest
• guayosr awarded T4863: Allow Workboard Cards to be customized for display a Like token.
Nov 14 2015, 1:09 AM · Projects, Workboards, Wikimedia
epriestley updated subscribers of T8971: Auto-fix patch is wrong when multiple issue affect the same line.
Nov 14 2015, 12:56 AM · Restricted Project, Arcanist
epriestley merged task T9783: Multiple linters affecting same line, one of which applying autocorrect into T8971: Auto-fix patch is wrong when multiple issue affect the same line.
Nov 14 2015, 12:56 AM · Restricted Project, Lint
nipunn added a comment to T9783: Multiple linters affecting same line, one of which applying autocorrect.

+1. I agree that conflicting rules are un-resolvable (and thus a configuration issue), but in this case, even consistent rules cause an issue.

Nov 14 2015, 12:09 AM · Restricted Project, Lint

Nov 13 2015

joshuaspence added a comment to T9783: Multiple linters affecting same line, one of which applying autocorrect.

In the general case, this is impossible to resolve. Suppose that you had conflicting linter rules, such as one whiche enforced that files end with a newline character and another which enforces that files do not end with a newline character.

Nov 13 2015, 11:36 PM · Restricted Project, Lint
nipunn created T9783: Multiple linters affecting same line, one of which applying autocorrect.
Nov 13 2015, 11:29 PM · Restricted Project, Lint
lpriestley added a revision to T6049: Implement Phurl, a URL shortener/bookmarking application: Unknown Object (Differential Revision).
Nov 13 2015, 10:54 PM · Phurl
joshuaspence added a comment to T9773: Unit tests are slow.

MySQL version is 5.6.27-0ubuntu1.

Nov 13 2015, 10:54 PM · Infrastructure
joshuaspence added a comment to T9773: Unit tests are slow.
> time ./bin/storage upgrade --namespace testT9773 --force --no-adjust
Loading quickstart template...
Applying patch 'phabricator:db.xhpast'...
Applying patch 'phabricator:20150906.mailinglist.sql'...
Applying patch 'phabricator:20150930.drydock.log.1.sql'...
Applying patch 'phabricator:20151001.drydock.rname.1.sql'...
Applying patch 'phabricator:20151002.dashboard.status.1.sql'...
Applying patch 'phabricator:20151002.harbormaster.bparam.1.sql'...
Applying patch 'phabricator:20151009.drydock.auth.1.sql'...
Applying patch 'phabricator:20151010.drydock.auth.2.sql'...
Applying patch 'phabricator:20151013.drydock.op.1.sql'...
Applying patch 'phabricator:20151023.harborpolicy.1.sql'...
Applying patch 'phabricator:20151023.harborpolicy.2.php'...
Applying patch 'phabricator:20151023.patchduration.sql'...
Applying patch 'phabricator:20151030.harbormaster.initiator.sql'...
Applying patch 'phabricator:20151106.editengine.1.table.sql'...
Applying patch 'phabricator:20151106.editengine.2.xactions.sql'...
Applying patch 'phabricator:20151106.phame.post.mailkey.1.sql'...
Applying patch 'phabricator:20151106.phame.post.mailkey.2.php'...
Applying patch 'phabricator:20151107.phame.blog.mailkey.1.sql'...
Applying patch 'phabricator:20151107.phame.blog.mailkey.2.php'...
Applying patch 'phabricator:20151108.phame.blog.joinpolicy.sql'...
Applying patch 'phabricator:20151108.xhpast.stderr.sql'...
Applying patch 'phabricator:20151109.phame.post.comments.1.sql'...
Applying patch 'phabricator:20151109.repository.coverage.1.sql'...
Applying patch 'phabricator:20151109.xhpast.db.1.sql'...
Applying patch 'phabricator:20151109.xhpast.db.2.sql'...
Applying patch 'phabricator:20151110.daemonenvhash.sql'...
Storage is up to date. Use 'storage status' for details.
Declining to apply storage adjustments.
Nov 13 2015, 10:52 PM · Infrastructure
joshuaspence added a comment to T4245: Make repository URIs slightly prettier.

This is the only thing that is blocking me from migrating all of our repositories from Gitlab to Phabricator. Is there a clear path forward here? If so, I could potentially work on this.

Nov 13 2015, 10:35 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
lpriestley added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.

If a Phurl doesn't have a name, should we still show the empty name property on the object view?

Nov 13 2015, 10:17 PM · Phurl
avivey added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

Any way to bump the priority of this up?

Nov 13 2015, 8:32 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
jsturgeon added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

Any way to bump the priority of this up?

Nov 13 2015, 8:31 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley updated subscribers of T4863: Allow Workboard Cards to be customized for display.
Nov 13 2015, 7:58 PM · Projects, Wikimedia, Workboards
epriestley merged task T9782: On a dashboard, the Differential panel should show the repository. into T4863: Allow Workboard Cards to be customized for display.
Nov 13 2015, 7:58 PM · Dashboards, Differential
epriestley added a comment to T9770: It is possible to use the same 2FA token more than once.

(HTTP over public wireless has those properties, but using MFA and not using HTTPS is silly and the lack of HTTPS is a far greater problem than the larger MFA vulnerability window.)

Nov 13 2015, 7:56 PM · Security, Auth
epriestley added a comment to T9770: It is possible to use the same 2FA token more than once.

could MITM the connection between the verifier and prover

Nov 13 2015, 7:53 PM · Security, Auth
eadler added a comment to T9770: It is possible to use the same 2FA token more than once.

Now that I think about this for a bit more there is a security concern here: In given two-factor authentication context, an attacker could MITM the connection between the verifier and prover, obtain the authentication credentials & a single OTP value, and then log in with these credentials within the current time step. This would allow for a second authenticated login, in sudo mode. I initially didn't think of this concern since the attacker can race, but in this case the new connection is created silently.

Nov 13 2015, 7:41 PM · Security, Auth
epriestley added a comment to T9770: It is possible to use the same 2FA token more than once.

There are some attacks that could be performed on such MFA schemes but that are not applicable in phabricator's security model.

Nov 13 2015, 7:40 PM · Security, Auth
eadler added a comment to T9770: It is possible to use the same 2FA token more than once.

I filed this as a correctness bug, not as a security bug. There are some attacks that could be performed on such MFA schemes but that are not applicable in phabricator's security model.

Nov 13 2015, 7:34 PM · Security, Auth
epriestley added a comment to T9770: It is possible to use the same 2FA token more than once.

I think the RFC should be followed.

Nov 13 2015, 7:33 PM · Security, Auth
dereckson created T9782: On a dashboard, the Differential panel should show the repository..
Nov 13 2015, 7:33 PM · Dashboards, Differential
Mnkras added a comment to T9770: It is possible to use the same 2FA token more than once.

So I just did some googling and came across the RFC for MFA, and this is
taken from the RFC:

Nov 13 2015, 7:27 PM · Security, Auth
epriestley added a comment to T9773: Unit tests are slow.

I can't reproduce this either, nor does it reproduce on this install.

Nov 13 2015, 7:26 PM · Infrastructure
epriestley added a comment to T9770: It is possible to use the same 2FA token more than once.

I'd like to understand the reason behind this before moving forward.

Nov 13 2015, 7:17 PM · Security, Auth
chad closed Q219: What is the difference between the individual and corporate CLA? as resolved.
Nov 13 2015, 7:11 PM · Phacility
epriestley closed T9776: Process Herald rules recursively as Wontfix.

I don't want to introduce this level of complexity into Herald.

Nov 13 2015, 6:57 PM · Herald
epriestley added Q219: What is the difference between the individual and corporate CLA? (Answer 252).
Nov 13 2015, 6:50 PM
chad updated subscribers of T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).
Nov 13 2015, 6:33 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
chad merged task T9781: add link auto expand feature into T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).
Nov 13 2015, 6:33 PM · Remarkup