Page MenuHomePhabricator
Create Task
Maniphest T9787

Raw files in Paste no longer attach to Pastes properly after ApplicationEditor
Closed, ResolvedPublic
Actions

Description

I think this might have been caused by recent changes to Paste as part of T9132. Basically, it seems that "View Raw File" in Paste no longer works except for the author of the paste. For example, if I click on "View Raw File" on P1887 on this install then I get a policy error:

62 You Shall Not Pass Restricted File.png (980×1 px, 111 KB)

Revisions and Commits

rP Phabricator
D14494rP06de60599288 Extract PHIDs from transactions later, fixing Paste extraction/attachment
D14493rP5aae89babb73 Fix file PHID extraction in Owners and Differential

Related Objects

Event Timeline

joshuaspence created this task.Nov 14 2015, 11:26 PM
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Paste.
joshuaspence added a subscriber: joshuaspence.
joshuaspence added a comment.Nov 14 2015, 11:28 PM

I started looking at this. It seems like the file attached to the Paste has a view policy of no-one, whereas it should probably inherit the view policy of the parent Paste.

joshuaspence added a comment.EditedNov 14 2015, 11:33 PM

I'm not sure how to fix this without adding pastePHID to PhabricatorFile, which doesn't feel like the best approach.

joshuaspence added a comment.Nov 14 2015, 11:35 PM

Actually something weird is going on... I can't edit pastes either, even if the Edit Policy is set to "All Users".

epriestley claimed this task.Nov 14 2015, 11:44 PM

File should be getting attached to the paste, but isn't. I think I accidentally caused a side effect here when changing how the transaction works.

joshuaspence added a comment.Nov 14 2015, 11:45 PM

Thanks, I spent ~10 minutes on it but couldn't figure it out.

epriestley added a comment.Nov 14 2015, 11:46 PM

I'm partly just guessing here but I think It's almost certainly my fault.

epriestley added a revision: D14493: Fix file PHID extraction in Owners and Differential.Nov 16 2015, 6:02 PM
epriestley renamed this task from Unable to view raw paste to Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.Nov 16 2015, 6:18 PM
epriestley triaged this task as Normal priority.
epriestley added a project: ApplicationEditor.
epriestley added a revision: D14494: Extract PHIDs from transactions later, fixing Paste extraction/attachment.Nov 16 2015, 6:22 PM
epriestley closed this task as Resolved by committing rP06de60599288: Extract PHIDs from transactions later, fixing Paste extraction/attachment.Nov 17 2015, 4:36 PM
epriestley added a commit: rP5aae89babb73: Fix file PHID extraction in Owners and Differential.
epriestley added a commit: rP06de60599288: Extract PHIDs from transactions later, fixing Paste extraction/attachment.
Phabricator · Built by Phacility