Page MenuHomePhabricator
Feed Advanced Search

Feb 29 2016

epriestley closed T10466: Wrong mail and extra feed story when joining a project as Resolved by committing Restricted Diffusion Commit.
Feb 29 2016, 12:32 AM · Projects, Bug Report
epriestley added a revision to T10466: Wrong mail and extra feed story when joining a project: Unknown Object (Differential Revision).
Feb 29 2016, 12:31 AM · Projects, Bug Report
epriestley added a comment to T10466: Wrong mail and extra feed story when joining a project.

Thanks, pretty sure that's the issue. Diff in a sec.

Feb 29 2016, 12:29 AM · Projects, Bug Report
epriestley added a comment to T10466: Wrong mail and extra feed story when joining a project.

Did you select "Disable Mail" from the "Members" page after joining the project?

Feb 29 2016, 12:23 AM · Projects, Bug Report
epriestley added a comment to T10466: Wrong mail and extra feed story when joining a project.

...except that I can't reproduce it locally. Hrrm..

Feb 29 2016, 12:22 AM · Projects, Bug Report
epriestley added a comment to T10466: Wrong mail and extra feed story when joining a project.

This is probably the "implicit membership" edge leaking through. Should be an easy fix.

Feb 29 2016, 12:20 AM · Projects, Bug Report
epriestley closed T10461: ui.footer-items doesn't support mailto links as Wontfix.

I'd like to wait for a better use case before trying to separate protocol filtering in link/redirection contexts. Linking to a wiki page or similar seems reasonable in footers, and there's diversity and some security complications in other affected contexts (today: object profile menus, footer links, core external redirects, "Link" custom fields, {nav} elements, OAuth callback URIs).

Feb 29 2016, 12:18 AM · Feature Request
epriestley closed T7979: Add ability to search by policy as Wontfix.

I don't anticipate ever building this. It would take months and only partially address a very narrow range of primarily operational use cases.

Feb 29 2016, 12:09 AM · Policy, Search

Feb 28 2016

epriestley edited projects for T10467: Diffusion history doesn't update, added: Bug Report (Needs Information); removed Bug Report.
Feb 28 2016, 11:32 PM · Bug Report (Needs Information), Diffusion
epriestley edited projects for T10468: cannot upload diff using svn, added: Bug Report (Needs Information); removed Bug Report.

I can't reproduce this. Here's what I did:

Feb 28 2016, 11:31 PM · Differential, Arcanist, Bug Report (Needs Information)
epriestley closed T10470: Feature Request Test as Spite.
Feb 28 2016, 6:43 PM · Feature Request
ProfFan awarded T7568: Support Desktop Notifications in Conpherence a Like token.
Feb 28 2016, 9:00 AM · Conpherence (v4)

Feb 27 2016

epriestley closed T10464: Understanding the as Spite.

Pretty sure this is the same user as @9999999999, @Persona, @nagya and @nagym. They're just registering an account every day, being vaguely annoying, and then getting disabled. O.o

Feb 27 2016, 6:50 PM · Feature Request
epriestley added a revision to T10457: Improve Harbomaster/Drydock UI/UX before release: Unknown Object (Differential Revision).
Feb 27 2016, 5:23 PM · Harbormaster (v3), Drydock (v3), Phacility
epriestley added a revision to T10457: Improve Harbomaster/Drydock UI/UX before release: Unknown Object (Differential Revision).
Feb 27 2016, 5:05 PM · Harbormaster (v3), Drydock (v3), Phacility
epriestley closed T10462: AASTNode in libphutil missing tokenCache declaration as Resolved.
Feb 27 2016, 5:03 PM · Infrastructure, Bug Report
epriestley added a comment to T10462: AASTNode in libphutil missing tokenCache declaration.

D15358 should fix this by declaring the property. Nice catch on finding this!

Feb 27 2016, 3:27 PM · Infrastructure, Bug Report
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Feb 27 2016, 3:27 PM
epriestley claimed T10462: AASTNode in libphutil missing tokenCache declaration.
Feb 27 2016, 3:27 PM · Infrastructure, Bug Report
epriestley added a comment to T10462: AASTNode in libphutil missing tokenCache declaration.

Specifically, the issue is that this class extends Phobject, which implements __set() and throws when an undeclared property is written to. The exception is swallowed elsewhere in the stack.

Feb 27 2016, 3:24 PM · Infrastructure, Bug Report
epriestley closed T10011: Allow to search for the build status in habormaster querys as Resolved by committing Restricted Diffusion Commit.
Feb 27 2016, 3:13 PM · Harbormaster (v3), Feature Request
epriestley added a comment to T10246: Deploy Drydock in the Phacility cluster.

This is detailed in T10463, but the API changes seem to have deployed with only a few minor rough patches, so we're currently on track to deploy everything else next Saturday (March 5).

Feb 27 2016, 1:59 PM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley closed T10463: Deploy Almanac v2 Changes to the Cluster as Resolved.

Test instance workflow looks good, and general monitoring also looks clean. I'll keep an eye on things but I think we're in the clear.

Feb 27 2016, 1:56 PM · Phacility, Ops
epriestley added a comment to T10463: Deploy Almanac v2 Changes to the Cluster.

Also, the backup changes from last week (rCOREbf0c93a46f8b) seem to have worked correctly. The instances that were hitting problems and delays have written backups exactly on schedule every day since then.

Feb 27 2016, 1:52 PM · Phacility, Ops
epriestley added a comment to T10463: Deploy Almanac v2 Changes to the Cluster.

Daemons look good -- we accumulated a bit of a queue of backup tasks while the tier was out of sync, but these have now almost completely flushed on their own.

Feb 27 2016, 1:50 PM · Phacility, Ops
epriestley added a comment to T10463: Deploy Almanac v2 Changes to the Cluster.

I've deployed the remainder of the repo tier, and the auxiliary service tiers. I believe deployment is essentially complete.

Feb 27 2016, 1:47 PM · Phacility, Ops
epriestley added a comment to T10463: Deploy Almanac v2 Changes to the Cluster.

repo001 seems to have gone smoothly and daemons/repositories are now restored, I'm deploying the remainder of the tier.

Feb 27 2016, 1:41 PM · Phacility, Ops
epriestley added a comment to T10463: Deploy Almanac v2 Changes to the Cluster.

db tier is deployed, now deploying repo001.

Feb 27 2016, 1:38 PM · Phacility, Ops
epriestley added a comment to T10463: Deploy Almanac v2 Changes to the Cluster.

I've upgraded db001 and sorted out host instances and service sync flows, which seem OK now. I'm going to upgrade the rest of the db tier.

Feb 27 2016, 1:32 PM · Phacility, Ops
epriestley added a comment to T10463: Deploy Almanac v2 Changes to the Cluster.

web is sort of back up, but needs the new schema to actually make any progress, so this isn't conclusive. I'm deploying the db tier now to get the new schema.

Feb 27 2016, 1:19 PM · Phacility, Ops
epriestley added a comment to T10463: Deploy Almanac v2 Changes to the Cluster.
  • I stopped web.
  • I deployed admin.
  • I manually removed now-invalid configuration from instances and from Alamanac properties.
  • I spot-checked instance/Almanac service relationships.
  • I spot-checked Almanac service properties.
  • I manually invoked almanac.service.search to look for issues, but everything looks good.
Feb 27 2016, 1:13 PM · Phacility, Ops
epriestley added a comment to T10463: Deploy Almanac v2 Changes to the Cluster.

I've stopped the daemons. I'm going to stop the web tier, deploy admin, fix instance configuration, then deploy the web tier. I expect this to be the riskiest part of the upgrade.

Feb 27 2016, 1:03 PM · Phacility, Ops
epriestley added a comment to T10463: Deploy Almanac v2 Changes to the Cluster.

I'm getting this underway now. I'm going to preemptively stop all daemons, which will pause repository imports, outgoing mail, etc. They'll be restarted at the end of the process.

Feb 27 2016, 1:00 PM · Phacility, Ops
epriestley created T10463: Deploy Almanac v2 Changes to the Cluster.
Feb 27 2016, 12:26 PM · Phacility, Ops
epriestley edited the content of Changelog.
Feb 27 2016, 12:16 PM
epriestley created 2016 Week 9 (Very Late February).
Feb 27 2016, 12:16 PM
epriestley created Blog Post: Development Notes (2016 Week 9).
Feb 27 2016, 12:15 PM
epriestley added a revision to T10457: Improve Harbomaster/Drydock UI/UX before release: Unknown Object (Differential Revision).
Feb 27 2016, 3:54 AM · Harbormaster (v3), Drydock (v3), Phacility
epriestley added a comment to T5822: Implement garbage collection / automatic archiving for Harbormaster logs.

Pretty sure I can scope this into the current iteration under T10457 and provide some corresponding purge tools, just in case any installs hypothetically insert gigabytes of data into build logs.

Feb 27 2016, 1:17 AM · Harbormaster, Restricted Project
epriestley moved T5822: Implement garbage collection / automatic archiving for Harbormaster logs from v2 to v3 on the Harbormaster board.
Feb 27 2016, 1:14 AM · Harbormaster, Restricted Project

Feb 26 2016

epriestley closed T10459: AphrontSchemaQueryException on create\update task as Invalid.

In any case, this is definitely some kind of problem in your local environment and not an issue with the upstream. We can't and won't be able to reproduce it and can't help you with installation and setup issues (see Support Resources).

Feb 26 2016, 11:40 PM · Bug Report (Needs Information)
epriestley added a comment to T10459: AphrontSchemaQueryException on create\update task.

Oh, wait, you're actually on stable and just haven't updated master.

Feb 26 2016, 11:38 PM · Bug Report (Needs Information)
epriestley added a comment to T10459: AphrontSchemaQueryException on create\update task.

This column and the property for it were both removed in 32225d1 (Feb 8). You are running b5518d4b (Feb 7), but have somehow upgraded your database using a newer version of Phabricator.

Feb 26 2016, 11:36 PM · Bug Report (Needs Information)
epriestley added a comment to T10461: ui.footer-items doesn't support mailto links.

A workaround is to write a wiki page like "how to get help with stuff" and put the link there.

Feb 26 2016, 9:18 PM · Feature Request
epriestley added a revision to T10011: Allow to search for the build status in habormaster querys: Unknown Object (Differential Revision).
Feb 26 2016, 8:47 PM · Harbormaster (v3), Feature Request
epriestley added a revision to T10457: Improve Harbomaster/Drydock UI/UX before release: Unknown Object (Differential Revision).
Feb 26 2016, 8:23 PM · Harbormaster (v3), Drydock (v3), Phacility
epriestley added a revision to T10457: Improve Harbomaster/Drydock UI/UX before release: Unknown Object (Differential Revision).
Feb 26 2016, 8:05 PM · Harbormaster (v3), Drydock (v3), Phacility
epriestley closed T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds as Resolved by committing Restricted Diffusion Commit.
Feb 26 2016, 7:38 PM · Harbormaster (v3), Restricted Project
epriestley added a comment to T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds.

My broad philosophical stance here is that engineers should be disciplined and professional about not killing enemy builds, but I think the complexity cost to put some more guard rails on the thing isn't overbearing and these additional policies are generally pretty reasonable and make sense, and have some redeeming value in preventing mistakes with tools like "Restart All Builds".

Feb 26 2016, 7:38 PM · Harbormaster (v3), Restricted Project
epriestley awarded T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds a Baby Tequila token.
Feb 26 2016, 7:32 PM · Harbormaster (v3), Restricted Project
epriestley added a revision to T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds: Unknown Object (Differential Revision).
Feb 26 2016, 7:32 PM · Harbormaster (v3), Restricted Project
epriestley closed T10458: Remove obsolete Drydock build steps from Harbormaster, a subtask of T10457: Improve Harbomaster/Drydock UI/UX before release, as Resolved.
Feb 26 2016, 6:35 PM · Harbormaster (v3), Drydock (v3), Phacility
epriestley closed T10458: Remove obsolete Drydock build steps from Harbormaster as Resolved by committing Restricted Diffusion Commit.
Feb 26 2016, 6:35 PM · Harbormaster (v3), Drydock (v3), Phacility
epriestley added a revision to T10458: Remove obsolete Drydock build steps from Harbormaster: Unknown Object (Differential Revision).
Feb 26 2016, 6:33 PM · Harbormaster (v3), Drydock (v3), Phacility
epriestley closed T10447: When the push phase of "Land Revision" fails, show the error in the UI as Resolved.

Presuming resolved by D15350.

Feb 26 2016, 6:30 PM · Drydock (v3)
epriestley added a comment to T10260: Harbormaster Herald Rules.

Maybe a more natural approach to this would be to add a "Notify" build step? We'd also need an "on failure" set of actions or something which implicitly accomplished the same goal, but that seems reasonable to me.

Feb 26 2016, 3:23 PM · Haskell.org, Restricted Project, Harbormaster, Feature Request
epriestley moved T9516: Copying text from a Harbormaster build log copies the line numbers as well from Backlog to v3 on the Harbormaster board.
Feb 26 2016, 3:07 PM · Harbormaster, Restricted Project
epriestley moved T10011: Allow to search for the build status in habormaster querys from Backlog to v3 on the Harbormaster board.
Feb 26 2016, 3:06 PM · Harbormaster (v3), Feature Request
epriestley moved T10093: When builds fail because the staging area was not pushed, make the cause clear from Backlog to v3 on the Harbormaster board.
Feb 26 2016, 3:06 PM · Haskell.org, Restricted Project, Harbormaster (v3), Diffusion, Feature Request
epriestley moved T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds from v2 to v3 on the Harbormaster board.
Feb 26 2016, 3:05 PM · Harbormaster (v3), Restricted Project
epriestley moved T10246: Deploy Drydock in the Phacility cluster from Backlog to v3 on the Harbormaster board.
Feb 26 2016, 3:05 PM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley moved T10457: Improve Harbomaster/Drydock UI/UX before release from Backlog to v3 on the Harbormaster board.
Feb 26 2016, 3:05 PM · Harbormaster (v3), Drydock (v3), Phacility
epriestley moved T10458: Remove obsolete Drydock build steps from Harbormaster from Backlog to v3 on the Harbormaster board.
Feb 26 2016, 3:05 PM · Harbormaster (v3), Drydock (v3), Phacility
epriestley created Harbormaster (v3).
Feb 26 2016, 3:05 PM
epriestley created T10458: Remove obsolete Drydock build steps from Harbormaster.
Feb 26 2016, 3:03 PM · Harbormaster (v3), Drydock (v3), Phacility
epriestley moved T10246: Deploy Drydock in the Phacility cluster from Backlog to v3 on the Drydock board.
Feb 26 2016, 3:02 PM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley moved T10447: When the push phase of "Land Revision" fails, show the error in the UI from Backlog to v3 on the Drydock board.
Feb 26 2016, 3:02 PM · Drydock (v3)
epriestley moved T10457: Improve Harbomaster/Drydock UI/UX before release from Backlog to v3 on the Drydock board.
Feb 26 2016, 3:01 PM · Harbormaster (v3), Drydock (v3), Phacility
epriestley moved T10024: Can't remove blueprint limit from v2 to v3 on the Drydock board.
Feb 26 2016, 3:01 PM · Drydock (v3), Bug Report
epriestley created Drydock (v3).
Feb 26 2016, 3:01 PM
epriestley added a subtask for T10457: Improve Harbomaster/Drydock UI/UX before release: T10024: Can't remove blueprint limit.
Feb 26 2016, 3:01 PM · Harbormaster (v3), Drydock (v3), Phacility
epriestley added a parent task for T10024: Can't remove blueprint limit: T10457: Improve Harbomaster/Drydock UI/UX before release.
Feb 26 2016, 3:01 PM · Drydock (v3), Bug Report
epriestley moved T9493: Formalize attributes on Drydock resources and leases from v2 to Future on the Drydock board.
Feb 26 2016, 3:01 PM · Restricted Project, Drydock (v3)
epriestley moved T9492: Make WorkingCopy resources more powerful and flexible from v2 to Future on the Drydock board.
Feb 26 2016, 3:01 PM · Restricted Project, Drydock
epriestley moved T8153: Improve detection and recovery when resources are mangled outside of Drydock's control from v2 to Future on the Drydock board.
Feb 26 2016, 3:01 PM · Prioritized, Drydock
epriestley created T10457: Improve Harbomaster/Drydock UI/UX before release.
Feb 26 2016, 2:59 PM · Harbormaster (v3), Drydock (v3), Phacility
epriestley added a comment to T10246: Deploy Drydock in the Phacility cluster.

New APIs are going out tomorrow morning (Saturday, February 27). I expect to unprototype Almanac shortly after that, provided things go relatively smoothly, so it will become available the following week (Saturday, March 5).

Feb 26 2016, 2:56 PM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley added a comment to Q326: Impossible to set boolean param with curl? (Answer 335).

Hmm, alright -- file a task and I'll take a look when I have a chance. I don't expect this to require any weird magic.

Feb 26 2016, 2:52 PM
epriestley added Q326: Impossible to set boolean param with curl? (Answer 335).
Feb 26 2016, 2:48 PM
kristo.mario awarded T4558: Make Diviner useful for third-parties a Like token.
Feb 26 2016, 2:22 PM · Diviner
epriestley closed T9762: Removing devices from Almanac services as Resolved by committing Restricted Diffusion Commit.
Feb 26 2016, 2:21 PM · Almanac (v2)
epriestley closed T9762: Removing devices from Almanac services, a subtask of T10246: Deploy Drydock in the Phacility cluster, as Resolved.
Feb 26 2016, 2:21 PM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley added a comment to T10452: Provide more flexible management over disabling/changing ldap user accounts.

It looks like that can leave two external (LDAP) accounts pointed at the same Phabricator account. If that's working, great. It will be supported explicitly after T2549.

Feb 26 2016, 2:16 PM · Restricted Project, LDAP, Auth, Feature Request
epriestley closed T10450: Owner locked out of project as Resolved.
Feb 26 2016, 2:06 PM · Projects, Bug Report
SpaceKees awarded T5954: Modularize "Export to Excel" as a feature of ApplicationSearch a Like token.
Feb 26 2016, 1:56 PM · Custom Fields, ApplicationSearch
epriestley removed 1 mock(s) for T10450: Owner locked out of project: Unknown Object (Pholio Mock).
Feb 26 2016, 1:55 PM · Projects, Bug Report
epriestley removed 1 mock(s) for T10433: Repo in Diffusion has no padding after Branches box if footer is not configured: Unknown Object (Pholio Mock).
Feb 26 2016, 1:55 PM · Diffusion, Bug Report
epriestley removed projects from T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails: Bug Report, 🐳, Abuse, Android.
Feb 26 2016, 1:55 PM · Phortune, Phacility
epriestley updated the task description for T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails.
Feb 26 2016, 1:54 PM · Phortune, Phacility
epriestley closed T10454: represents-Thenth, as Spite.
Feb 26 2016, 1:54 PM
epriestley placed T10455: technology"... up for grabs.
Feb 26 2016, 1:54 PM
epriestley removed projects from T10455: technology"...: Chad's House, Bug Report, Aphront, Aphlict, ApplicationEditor, Abuse, Applications.
Feb 26 2016, 1:54 PM
epriestley closed T10455: technology"... as Spite.
Feb 26 2016, 1:53 PM
epriestley added a comment to T5391: Support custom fields in 'Export to Excel'.

is T5954 really a fully blocking Task of this feature?

Feb 26 2016, 1:53 PM · Data Exporters
chad awarded T10449: Almanac v2 (Unprototype) a Doubloon token.
Feb 26 2016, 3:34 AM · Almanac (v2), Phacility
epriestley added a comment to T10449: Almanac v2 (Unprototype).
In T10449#161931, @dtf wrote:

Shouldn't restricted repositories short-names be rendered as [ Restricted Repository]? Sorry for this off-topic.

Feb 26 2016, 1:43 AM · Almanac (v2), Phacility

Feb 25 2016

eserrano awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Pterodactyl token.
Feb 25 2016, 10:26 PM · Workboards (v3), Restricted Project
epriestley added a comment to T10337: Implement `diffusion.search` and think about `diffusion.edit`.

Oh, there are also really two issues here, but only one that I think is actually hard:

Feb 25 2016, 10:07 PM · Diffusion (v3), Restricted Project, Projects, Feature Request
epriestley added a comment to T10452: Provide more flexible management over disabling/changing ldap user accounts.

On external account mangling in particular:

Feb 25 2016, 9:58 PM · Restricted Project, LDAP, Auth, Feature Request
epriestley added a comment to T10337: Implement `diffusion.search` and think about `diffusion.edit`.

Yeah, that's broadly the "think about" part in the task title -- I don't have a good answer. I'm not quite sure how to reconcile diffusion.edit with the current multi-page form.

Feb 25 2016, 9:48 PM · Diffusion (v3), Restricted Project, Projects, Feature Request