Page MenuHomePhabricator
Create Task
Maniphest T10466

Wrong mail and extra feed story when joining a project
Closed, ResolvedPublic
Actions

Description

I got a mail saying eadler added an edge: eadler. when joining Wikimedia. In addition the feed looks like

Screenshot 2016-02-27 21.25.00.png (388×752 px, 65 KB)
\

it shouldn't talk about edges, but members. The feed story has one correct entry and one extra.

Revisions and Commits

rP Phabricator
D15361rP2e19b78b8dd6 Don't publish anything for "Disable Mail" / "Enable Mail" on projects

Event Timeline

eadler created this task.Feb 28 2016, 5:25 AM
Herald added a subscriber: qgil. · View Herald TranscriptFeb 28 2016, 5:25 AM
eadler updated the task description. (Show Details)Feb 28 2016, 5:27 AM
epriestley added a subscriber: epriestley.Feb 29 2016, 12:20 AM

This is probably the "implicit membership" edge leaking through. Should be an easy fix.

epriestley added a comment.Feb 29 2016, 12:22 AM

...except that I can't reproduce it locally. Hrrm..

epriestley added a comment.Feb 29 2016, 12:23 AM

Did you select "Disable Mail" from the "Members" page after joining the project?

eadler added a comment.Feb 29 2016, 12:29 AM

Yes. Forgot about that.

epriestley added a comment.Feb 29 2016, 12:29 AM

Thanks, pretty sure that's the issue. Diff in a sec.

epriestley added a revision: D15361: Don't publish anything for "Disable Mail" / "Enable Mail" on projects.Feb 29 2016, 12:31 AM
epriestley closed this task as Resolved by committing rP2e19b78b8dd6: Don't publish anything for "Disable Mail" / "Enable Mail" on projects.Feb 29 2016, 12:32 AM
epriestley added a commit: rP2e19b78b8dd6: Don't publish anything for "Disable Mail" / "Enable Mail" on projects.
epriestley added a comment.Feb 29 2016, 12:33 AM

That fix isn't retroactive, but should stop the problem in the future once it deploys. Thanks for the report!

joshuaspence added a project: Projects.Feb 29 2016, 8:30 AM
joshuaspence added a subscriber: joshuaspence.
Phabricator · Built by Phacility