Page MenuHomePhabricator
Create Task
Maniphest T10462

AASTNode in libphutil missing tokenCache declaration
Closed, ResolvedPublic
Actions

Description

libphutil/src/parser/aast/api/AASTNode.php has a tokenCache attribute which is not declared. This causes selectTokensOfTypes to miss the cache every time.

Steps to reproduce:

Related Objects

Event Timeline

tetrapus created this task.Feb 27 2016, 4:56 AM
epriestley added a subscriber: epriestley.Feb 27 2016, 3:24 PM

Specifically, the issue is that this class extends Phobject, which implements __set() and throws when an undeclared property is written to. The exception is swallowed elsewhere in the stack.

This was likely introduced accidentally by 3ff84448; the cache presumably functioned before then. Declaring this property would not be necessary without the inherited implementation of __set().

epriestley mentioned this in D15358: Declare tokenCache on AASTNode.Feb 27 2016, 3:25 PM
epriestley claimed this task.Feb 27 2016, 3:27 PM
epriestley triaged this task as Normal priority.
epriestley added a project: Infrastructure.

D15358 should fix this by declaring the property. Nice catch on finding this!

epriestley mentioned this in rPHU6ef9295e388d: Declare tokenCache on AASTNode.Feb 27 2016, 4:08 PM
epriestley closed this task as Resolved.Feb 27 2016, 5:03 PM
joshuaspence awarded a token.Feb 29 2016, 8:31 AM
joshuaspence added a subscriber: joshuaspence.
joshuaspence added a comment.Mar 1 2016, 7:47 PM

Why not change Phobject::__isset and Phobject::__unset to throw an exception in the same way that Phobject::__get and Phobject::__set do?

epriestley added a comment.Mar 1 2016, 7:50 PM

I think that would be reasonable.

Phabricator · Built by Phacility