I want to be able to add a link to mail our internal code review team. Simple enough use case
Description
Description
Event Timeline
Comment Actions
A workaround is to write a wiki page like "how to get help with stuff" and put the link there.
This is vaguely complicated to fix. The culprit is:
if (!PhabricatorEnv::isValidURIForLink($href)) {
$href = null;
}...which doesn't accept mailto (or tel) because it lacks the special handling rules those protocols need.
Comment Actions
Yeah footer links aren't a great place for a mailto:. Overall you're better making a Phriction document with all the vital information, and have a link to that in the footer under "Contact Review Team" or something. Just an email link without context seems a like a wasted opportunity.
Comment Actions
I'd like to wait for a better use case before trying to separate protocol filtering in link/redirection contexts. Linking to a wiki page or similar seems reasonable in footers, and there's diversity and some security complications in other affected contexts (today: object profile menus, footer links, core external redirects, "Link" custom fields, {nav} elements, OAuth callback URIs).
mailto and tel links will work in Remarkup, so the linked page may contain a direct mailto:.