Page MenuHomePhabricator
Feed Advanced Search

Feb 5 2016

epriestley added a comment to T6502: Policy to define who can move cards in a workboard.

This is probably happening tomorrow, unless I am just toying with everyone's emotions.

Feb 5 2016, 10:30 PM · Projects, Wikimedia, Policy, Workboards
epriestley created Blog Post: Clarifying Projects as a General Purpose Tool.
Feb 5 2016, 10:28 PM · Projects
epriestley closed T10279: Allow bot users to see email addresses of users as Wontfix.

Yeah, this feature was a mistake and the data should never have been disclosed. We consider user email addresses private. I don't plan to expose this information again.

Feb 5 2016, 9:55 PM · Feature Request
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

I think I can fix that. The current assumption is that the wrap is the result of multiple words:

Feb 5 2016, 9:48 PM · Remarkup, Typeahead
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Feb 5 2016, 9:34 PM · Projects (v3)
epriestley added a comment to T10286: Design a Milestone Tag.

This bare "v3" in the is still a little weird:

Feb 5 2016, 8:52 PM · Restricted Project, Design, Projects (v3)
epriestley added a revision to T10289: Clarify project type in search typeahead: Unknown Object (Differential Revision).
Feb 5 2016, 8:45 PM · Projects (v3)
epriestley closed T10287: Clicking on a Milestone's workboard link 404's as Resolved by committing Restricted Diffusion Commit.
Feb 5 2016, 8:26 PM · Projects (v3), Bug Report
epriestley added a revision to T10287: Clicking on a Milestone's workboard link 404's: Unknown Object (Differential Revision).
Feb 5 2016, 8:25 PM · Projects (v3), Bug Report
epriestley added a revision to T10286: Design a Milestone Tag: Unknown Object (Differential Revision).
Feb 5 2016, 8:25 PM · Restricted Project, Design, Projects (v3)
epriestley added a comment to T10286: Design a Milestone Tag.

yeah whatever

Feb 5 2016, 8:17 PM · Restricted Project, Design, Projects (v3)
epriestley added a comment to T10286: Design a Milestone Tag.

》 looks okayish but has weird spacing:

Feb 5 2016, 8:17 PM · Restricted Project, Design, Projects (v3)
epriestley added a comment to T10286: Design a Milestone Tag.

❱ he he he

Feb 5 2016, 8:15 PM · Restricted Project, Design, Projects (v3)
epriestley added a comment to T10286: Design a Milestone Tag.

HOLD ON WE HAVE HUNDREDS OF BRACKETS TO LOOK THROUGH STILL

Feb 5 2016, 8:14 PM · Restricted Project, Design, Projects (v3)
epriestley added a comment to T10286: Design a Milestone Tag.

⟩ doesn't have the bad spacing but does have an odd baseline:

Feb 5 2016, 8:13 PM · Restricted Project, Design, Projects (v3)
epriestley added a comment to T10286: Design a Milestone Tag.

〉 has the bad spacing and also a weird baseline:

Feb 5 2016, 8:12 PM · Restricted Project, Design, Projects (v3)
epriestley added a comment to T10286: Design a Milestone Tag.

〉 looks a lot better, except that it has some kind of bizarre super-wide right margin on the actual glyph, at least on my system/font:

Feb 5 2016, 8:11 PM · Restricted Project, Design, Projects (v3)
epriestley added a comment to T10286: Design a Milestone Tag.

Well, it doesn't look awesome either:

Feb 5 2016, 8:10 PM · Restricted Project, Design, Projects (v3)
epriestley added a comment to T10286: Design a Milestone Tag.

› probably doesn't look that bad.

Feb 5 2016, 8:06 PM · Restricted Project, Design, Projects (v3)
epriestley added a comment to T10286: Design a Milestone Tag.

it's beautiful

Feb 5 2016, 8:03 PM · Restricted Project, Design, Projects (v3)
epriestley closed T10115: Upgrading: Unique, Sensible Repository Slugs as Resolved.

This has been live for a few weeks without any issues, and I generally expect it to have nearly zero impact on reasonable workflows, so I'm going to assume the best and close this out.

Feb 5 2016, 8:01 PM · Diffusion, Installing & Upgrading
epriestley closed T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed as Resolved.

The WMF-specific aspects of this are covered on the WMF install in https://phabricator.wikimedia.org/T125104, and that looks like it has a promising path forward that doesn't rely on this event. We haven't seen other outstanding unresolved issues and this has been in the wild for about two months now, so I'm going to assume the best and close it out.

Feb 5 2016, 7:59 PM · Maniphest, Installing & Upgrading
epriestley closed T10180: Upgrading: Project Members, Watchers and Subscribers as Resolved.

This has been live for a couple weeks without making any waves and these changes were all pretty straightforward so I'm going to assume we're in good shape, but yell if anyone bumps into issues.

Feb 5 2016, 7:54 PM · Projects (v3), Installing & Upgrading
epriestley added a member for Community: 20after4.
Feb 5 2016, 7:35 PM
epriestley updated the post content for Blog Post: Projects in Policy Controls: No Longer Total Garbage.
Feb 5 2016, 6:17 PM · Policy, Projects
chad awarded Blog Post: Projects in Policy Controls: No Longer Total Garbage a Love token.
Feb 5 2016, 6:15 PM · Policy, Projects
epriestley created Blog Post: Projects in Policy Controls: No Longer Total Garbage.
Feb 5 2016, 6:15 PM · Policy, Projects
epriestley closed T4136: Project options shown in Policy control should be smarter and more powerful as Resolved by committing Restricted Diffusion Commit.
Feb 5 2016, 5:50 PM · Projects, Policy
epriestley added a comment to T10283: improve differential emails, optimizing for efficiency.

Broadly, these emails can certainly be improved (see T6600; see also some outstanding known issues like T6576, T7031, T7030, although I think those are non-impactful). The "with context" inlines and inline diffs are particularly bad, but these features are off by default and I believe they generally run counter to the goals of the mail and do not expect most installs to enable them (they exist for a variety of historical reasons, and because some installs have special needs), so they've been fairly far down the priority list.

Feb 5 2016, 4:36 PM · Mail, Restricted Project, Feature Request
epriestley added a comment to T10283: improve differential emails, optimizing for efficiency.

Couple of quick basics for easily addressable / surface issues:

Feb 5 2016, 4:29 PM · Mail, Restricted Project, Feature Request
yelirekim awarded T9789: Make it easier to write custom transaction types a Doubloon token.
Feb 5 2016, 9:00 AM · Modernization, Transactions
rdfree50 awarded T3967: Build a 2-up preview mode into the fullscreen Remarkup editor a Piece of Eight token.
Feb 5 2016, 4:27 AM · Remarkup
rdfree50 awarded T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed a Piece of Eight token.
Feb 5 2016, 4:25 AM · Maniphest, Installing & Upgrading
rdfree50 awarded T10003: Upgrading: Maniphest field-level policies ("Can Prioritize Tasks", etc.) have been deprecated and will be removed a Manufacturing Defect? token.
Feb 5 2016, 4:24 AM · Policy, Maniphest, Installing & Upgrading
rdfree50 awarded T10004: ApplicationEditor Errata a Mountain of Wealth token.
Feb 5 2016, 4:22 AM · ApplicationEditor
epriestley closed T10280: large file still stored in mysql when "mysql-engine.max-size=5mb" as Wontfix.

The behavior is not inconsistent with the documentation, and the documentation does not suggest the configuration you selected.

Feb 5 2016, 3:51 AM · Bug Report
epriestley added a comment to T10274: Did arc land --hold change behavior?.

I was referring to T9973

Feb 5 2016, 3:45 AM · Bug Report

Feb 4 2016

epriestley merged task T10278: allow maniphest forms to require an entry in a field into T6030: Allow CustomFields to specify additional options (like "required") configurable in `<application>.fields`.
Feb 4 2016, 9:35 PM · ApplicationEditor, Feature Request
epriestley merged T10278: allow maniphest forms to require an entry in a field into T6030: Allow CustomFields to specify additional options (like "required") configurable in `<application>.fields`.
Feb 4 2016, 9:35 PM · Restricted Project, Restricted Project, Custom Fields
epriestley added a comment to T10278: allow maniphest forms to require an entry in a field.

See also T5118.

Feb 4 2016, 9:35 PM · ApplicationEditor, Feature Request
epriestley added a comment to T7650: Support Impressum for public policy legal compliance.

I guess "impressum" is the "mesothelioma" of 2016.

Feb 4 2016, 8:25 PM
epriestley added a comment to T7650: Support Impressum for public policy legal compliance.

Actually, I'm pretty sure @denialgorge's comment is also SEO spam!

Feb 4 2016, 8:22 PM
epriestley added a comment to T7650: Support Impressum for public policy legal compliance.

Pretty sure that was SEO spam, not just bumbling.

Feb 4 2016, 8:22 PM
epriestley added a revision to T4136: Project options shown in Policy control should be smarter and more powerful: Unknown Object (Differential Revision).
Feb 4 2016, 8:20 PM · Projects, Policy
epriestley updated the task description for T10010: Implement Subprojects.
Feb 4 2016, 3:59 PM · Projects (v3)
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Feb 4 2016, 3:58 PM · Projects (v3)
epriestley closed T10275: People profile display error when prototypes are disabled as Resolved by committing Restricted Diffusion Commit.
Feb 4 2016, 3:17 PM · Badges, People, Bug Report
epriestley merged task T10276: Aphlict option parsing for empty values into T8982: Aphlict wont LISTEN to 22280 if notification.client-uri is switch to /ws (nginx).
Feb 4 2016, 3:17 PM · Bug Report
epriestley updated subscribers of T8982: Aphlict wont LISTEN to 22280 if notification.client-uri is switch to /ws (nginx).
Feb 4 2016, 3:17 PM · Restricted Project, Aphlict
epriestley added a revision to T10275: People profile display error when prototypes are disabled: Unknown Object (Differential Revision).
Feb 4 2016, 3:15 PM · Badges, People, Bug Report
epriestley claimed T10275: People profile display error when prototypes are disabled.
Feb 4 2016, 3:15 PM · Badges, People, Bug Report
storrgie awarded T9378: Build Projects v3 a Love token.
Feb 4 2016, 2:25 PM · Projects (v3), Prioritized
epriestley deleted Demo Page.
Feb 4 2016, 1:03 PM
epriestley updated the task description for T10010: Implement Subprojects.
Feb 4 2016, 2:28 AM · Projects (v3)
epriestley updated the task description for T10010: Implement Subprojects.
Feb 4 2016, 2:27 AM · Projects (v3)
epriestley added a comment to T10274: Did arc land --hold change behavior?.

Where's the other request for this?

Feb 4 2016, 1:38 AM · Bug Report
epriestley changed the status of T10274: Did arc land --hold change behavior? from Invalid to Resolved.
Feb 4 2016, 1:29 AM · Bug Report
epriestley added a comment to T10274: Did arc land --hold change behavior?.

In your first example, you can likely:

Feb 4 2016, 1:28 AM · Bug Report
epriestley added a comment to T10274: Did arc land --hold change behavior?.

T9657 is probably the relevant guidance. There is no way to get the old behavior back.

Feb 4 2016, 1:25 AM · Bug Report
epriestley closed T10274: Did arc land --hold change behavior? as Invalid.

This is not a valid Phabricator bug report. Please see Contributing Bug Reports.

Feb 4 2016, 1:23 AM · Bug Report
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Feb 4 2016, 1:23 AM · Projects (v3)
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

I'm not planning to touch all the cases like ` #x, {nav #x, ``` #x, %%% #x, etc. We don't have a client-side Remarkup parser and I'm not planning to build one for this. See T3725#39466 for some earlier discussion.

Feb 4 2016, 12:37 AM · Remarkup, Typeahead
joshuaspence added a comment to T10163: Remarkup Autocomplete Errata.

This currently triggers autocomplete, but probably shouldn't: ` #f.

Feb 4 2016, 12:24 AM · Remarkup, Typeahead

Feb 3 2016

epriestley added a comment to T10273: Viewing any file (regardless of size) in Diffusion throws Unhandled Exception..

and also the culprit! hoo hoo hoo!!

Feb 3 2016, 10:47 PM · Diffusion, Bug Report
epriestley closed T10273: Viewing any file (regardless of size) in Diffusion throws Unhandled Exception. as Resolved by committing Restricted Diffusion Commit.
Feb 3 2016, 10:46 PM · Diffusion, Bug Report
epriestley added a revision to T10273: Viewing any file (regardless of size) in Diffusion throws Unhandled Exception.: Unknown Object (Differential Revision).
Feb 3 2016, 10:45 PM · Diffusion, Bug Report
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Feb 3 2016, 9:07 PM · Projects (v3)
epriestley added a comment to T10000: Consider restoring Clowncopterize.

It can't currently move to translations or be per-user because it has global effects, notably the availability of "silly" statuses in Maniphest. We can't show different users different sets of available task statuses.

Feb 3 2016, 8:38 PM · Differential, Feature Request
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Feb 3 2016, 8:14 PM · Projects (v3)
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Feb 3 2016, 8:03 PM · Projects (v3)
epriestley added a comment to T10000: Consider restoring Clowncopterize.

Such a setting already exists: Config → phabricator.serious-business

Feb 3 2016, 7:42 PM · Differential, Feature Request
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Feb 3 2016, 7:08 PM · Projects (v3)
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Feb 3 2016, 5:52 PM · Projects (v3)
spawnlt awarded T6526: Implement "Badges" or "Medals", for annotating special users a Like token.
Feb 3 2016, 5:43 PM · Restricted Project, Badges (v0), People
epriestley added a comment to T10260: Harbormaster Herald Rules.

To be more specific, I just mean:

Feb 3 2016, 5:31 PM · Haskell.org, Restricted Project, Harbormaster, Feature Request
epriestley edited projects for T10264: git clone using http hangs after update, added: Bug Report (Needs Information); removed Bug Report.

I'm out of ideas and can't reproduce this problem, then, so we can't move forward (see Contributing Bug Reports). Here's, e.g., this working fine for me against this server:

Feb 3 2016, 4:52 PM · Bug Report, Diffusion
epriestley changed the status of T10265: VCS password using LDAP from Wontfix to Resolved by committing Restricted Diffusion Commit.
Feb 3 2016, 3:23 PM · Diffusion, Feature Request
epriestley closed T10054: Define product direction for Project/Profile UIs as Resolved.

I think this has served its purpose, so I'm going to close it out. Results:

Feb 3 2016, 2:50 PM · Projects
epriestley closed T10054: Define product direction for Project/Profile UIs, a subtask of T10010: Implement Subprojects, as Resolved.
Feb 3 2016, 2:50 PM · Projects (v3)
epriestley closed T10271: Test bug as Spite.
Feb 3 2016, 2:37 PM · Bug Report
epriestley added a comment to T10260: Harbormaster Herald Rules.

How are these tests executing?

Feb 3 2016, 2:14 PM · Haskell.org, Restricted Project, Harbormaster, Feature Request
epriestley added a comment to T10264: git clone using http hangs after update.

I'm unable to reproduce this against this host or hosts in the Phacility cluster.

Feb 3 2016, 2:12 PM · Bug Report, Diffusion
epriestley closed T10265: VCS password using LDAP as Wontfix.

D15173 updates the documentation.

Feb 3 2016, 2:02 PM · Diffusion, Feature Request
epriestley added a revision to T10265: VCS password using LDAP: Unknown Object (Differential Revision).
Feb 3 2016, 1:58 PM · Diffusion, Feature Request
epriestley closed T10270: Permissions posture for Database as Invalid.

doesn't seem like good practice

Feb 3 2016, 1:48 PM · Installing & Upgrading
joshuaspence added a comment to T10268: "Batch Edit" from workboards uses "?ids=X,Y,Z" which can exceed "Location" header or URL byte limits for large task sets.

Yeah, I suspect that the length of the header is the issue.

Feb 3 2016, 12:10 PM · Customer Impact, Workboards, Maniphest
ohler awarded T10246: Deploy Drydock in the Phacility cluster a Orange Medal token.
Feb 3 2016, 4:45 AM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
joshuaspence added a comment to T9348: No way to kick users out of a Conpherence.

I tried doing an arc diff to submit my patch but ran into this,

[2016-02-02 21:15:55] EXCEPTION: (PhutilTypeExtraParametersException) Got unexpected parameters: standard at [<phutil>/src/parser/PhutilTypeSpec.php:150]
arcanist(), phabricator(head=master, ref.master=3264d9f680cb), phutil()
  #0 PhutilTypeSpec::checkMap(array, array) called at [<arcanist>/src/lint/engine/ArcanistConfigurationDrivenLintEngine.php:90]
  #1 ArcanistConfigurationDrivenLintEngine::buildLinters() called at [<arcanist>/src/workflow/ArcanistLintersWorkflow.php:44]
  #2 ArcanistLintersWorkflow::run() called at [<arcanist>/scripts/arcanist.php:382]

I could run through it by removing the following section in .arclint file,

,
    "xhpast": {
      "type": "xhpast",
      "include": "(\\.php$)"
    }

But it wouldn't let me commit.

Feb 3 2016, 12:28 AM · Conpherence (v4)

Feb 2 2016

epriestley added a comment to T10268: "Batch Edit" from workboards uses "?ids=X,Y,Z" which can exceed "Location" header or URL byte limits for large task sets.

If that's the case, a workaround is to query for the tasks in Maniphest with page size > 865 instead, then "Select All" and "Batch Edit Selected".

Feb 2 2016, 11:44 PM · Customer Impact, Workboards, Maniphest
epriestley added a comment to T10268: "Batch Edit" from workboards uses "?ids=X,Y,Z" which can exceed "Location" header or URL byte limits for large task sets.

Oh, maybe the issue is actually the redirect. Specifically, we'll end up issuing this:

Feb 2 2016, 11:43 PM · Customer Impact, Workboards, Maniphest
epriestley added a comment to T10268: "Batch Edit" from workboards uses "?ids=X,Y,Z" which can exceed "Location" header or URL byte limits for large task sets.

I can't immediately reproduce this by issuing a query for 1,000 tasks, then doing "Select All > Batch Edit Selected". The page takes a couple seconds, but loads fine.

Feb 2 2016, 11:41 PM · Customer Impact, Workboards, Maniphest
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Feb 2 2016, 11:36 PM · Projects (v3)
joshuaspence added a comment to T10269: Duplicate entry for key "key_object".

sorry that I can't provide reproduction steps

Historically, I don't think these tasks (error logs with no obvious negative effects and no reproduction steps) are very useful. I don't immediately know what's going on here, nor plan to dig into it unless it creates an observable problem.

Feb 2 2016, 11:36 PM · Maniphest
joshuaspence added a comment to T10268: "Batch Edit" from workboards uses "?ids=X,Y,Z" which can exceed "Location" header or URL byte limits for large task sets.

Well I don't choose any tasks, I guess it defaults to all objects visible on the workboard (of which there are 865).

Feb 2 2016, 11:34 PM · Customer Impact, Workboards, Maniphest
epriestley added a comment to T10268: "Batch Edit" from workboards uses "?ids=X,Y,Z" which can exceed "Location" header or URL byte limits for large task sets.

How many tasks are you attempting to batch edit?

Feb 2 2016, 10:33 PM · Customer Impact, Workboards, Maniphest
epriestley closed T10269: Duplicate entry for key "key_object" as Invalid.

sorry that I can't provide reproduction steps

Feb 2 2016, 10:32 PM · Maniphest
joshuaspence added a comment to T10269: Duplicate entry for key "key_object".

(This isn't a once off, there are a bunch of these errors)

Feb 2 2016, 10:07 PM · Maniphest
joshuaspence created T10269: Duplicate entry for key "key_object".
Feb 2 2016, 10:07 PM · Maniphest
joshuaspence created T10268: "Batch Edit" from workboards uses "?ids=X,Y,Z" which can exceed "Location" header or URL byte limits for large task sets.
Feb 2 2016, 10:05 PM · Customer Impact, Workboards, Maniphest
epriestley added a comment to T10266: Firefox body scroll fails when dragging tasks.

(Specifically, the scrolling is a feature which I added in D10188 but punted on making work in Firefox.)

Feb 2 2016, 9:57 PM · Firefox, Projects