Page MenuHomePhabricator
Feed Advanced Search

Nov 23 2015

epriestley added a comment to T9833: Remarkup comment areas have an excessively tall bottom margin.

Haven't seen any more issues since rolling the server; I'll keep my eyes peeled.

Nov 23 2015, 4:47 PM · Remarkup
epriestley updated subscribers of T8298: Fix Windows Escaping.
Nov 23 2015, 4:15 PM · Windows
epriestley merged task T6966: Windows quoting conventions still bad into T8298: Fix Windows Escaping.
Nov 23 2015, 4:15 PM · Windows, Arcanist
epriestley closed T7000: 404 when accessing repo via http as Invalid.

I can not reproduce this. Here's what I did:

Nov 23 2015, 4:14 PM · Diffusion
epriestley removed a reviewer for D11047: Inline Comments not working: Blessed Reviewers.
Nov 23 2015, 4:04 PM
epriestley closed T6777: Arcanist creates a branch when --nobranch is specified as Wontfix.

We haven't seen any other users find this confusing.

Nov 23 2015, 4:03 PM · Arcanist
epriestley added a comment to T4256: Support Azure as an auth provider.

As a general note, Azure appears to have both SAML and OAuth flavors. D10297 / D10289 implement the OAuth flavors, and don't invoke the messy SAML problem. I'm not sure if these providers are equivalent or not.

Nov 23 2015, 3:48 PM · Auth
epriestley moved T4256: Support Azure as an auth provider from Backlog to Far Future on the Auth board.
Nov 23 2015, 3:48 PM · Auth
epriestley added a comment to T4256: Support Azure as an auth provider.

Current state of the world is:

Nov 23 2015, 3:47 PM · Auth
epriestley updated subscribers of T4256: Support Azure as an auth provider.
Nov 23 2015, 3:45 PM · Auth
epriestley merged task T5899: Add support for authentication through Office 365 into T4256: Support Azure as an auth provider.
Nov 23 2015, 3:45 PM · Auth
epriestley closed T9832: Projects with specific hashtags cannot be referenced in Phriction and Maniphest as Resolved by committing Restricted Diffusion Commit.
Nov 23 2015, 2:50 PM · Remarkup, Projects
epriestley added a comment to T9789: Make it easier to write custom transaction types.

I think we can do this gradually by:

Nov 23 2015, 2:05 PM · Modernization, Transactions
epriestley claimed T9832: Projects with specific hashtags cannot be referenced in Phriction and Maniphest.
Nov 23 2015, 1:59 PM · Remarkup, Projects
epriestley closed T9831: Opening Changelog 2015.46 shows a PhutilInvalidState exception as Resolved.
Nov 23 2015, 1:59 PM · Phriction
epriestley closed T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier as Resolved by committing Restricted Diffusion Commit.
Nov 23 2015, 1:58 PM · Harbormaster, Drydock
epriestley added a revision to T9832: Projects with specific hashtags cannot be referenced in Phriction and Maniphest: Unknown Object (Differential Revision).
Nov 23 2015, 1:55 PM · Remarkup, Projects
epriestley added a comment to T9833: Remarkup comment areas have an excessively tall bottom margin.

(This is likely an example of the issue.)

Nov 23 2015, 1:44 PM · Remarkup
epriestley created T9833: Remarkup comment areas have an excessively tall bottom margin.
Nov 23 2015, 1:44 PM · Remarkup
epriestley added a comment to T9831: Opening Changelog 2015.46 shows a PhutilInvalidState exception.

Oh, this was already fixed at HEAD (rP06aa3a0a1b). I pushed this server, should be good now.

Nov 23 2015, 1:38 PM · Phriction
epriestley added a comment to T9831: Opening Changelog 2015.46 shows a PhutilInvalidState exception.

Thanks, I'll look into this.

Nov 23 2015, 1:34 PM · Phriction
epriestley claimed T9831: Opening Changelog 2015.46 shows a PhutilInvalidState exception.
Nov 23 2015, 1:34 PM · Phriction
joshuaspence added a comment to Q175: Should I Reuse Device Keys? (Answer 207).

Just wanted to clarify as I'm not entirely sure that I understand... So we currently have a puppet role named phabricator_worker which runs phd daemons. As a step in our puppet scripts, we basically run /usr/src/phabricator/bin/almanac register --device=worker.phabricator.example.com --private-key=/path/to/private.key.

Nov 23 2015, 2:08 AM

Nov 22 2015

epriestley closed T9806: Exception while editing Ponder comment to an answer as Resolved by committing Restricted Diffusion Commit.
Nov 22 2015, 11:12 PM · Ponder
epriestley added a revision to T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier: Unknown Object (Differential Revision).
Nov 22 2015, 11:01 PM · Harbormaster, Drydock
epriestley claimed T9806: Exception while editing Ponder comment to an answer.
Nov 22 2015, 10:59 PM · Ponder
epriestley added a comment to D14535: Add external-json linter.

This code looks good to me in a technical sense, we just don't want to take over maintaining it. Two minor suggestions:

Nov 22 2015, 10:53 PM
epriestley requested changes to D14535: Add external-json linter.

Per T9827, I currently believe this would be used by only one install and don't want to bring it upstream without seeing much broader interest first.

Nov 22 2015, 10:40 PM
epriestley closed T9827: Provide a more structured way of interfacing with external linters as Wontfix.

We haven't seen other requests in this vein from other users, and are not aware of a more general interest in using JSON bindings to write linters. From your problem description, it sounds like you have a fairly unusual and specific need within your project. We haven't seen other projects report similar needs, and I think this is isn't a good candidate for bringing upstream: we don't want to upstream code which will only be used by one install, and I have no reason to believe that these bindings will see wider use.

Nov 22 2015, 10:39 PM · Lint, Arcanist
epriestley added a revision to T9806: Exception while editing Ponder comment to an answer: Unknown Object (Differential Revision).
Nov 22 2015, 10:15 PM · Ponder
epriestley added a comment to T9806: Exception while editing Ponder comment to an answer.

This probably requires $types[] = PhabricatorTransactions::TYPE_EDGE; in PonderAnswerEditor->getTransactionTypes(). It would be vaguely nice to do this more automatically/consistently, but probably not worth pursuing some grander approach at this time. T9789 is probably on the horizon and represents a better opportunity.

Nov 22 2015, 10:13 PM · Ponder
epriestley moved T9811: Make it easier to diagnose command failures occurring inside Drydock allocations from Backlog to Far Future on the Drydock board.
Nov 22 2015, 10:09 PM · Drydock
epriestley added a comment to T9811: Make it easier to diagnose command failures occurring inside Drydock allocations.

This obscurity is currently intentional, for policy/security reasons. I don't want to leak anything sensitive into the relatively-accessible web UI.

Nov 22 2015, 10:09 PM · Drydock
epriestley added a comment to T9827: Provide a more structured way of interfacing with external linters.

See Contributing Feature Requests. Please describe the specific, concrete problem you're encountering.

Nov 22 2015, 10:08 PM · Lint, Arcanist
epriestley triaged T9811: Make it easier to diagnose command failures occurring inside Drydock allocations as Wishlist priority.
Nov 22 2015, 10:04 PM · Drydock
epriestley merged T9812: Show SSH diagnostic information in Drydock logs into T9811: Make it easier to diagnose command failures occurring inside Drydock allocations.
Nov 22 2015, 10:04 PM · Drydock
epriestley merged task T9812: Show SSH diagnostic information in Drydock logs into T9811: Make it easier to diagnose command failures occurring inside Drydock allocations.
Nov 22 2015, 10:04 PM · Drydock
epriestley closed T9814: Add SVG icon for Safari 9's pinned tabs as Resolved.

Fixed by D14527.

Nov 22 2015, 10:04 PM · User Delight
epriestley added a comment to T9825: Remarkup is rendered literally in Diviner.

To move forward, we should split this into two tasks:

Nov 22 2015, 10:03 PM · Diviner
epriestley triaged T9825: Remarkup is rendered literally in Diviner as Low priority.
Nov 22 2015, 10:02 PM · Diviner
epriestley added a comment to T9825: Remarkup is rendered literally in Diviner.

These cases aren't closely related.

Nov 22 2015, 10:01 PM · Diviner
epriestley renamed Blog Post: Development Notes (2015 Week 47) blog post from to Development Notes (2015 Week 47).
Nov 22 2015, 9:55 PM
epriestley edited the content of 2015 Week 47 (Late November).
Nov 22 2015, 9:18 PM
epriestley requested changes to D14535: Add external-json linter.

See Contributing Code.

Nov 22 2015, 9:05 PM
joshuaspence renamed T9826: Phriction saved page is not same as previewing one from phriction saved page is not same as previewing one. to Phriction saved page is not same as previewing one.
Nov 22 2015, 8:17 PM · Phriction
joshuaspence added a comment to T9784: `arc patch`: Directory move in SVN patch workflow is implemented erroneously.

@joshuaspence what do you think about this issue?

Nov 22 2015, 7:18 PM · Subversion, Arcanist
joshuaspence renamed T9819: Allow Phurl URLs to reference objects from allow multiple aliases to a phurl to Allow multiple aliases to a Phurl URL.
Nov 22 2015, 2:34 AM · Restricted Project, Phurl
joshuaspence added a comment to T9825: Remarkup is rendered literally in Diviner.

("No time specified" in Phame is a bit odd too, but I think that's been fixed already)

Nov 22 2015, 2:33 AM · Diviner

Nov 21 2015

epriestley added a comment to T9821: Allow Harbormaster build plans to run on branch push instead of per-commit.

Why can't your publish step just check if the commit is on master (or even if it's HEAD of master) and no-op if it isn't?

Nov 21 2015, 11:25 PM · Restricted Project, Harbormaster
joshuaspence added a project to T9824: Daemons and Web Have Different Config does not disappear after a reboot of Deamons: Daemons.
Nov 21 2015, 10:27 PM · Daemons
joshuaspence reopened T9825: Remarkup is rendered literally in Diviner as "Open".

I'm assuming that @terrismotox is just playing around.

Nov 21 2015, 10:25 PM · Diviner
joshuaspence added a project to T9825: Remarkup is rendered literally in Diviner: Remarkup.
Nov 21 2015, 9:46 PM · Diviner
joshuaspence created T9825: Remarkup is rendered literally in Diviner.
Nov 21 2015, 9:46 PM · Diviner
epriestley added a comment to T9823: Expand Phacility cluster repo and db tiers (add nodes: 005).

There was a minor config issue with db005 but I sorted that out; no users were affected.

Nov 21 2015, 8:56 PM · Phacility, Ops
epriestley closed T9823: Expand Phacility cluster repo and db tiers (add nodes: 005) as Resolved.

The 005 nodes are in production. I'm not going to bother with web002 for now but I'll probably do the other half of that the next time I do ops stuff.

Nov 21 2015, 8:42 PM · Phacility, Ops
epriestley added a revision to T9823: Expand Phacility cluster repo and db tiers (add nodes: 005): Unknown Object (Differential Revision).
Nov 21 2015, 8:29 PM · Phacility, Ops
epriestley closed T9824: Daemons and Web Have Different Config does not disappear after a reboot of Deamons as Invalid.

This message no longer exists at HEAD. Upgrade Phabricator.

Nov 21 2015, 8:28 PM · Daemons
epriestley closed T9291: When allocating services, the cluster should choose the same dbx and repox nodes as Resolved by committing Restricted Diffusion Commit.
Nov 21 2015, 8:25 PM · Phacility
epriestley added a revision to T9291: When allocating services, the cluster should choose the same dbx and repox nodes: Unknown Object (Differential Revision).
Nov 21 2015, 8:12 PM · Phacility
epriestley added a revision to T9823: Expand Phacility cluster repo and db tiers (add nodes: 005): Unknown Object (Differential Revision).
Nov 21 2015, 8:12 PM · Phacility, Ops
epriestley added a comment to T9807: `arc land` no longer works with upgraded Mercurial (3.6.1).

Awesome, thanks for the report!

Nov 21 2015, 8:00 PM · Arcanist, Mercurial
epriestley added a comment to T9823: Expand Phacility cluster repo and db tiers (add nodes: 005).

I've brought up the 005 nodes. I also brought up web002 while I was in there, although we don't appear to be near capacity on web001 yet.

Nov 21 2015, 6:28 PM · Phacility, Ops
epriestley edited the content of Phacility Cluster Devices.
Nov 21 2015, 5:55 PM
epriestley closed T9807: `arc land` no longer works with upgraded Mercurial (3.6.1) as Resolved by committing Restricted Diffusion Commit.
Nov 21 2015, 5:54 PM · Arcanist, Mercurial
epriestley created T9823: Expand Phacility cluster repo and db tiers (add nodes: 005).
Nov 21 2015, 5:45 PM · Phacility, Ops
epriestley added a comment to T9807: `arc land` no longer works with upgraded Mercurial (3.6.1).

That's the patch from earlier, yell if you spot any issues with it.

Nov 21 2015, 5:35 PM · Arcanist, Mercurial
epriestley claimed T9807: `arc land` no longer works with upgraded Mercurial (3.6.1).
Nov 21 2015, 5:34 PM · Arcanist, Mercurial
epriestley added a revision to T9807: `arc land` no longer works with upgraded Mercurial (3.6.1): Unknown Object (Differential Revision).
Nov 21 2015, 5:34 PM · Arcanist, Mercurial
epriestley triaged T9807: `arc land` no longer works with upgraded Mercurial (3.6.1) as Normal priority.
Nov 21 2015, 5:31 PM · Arcanist, Mercurial
epriestley triaged T9818: Memes with multiline texts have their text placed incorrectly as Wishlist priority.

Deeply tragic.

Nov 21 2015, 5:29 PM · Macros
epriestley updated subscribers of T9800: Upgrading: Possible issue with `xhpast` database for installs that upgraded between October 8, 2012 and October 9, 2012.

@mbishopim3, yeah, looks like you're lucky winner #2 on this. Your workaround (creating the database) was correct.

Nov 21 2015, 5:16 PM · Installing & Upgrading
epriestley renamed T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds from Adjust / consider policies surrounding who is able to restart, pause, abort builds to Require "Can Edit" permission on a build plan to pause or abort corresponding builds.
Nov 21 2015, 4:34 PM · Harbormaster (v3), Restricted Project
epriestley renamed T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier from Begin searching for Drydock / Harbormaster gremlins which prevent builds from starting properly to Add objectPHID to Harbormaster workers to make root cause analysis easier.
Nov 21 2015, 4:24 PM · Harbormaster, Drydock
epriestley added a comment to T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.

I'm going to repurpose this as "get that data in the database so we're better prepared if this happens again", but feel free to follow up if you go on a hunting expedition or hit the issue in the meantime.

Nov 21 2015, 4:24 PM · Harbormaster, Drydock
epriestley added a comment to T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds.

My specific plan here is:

Nov 21 2015, 4:23 PM · Harbormaster (v3), Restricted Project
epriestley triaged T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds as Normal priority.
Nov 21 2015, 4:22 PM · Harbormaster (v3), Restricted Project
epriestley moved T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier from Backlog to v2 on the Harbormaster board.
Nov 21 2015, 4:21 PM · Harbormaster, Drydock
epriestley moved T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds from Backlog to v2 on the Harbormaster board.
Nov 21 2015, 4:21 PM · Harbormaster (v3), Restricted Project
epriestley moved T9821: Allow Harbormaster build plans to run on branch push instead of per-commit from Backlog to Far Future on the Harbormaster board.
Nov 21 2015, 4:21 PM · Restricted Project, Harbormaster
epriestley triaged T9819: Allow Phurl URLs to reference objects as Wishlist priority.

If we do this, one has to be designated "primary" (like Projects) so we can get a consistent default /u/xyz when rendering. This broadly seems like a lot of work for not a lot of payoff, to me, at least today.

Nov 21 2015, 4:15 PM · Restricted Project, Phurl
epriestley triaged T9821: Allow Harbormaster build plans to run on branch push instead of per-commit as Wishlist priority.

It sounds like this use case (using Harbormaster to build a GitHub project, and not using Differential) is far afield from the use cases I consider core. There are a large number of existing tools (Travis, CircleCI) which are purpose-built to address this use case.

Nov 21 2015, 4:00 PM · Restricted Project, Harbormaster
epriestley edited the content of Changelog.
Nov 21 2015, 3:49 PM
epriestley edited the content of 2015 Week 47 (Late November).
Nov 21 2015, 3:49 PM
epriestley created 2015 Week 47 (Late November).
Nov 21 2015, 3:49 PM
epriestley edited the content of 2015 Week 45 (Early November).
Nov 21 2015, 3:21 PM

Nov 20 2015

chad awarded T9378: Build Projects v3 a Love token.
Nov 20 2015, 9:54 PM · Projects (v3), Prioritized
20after4 awarded T9378: Build Projects v3 a Love token.
Nov 20 2015, 9:01 PM · Projects (v3), Prioritized
epriestley added a comment to T7732: Convoluted flow when locked out of account with only one auth provider.

You can manually update phabricator_user.user_externalaccount to change the external account ID reference.

Nov 20 2015, 7:06 PM · Restricted Project, Auth
nipunn awarded T8227: Why not just add an option/setting/preference? a Like token.
Nov 20 2015, 6:44 AM · Guides

Nov 19 2015

joshuaspence added a revision to T1116: Function __phutil_autoload should probably not throw an exception if it is the only registered autoload function: Unknown Object (Differential Revision).
Nov 19 2015, 7:27 PM · libphutil
epriestley added a member for Blessed Committers: cburroughs.
Nov 19 2015, 4:09 PM
epriestley added Q224: Phabricator development - IDE (Answer 262).
Nov 19 2015, 4:08 PM
joshuaspence added a project to Q223: How to restrict outgoing MySQL ports to specific range: Aphront.
Nov 19 2015, 9:12 AM · Aphront
joshuaspence updated Q223: How to restrict outgoing MySQL ports to specific range from How to restrict outgoing aphrontMySQL ports to specific range to How to restrict outgoing MySQL ports to specific range.
Nov 19 2015, 9:12 AM · Aphront
joshuaspence added Q224: Phabricator development - IDE (Answer 260).
Nov 19 2015, 9:09 AM
joshuaspence added a comment to T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host.

For what it's worth, we have a very similar setup (40ish repositories in Phabricator, all hosted in Gitlab). We have not observed any performance issues such as those described in this ticket.

Nov 19 2015, 8:15 AM · Diffusion, Daemons
joshuaspence renamed T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier from Begin searching for drydock / harbormaster gremlins which prevent builds from starting properly to Begin searching for Drydock / Harbormaster gremlins which prevent builds from starting properly.
Nov 19 2015, 7:32 AM · Harbormaster, Drydock
epriestley closed T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host as Invalid.

Since we don't have access to whatever GitLab is measuring, we can't understand this issue in greater detail. Particularly, we can not reproduce the underlying heavy load in a way we can examine. We have not seen similar reports from other users, except @jcarrillo7, who has not filed any details. We have many installs with hundreds of repositories and my expectation is that the operation is cheap, so I suspect this may be an issue unique to GitLab.

Nov 19 2015, 3:32 AM · Diffusion, Daemons
epriestley added a comment to T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.

My next step would be to put more crumbs in the UI, but we're missing a little data right now. Basically, I'd do this:

Nov 19 2015, 3:03 AM · Harbormaster, Drydock
epriestley added a comment to T9815: Fast repository polling on multiple repositories causes 2Hz polling of remote host.

huge amount of traffic

Nov 19 2015, 2:53 AM · Diffusion, Daemons