This provides a facility for implementing external linters which can
report violations via a JSON representation.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T9827: Provide a more structured way of interfacing with external linters
Try it
Diff Detail
Diff Detail
- Branch
- master
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 8980 Build 10544: arc lint + arc unit
Event Timeline
Comment Actions
Per T9827, I currently believe this would be used by only one install and don't want to bring it upstream without seeing much broader interest first.
Comment Actions
This code looks good to me in a technical sense, we just don't want to take over maintaining it. Two minor suggestions:
- phutil_utf8_strtolower() has better behavior than strtolower() on some utf8 inputs.
- phutil_json_decode() has better behavior (throws a detailed exception) on invalid JSON than json_decode() (returns false).
We don't currently have a way to, say, sign an extension as "this code is broadly reasonable and won't root your box or destroy your data, just not something the upstream wants to maintain or take responsibility for", but we might after T5055.
Comment Actions
Thanks for the review!
We don't currently have a way to, say, sign an extension as "this code is broadly reasonable and won't root your box or destroy your data, just not something the upstream wants to maintain or take responsibility for", but we might after T5055.
Sure. I'll be putting the code up here.