I would like to take this one step further and consider dependencies recursively. If task X blocks task Y, which itself blocks task Z, then I would like to be able to search for "tasks blocking Z" which should include both X and Y.

I guess this is related to / a duplicate of T4345.

Yeah, we usually try to make these pages have an alternate non-AJAX rendering. Even if users can't generally hit it, it makes debugging a lot easier and is usually trivial, so it tends to pay for itself in the long run.

A lot of the practical cases here are resolved, but the root problem still exists. Basically, the core issue is that an object can say:

the command has potential side effects, or the time of execution is important, and cannot be simply re-run under LC_ALL=C.

D13956 adds a new DarkConsole tab with performance information about request startup. Here's what it looks like on this server:

system default locale

Also not mentioned here is cases where we phutil_passthru() some command like git push. These would be best run in the system default locale, since we echo the output to the user -- unless we also parse it. I think we never do this right now, but I'm not 100% sure.

See also T7339, which is somewhat related.

(Maybe we should modularize profile panels and then just let Ponder stick a stats panel on your profile?)

Oh I'm not fussed about not being able to prioritize tasks on this install, I just was confused and initially thought I had stumbled across a bug.

Yeah, @chad locked this down (I think to stop new users from, e.g., filing "High" priority issues).

Actually, it seems that the "Can Prioritize Tasks" policy on this install has changed. I think that the option to change priority should probably still be visible though, even if it is not allowed by policies. Generally I thought that this was the preferred approach (showing as disabled rather than hiding).

At HEAD, I think we've replaced the bar with icons everywhere, and I think we're planning to let different priorities have different icons, so this information will no longer be communicated only through the use of color once that happens (@chad, does that sound right?).

To avoid this warning set 'always_populate_raw_post_data' to '-1' in php.ini

Maybe I'll take a shot at this before T9132 starts rolling out since that will probably involve touching every /edit/ route in every application, much like we previously replaced every /query/ route for ApplicationSearch.

Ah, thanks. That makes sense.

If you want to hunt those down I'll review 'em, but am generally in agreement with @chad here that this is the minorest of nits.

It's also nice to have the whole current/new title linked, so maybe ideal would be:

Ah that's true, I wasn't considering historical stories. But yes, "from X to Y" definitely reads better IMO.

Yeah that's seem fair. The "changed title" use case seems different to others (such as "changed subscribers") because the {T123} includes the title anyway.

I think there are two separate issues here:

I don't quite understand the use case here... I imagine that importing repositories is something that happens very infrequently and so I think that such a change would have no effect most of the time. Am I misunderstanding?

In T9192#132389, @avivey wrote:

Maybe rename the edit page "advanced" or something, and let anyone with "can view" see it?

Pretty much all the hg stuff uses bookmarks where the git stuff would use branches. This partly makes more sense with Mercurial (in Mercurial, branches are normally permanent and durable, and Mercurial warns you about this when you create one and asks if you meant to create a bookmark instead -- Mercurial bookmarks are more similar to Git branches than Mercurial branches are), and partly Facebook was heavily involved in shaping the Mercurial flows and they use bookmarks.

I've historically thought about this mostly from the point of view of having the $object reach up to the $application and get URIs from it -- since the Application defines the routes -- but maybe that's not really the right way to tackle it, especially since it's hard to generate URIs from routes but relatively easy to generate routes from URIs.

I'm not familiar with Mercurial, but are these feature branches which are eventually merged into a master branch? If so, I've had a thought about this previously... What if you could just put the Ref T5 message in the merge commit and have that associate all commits from the merge with the task? I'm not sure if this is easy to do technically because a branch could be merged into multiple other branches.

getApplicationURI() only solves this for the first part of the path (although that happens to be the issue here), and isn't available inside the Editor where mail is being constructed. One thing we could do is throw if URIs passed to getApplicationURI() don't route when in development mode, although that doesn't feel amazing.

Lol nice.

From memory, that just gets the /badges/ part of the URL? I'm talking about this (I'm on the train so excuse the pseudo-code):

I've seen a bunch of cases where dead URLs have persisted for a while before being caught... Have you given any thought to improving the way that we handle URLs? I feel like there should be some getUrl() method for most (all?) objects.

I've often been frustrated by this. It's possible to associate differential revisions with a task from the task itself, but not for commits.

Yes, the related tasks added a direct way to accomplish this by using Herald rules.

Hmm, okay. In the short term, I think we can bring some equivalent of MavenTestEngine upstream after T5568, more or less as written.

Yeah, maybe a good general question is: does mvn-unit <one trivial test> run in under, say, 60 seconds in any realistic environment? If the answer is "no", maybe arc diff isn't a good venue for these tests.

We could fix the "maven-make can't detect a no-op quickly" issue in arc itself by letting your test engine say "run maven-make unless some other part of the current arc workflow already ran it and hasn't made changes to the working copy in the meantime", since we're fine with assuming that the rest of the world is frozen while you're running arc.

Also, just to check that my thinking is right since I'm not in touch with the Java world, we're really talking about Maven here, not Java in general, right? Maven is just a build tool for Java, not part of the core language? Is it so ubiquitous that it's effectively universal, or is it just the most common/popular tool? How are Maven, Gradle, and Ant related? Is Maven also used for other languages (Scala, Groovy)?

Can you compile the code explicitly, without running tests?

This seems to have completed without incident.

I've added support for dedicated log volumes (see commit above). Only repo class hosts currently have much use for them, although I'd expect to deploy them more widely eventually.