Page MenuHomePhabricator

Require all Differential reviews to accept before greenlighting a review
Closed, DuplicatePublic

Description

Problem

Some reviews require multiple people to accept it:

  1. It touches code in multiple groups
  2. We're training someone to do code reviews and want to have someone sanity-check/shadow their review

Right now, code reviews are ready to land as soon as one reviewer accepts and no other reviewers have requested changes.

Feature request

It would be nice if there was a way to make code reviewers require all (rather than any) reviewers to accept.

Workaround

The only workaround right now is to have all reviewers who we need to accept to "request changes" immediately, which doesn't scale well and is a pain.

Event Timeline

mjlyons raised the priority of this task from to Needs Triage.
mjlyons updated the task description. (Show Details)
mjlyons added a project: Restricted Project.
mjlyons added subscribers: jhurwitz, angie, mjlyons.
avivey added a subscriber: avivey.

You can set Projects to be Blocking Reviewers via Herald.

angie moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Aug 14 2015, 8:29 PM