Page MenuHomePhabricator

Some objects are not properly rejected from willFilterPage() by calling didRejectResult(), producing "Unknown Object (Object Type)"
Closed, ResolvedPublic


If objects are rejected from willFilterPage(), they should be didRejectResult()'d before being discarded. Without this, handles won't be able to distinguish between unknown and filtered results, and may render "Unknown Object (Diffusion Commit)" instead of "Restricted Diffusion Commit".


Just throwing this in Maniphest so I don't forget about it; see IRC.

@mbishopim3 reported users being confused about "Unknown Object" emails, and particularly thinking that they were erroneous. These are supposed to say "Restricted Task" / "Restricted Revision", etc., not "Unknown Object", so that's an issue at a minimum.

Beyond that, we may want to improve the wording on these emails (e.g., if the mail renders handles which are restricted, include a note like "You don't have permission to see some of the objects discussed in this email.").

I wasn't able to reproduce this immediately yesterday, but got pulled off after like two seconds of poking at it.

Event Timeline

epriestley claimed this task.
epriestley raised the priority of this task from to Needs Triage.
epriestley updated the task description. (Show Details)
epriestley added a project: Policy.
epriestley added subscribers: epriestley, mbishopim3.

At this point, I'd guess this is probably something real dumb like us rendering the text forms of these wrong.

epriestley triaged this task as Normal priority.Jun 14 2015, 9:55 PM

I actually can't reproduce this immediately now, either.

$ ./bin/mail show-outbound --id 3335
ID: 3335
Status: sent
Related PHID: PHID-TASK-iuzuas3cjw37zbl45cuo

subject: T50: Skunk Parent
from: PHID-USER-cvfydnwadpdj7vdon36z
subject-prefix: [Maniphest]
vary-subject-prefix: [Updated]
thread-id: maniphest-task-PHID-TASK-iuzuas3cjw37zbl45cuo
exclude: []
herald-force-recipients: []
mailtags: ["maniphest-other"]
is-bulk: 1
to: ["PHID-USER-3luhmalv2kqfvgkm4xy7"]

Thread-Topic: T50: Skunk Parent
X-Herald-Rules: none
X-Phabricator-Projects: <#dog_project>
X-Phabricator-To: <PHID-USER-cvfydnwadpdj7vdon36z>
X-Phabricator-Cc: <PHID-USER-3luhmalv2kqfvgkm4xy7>
X-Phabricator-Cc: <PHID-USER-oholbjw3zgtbvzqzwk7p>
X-Phabricator-Cc: <PHID-USER-cvfydnwadpdj7vdon36z>

  nnn (nnn)

admin added a blocking task: Restricted Maniphest Task.



To: admin
Cc: nnn, saurus, admin

<div>admin added a blocking task: Restricted Maniphest Task.</div><br /><div><strong>TASK DETAIL</strong><div><a href="" rel="noreferrer"></a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="" rel="noreferrer"></a></div></div><br /><div><strong>To: </strong>admin<br /><strong>Cc: </strong>nnn, saurus, admin<br /></div>

Let me see if it's specific to commits, maybe? Since that was the specific issue in @joshuaspence's T6367 repro...

epriestley renamed this task from Maniphest emails about policy-filtered objects show "Unknown Object" instead of "Restricted Task" to Some objects are not properly rejected from willFilterPage() by calling didRejectResult(), producing "Unknown Object (Object Type)".Jun 14 2015, 10:25 PM
epriestley updated the task description. (Show Details)

Turns out these are type-by-type, so yell if you see more and I'll just close this sooner or later if nothing turns up.

We haven't seen more of these for a few months and I've been more consistent about tidying them up so I'm just going to close this out, but let us know if anyone catches more of these.