Page MenuHomePhabricator
Create Task
Maniphest T4345

Some objects are not properly rejected from willFilterPage() by calling didRejectResult(), producing "Unknown Object (Object Type)"
Closed, ResolvedPublic
Actions

Description

If objects are rejected from willFilterPage(), they should be didRejectResult()'d before being discarded. Without this, handles won't be able to distinguish between unknown and filtered results, and may render "Unknown Object (Diffusion Commit)" instead of "Restricted Diffusion Commit".

Previously

Just throwing this in Maniphest so I don't forget about it; see IRC.

@mbishopim3 reported users being confused about "Unknown Object" emails, and particularly thinking that they were erroneous. These are supposed to say "Restricted Task" / "Restricted Revision", etc., not "Unknown Object", so that's an issue at a minimum.

Beyond that, we may want to improve the wording on these emails (e.g., if the mail renders handles which are restricted, include a note like "You don't have permission to see some of the objects discussed in this email.").

I wasn't able to reproduce this immediately yesterday, but got pulled off after like two seconds of poking at it.

Revisions and Commits

rP Phabricator
D13981rP9e3f3e692d7f Use didRejectResult() when querying workboard columns
D13289rP2fbc65e39649 Call didRejectResult() in DiffusionCommitQuery properly

Related Objects

Event Timeline

epriestley created this task.Jan 25 2014, 8:42 PM
epriestley claimed this task.
epriestley raised the priority of this task from to Needs Triage.
epriestley updated the task description. (Show Details)
epriestley added a project: Policy.
epriestley added subscribers: epriestley, mbishopim3.
• ryanlopez310 closed this task as Invalid.Jul 21 2014, 2:20 PM
epriestley reopened this task as Open.Jul 21 2014, 2:21 PM
epriestley mentioned this in T7781: Make feed.http-hooks staff-editable or user-editable.Apr 8 2015, 6:45 PM
cburroughs added a subscriber: cburroughs.Apr 8 2015, 6:46 PM
epriestley mentioned this in T6367: Send email with recipient's language and access levels, not sender's.Jun 14 2015, 9:24 PM
joshuaspence added a subscriber: joshuaspence.Jun 14 2015, 9:25 PM
epriestley added a comment.Jun 14 2015, 9:32 PM

At this point, I'd guess this is probably something real dumb like us rendering the text forms of these wrong.

epriestley triaged this task as Normal priority.Jun 14 2015, 9:55 PM
epriestley added a comment.Jun 14 2015, 10:03 PM

I actually can't reproduce this immediately now, either.

$ ./bin/mail show-outbound --id 3335
PROPERTIES
ID: 3335
Status: sent
Related PHID: PHID-TASK-iuzuas3cjw37zbl45cuo
Message: 

PARAMETERS
subject: T50: Skunk Parent
from: PHID-USER-cvfydnwadpdj7vdon36z
subject-prefix: [Maniphest]
vary-subject-prefix: [Updated]
thread-id: maniphest-task-PHID-TASK-iuzuas3cjw37zbl45cuo
is-first-message: 
exclude: []
herald-force-recipients: []
mailtags: ["maniphest-other"]
is-bulk: 1
reply-to: T50+12+c23f289ede1e8501@local.phacility.com
to: ["PHID-USER-3luhmalv2kqfvgkm4xy7"]

HEADERS
Thread-Topic: T50: Skunk Parent
X-Herald-Rules: none
X-Phabricator-Projects: <#dog_project>
X-Phabricator-To: <PHID-USER-cvfydnwadpdj7vdon36z>
X-Phabricator-Cc: <PHID-USER-3luhmalv2kqfvgkm4xy7>
X-Phabricator-Cc: <PHID-USER-oholbjw3zgtbvzqzwk7p>
X-Phabricator-Cc: <PHID-USER-cvfydnwadpdj7vdon36z>

RECIPIENTS
  nnn (nnn)

TEXT BODY
admin added a blocking task: Restricted Maniphest Task.

TASK DETAIL
  http://local.phacility.com/T50

EMAIL PREFERENCES
  http://local.phacility.com/settings/panel/emailpreferences/

To: admin
Cc: nnn, saurus, admin


HTML BODY
<div>admin added a blocking task: Restricted Maniphest Task.</div><br /><div><strong>TASK DETAIL</strong><div><a href="http://local.phacility.com/T50" rel="noreferrer">http://local.phacility.com/T50</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="http://local.phacility.com/settings/panel/emailpreferences/" rel="noreferrer">http://local.phacility.com/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>admin<br /><strong>Cc: </strong>nnn, saurus, admin<br /></div>

Let me see if it's specific to commits, maybe? Since that was the specific issue in @joshuaspence's T6367 repro...

epriestley renamed this task from Maniphest emails about policy-filtered objects show "Unknown Object" instead of "Restricted Task" to Some objects are not properly rejected from willFilterPage() by calling didRejectResult(), producing "Unknown Object (Object Type)".Jun 14 2015, 10:25 PM
epriestley updated the task description. (Show Details)
epriestley added a revision: D13289: Call didRejectResult() in DiffusionCommitQuery properly.Jun 14 2015, 10:28 PM
epriestley added a comment.Jun 14 2015, 10:35 PM

Turns out these are type-by-type, so yell if you see more and I'll just close this sooner or later if nothing turns up.

epriestley added a commit: rP2fbc65e39649: Call didRejectResult() in DiffusionCommitQuery properly.Jun 14 2015, 10:35 PM
aklapper added a subscriber: aklapper.Jun 15 2015, 10:17 AM
joshuaspence mentioned this in T9250: "Unknown Object" shown when an object is moved on a workboard that cannot be seen.Aug 23 2015, 3:22 AM
epriestley added a revision: D13981: Use didRejectResult() when querying workboard columns.Aug 23 2015, 2:23 PM
epriestley added a commit: rP9e3f3e692d7f: Use didRejectResult() when querying workboard columns.Aug 23 2015, 3:31 PM
epriestley closed this task as Resolved.Dec 19 2015, 3:39 PM

We haven't seen more of these for a few months and I've been more consistent about tidying them up so I'm just going to close this out, but let us know if anyone catches more of these.

Phabricator · Built by Phacility