Page MenuHomePhabricator

Aggregate exceptions aren't displayed on linter failures
Open, Needs TriagePublic

Description

I am testing some changes to ArcanistXHPASTLinter and I got the following failure:

Assertion failed, expected values to be equal (at ArcanistLinterTestCase.php:173): Some linters failed:
    - Exception: Child in position '1' is not of type 'n_CALL_PARAMETER_LIST': a node of type n_METHOD_CALL: "$o->m()[0]"

#0 /home/joshua/workspace/github.com/phacility/arcanist/src/lint/linter/__tests__/ArcanistLinterTestCase.php(132): ArcanistLintEngine->run()
#1 /home/joshua/workspace/github.com/phacility/arcanist/src/lint/linter/__tests__/ArcanistLinterTestCase.php(44): ArcanistLinterTestCase->lintFile('/home/joshua/wo...', Object(ArcanistXHPASTLinter))
#2 /home/joshua/workspace/github.com/phacility/arcanist/src/lint/linter/__tests__/ArcanistXHPASTLinterTestCase.php(6): ArcanistLinterTestCase->executeTestsInDirectory('/home/joshua/wo...')
#3 [internal function]: ArcanistXHPASTLinterTestCase->testLinter()
#4 /home/joshua/workspace/github.com/phacility/arcanist/src/unit/engine/phutil/PhutilTestCase.php(492): call_user_func_array(Array, Array)
#5 /home/joshua/workspace/github.com/phacility/arcanist/src/unit/engine/PhutilUnitTestEngine.php(69): PhutilTestCase->run()
#6 /home/joshua/workspace/github.com/phacility/arcanist/src/unit/engine/ArcanistConfigurationDrivenUnitTestEngine.php(143): PhutilUnitTestEngine->run()
#7 /home/joshua/workspace/github.com/phacility/arcanist/src/workflow/ArcanistUnitWorkflow.php(162): ArcanistConfigurationDrivenUnitTestEngine->run()
#8 /home/joshua/workspace/github.com/phacility/arcanist/scripts/arcanist.php(382): ArcanistUnitWorkflow->run()
#9 {main}

This isn't particular useful because I can't see the backtrace for the actual failure.

Event Timeline

joshuaspence claimed this task.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Arcanist.
joshuaspence added a subscriber: joshuaspence.
epriestley moved this task from Backlog to Upstream on the Arcanist board.Sep 27 2018, 3:17 PM