Page MenuHomePhabricator

"Show older changes" link spits out JSON when opened on a new tab
Open, Needs TriagePublic

Description

Middle-clicking the Show older changes link in a collapsed timeline just renders some JSON on the new tab.

I understand middle-clicking it is not The Way It's Meant to be Played™, but it does look ugly.

Event Timeline

jbeta created this task.Aug 22 2015, 5:10 AM
jbeta updated the task description. (Show Details)
jbeta added a subscriber: jbeta.

Yeah, we usually try to make these pages have an alternate non-AJAX rendering. Even if users can't generally hit it, it makes debugging a lot easier and is usually trivial, so it tends to pay for itself in the long run.

This one is a little more involved and might be a little tricky to generate a suitable standalone page for since it needs more context than many responses to make sense, but if it's not practical to make it work in a standalone way we could at least kill the link target so open-in-new-tab'ing it doesn't lead to JSON.

chad added a project: PHUI.Aug 22 2015, 3:11 PM