Page MenuHomePhabricator
Feed Advanced Search

May 5 2017

epriestley removed a reviewer for D17832: chnages in file: Blessed Reviewers.
May 5 2017, 10:50 PM
epriestley removed reviewers for D17834: Added space in file: • dbansal-snk, Blessed Reviewers.
May 5 2017, 10:50 PM
epriestley removed reviewers for D17833: chnages in file: • dbansal-snk, Blessed Reviewers.
May 5 2017, 10:50 PM
epriestley edited the content of Planning.
May 5 2017, 10:39 PM
epriestley added a comment to T12681: Upcoming Support Product / End of Paid Prioritization.

I've just removed mentions from Consulting, but that should eventually be updated when this is formally available.

May 5 2017, 10:21 PM · Guides, Phacility
epriestley edited the content of Consulting.
May 5 2017, 10:20 PM
epriestley edited the content of Consulting.
May 5 2017, 10:19 PM
epriestley edited the content of Paid Prioritization.
May 5 2017, 10:17 PM
epriestley created T12681: Upcoming Support Product / End of Paid Prioritization.
May 5 2017, 10:16 PM · Guides, Phacility
epriestley created T12680: Convert Audit to use UNION to improve the performance of the dashboard bucketing query.
May 5 2017, 6:30 PM · Customer Impact, Restricted Project, Performance, Audit
epriestley added projects to T12679: Fix trivial errors in various View controllers: Audit, Differential.
May 5 2017, 6:21 PM · Differential, Audit, Restricted Project, Customer Impact
epriestley created T12679: Fix trivial errors in various View controllers.
May 5 2017, 6:21 PM · Differential, Audit, Restricted Project, Customer Impact
epriestley created T12678: Bring sanity to the world of all MySQL data being string-typed.
May 5 2017, 4:11 PM · Database, Infrastructure
epriestley created T12677: Support multiple mail delivery services for automatic failover.
May 5 2017, 3:45 PM · Phacility, Mail

May 4 2017

epriestley added a comment to T12674: Update developer docs to include rCORGI setup.

test 2

May 4 2017, 11:44 PM
epriestley closed T12546: "bin/remote deploy" picks up deployment keys locally instead of on the bastion as Resolved by committing Restricted Diffusion Commit.
May 4 2017, 10:29 PM · Ops, Infrastructure, Phacility
epriestley added a comment to P2047 DifferentialSetBaseCommitConduitAPIMethod.php.

For mention purposes, see also T12618.

May 4 2017, 8:01 PM · Customer Impact
epriestley added a comment to P2047 DifferentialSetBaseCommitConduitAPIMethod.php.
NOTE: Anyone who can see a diff can call this method to mutate it. Diffs are normally immutable after creation, so they don't have an edit policy which we can check for.
May 4 2017, 8:00 PM · Customer Impact
epriestley created P2047 DifferentialSetBaseCommitConduitAPIMethod.php.
May 4 2017, 7:59 PM · Customer Impact
epriestley closed T12669: differential.revision.search doesn't return the reviewers. as Resolved.

Sounds good, let us know if you run into issues.

May 4 2017, 4:34 PM · Bug Report
epriestley added a project to T12670: Workboard action UI needs improvements: Customer Impact.

From blame, it looks like D15278 originally stuffed these and some other things into a bit of a weird place -- I think we had some other problems with too much stuff in dropdowns at the time, and that was sort of a "shove this stuff under a rug for now" change? But I don't really remember.

May 4 2017, 4:22 PM · Customer Impact, Design, Workboards
epriestley added a comment to T12670: Workboard action UI needs improvements.

T.T

May 4 2017, 4:19 PM · Customer Impact, Design, Workboards
epriestley added a comment to T12669: differential.revision.search doesn't return the reviewers..

You should be able to use the "reviewers" attachment to get reviewer information. Here's an example of a query which asks for this attachment, and a response which includes it:

May 4 2017, 3:40 PM · Bug Report
epriestley added a comment to T12616: Modernize display code for inline comments.

Just some notes for myself:

May 4 2017, 2:25 PM · Inline Comments
epriestley moved T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does) from Backlog to Requests on the Customer Impact board.
May 4 2017, 1:34 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley moved T12658: Make it more clear what renaming a user does and doesn't affect from Backlog to Active Impact on the Customer Impact board.
May 4 2017, 1:33 PM · Customer Impact, Feature Request
epriestley moved T12668: "arc help land" says "current branch", but means "branch targeted by the land operation" from Backlog to Active Impact on the Customer Impact board.
May 4 2017, 1:33 PM · Arcanist
epriestley created T12668: "arc help land" says "current branch", but means "branch targeted by the land operation".
May 4 2017, 4:34 AM · Arcanist

May 3 2017

epriestley added a comment to T12666: Make Conpherence sidebar show unread counts.

Probably just a flavor of T7332? I think the non-realtime counts (e.g., after page load) have been accurate for me.

May 3 2017, 8:12 PM · Conpherence, Feature Request
epriestley added a comment to T9577: Why do workboards have story point displays and limits if there's no way to customize the size of a card?.

Yes, see maniphest.points in Config.

May 3 2017, 7:56 PM · Workboards
epriestley added a comment to T3498: Allow ignore whitespace in Audit/Diffusion diffs.

Yes, this will be implemented.

May 3 2017, 5:59 PM · Diffusion
epriestley added a comment to T4334: Support PHP5.4+ syntax in XHPAST.

Also, just so I don't completely forget about it:

May 3 2017, 5:25 PM · XHPAST
epriestley added a comment to T4334: Support PHP5.4+ syntax in XHPAST.

Changes in D17802, D17803, D17816 and D17817 all seem generally fine to me from cursory inspection. If D17819 seems sane for fixing the "huge blobs of unstable JSON" problem, let's stick them all on that, I'll take a closer look at the nodes, and we can get everything in? Good luck racing each other on minor version numbers.

May 3 2017, 5:24 PM · XHPAST
epriestley added a revision to T4334: Support PHP5.4+ syntax in XHPAST: Unknown Object (Differential Revision).
May 3 2017, 5:09 PM · XHPAST
epriestley added a revision to T4334: Support PHP5.4+ syntax in XHPAST: Unknown Object (Differential Revision).
May 3 2017, 5:07 PM · XHPAST
joshuaspence added a revision to T4334: Support PHP5.4+ syntax in XHPAST: Unknown Object (Differential Revision).
May 3 2017, 12:00 PM · XHPAST
joshuaspence added a revision to T4334: Support PHP5.4+ syntax in XHPAST: Unknown Object (Differential Revision).
May 3 2017, 11:42 AM · XHPAST
epriestley added a comment to T10448: Modularize mail tags.

Yeah, that directly helps with this. I think I have a pretty good plan for the actual mail part that isn't too crazy complicated, but the cutover/migration bit will be much simpler/smoother if we get things swapped over -- at least, most of the way -- ahead of this.

May 3 2017, 2:51 AM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request

May 2 2017

20after4 awarded T12003: Explain to users how fulltext queries are parsed and executed a Love token.
May 2 2017, 9:27 PM · Search
epriestley added a comment to T12153: 'Show Hidden Comments' bubble does not fit in margin next to line numbers >1000.

I'm thinking about resolving this by having three states instead:

May 2 2017, 6:48 PM · Inline Comments, Differential, Bug Report
epriestley updated the task description for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 5:12 PM · Arcanist, Differential
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T8647: Arc Patch does not patch images.
May 2 2017, 5:02 PM · Arcanist, Differential
epriestley added a parent task for T8647: Arc Patch does not patch images: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 5:02 PM · Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T6157: Failing to parse patch with binary delta.
May 2 2017, 5:01 PM · Arcanist, Differential
epriestley added a parent task for T6157: Failing to parse patch with binary delta: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 5:01 PM · Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T6094: Arc patch fails with 'inconsistent old filename on line NNN'.
May 2 2017, 5:01 PM · Arcanist, Differential
epriestley added a parent task for T6094: Arc patch fails with 'inconsistent old filename on line NNN': T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 5:01 PM · Arcanist
epriestley added a parent task for T9069: arc patch can't handle binary file correctly: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 5:01 PM · Differential, Restricted Project, Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T9069: arc patch can't handle binary file correctly.
May 2 2017, 5:01 PM · Arcanist, Differential
epriestley added a parent task for T4977: arc patch fails even when cherry pick appears successful: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 5:00 PM · Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T4977: arc patch fails even when cherry pick appears successful.
May 2 2017, 5:00 PM · Arcanist, Differential
epriestley added a parent task for T1022: arc patch fails to properly apply a patch which changes a symlink to a real file: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 5:00 PM · Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T1022: arc patch fails to properly apply a patch which changes a symlink to a real file.
May 2 2017, 5:00 PM · Arcanist, Differential
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T9784: `arc patch`: Directory move in SVN patch workflow is implemented erroneously.
May 2 2017, 5:00 PM · Arcanist, Differential
epriestley added a parent task for T9784: `arc patch`: Directory move in SVN patch workflow is implemented erroneously: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 5:00 PM · Subversion, Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T11570: `arc patch` download empty binary file from hosted svn repository.
May 2 2017, 5:00 PM · Arcanist, Differential
epriestley added a parent task for T11570: `arc patch` download empty binary file from hosted svn repository: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 5:00 PM · Arcanist, Bug Report
epriestley closed T11635: tagging a differential revision with a milestone breaks `arc diff` as Resolved.

I think this was fixed by T12659 -- yell if you're still seeing issues?

May 2 2017, 4:59 PM · Restricted Project, Arcanist, Bug Report
epriestley added a parent task for T8768: Under Mercurial, `arc patch` mishandles files with spaces in them : T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 4:58 PM · Git, Mercurial, Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T8768: Under Mercurial, `arc patch` mishandles files with spaces in them .
May 2 2017, 4:58 PM · Arcanist, Differential
epriestley removed a parent task for T1508: When running "arc diff" on a range of commits, preserve the individual commits while still creating a single diff from them: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 4:57 PM · Restricted Project, Arcanist
epriestley removed a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T1508: When running "arc diff" on a range of commits, preserve the individual commits while still creating a single diff from them.
May 2 2017, 4:57 PM · Arcanist, Differential
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T1508: When running "arc diff" on a range of commits, preserve the individual commits while still creating a single diff from them.
May 2 2017, 4:57 PM · Arcanist, Differential
epriestley added a parent task for T1947: Merged files in SVN don't pull content correctly when diffed: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 4:57 PM · Subversion, Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T1947: Merged files in SVN don't pull content correctly when diffed.
May 2 2017, 4:57 PM · Arcanist, Differential
epriestley added a parent task for T2480: getRepositoryVersion() tries to call Filesystem::pathExists() on "svn+ssh://" paths: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 4:56 PM · Subversion, Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T2480: getRepositoryVersion() tries to call Filesystem::pathExists() on "svn+ssh://" paths.
May 2 2017, 4:56 PM · Arcanist, Differential
epriestley added a parent task for T3801: Consolidate binary file handling in `arc diff`: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 4:56 PM · Restricted Project, Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T3801: Consolidate binary file handling in `arc diff`.
May 2 2017, 4:56 PM · Arcanist, Differential
epriestley added a parent task for T2999: When we detect a file as binary, explain why: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 4:56 PM · Diffusion, Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T2999: When we detect a file as binary, explain why.
May 2 2017, 4:56 PM · Arcanist, Differential
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: Unknown Object (Maniphest Task).
May 2 2017, 4:55 PM · Arcanist, Differential
epriestley added a parent task for T3981: arcanist needs to be savvier about svn externals in patch workflow: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 4:55 PM · Subversion, Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T3981: arcanist needs to be savvier about svn externals in patch workflow.
May 2 2017, 4:55 PM · Arcanist, Differential
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T4124: Test the capabilities of `diff` better, especially for Solaris.
May 2 2017, 4:55 PM · Arcanist, Differential
epriestley added a parent task for T4124: Test the capabilities of `diff` better, especially for Solaris: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 4:55 PM · Arcanist
epriestley added a parent task for T4682: With SVN 1.7, certain property changes won't show properly in Differential: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 4:54 PM · Subversion, Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T4682: With SVN 1.7, certain property changes won't show properly in Differential.
May 2 2017, 4:54 PM · Arcanist, Differential
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T6120: arc export doesn't preserve author information.
May 2 2017, 4:53 PM · Arcanist, Differential
epriestley added a parent task for T6120: arc export doesn't preserve author information: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 4:53 PM · Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T6447: SVN file externals aren't properly detected.
May 2 2017, 4:53 PM · Arcanist, Differential
epriestley added a parent task for T6447: SVN file externals aren't properly detected: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 4:53 PM · Subversion, Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T5999: `arc diff` not uploading file content for svn:executable files under SVN 1.7.4.
May 2 2017, 4:53 PM · Arcanist, Differential
epriestley added a parent task for T5999: `arc diff` not uploading file content for svn:executable files under SVN 1.7.4: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 4:53 PM · Arcanist, Differential, Subversion
epriestley added a parent task for T6362: parseDiff assumes GNU-style unified diff: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 4:52 PM · Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T6362: parseDiff assumes GNU-style unified diff.
May 2 2017, 4:52 PM · Arcanist, Differential
epriestley added a parent task for T9457: arc diff crashes when trying to stash submodule diffs: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 4:52 PM · Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T9457: arc diff crashes when trying to stash submodule diffs.
May 2 2017, 4:52 PM · Arcanist, Differential
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T10608: Arc diff failing to generate diff with svn 1.9.3.
May 2 2017, 4:51 PM · Arcanist, Differential
epriestley added a parent task for T10608: Arc diff failing to generate diff with svn 1.9.3: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 4:51 PM · Arcanist, Bug Report
epriestley added a parent task for T7158: arc commit for subversion fails with untracked files where a directory has a property change: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 4:50 PM · Subversion, Arcanist
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T7158: arc commit for subversion fails with untracked files where a directory has a property change.
May 2 2017, 4:50 PM · Arcanist, Differential
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T7581: arc diff errors out when a directory is removed between diffs.
May 2 2017, 4:50 PM · Arcanist, Differential
epriestley added a parent task for T7581: arc diff errors out when a directory is removed between diffs: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 4:50 PM · Subversion, Arcanist
epriestley renamed T12618: Parse multiple commits and commit metadata from "hg log --patch" and "hg export" from Create a revision/diff using Conduit which sets the base revision to Parse multiple commits and commit metadata from "hg log --patch" and "hg export".
May 2 2017, 4:48 PM · Arcanist, Mercurial, Differential, Conduit, Feature Request
epriestley added a parent task for T12256: Parse multiple commits and commit metadata from "git show" and "git format-patch": T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 4:47 PM · Differential, KDE
epriestley added subtasks for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T12618: Parse multiple commits and commit metadata from "hg log --patch" and "hg export", T12256: Parse multiple commits and commit metadata from "git show" and "git format-patch".
May 2 2017, 4:47 PM · Arcanist, Differential
epriestley added a parent task for T12618: Parse multiple commits and commit metadata from "hg log --patch" and "hg export": T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 4:47 PM · Arcanist, Mercurial, Differential, Conduit, Feature Request
epriestley created T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
May 2 2017, 4:46 PM · Arcanist, Differential
epriestley added a project to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): Customer Impact.

This is also extremely silly, but I sometimes do it because I'm dumb and have muscle-memory for ⌘+1+⇥+⌘+V+⏎: searching for an object URL doesn't jump you to that object URL, but you probably meant to put it in the other box.

May 2 2017, 4:41 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia