Page MenuHomePhabricator

getRepositoryVersion() tries to call Filesystem::pathExists() on "svn+ssh://" paths
Open, NormalPublic

Description

See P706 for a stack trace.

I'm guessing svn diff ... svn+ssh://../ produces svn+ssh URLs?

Event Timeline

epriestley triaged this task as Normal priority.Feb 4 2013, 2:42 PM
epriestley added a project: Arcanist.
epriestley added subscribers: epriestley, vrana, svemir.

Yes, our repo is on svn+ssh URL

But no, you do not need to specify the full path on the command line, it figures that all on its own.

Sorry, my description is not very thorough. In rARC6cd3d8e995705231ab6e04affbb945da1f13fad6, we changed the behavior of an internal call (getChangedFiles()) to run something like:

svn diff ... svn+ssh://.../

Instead of:

svn diff ...

My guess is that this change is causing the command to return files with remote "svn+ssh" URLs in them (where, previously, it would return only local URLs), which we then incorrectly perform an existence check on.

chad changed the visibility from "All Users" to "Public (No Login Required)".Jul 3 2015, 4:06 AM