Page MenuHomePhabricator
Feed Advanced Search

Apr 5 2017

epriestley closed T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles), a subtask of T6721: Would like ability to search tasks by title, as Resolved.
Apr 5 2017, 7:54 PM · Search, Maniphest
epriestley added a project to T8788: Allow querying for files by name: Contributor Onboarding.
Apr 5 2017, 7:52 PM · Contributor Onboarding, Files
epriestley added a project to T10828: File deletion should be queued up and run by daemons: Contributor Onboarding.
Apr 5 2017, 7:52 PM · Contributor Onboarding, Daemons, Files, Bug Report
epriestley added a comment to T8787: Add support for U2F MFA once browser implementations improve and compatible hardware is more widely available.

Just dropping this here since it's the first hit for "SAML" and makes it easier for me to contextualize things when I quote $50K for it, which I'm starting to think is too low:

Apr 5 2017, 7:44 PM · Haskell.org, Auth
epriestley added a comment to T12470: Store integrity hashes for file blobs in Files.

The HackerOne issue for this is here:

Apr 5 2017, 7:29 PM · Files
epriestley added a comment to T12470: Store integrity hashes for file blobs in Files.

The security part of this is fixed by D17625, but I'm planning to write a support script like bin/files integrity or similar to do things like "compute hashes for existing files" and "check that a file or set of files match their integrity hashes".

Apr 5 2017, 7:28 PM · Files
epriestley closed T12219: Some MP4 videos do not play in Chrome as Resolved.

This appears to be resolved for me, now. Handling Range: bytes=123- and Range: bytes=0- (plus the fixes for the broader issues in T8266 and T12079) seemed to be the key issues.

Apr 5 2017, 6:59 PM · Files
epriestley added a revision to T12219: Some MP4 videos do not play in Chrome: Unknown Object (Differential Revision).
Apr 5 2017, 6:34 PM · Files
epriestley added a revision to T12219: Some MP4 videos do not play in Chrome: Unknown Object (Differential Revision).
Apr 5 2017, 6:05 PM · Files
epriestley closed T8266: Some audio isn't streaming correctly in Safari as Resolved.

F60036 now plays correctly for me in Safari.

Apr 5 2017, 5:13 PM · Safari, Files
epriestley added a comment to T12079: Files does not serve HTTP "Content-Range" requests correctly if the underlying blob data is encrypted.

The video in T12078 now plays correctly for me so I think this is, in fact, resolved.

Apr 5 2017, 5:12 PM · Files, Public & Media Relations, Bug Report
epriestley closed T12079: Files does not serve HTTP "Content-Range" requests correctly if the underlying blob data is encrypted as Resolved by committing Restricted Diffusion Commit.
Apr 5 2017, 4:56 PM · Files, Public & Media Relations, Bug Report
epriestley added a revision to T12470: Store integrity hashes for file blobs in Files: Unknown Object (Differential Revision).
Apr 5 2017, 4:56 PM · Files
epriestley added a revision to T8266: Some audio isn't streaming correctly in Safari: Unknown Object (Differential Revision).
Apr 5 2017, 1:53 PM · Safari, Files
epriestley added a revision to T12079: Files does not serve HTTP "Content-Range" requests correctly if the underlying blob data is encrypted: Unknown Object (Differential Revision).
Apr 5 2017, 1:35 PM · Files, Public & Media Relations, Bug Report
epriestley added a comment to T12506: hackerone: possible issue with secrets sharing.

T4721 (which I also linked on the HackerOne report) discusses usability improvements to Passphrase, including better documentation and hinting about this use case and possibly the separation of the "Can Use Credential" and "Can View Secret" policies. These are reasonable usability concerns.

Apr 5 2017, 1:16 PM · Security
epriestley closed T12506: hackerone: possible issue with secrets sharing as Invalid.

You can review the HackerOne report, including my response, here:

Apr 5 2017, 12:51 PM · Security
epriestley edited the content of 2017 Week 13 (Very Early April).
Apr 5 2017, 1:38 AM

Apr 4 2017

epriestley closed T12464: Move away from SHA1 in Files as Resolved by committing Restricted Diffusion Commit.
Apr 4 2017, 11:56 PM · Files
epriestley closed T8348: `arc download` doesn't support chunked downloads as Resolved by committing Restricted Diffusion Commit.
Apr 4 2017, 11:16 PM · Restricted Project, Files, Arcanist
epriestley closed T8348: `arc download` doesn't support chunked downloads, a subtask of T11357: Move Files to EditEngine and modern APIs, as Resolved.
Apr 4 2017, 11:16 PM · Restricted Project, Files
epriestley added a comment to T8348: `arc download` doesn't support chunked downloads.

After D17614, arc download uses file.search to retrieve a URI it can GET, then does a normal HTTP GET to that URI, retrieving the file content in the HTTP response body.

Apr 4 2017, 11:14 PM · Restricted Project, Files, Arcanist
epriestley added a revision to T12464: Move away from SHA1 in Files: Unknown Object (Differential Revision).
Apr 4 2017, 10:54 PM · Files
epriestley added a revision to T12464: Move away from SHA1 in Files: Unknown Object (Differential Revision).
Apr 4 2017, 10:49 PM · Files
epriestley added a revision to T12464: Move away from SHA1 in Files: Unknown Object (Differential Revision).
Apr 4 2017, 10:38 PM · Files
epriestley updated the task description for T12464: Move away from SHA1 in Files.
Apr 4 2017, 10:34 PM · Files
chad awarded T12464: Move away from SHA1 in Files a Y So Serious token.
Apr 4 2017, 10:25 PM · Files
epriestley added a revision to T12464: Move away from SHA1 in Files: Unknown Object (Differential Revision).
Apr 4 2017, 10:24 PM · Files
epriestley added a revision to T12464: Move away from SHA1 in Files: Unknown Object (Differential Revision).
Apr 4 2017, 9:40 PM · Files
epriestley added a revision to T12464: Move away from SHA1 in Files: Unknown Object (Differential Revision).
Apr 4 2017, 9:32 PM · Files
epriestley added a revision to T11357: Move Files to EditEngine and modern APIs: Unknown Object (Differential Revision).
Apr 4 2017, 7:28 PM · Restricted Project, Files
epriestley moved T12504: Files "Temporary" badge is white-on-grey from Backlog to vNext on the Files board.
Apr 4 2017, 6:56 PM · Files, PHUI
epriestley created T12504: Files "Temporary" badge is white-on-grey.
Apr 4 2017, 6:56 PM · Files, PHUI
epriestley created T12503: Curtain sections may overflow boundaries in the UI.
Apr 4 2017, 6:52 PM · PHUI
epriestley closed T12502: Creating a task in the non-default space causes exception in feed renderer as Resolved by committing Restricted Diffusion Commit.
Apr 4 2017, 5:24 PM · Bug Report
epriestley added a revision to T8348: `arc download` doesn't support chunked downloads: Unknown Object (Differential Revision).
Apr 4 2017, 4:53 PM · Restricted Project, Files, Arcanist
epriestley added a revision to T11357: Move Files to EditEngine and modern APIs: Unknown Object (Differential Revision).
Apr 4 2017, 4:10 PM · Restricted Project, Files
epriestley added a revision to T11357: Move Files to EditEngine and modern APIs: Unknown Object (Differential Revision).
Apr 4 2017, 3:50 PM · Restricted Project, Files
epriestley added a revision to T11357: Move Files to EditEngine and modern APIs: Unknown Object (Differential Revision).
Apr 4 2017, 3:04 PM · Restricted Project, Files
epriestley added a revision to T11357: Move Files to EditEngine and modern APIs: Unknown Object (Differential Revision).
Apr 4 2017, 2:47 PM · Restricted Project, Files
epriestley removed a project from T7954: Make it easier to upload XHProf profiles: Files.

(This isn't really very closely related to the Files application anymore, just cleaning up that board a little.)

Apr 4 2017, 1:01 PM · Infrastructure, XHProf
epriestley added a revision to T12502: Creating a task in the non-default space causes exception in feed renderer: Unknown Object (Differential Revision).
Apr 4 2017, 12:56 PM · Bug Report
epriestley closed T12481: Obtain a link to harbormaster build output from a commit or review. as Resolved.

Great! Let us know if you run into anything else.

Apr 4 2017, 12:52 AM · Feature Request

Apr 3 2017

epriestley added a comment to T12494: "Use Results..." button from Maniphest missing in the stable release.

Oh, of course. Good catch.

Apr 3 2017, 5:08 PM · Bug Report
epriestley added a comment to T12496: "differential.sticky-accept" isn't working because of overbroad accept downgrading.

I cherry-picked this to stable and will plan to push it to the cluster tomorrow morning.

Apr 3 2017, 4:58 PM · Differential
epriestley closed T12496: "differential.sticky-accept" isn't working because of overbroad accept downgrading, a subtask of T10967: Move Differential reviewers back to a dedicated database storage table, as Resolved.
Apr 3 2017, 4:55 PM · Restricted Project, Infrastructure, Differential
epriestley closed T12496: "differential.sticky-accept" isn't working because of overbroad accept downgrading as Resolved by committing Restricted Diffusion Commit.
Apr 3 2017, 4:55 PM · Differential
epriestley moved T7501: Documentation for Files from vNext to Far Future on the Files board.
Apr 3 2017, 4:05 PM · Files, Documentation
epriestley added a comment to T12497: Cannot set a mailing list user to watch a project.

This is also not a valid feature request.

Apr 3 2017, 3:59 PM · Mailing Lists, Bug Report
epriestley closed T12499: Official docker Image as Invalid.
Apr 3 2017, 3:58 PM · Feature Request
epriestley added a revision to T12496: "differential.sticky-accept" isn't working because of overbroad accept downgrading: Unknown Object (Differential Revision).
Apr 3 2017, 3:38 PM · Differential
epriestley removed a project from T10900: Repository content search with `hg grep` returns matches found in old versions of files: Search.

(This isn't related to the "Search" application, even though it's about searching for things.)

Apr 3 2017, 3:26 PM · Mercurial, Diffusion
epriestley closed T12497: Cannot set a mailing list user to watch a project as Invalid.

This does not describe a bug in Phabricator.

Apr 3 2017, 3:22 PM · Mailing Lists, Bug Report
epriestley closed T12498: Cannot get the details about the reviewers of a revision through Conduit as Invalid.
Apr 3 2017, 3:21 PM · Feature Request
20after4 awarded T12493: Upgrading: Fulltext Search Services a Love token.
Apr 3 2017, 2:44 PM · Elasticsearch, Search, Guides
epriestley edited the content of Changelog.
Apr 3 2017, 11:22 AM
epriestley created 2017 Week 13 (Very Early April).
Apr 3 2017, 11:22 AM
epriestley added a comment to T12496: "differential.sticky-accept" isn't working because of overbroad accept downgrading.

I've gotten way behind this week so I'm going to cut and deploy the release now to try to catch up, then fix this afterwards and deploy it separately.

Apr 3 2017, 11:12 AM · Differential
epriestley added a subtask for T10967: Move Differential reviewers back to a dedicated database storage table: T12496: "differential.sticky-accept" isn't working because of overbroad accept downgrading.
Apr 3 2017, 11:10 AM · Restricted Project, Infrastructure, Differential
epriestley added a parent task for T12496: "differential.sticky-accept" isn't working because of overbroad accept downgrading: T10967: Move Differential reviewers back to a dedicated database storage table.
Apr 3 2017, 11:10 AM · Differential
epriestley created T12496: "differential.sticky-accept" isn't working because of overbroad accept downgrading.
Apr 3 2017, 11:10 AM · Differential
epriestley added a comment to T12494: "Use Results..." button from Maniphest missing in the stable release.

I can't reproduce this in production (8f7983a5be3a56db5b79dc7c3a0eb470f1d7ca02):

Apr 3 2017, 10:54 AM · Bug Report
epriestley closed T12480: Be able to obtain the commits (related objects) associated with a task and the reviews associated with a commit as Resolved by committing Restricted Diffusion Commit.
Apr 3 2017, 2:50 AM · Feature Request
epriestley closed T12461: more consistency between results of maniphest.query and .search as Resolved by committing Restricted Diffusion Commit.
Apr 3 2017, 12:44 AM · Feature Request
epriestley added a comment to T12481: Obtain a link to harbormaster build output from a commit or review..

Not everything you need here has modern API methods, but I think you can get pretty close:

Apr 3 2017, 12:43 AM · Feature Request
epriestley added a comment to T12480: Be able to obtain the commits (related objects) associated with a task and the reviews associated with a commit.

D17604 adds the six edge types representing relationships between tasks, revisions, and commits to edge.search.

Apr 3 2017, 12:29 AM · Feature Request
epriestley added a revision to T12480: Be able to obtain the commits (related objects) associated with a task and the reviews associated with a commit: Unknown Object (Differential Revision).
Apr 3 2017, 12:28 AM · Feature Request
epriestley added a comment to T12461: more consistency between results of maniphest.query and .search.

D17603 makes maniphest.search return a "description" field, which looks like this:

Apr 3 2017, 12:17 AM · Feature Request
epriestley added a revision to T12461: more consistency between results of maniphest.query and .search: Unknown Object (Differential Revision).
Apr 3 2017, 12:14 AM · Feature Request

Apr 2 2017

epriestley added a comment to T12450: New Search Configuration Errata.

If you can run bin/whatever, policies no longer matter since you can bin/storage shell or any other number of dangerous things.

Apr 2 2017, 9:56 PM · Search
epriestley added a comment to T12450: New Search Configuration Errata.

PhabricatorEnv::beginScopedEnv(); works anywhere if this makes more sense as, like, bin/search self-test or something rather than a unit test.

Apr 2 2017, 8:52 PM · Search
epriestley updated the task description for T12450: New Search Configuration Errata.
Apr 2 2017, 8:08 PM · Search
epriestley added a revision to T12450: New Search Configuration Errata: Unknown Object (Differential Revision).
Apr 2 2017, 8:05 PM · Search
epriestley updated the task description for T12450: New Search Configuration Errata.
Apr 2 2017, 7:20 PM · Search
epriestley updated the task description for T12450: New Search Configuration Errata.
Apr 2 2017, 7:19 PM · Search
epriestley updated the task description for T12493: Upgrading: Fulltext Search Services.
Apr 2 2017, 7:14 PM · Elasticsearch, Search, Guides
epriestley added a revision to T12450: New Search Configuration Errata: Unknown Object (Differential Revision).
Apr 2 2017, 7:10 PM · Search
epriestley created T12493: Upgrading: Fulltext Search Services.
Apr 2 2017, 6:59 PM · Elasticsearch, Search, Guides
epriestley added a comment to T12450: New Search Configuration Errata.

Oh, I'm wrong. It hasn't been removed without replacement: there's a new path option for Elastic. I think there's probably a bug in indexExists() then, since it looks for 'phabricator' by name:

Apr 2 2017, 6:49 PM · Search
epriestley added a comment to T12450: New Search Configuration Errata.

(This is all wrong, see below.)

Apr 2 2017, 6:42 PM · Search
epriestley updated the task description for T12450: New Search Configuration Errata.
Apr 2 2017, 6:29 PM · Search
epriestley updated the task description for T12450: New Search Configuration Errata.
Apr 2 2017, 6:19 PM · Search
epriestley merged T12492: Allow an admin to delete files from the Web interface into T7593: Allow administrators to disable files to prevent "l33t w4r3z" abuse cases.
Apr 2 2017, 5:37 PM · Abuse, Files
epriestley merged task T12492: Allow an admin to delete files from the Web interface into T7593: Allow administrators to disable files to prevent "l33t w4r3z" abuse cases.
Apr 2 2017, 5:37 PM · Feature Request
epriestley updated the task description for T12450: New Search Configuration Errata.
Apr 2 2017, 5:06 PM · Search
epriestley added a revision to T12450: New Search Configuration Errata: Unknown Object (Differential Revision).
Apr 2 2017, 5:05 PM · Search
epriestley added a revision to T12450: New Search Configuration Errata: Unknown Object (Differential Revision).
Apr 2 2017, 4:59 PM · Search
epriestley updated the task description for T12450: New Search Configuration Errata.
Apr 2 2017, 4:44 PM · Search
epriestley updated the task description for T12450: New Search Configuration Errata.
Apr 2 2017, 4:37 PM · Search
epriestley added a revision to T12450: New Search Configuration Errata: Restricted Differential Revision.
Apr 2 2017, 4:33 PM · Search
epriestley added a revision to T12450: New Search Configuration Errata: Unknown Object (Differential Revision).
Apr 2 2017, 4:20 PM · Search
epriestley added a comment to T12450: New Search Configuration Errata.

So I ran into one problem when deploying the latest code to WMF production. We now throw a setup error if we have a cluster with no readable hosts. It actually makes sense to have a cluster that is write-only so that setup error is bogus.

Apr 2 2017, 3:57 PM · Search
epriestley updated the task description for T12450: New Search Configuration Errata.
Apr 2 2017, 3:42 PM · Search
epriestley updated the task description for T12450: New Search Configuration Errata.
Apr 2 2017, 3:05 PM · Search
epriestley added a comment to T12491: Error reply emails which are generated before identifying the sender should no longer be sent, now that the "always require verification" rule is in place.

Version?

Apr 2 2017, 1:57 PM · Mail, Bug Report
Beltran-rubo awarded T9456: Evaluate upstream support for third-party build systems a Mountain of Wealth token.
Apr 2 2017, 8:23 AM · Restricted Project, Harbormaster

Mar 31 2017

epriestley merged T12487: Add support for linting multiple files in script-and-regex linter into T10038: Plan the mid-term pathway for unit-test/linter bindings.
Mar 31 2017, 1:56 PM · Lint, Arcanist
epriestley merged task T12487: Add support for linting multiple files in script-and-regex linter into T10038: Plan the mid-term pathway for unit-test/linter bindings.
Mar 31 2017, 1:56 PM · Feature Request
pouyana awarded T4900: Workboards updating in real time a Love token.
Mar 31 2017, 1:30 PM · Workboards (v3), User Delight, Wikimedia
epriestley closed T12482: It's not clear that SSH keys for mirroring repositories should have Conduit access enabled as Resolved.
Mar 31 2017, 1:23 PM · Bug Report