Page MenuHomePhabricator
Feed Advanced Search

Oct 20 2016

epriestley closed T11669: Dashboard drag and drop a test in patience as Invalid.

It should show a pretty clear preview of what it's going to do before you drop, so I'm not sure how it could be unpredictable? I wasn't able to identify any weird/surprising behavior when I tried to reproduce this.

Oct 20 2016, 5:02 PM · Restricted Project, Dashboards, Bug Report
epriestley closed T11775: Panel positioning improvements as Invalid.

even sometime seems to me not properly working

Oct 20 2016, 4:52 PM · Dashboards, Feature Request
epriestley updated subscribers of T11669: Dashboard drag and drop a test in patience.

I wasn't actually able to reproduce this -- were you, @chad?

Oct 20 2016, 4:50 PM · Restricted Project, Dashboards, Bug Report
epriestley added a revision to T11773: Improve behaviors for "overheated" policy queries: Unknown Object (Differential Revision).
Oct 20 2016, 4:11 PM · Performance
epriestley added a comment to T11773: Improve behaviors for "overheated" policy queries.

Pagination isn't quite as simple as I'd remembered. Specifically, we do not expose internal pagination cursors to viewers today because doing so permits an information discovery attack that goes like this:

Oct 20 2016, 3:51 PM · Performance
epriestley added a revision to T11773: Improve behaviors for "overheated" policy queries: Unknown Object (Differential Revision).
Oct 20 2016, 3:36 PM · Performance
epriestley added a comment to T11036: Put subproject columns on workboards.

Broadly, I think the two above comments are expressing a mixture of two ideas:

Oct 20 2016, 2:07 PM · Workboards (v3), Projects (v3)
epriestley added a comment to T11036: Put subproject columns on workboards.

The proposed behavior (no subproject columns) means that tasks could be in multiple different columns at different levels, since they'd be draggable normally on each workboard:

Oct 20 2016, 1:49 PM · Workboards (v3), Projects (v3)
epriestley added a comment to T11357: Move Files to EditEngine and modern APIs.

T11774 wants a "delete file data" transaction, which is reasonable.

Oct 20 2016, 1:31 PM · Restricted Project, Files
epriestley merged task T11774: Files are not deletable when uploaded by a bot user into T11357: Move Files to EditEngine and modern APIs.
Oct 20 2016, 1:31 PM · Conduit, Arcanist, Files, People, Bug Report
epriestley merged T11774: Files are not deletable when uploaded by a bot user into T11357: Move Files to EditEngine and modern APIs.
Oct 20 2016, 1:31 PM · Restricted Project, Files
epriestley added a comment to T11774: Files are not deletable when uploaded by a bot user.

This is working as intended, and not a bug. Administrators can not bypass policies. See the User Guide: Account Roles documentation:

Oct 20 2016, 1:31 PM · Conduit, Arcanist, Files, People, Bug Report

Oct 19 2016

epriestley added a comment to T11773: Improve behaviors for "overheated" policy queries.

I think this behavior is very good

Oct 19 2016, 10:37 PM · Performance
epriestley added a comment to T11773: Improve behaviors for "overheated" policy queries.

This is also a potential problem in the general case, although the general case of this is very rare.

Oct 19 2016, 10:30 PM · Performance
epriestley renamed T11773: Improve behaviors for "overheated" policy queries from Feed does not perform well in the presence of exclusive spaces? to Feed does not perform well in the presence of exclusive spaces.
Oct 19 2016, 10:11 PM · Performance
epriestley added a comment to T11773: Improve behaviors for "overheated" policy queries.

Broadly, most applications can execute Spaces queries cheaply by querying ... AND spacePHID IN (<list of spaces the viewer can see>) when Spaces are configured, which is efficient until some install decides to create 30,000 Spaces for some reason.

Oct 19 2016, 10:10 PM · Performance
epriestley added projects to T11773: Improve behaviors for "overheated" policy queries: Feed, Performance.
Oct 19 2016, 9:59 PM · Performance
epriestley added a comment to T11773: Improve behaviors for "overheated" policy queries.

The reporting user configured debug.time-limit to get a stack, which confirms this is a Feed issue:

Oct 19 2016, 9:59 PM · Performance
epriestley added a comment to T11773: Improve behaviors for "overheated" policy queries.

Here are slightly cleaned-up recent timeouts from the logs:

Oct 19 2016, 9:56 PM · Performance
epriestley updated the task description for T11773: Improve behaviors for "overheated" policy queries.
Oct 19 2016, 9:52 PM · Performance
epriestley created T11773: Improve behaviors for "overheated" policy queries.
Oct 19 2016, 9:37 PM · Performance
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 19 2016, 4:57 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 19 2016, 4:55 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 19 2016, 4:20 PM · Restricted Project, Prioritized, Calendar
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 19 2016, 4:20 PM · Restricted Project, Prioritized, Calendar
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 19 2016, 4:03 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 19 2016, 4:02 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 19 2016, 3:35 PM · Restricted Project, Prioritized, Calendar
epriestley closed T11735: Upgrading: Calendar Storage Migrations as Resolved.

I'm going to close this since things seem to have at least mostly worked and installs have had a couple of weeks to yell at us if we blew anything major up, but let us know if anyone runs into further issues.

Oct 19 2016, 3:25 PM · Calendar

Oct 18 2016

epriestley added a comment to T10215: Provide tools to combat and recover from abuse.

I can't remember if Phabricator already requires a confirmed e-mail address to do anything.

Oct 18 2016, 10:46 PM · Abuse
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 18 2016, 9:36 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 18 2016, 9:36 PM · Restricted Project, Prioritized, Calendar
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 18 2016, 9:31 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 18 2016, 9:30 PM · Restricted Project, Prioritized, Calendar
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 18 2016, 8:56 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 18 2016, 8:54 PM · Restricted Project, Prioritized, Calendar
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 18 2016, 8:41 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 18 2016, 8:40 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 18 2016, 8:26 PM · Restricted Project, Prioritized, Calendar
epriestley awarded Image Macro "punt" a Hungry Hippo token.
Oct 18 2016, 8:10 PM
epriestley added a comment to T10215: Provide tools to combat and recover from abuse.

We can also let installs send us all their data, we'll decide if it's spam or not, then we remotely delete any data that we feel like deleting. But we'd have to charge like a gorillion dollars per message to make this sustainable today.

Oct 18 2016, 8:10 PM · Abuse
epriestley added a comment to T10215: Provide tools to combat and recover from abuse.

What sort of reliable and automatic solution are you hoping for? How could the system reliably, automatically detect that a user is a spammer or that a task assignment is unwanted?

Oct 18 2016, 7:07 PM · Abuse
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 18 2016, 6:00 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 18 2016, 5:11 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 18 2016, 5:07 PM · Restricted Project, Prioritized, Calendar
stevex awarded T3563: Consider fullscreen modes for Pholio (and other applications?) a Love token.
Oct 18 2016, 4:47 PM · Pholio
epriestley created T11771: Protect GC operations with a lock.
Oct 18 2016, 11:33 AM · Daemons
cguenther awarded T7789: Support Git Large File Storage a Love token.
Oct 18 2016, 9:07 AM · Customer Impact, Restricted Project, Files, Diffusion

Oct 17 2016

epriestley added a comment to T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.

After D16714, the problem tasks should complete cleanly.

Oct 17 2016, 11:05 PM · Bug Report
epriestley added a subtask for T10978: Modernize Audit: T11763: Make commit query useful enough to show "recent commits + build status on master" of a particular repository.
Oct 17 2016, 10:57 PM · Audit
epriestley added a parent task for T11763: Make commit query useful enough to show "recent commits + build status on master" of a particular repository: T10978: Modernize Audit.
Oct 17 2016, 10:57 PM · Haskell.org, Harbormaster, Feature Request
epriestley renamed T11763: Make commit query useful enough to show "recent commits + build status on master" of a particular repository from Filter Harbormaster builds by their provenance to Make commit query useful enough to show "recent commits + build status on master" of a particular repository.
Oct 17 2016, 10:57 PM · Haskell.org, Harbormaster, Feature Request
epriestley closed T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails as Resolved by committing Restricted Diffusion Commit.
Oct 17 2016, 10:56 PM · Bug Report
epriestley closed T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails, a subtask of T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion, as Resolved.
Oct 17 2016, 10:56 PM · Diffusion (v3), Differential, Mail
epriestley closed T11768: Show diff statistics (lines changed) as Invalid.

This feature request doesn't describe a root problem. See Describing Root Problems and Contributing Feature Requests for help filing a feature request which we'll consider.

Oct 17 2016, 10:50 PM · Feature Request
epriestley added a comment to T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.

D16714 should fix this by adding an implicit byte limit.

Oct 17 2016, 10:32 PM · Bug Report
epriestley added a comment to T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion.

Differential also currently does not substitute a diagnostic message when declining to inline a patch: it should. ("Patch is too big to inline because limit X is set to Y." or similar.)

Oct 17 2016, 10:31 PM · Diffusion (v3), Differential, Mail
epriestley added a revision to T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails: Unknown Object (Differential Revision).
Oct 17 2016, 10:30 PM · Bug Report
epriestley added a subtask for T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion: T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.
Oct 17 2016, 10:17 PM · Diffusion (v3), Differential, Mail
epriestley added a parent task for T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails: T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion.
Oct 17 2016, 10:17 PM · Bug Report
epriestley added a comment to T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion.

An additional inconsistency is that the diffusion.byte-limit applies to attached patches, but the differential.byte-limit does not. There's some vague argument for this behavior (you "shouldn't" be reviewing patches which are so enormous that they can not be emailed) but consistent behavior is probably better.

Oct 17 2016, 10:13 PM · Diffusion (v3), Differential, Mail
epriestley renamed T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion from Unify patch byte/line limit behaviors to Unify email patch byte/line/time limit behaviors across Differential/Diffusion.
Oct 17 2016, 10:10 PM · Diffusion (v3), Differential, Mail
epriestley created T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion.
Oct 17 2016, 10:10 PM · Diffusion (v3), Differential, Mail
epriestley added a comment to T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.

Sorry, "tomorrow" definitely didn't happen. Looking at this now.

Oct 17 2016, 10:00 PM · Bug Report
epriestley moved T11469: Checking out from Phacility sometimes fails from Backlog to Near Future on the Phacility board.
Oct 17 2016, 9:58 PM · Phacility, Bug Report
epriestley moved T11766: Write to the pull log from SSH, not just HTTP from Backlog to Near Future on the Phacility board.
Oct 17 2016, 9:58 PM · Diffusion, Phacility
epriestley created T11766: Write to the pull log from SSH, not just HTTP.
Oct 17 2016, 9:57 PM · Diffusion, Phacility
epriestley added a comment to T11761: Return to previous page after exiting high security mode.

Some possible implementations of this expose an open redirect (e.g., by passing returnURI=<something> where <something> can be anything). An open redirect here isn't necessarily inherently dangerous, but the minor inconvenience we'd avoid probably isn't worth the security risk.

Oct 17 2016, 9:47 PM · Security
epriestley edited the content of Changelog.
Oct 17 2016, 9:41 PM
epriestley created 2016 Week 42 (Mid October).
Oct 17 2016, 9:40 PM
epriestley triaged T11763: Make commit query useful enough to show "recent commits + build status on master" of a particular repository as Low priority.

Broadly, I think this is better expressed as "Commits in rXYZ on master, including build status" than "Builds of commits in rXYZ on master". Diffusion proper already shows build status in commit lists, although the commit query in Audit currently does not. This probably won't get an update until T10978 happens.

Oct 17 2016, 9:39 PM · Haskell.org, Harbormaster, Feature Request

Oct 16 2016

demix awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Oct 16 2016, 9:41 AM · Workboards (v3), Restricted Project

Oct 14 2016

alexmv awarded T1022: arc patch fails to properly apply a patch which changes a symlink to a real file a Like token.
Oct 14 2016, 8:19 PM · Arcanist
epriestley added a comment to T11760: Phacility Cluster: Ad-Hoc Query Log.

As a followup, ran this script on a subset of instances to collect data about mail delivered on a per-action basis versus a per-user basis:

Oct 14 2016, 4:54 PM · Phacility
epriestley added a comment to T11760: Phacility Cluster: Ad-Hoc Query Log.

Per above, here are the specific queries I executed while collecting statistics about the "Self Actions" preference:

Oct 14 2016, 3:52 PM · Phacility
epriestley updated the task description for T11760: Phacility Cluster: Ad-Hoc Query Log.
Oct 14 2016, 3:20 PM · Phacility
epriestley added a comment to T11760: Phacility Cluster: Ad-Hoc Query Log.

I am running a query to collect this data:

Oct 14 2016, 3:18 PM · Phacility
epriestley added a comment to T11760: Phacility Cluster: Ad-Hoc Query Log.

Circa September 13, 2016 we ran a query which collected this data from instances:

Oct 14 2016, 3:16 PM · Phacility
epriestley updated the task description for T11760: Phacility Cluster: Ad-Hoc Query Log.
Oct 14 2016, 3:08 PM · Phacility
epriestley created T11760: Phacility Cluster: Ad-Hoc Query Log.
Oct 14 2016, 3:02 PM · Phacility
epriestley closed T11759: osksjksjk as Spite.
Oct 14 2016, 2:40 AM · Bug Report
epriestley created T11758: "aliases" is valid configuration in Arcanist, but not recognized by "arc get-config".
Oct 14 2016, 2:11 AM · Arcanist
epriestley changed the visibility for P2013 aliases_in_arcconfig.txt.
Oct 14 2016, 1:49 AM
epriestley created P2013 aliases_in_arcconfig.txt.
Oct 14 2016, 1:49 AM
epriestley added a comment to T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.

Ah, thanks! Yeah, looks pretty conclusive.

Oct 14 2016, 1:04 AM · Bug Report
epriestley closed T11757: Hash search fails in advanced search (works at top of page) as Invalid.

This is expected.

Oct 14 2016, 12:36 AM · Search, Bug Report
epriestley added a comment to T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.

I'm vaguely suspicious that the mail is just too big (1MB of text plus tons and tons of HTML for syntax highlighting it?), and that the error is really arising from max_allowed_packet being violated, particularly given that the INSERT took 233ms to execute.

Oct 14 2016, 12:34 AM · Bug Report

Oct 13 2016

epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 13 2016, 7:02 PM · Restricted Project, Prioritized, Calendar
chad awarded T2334: Implement Google Calendar v3 API into Calendar a Cup of Joe token.
Oct 13 2016, 4:55 PM · Restricted Project, Prioritized, Calendar
fernofry awarded T2334: Implement Google Calendar v3 API into Calendar a Mountain of Wealth token.
Oct 13 2016, 4:10 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 13 2016, 3:52 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Restricted Differential Revision.
Oct 13 2016, 3:33 PM · Restricted Project, Prioritized, Calendar
epriestley closed T11756: Export to Spreadsheet/Excel feature from Batch Edit mode on a project column as Invalid.

This feature request does not describe a root problem. See Describing Root Problems.

Oct 13 2016, 3:11 PM · Projects, Feature Request
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 13 2016, 3:04 PM · Restricted Project, Prioritized, Calendar
epriestley moved T10747: Import and export ICS from Calendar from Backlog to The Queue on the Prioritized board.
Oct 13 2016, 2:20 PM · Restricted Project, Prioritized, Calendar
epriestley moved T2334: Implement Google Calendar v3 API into Calendar from Backlog to The Queue on the Prioritized board.
Oct 13 2016, 2:20 PM · Restricted Project, Prioritized, Calendar
epriestley moved T7924: Unprototype Calendar (v1) from Backlog to The Queue on the Prioritized board.
Oct 13 2016, 2:20 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

(If the policy isn't fixable, you can personally bear the cost of this policy by tunneling the traffic over 80 or 443 locally.)

Oct 13 2016, 2:12 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

Have they asked network operations to allow outbound traffic on port 22? It seems like organizations which employ software developers should reasonably permit this traffic. Particularly, security-minded organizations should reasonably prefer asymmetric keypair authentication over HTTP password authentication in the general case.

Oct 13 2016, 2:10 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
Yuriovich awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Pterodactyl token.
Oct 13 2016, 11:08 AM · Workboards (v3), Restricted Project