Page MenuHomePhabricator
Feed Advanced Search

Oct 30 2016

epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Oct 30 2016, 4:21 PM · Design, Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Unknown Object (Differential Revision).
Oct 30 2016, 4:17 PM · Design, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Restricted Differential Revision.
Oct 30 2016, 4:13 PM · Restricted Project, Prioritized, Calendar
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 30 2016, 3:45 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10747: Import and export ICS from Calendar.

The Gmail/ICS integration seems to actually work OK in practice, here's an event from this install working (modulo some stuff like us not exporting a host/organizer yet):

Oct 30 2016, 3:45 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Restricted Differential Revision.
Oct 30 2016, 3:22 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 30 2016, 3:14 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T11799: Garbage tool complains about invalid translation on 'set-policy' command.

This should be fixed in HEAD of master. Thanks for the report!

Oct 30 2016, 12:13 AM · Bug Report
epriestley closed T11799: Garbage tool complains about invalid translation on 'set-policy' command as Resolved by committing Restricted Diffusion Commit.
Oct 30 2016, 12:12 AM · Bug Report
epriestley added a revision to T11799: Garbage tool complains about invalid translation on 'set-policy' command: Unknown Object (Differential Revision).
Oct 30 2016, 12:01 AM · Bug Report

Oct 29 2016

epriestley added a comment to T7607: Invoicing emails probably need some work.

We can probably just use the merchant name for now. I could maybe imagine some "International Business Machines, Inc" vs "IBM" stuff down the line, but no immediate issue for "Phacility".

Oct 29 2016, 5:05 PM · Phortune, Phacility
epriestley added a comment to T11794: OAuth Server Doesn't Handle Client ID and Secret in HTTP Basic Auth.

...and here are foreseeable issues with this mess occurring in the wild:

Oct 29 2016, 12:49 AM · OAuthServer, Bug Report
epriestley added a comment to T11794: OAuth Server Doesn't Handle Client ID and Secret in HTTP Basic Auth.

Broadly, I want to avoid implementing things that don't have good technical justifications.

Oct 29 2016, 12:30 AM · OAuthServer, Bug Report

Oct 28 2016

epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 28 2016, 11:01 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10747: Import and export ICS from Calendar.

OK I imported some real great events:

Oct 28 2016, 10:51 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 28 2016, 10:44 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 28 2016, 10:16 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T11794: OAuth Server Doesn't Handle Client ID and Secret in HTTP Basic Auth.

Is "GitHub-specific OAuth" just normal OAuth with client_id / client_secret as parameters instead of in an "Authorization" header? The GitHub OAuth documentation seems to suggest passing these as parameters, too.

Oct 28 2016, 9:31 PM · OAuthServer, Bug Report
epriestley added a comment to T11792: Remove "No Highlighting" mode from Diffusion.

I think the textarea predates using JS magic to make "copy" work. I think we could probably remove the "disable highlighting" mode now; I can't really imagine any legitimate reason to intentionally disable it in modern code, except maybe not realizing that "copy" will work correctly via magic.

Oct 28 2016, 7:39 PM · Diffusion, Bug Report
epriestley added a comment to T11794: OAuth Server Doesn't Handle Client ID and Secret in HTTP Basic Auth.

I don't think we have a "client password" in this case -- I believe that refers to a mode that no one uses for anything (well, maybe a mode that Concourse uses, I guess), where the flow is actually handling normal user passwords?

Oct 28 2016, 7:36 PM · OAuthServer, Bug Report
epriestley edited the content of Changelog.
Oct 28 2016, 7:14 PM
epriestley created 2016 Week 44 (Very Late October).
Oct 28 2016, 7:13 PM
kontextbewusst awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Oct 28 2016, 1:41 PM · Workboards (v3), Restricted Project

Oct 27 2016

epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 27 2016, 9:34 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 27 2016, 8:08 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T11790: "VALARM" in ics makes phabricator fail parsing: Unknown Object (Differential Revision).
Oct 27 2016, 8:08 PM · Bug Report
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 27 2016, 6:34 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 27 2016, 6:32 PM · Restricted Project, Prioritized, Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Oct 27 2016, 5:21 PM · Design, Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Oct 27 2016, 5:21 PM · Design, Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Unknown Object (Differential Revision).
Oct 27 2016, 5:21 PM · Design, Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Oct 27 2016, 5:21 PM · Design, Calendar
epriestley added a comment to T7607: Invoicing emails probably need some work.

We can, but all styles need to be inline. DifferentialInlineCommentMailView is an example of an arbitrary-HTML-generating rendering class used in mail.

Oct 27 2016, 4:04 PM · Phortune, Phacility
epriestley closed T11790: "VALARM" in ics makes phabricator fail parsing as Invalid.

Calendar is a prototype application, and we don't accept bug reports against prototypes. See User Guide: Prototype Applications and Contributing Bug Reports.

Oct 27 2016, 4:02 PM · Bug Report
epriestley closed T11789: Hide username/password in ical import url as Invalid.

See Contributing Feature Requests for a detailed breakdown of what a feature request needs to have before we'll accept it.

Oct 27 2016, 4:01 PM · Feature Request
epriestley merged T11788: Harbormaster build step "Make HTTP request" don't trim URL field into T10510: Harbormaster failing to trigger Jenkins build through HTTP GET and producing abnormal HTTP error code .
Oct 27 2016, 12:17 PM · Restricted Project, Harbormaster, Bug Report
epriestley merged task T11788: Harbormaster build step "Make HTTP request" don't trim URL field into T10510: Harbormaster failing to trigger Jenkins build through HTTP GET and producing abnormal HTTP error code .
Oct 27 2016, 12:17 PM · Bug Report
epriestley merged task T11788: Harbormaster build step "Make HTTP request" don't trim URL field into T10510: Harbormaster failing to trigger Jenkins build through HTTP GET and producing abnormal HTTP error code .
Oct 27 2016, 12:17 PM · Bug Report
epriestley merged T11788: Harbormaster build step "Make HTTP request" don't trim URL field into T10510: Harbormaster failing to trigger Jenkins build through HTTP GET and producing abnormal HTTP error code .
Oct 27 2016, 12:17 PM · Restricted Project, Harbormaster, Bug Report
epriestley added a comment to T11788: Harbormaster build step "Make HTTP request" don't trim URL field .

I'm going to merge this into T10510, which discusses improving Harbormaster error behavior.

Oct 27 2016, 12:17 PM · Bug Report
stevex awarded T10215: Provide tools to combat and recover from abuse a Love token.
Oct 27 2016, 9:51 AM · Abuse

Oct 26 2016

epriestley added a comment to T11002: permit wildcards in OWNERs paths.

@pingpongboss, in T11787 it looks like you actually want to wildcard the repository names, not the paths?

Oct 26 2016, 10:44 PM · FreeBSD, Owners, Feature Request
epriestley merged task T11787: Allow Owners to set path based on string match into T11002: permit wildcards in OWNERs paths.
Oct 26 2016, 10:38 PM · Owners, Feature Request
epriestley merged T11787: Allow Owners to set path based on string match into T11002: permit wildcards in OWNERs paths.
Oct 26 2016, 10:38 PM · FreeBSD, Owners, Feature Request
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Oct 26 2016, 9:13 PM · Design, Calendar
epriestley closed T11638: "Create Event" from day view does not default to visible day as Resolved by committing Restricted Diffusion Commit.
Oct 26 2016, 8:10 PM · Calendar
epriestley closed T11733: Calendar custom forms with modified start date / end date defaults don't work properly as Resolved by committing Restricted Diffusion Commit.
Oct 26 2016, 8:10 PM · Calendar
epriestley added a revision to T11638: "Create Event" from day view does not default to visible day: Unknown Object (Differential Revision).
Oct 26 2016, 7:52 PM · Calendar
epriestley added a revision to T11733: Calendar custom forms with modified start date / end date defaults don't work properly: Unknown Object (Differential Revision).
Oct 26 2016, 7:38 PM · Calendar
epriestley added a comment to T11733: Calendar custom forms with modified start date / end date defaults don't work properly.

I'm just going to "fix" this by just preventing you from hiding/locking/defaulting these fields, since it doesn't seem useful to create a "New Event on January 3, 2013" sort of form anyway.

Oct 26 2016, 7:25 PM · Calendar
epriestley added a comment to T7931: Create Calendar triggers which notify users before meetings.

D16752 was approximately the same thing but I think this is a little complicated -- both in general, and for recurring events. I'm also not really sure this should use the trigger system at all.

Oct 26 2016, 7:10 PM · Calendar
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 26 2016, 6:52 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 26 2016, 6:51 PM · Restricted Project, Prioritized, Calendar
• st_we awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Oct 26 2016, 2:22 PM · Workboards (v3), Restricted Project
rabahmeradi awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Oct 26 2016, 1:56 PM · Workboards (v3), Restricted Project
nhitze awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Oct 26 2016, 8:11 AM · Workboards (v3), Restricted Project
epriestley created T11786: Loop/degenerate behavior in RepositoryGraphCache.
Oct 26 2016, 12:26 AM · Performance, Diffusion
epriestley added a project to T11050: Allow resigning from a review you are not directly responsible for: Prioritized.
Oct 26 2016, 12:20 AM · Prioritized, Restricted Project, Differential, Feature Request

Oct 25 2016

epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 25 2016, 6:27 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 25 2016, 5:32 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 25 2016, 5:18 PM · Restricted Project, Prioritized, Calendar
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 25 2016, 5:10 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 25 2016, 5:02 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T7607: Invoicing emails probably need some work.

If you do Merchants, you could add sendFromEmailAddress or whatever and maybe shortNameForEmailSubjectLines (perhaps with less-awful names) and I can hook them up at some point so this:

Oct 25 2016, 4:46 PM · Phortune, Phacility
epriestley added a comment to T7607: Invoicing emails probably need some work.

I guess the Merchant version would be businessAddress or something since Merchants aren't normally billed.

Oct 25 2016, 4:39 PM · Phortune, Phacility
epriestley added a comment to T7607: Invoicing emails probably need some work.

I think we could reasonably do this:

Oct 25 2016, 4:38 PM · Phortune, Phacility
epriestley added a comment to T7607: Invoicing emails probably need some work.

An instance needs their own address (and some other information) on the invoice for tax purposes:

Oct 25 2016, 4:28 PM · Phortune, Phacility
epriestley updated the task description for T10747: Import and export ICS from Calendar.
Oct 25 2016, 4:08 PM · Restricted Project, Prioritized, Calendar
epriestley closed T11766: Write to the pull log from SSH, not just HTTP as Resolved.

It looks like the underlying issue (T11469) was resolved through configuration changes, so we don't need to go any further here. We are writing this log now, but it could use more work eventually.

Oct 25 2016, 4:05 PM · Diffusion, Phacility
epriestley closed T11766: Write to the pull log from SSH, not just HTTP, a subtask of T11469: Checking out from Phacility sometimes fails, as Resolved.
Oct 25 2016, 4:05 PM · Phacility, Bug Report
epriestley closed T11469: Checking out from Phacility sometimes fails as Resolved.

Another instance was reproducing this more frequently/reliably and reports that they're no longer seeing issues, and I haven't been able to reproduce it myself since the configuration changes. Presuming we're in the clear now, but let us know if you see further issues.

Oct 25 2016, 4:04 PM · Phacility, Bug Report
epriestley renamed T11784: Differential "stick to the comment area" and "jump to anchor" scroll behaviors interact destructively while loading content from direct links to differential comments are not scrolling to the comment to Differential "stick to the comment area" and "jump to anchor" scroll behaviors interact destructively while loading content.
Oct 25 2016, 3:50 PM · Inline Comments, Differential, Bug Report
epriestley added a comment to T11784: Differential "stick to the comment area" and "jump to anchor" scroll behaviors interact destructively while loading content.

I think this is actually a bug between several of the 300 different pieces of scroll magic we have on the page.

Oct 25 2016, 3:49 PM · Inline Comments, Differential, Bug Report
epriestley edited projects for T11785: Clicking on images for lightbox won't load with Persistent Chat enabled, added: Bug Report (Needs Information); removed Bug Report.

I can't reproduce this by following the steps you describe. Here's a screenshot of this working properly for me:

Oct 25 2016, 11:45 AM · Bug Report, Quicksand, Conpherence (v4)
epriestley added a comment to T11783: Diffusion Post-Push Webhooks.

In almost all cases, it's within a second or two of the push.

Oct 25 2016, 2:44 AM · Feature Request
epriestley merged task T11783: Diffusion Post-Push Webhooks into T11330: Allow Herald to "Queue Call to Webhook: ...".
Oct 25 2016, 2:33 AM · Feature Request
epriestley merged T11783: Diffusion Post-Push Webhooks into T11330: Allow Herald to "Queue Call to Webhook: ...".
Oct 25 2016, 2:33 AM · Feature Request
epriestley added a comment to T11783: Diffusion Post-Push Webhooks.

I'm going to merge this into T11330, but note that you can already do this via Harbormaster, as this install does (we build via Drydock, but you can run a "Make HTTP Request..." build plan instead).

Oct 25 2016, 2:33 AM · Feature Request

Oct 22 2016

epriestley added a project to T4776: Notify users when someone takes an action that takes them off an object's recipient list: Mail.
Oct 22 2016, 5:01 PM · Mail, Restricted Project, Transactions
epriestley edited the content of Changelog.
Oct 22 2016, 3:04 PM
epriestley created 2016 Week 43 (Late October).
Oct 22 2016, 3:03 PM

Oct 21 2016

epriestley closed T11758: "aliases" is valid configuration in Arcanist, but not recognized by "arc get-config" as Resolved by committing Restricted Diffusion Commit.
Oct 21 2016, 11:08 PM · Arcanist
epriestley added a revision to T11758: "aliases" is valid configuration in Arcanist, but not recognized by "arc get-config": Unknown Object (Differential Revision).
Oct 21 2016, 9:44 PM · Arcanist
chad awarded T11780: Consider quota systems a Pirate Logo token.
Oct 21 2016, 3:47 PM · Phacility, Abuse
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Oct 21 2016, 3:10 PM · Design, Calendar
epriestley updated the task description for T11780: Consider quota systems.
Oct 21 2016, 2:44 PM · Phacility, Abuse
epriestley created T11780: Consider quota systems.
Oct 21 2016, 2:44 PM · Phacility, Abuse
epriestley added a comment to T11469: Checking out from Phacility sometimes fails.

D16744 should also improve SSH performance slightly, with a larger impact on larger instances.

Oct 21 2016, 2:27 PM · Phacility, Bug Report
epriestley added a revision to T11469: Checking out from Phacility sometimes fails: Unknown Object (Differential Revision).
Oct 21 2016, 2:27 PM · Phacility, Bug Report
epriestley added a comment to T11469: Checking out from Phacility sometimes fails.

This may have been the "MaxStartups" directive in sshd; if so, a partial fix is currently deployed (raising the limit on application load balancers) and a more comprehensive fix will go out tomorrow morning (also raising the limit on repository shards).

Oct 21 2016, 2:14 PM · Phacility, Bug Report
epriestley closed T11779: Header as Invalid.
Oct 21 2016, 11:38 AM · Dashboards (v2)

Oct 20 2016

epriestley closed T11771: Protect GC operations with a lock as Resolved by committing Restricted Diffusion Commit.
Oct 20 2016, 8:40 PM · Daemons
epriestley added a comment to T11748: Rendering a diff on a giant line runs for minutes, publishing transaction fails.

Awesome, thanks for following up. Let us know if you run into anything else!

Oct 20 2016, 8:16 PM · Bug Report
epriestley added a comment to T11036: Put subproject columns on workboards.

I do not plan to ever let you reorder milestones.

Oct 20 2016, 8:15 PM · Workboards (v3), Projects (v3)
cguenther awarded T11357: Move Files to EditEngine and modern APIs a Love token.
Oct 20 2016, 6:46 PM · Restricted Project, Files
epriestley added a revision to T11771: Protect GC operations with a lock: Unknown Object (Differential Revision).
Oct 20 2016, 6:40 PM · Daemons
epriestley added a revision to T11766: Write to the pull log from SSH, not just HTTP: Unknown Object (Differential Revision).
Oct 20 2016, 6:32 PM · Diffusion, Phacility
epriestley renamed T11773: Improve behaviors for "overheated" policy queries from Feed does not perform well in the presence of exclusive spaces to Improve behaviors for "overheated" policy queries.
Oct 20 2016, 5:08 PM · Performance
epriestley closed T11533: Upgrading: Changes to Default Homepage as Resolved.

This has been live for about two months without any substantive issues arising.

Oct 20 2016, 5:07 PM · NUX, Dashboards, Installing & Upgrading
epriestley added a comment to T11775: Panel positioning improvements.

I don't plan to implement the rest of the feature request. Assuming drag and drop works correctly, I think this operation (reordering panels) is rare enough that using it is reasonable without introducing the additional complexity of duplicate controls.

Oct 20 2016, 5:06 PM · Dashboards, Feature Request