Page MenuHomePhabricator
Feed Advanced Search

Jul 31 2016

epriestley added a comment to T11405: Need to watch the project programmatically.

Example 1: Batch edit of more projects at once - obviously easier to run script than having to click it manually.

Jul 31 2016, 9:45 PM · Feature Request (Needs Information), Conduit
epriestley added a comment to T11406: arc diff now fails at 'differential.query'.

Try now?

Jul 31 2016, 8:09 PM · Bug Report
epriestley closed T11406: arc diff now fails at 'differential.query' as Resolved by committing Restricted Diffusion Commit.
Jul 31 2016, 8:08 PM · Bug Report
epriestley claimed T11406: arc diff now fails at 'differential.query'.
Jul 31 2016, 8:05 PM · Bug Report
epriestley renamed T11401: Add ability to quote, edit, view raw, view history, and remove inline comments from Add ability to quote inline comments to Add ability to quote, edit, view raw, view history, and remove inline comments.
Jul 31 2016, 7:09 PM · Inline Comments, Restricted Project, Differential, Feature Request
epriestley added a comment to T6273: Inline comments do not support editing (Pholio, Differential, Diffusion).

See also T11401, although this started life as a Pholio task and that's now a code-specific UI task so I don't know if they're actually the same.

Jul 31 2016, 7:08 PM · Audit, Restricted Project, Diffusion, Differential, Transactions, Pholio
epriestley added a comment to T11401: Add ability to quote, edit, view raw, view history, and remove inline comments.

Yeah, I think this is largely an issue of how much space we have in the UI.

Jul 31 2016, 7:06 PM · Inline Comments, Restricted Project, Differential, Feature Request
epriestley closed T11404: Improve the performance of custom field queries as Resolved.

I deployed this stuff here. I neglected to get a production timing beforehand so I can't really claim it's actually faster, but it seems fast-ish now. Let me know if things look better and/or I ruined everything when you get around to deploying it.

Jul 31 2016, 6:48 PM · Performance, Feature Request
epriestley reopened T11405: Need to watch the project programmatically as "Open".

How about this: we'll play the "5 whys" game described in Describing Root Problems to get to bottom of this problem. After we figure it out, you tell me why you didn't provide that information in the first place and how to improve the documentation so that it's clear what we're after. Sound good?

Jul 31 2016, 6:29 PM · Feature Request (Needs Information), Conduit
epriestley added a comment to T11404: Improve the performance of custom field queries.

I don't immediately have an attack on the JIRA thing (it should be less expensive in normal cases), and don't want to do the Auth stuff without more planning, and nothing else leaps out at me as having a similar sort of value for the cost.

Jul 31 2016, 5:08 PM · Performance, Feature Request
epriestley added a revision to T11404: Improve the performance of custom field queries: Unknown Object (Differential Revision).
Jul 31 2016, 4:49 PM · Performance, Feature Request
epriestley added a revision to T11404: Improve the performance of custom field queries: Unknown Object (Differential Revision).
Jul 31 2016, 4:33 PM · Performance, Feature Request
epriestley added a comment to T11404: Improve the performance of custom field queries.

There's still quite a bit of room here. Locally, I see a 220ms call for differential.revision.search. Here are savings which look fairly easy to capture:

Jul 31 2016, 4:25 PM · Performance, Feature Request
epriestley added a revision to T11404: Improve the performance of custom field queries: Unknown Object (Differential Revision).
Jul 31 2016, 4:06 PM · Performance, Feature Request
epriestley added a revision to T11404: Improve the performance of custom field queries: Unknown Object (Differential Revision).
Jul 31 2016, 3:46 PM · Performance, Feature Request
epriestley added a revision to T11404: Improve the performance of custom field queries: Unknown Object (Differential Revision).
Jul 31 2016, 3:29 PM · Performance, Feature Request
epriestley added a comment to T11404: Improve the performance of custom field queries.

That sort of leaves you in trouble with custom edge-based fields like the one above, but a reasonable short term approach is the one you've already taken:

Jul 31 2016, 3:08 PM · Performance, Feature Request
epriestley added a comment to T11404: Improve the performance of custom field queries.

Ah, there are really a couple of issues here.

Jul 31 2016, 3:02 PM · Performance, Feature Request
epriestley closed T11405: Need to watch the project programmatically as Invalid.

Please please please please please please please please please please please please read Describing Root Problems carefully and think about what it is asking for.

Jul 31 2016, 2:49 PM · Feature Request (Needs Information), Conduit
epriestley added a comment to T11404: Improve the performance of custom field queries.

That looks broadly correct to me, I just want to try to remove the assumption that the first object's first field's storage is universally the right storage in fixing this upstream. It's always true today and for the foreseeable future, just obviously not a Fundamental Axiom of the System. Let me review D16346 and I'll spend 10 minutes on this, I'm pretty sure it's straightforward, not a weird snowbally mess, and that the upstreamable patch is only cosmetically different from that one.

Jul 31 2016, 1:15 PM · Performance, Feature Request
epriestley added a comment to T11404: Improve the performance of custom field queries.

I think the issue is that there's no callable thing for bulk-loading custom fields right now, which is why SearchEngineExtension doesn't have a hook for it. Other SearchEngine extensions don't need it since none currently load any data.

Jul 31 2016, 12:57 PM · Performance, Feature Request
epriestley added a comment to T11402: Garbage collect and/or compress/archive harbormaster build unit messages.

T10635 is vaguely related, too.

Jul 31 2016, 12:37 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a comment to T2495: Improve whitespace expansion of tab literals.

See Planning for help understanding timelines and priorities.

Jul 31 2016, 12:31 PM · Restricted Project, FreeBSD, Diffusion, Differential
epriestley added a comment to T11403: Phabricator hosted git repositories appear to error with 'failed to push some refs' without any error detail...

I can't reproduce this here, locally, or in the Phacility cluster. Can you? You should be able to push to rGITTEST on this install, or launch a test instance from admin.phacility.com and create a repository there.

Jul 31 2016, 12:30 PM · Diffusion, Bug Report
epriestley added a project to T11404: Improve the performance of custom field queries: Performance.
Jul 31 2016, 12:20 PM · Performance, Feature Request
Info-Screen awarded T9640: Make Phabricator compatible with PHP7 a Like token.
Jul 31 2016, 8:20 AM · Prioritized, Restricted Project, Infrastructure

Jul 30 2016

epriestley added a comment to Q456: Why do phabricator hosted git repositories appear to error with 'failed to push some refs' without any error detail, even though the push works?.

This is not an expected behavior.

Jul 30 2016, 3:53 PM
epriestley updated the task description for T11400: Packages v1 Errata.
Jul 30 2016, 12:47 PM · Restricted Project, Packages
epriestley created T11400: Packages v1 Errata.
Jul 30 2016, 12:47 PM · Restricted Project, Packages
epriestley created Phacility.
Jul 30 2016, 12:45 PM · Phacility
epriestley edited the content of Changelog.
Jul 30 2016, 12:43 PM
epriestley created 2016 Week 31 (Very Late July).
Jul 30 2016, 12:42 PM
epriestley moved T7939: Support Herald rules for Calendar events from Backlog to Next on the Herald board.
Jul 30 2016, 12:28 PM · Herald, Calendar
epriestley merged task T9305: "A task is moved between columns on a workboard." email preference not respected into T10448: Modularize mail tags.
Jul 30 2016, 12:27 PM · Herald
epriestley merged T9305: "A task is moved between columns on a workboard." email preference not respected into T10448: Modularize mail tags.
Jul 30 2016, 12:27 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley added a comment to T9305: "A task is moved between columns on a workboard." email preference not respected.

I'm going to close this in favor of T10448, which discusses fixing "other" tags and generally improving how tags work.

Jul 30 2016, 12:27 PM · Herald
epriestley closed T10966: Let Herald move objects between Spaces as Wontfix.

I think custom forms (today), workboard support for custom forms (likely, in the future), and T8442 are the most promising ways forward here.

Jul 30 2016, 12:24 PM · Herald, Feature Request
epriestley closed T11312: Watch / Subscribe project Herald action needed as Invalid.

It's still not really clear to me what this issue is describing. Here are my best guesses at how to fix various things which might be problems?

Jul 30 2016, 12:17 PM · Herald, Feature Request
epriestley added a comment to T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.

T7961 is probably worth fixing while I'm in here.

Jul 30 2016, 11:50 AM · Documentation, Herald
epriestley added a subtask for T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess: T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules.
Jul 30 2016, 11:50 AM · Documentation, Herald
epriestley added a parent task for T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules: T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.
Jul 30 2016, 11:50 AM · Applications, Herald
epriestley added a comment to T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.

I'm going to at least fix the instanceof mess before adding a Calendar adapter in T7939.

Jul 30 2016, 11:48 AM · Documentation, Herald
epriestley claimed T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.
Jul 30 2016, 11:48 AM · Documentation, Herald
epriestley added a subtask for T7939: Support Herald rules for Calendar events: T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.
Jul 30 2016, 11:48 AM · Herald, Calendar
epriestley added a parent task for T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess: T7939: Support Herald rules for Calendar events.
Jul 30 2016, 11:48 AM · Documentation, Herald
epriestley added a comment to T11399: Add support for locations in calendar events.

Calendar is currently prioritized, but the scope is focused on basic functionality (getting it out of the "prototype" stage, roughly described in T11326 with more recent activity in T11326) and API integrations (Google Calendar in T2334, ICS in T10747).

Jul 30 2016, 11:47 AM · Calendar, Feature Request
epriestley claimed T7931: Create Calendar triggers which notify users before meetings.
Jul 30 2016, 11:45 AM · Calendar
epriestley claimed T7939: Support Herald rules for Calendar events.
Jul 30 2016, 11:45 AM · Herald, Calendar
epriestley moved T7931: Create Calendar triggers which notify users before meetings from Future Work (v2+) to Unprototype (v1) on the Calendar board.
Jul 30 2016, 11:43 AM · Calendar
epriestley closed T11397: Overcommit -> arc lint as Wontfix.

I'm just going to close this in favor of T10038. The short answer is: write bindings.

Jul 30 2016, 11:38 AM · Feature Request
epriestley closed T11397: Overcommit -> arc lint, a subtask of T10038: Plan the mid-term pathway for unit-test/linter bindings, as Wontfix.
Jul 30 2016, 11:38 AM · Lint, Arcanist
epriestley moved T11399: Add support for locations in calendar events from Backlog to Future Work (v2+) on the Calendar board.
Jul 30 2016, 11:34 AM · Calendar, Feature Request
epriestley added a comment to T11399: Add support for locations in calendar events.

I expect to do this eventually, but I'm hesitant to just put a freeform "Location" text field on events. If we do, we can't prevent double-booking physical meeting rooms, since users may spell physical space names differently and we can't know for sure that "Meeting 6", "Meeting Room 6", "Meting Rum Six", and "Meeting Room#6" are all the same.

Jul 30 2016, 11:33 AM · Calendar, Feature Request
epriestley added a revision to T11392: Unhandled Exception when opening specific Task while not logged in: Unknown Object (Differential Revision).
Jul 30 2016, 11:24 AM · Bug Report
epriestley added a revision to T4788: Allow "Edit Dependencies" both ways (blocking and depending): Unknown Object (Differential Revision).
Jul 30 2016, 11:24 AM · Prioritized, FreeBSD, User Delight, Wikimedia, Maniphest

Jul 29 2016

epriestley created T11396: Calendar stub events do not respect recurring event end dates.
Jul 29 2016, 5:19 PM · Restricted Project, Calendar
epriestley edited this Badge.
Jul 29 2016, 2:30 PM
epriestley added a comment to T11392: Unhandled Exception when opening specific Task while not logged in.

Thanks for the report, and for including detailed reproduction steps which allowed us to reproduce the issue.

Jul 29 2016, 2:29 PM · Bug Report
epriestley closed T11393: separate the git html diff into a separate component as Wontfix.

See T5447 for information on reusing Phabricator code in third-party applications.

Jul 29 2016, 2:23 PM · Process Improvement
epriestley closed T11392: Unhandled Exception when opening specific Task while not logged in as Resolved by committing Restricted Diffusion Commit.
Jul 29 2016, 2:21 PM · Bug Report
epriestley added a revision to T11392: Unhandled Exception when opening specific Task while not logged in: Unknown Object (Differential Revision).
Jul 29 2016, 2:03 PM · Bug Report
epriestley added a comment to T11391: Unable to add uri to Diffusion.

What version of Phabricator you're running? See Providing Version Information for help figuring it out.

Jul 29 2016, 11:38 AM · Bug Report (Needs Information), Diffusion

Jul 28 2016

epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Jul 28 2016, 10:53 PM · Design, Calendar
epriestley closed T9238: Field-level policy controls are not made clear in the UI as Invalid.

I think this was obsoleted by T10003 and EditEngine.

Jul 28 2016, 10:33 PM · Maniphest
epriestley closed T9620: Every entry in the Maniphest Report table should be clickable as Wontfix.

This UI is on life support until Facts (T1562) gets built, and I don't plan to make any upstream changes/improvements.

Jul 28 2016, 10:26 PM · Maniphest
epriestley closed T8120: Priority grouped tasks doesn't handle task being set to priority outside grouping as Wontfix.

I think this is possibly undesirable to resolve in the general case, e.g.:

Jul 28 2016, 10:24 PM · Maniphest
epriestley closed T5011: Convert builtin fields in Maniphest to CustomField as Wontfix.

Phabricator's infrastructure has evolved a lot and CustomFields now serve a smaller role than they once did -- roughly, just custom fields. Later generation stuff (particularly EditEngine) feels better factored, and has reduced the responsibility of CustomFields.

Jul 28 2016, 10:13 PM · Custom Fields, Maniphest
epriestley closed T5011: Convert builtin fields in Maniphest to CustomField, a subtask of T6030: Allow CustomFields to specify additional options (like "required") configurable in `<application>.fields`, as Wontfix.
Jul 28 2016, 10:13 PM · Restricted Project, Restricted Project, Custom Fields
epriestley added a comment to T9690: Remove calls to methods deprecated by newPage().

When we make a hire we can make them do this "to become more familiar with Phabricator's codebase".

Jul 28 2016, 10:01 PM · Contributor Onboarding, Modernization, Infrastructure
epriestley closed Restricted Maniphest Task, a subtask of T10034: Plan the future of Maniphest task relationships, as Resolved.
Jul 28 2016, 9:59 PM · Maniphest
epriestley merged T9151: Search for Task by parent into T6638: Be able to find tasks by "is a blocker to task Y" or "is blocked by task Y" in the search interface.
Jul 28 2016, 9:53 PM · Restricted Project, Maniphest, Search
epriestley merged task T9151: Search for Task by parent into T6638: Be able to find tasks by "is a blocker to task Y" or "is blocked by task Y" in the search interface.
Jul 28 2016, 9:53 PM · Maniphest
epriestley closed T10034: Plan the future of Maniphest task relationships as Resolved.
Jul 28 2016, 9:52 PM · Maniphest
epriestley added a comment to T10034: Plan the future of Maniphest task relationships.

I think we pretty much have clarity on stuff this task was tracking:

Jul 28 2016, 9:52 PM · Maniphest
epriestley closed T6638: Be able to find tasks by "is a blocker to task Y" or "is blocked by task Y" in the search interface as Resolved.

At HEAD of master, this is now supported. There's no default UI for it, but you can get to it in three ways:

Jul 28 2016, 9:44 PM · Restricted Project, Maniphest, Search
epriestley closed T6638: Be able to find tasks by "is a blocker to task Y" or "is blocked by task Y" in the search interface, a subtask of T10034: Plan the future of Maniphest task relationships, as Resolved.
Jul 28 2016, 9:44 PM · Maniphest
epriestley renamed T8345: Add task tabs for "Mentions" and "Merged" from Add related tasks to Add task tabs for "Mentions" and "Merged".
Jul 28 2016, 9:40 PM · Restricted Project, FreeBSD, Maniphest
epriestley added a comment to T8345: Add task tabs for "Mentions" and "Merged".

Tentatively, I'm thinking about doing this (some discussion in T4788, too):

Jul 28 2016, 9:39 PM · Restricted Project, FreeBSD, Maniphest
epriestley added a comment to D16304: Fall back to parent tasks / subtasks when the task graph is big.

I think the commit stuff is working properly already -- the code is a little tangled, but we try to merge revisions into that section if we can, and only render it separately if we need to. That is, we attempt to render:

Jul 28 2016, 9:05 PM
epriestley added a revision to T4788: Allow "Edit Dependencies" both ways (blocking and depending): Unknown Object (Differential Revision).
Jul 28 2016, 8:57 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley added a revision to T4788: Allow "Edit Dependencies" both ways (blocking and depending): Unknown Object (Differential Revision).
Jul 28 2016, 8:29 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley closed T11386: Weird effect on closed tasks in graph view as Resolved by committing Restricted Diffusion Commit.
Jul 28 2016, 6:50 PM · Google Chrome, Bug Report
epriestley added a revision to T4788: Allow "Edit Dependencies" both ways (blocking and depending): Unknown Object (Differential Revision).
Jul 28 2016, 6:48 PM · Prioritized, FreeBSD, User Delight, Wikimedia, Maniphest
epriestley added a revision to T11386: Weird effect on closed tasks in graph view: Unknown Object (Differential Revision).
Jul 28 2016, 6:48 PM · Google Chrome, Bug Report
epriestley added a comment to T11388: Running "arc diff" on this instance, with a restricted owners package fails (after "arc patch").

Yeah I think the need for corporate users to hide things from their enemies is probably outside of our control. Just try to find lots of bugs with it.

Jul 28 2016, 6:29 PM · Bug Report
epriestley added a comment to T11388: Running "arc diff" on this instance, with a restricted owners package fails (after "arc patch").

Oops -- I assumed that package was someone testing things since every other object that has ever been hidden has been and ran bin/policy unlock without examining it, but it's actually a legitimate package. I think I put it back the way it was.

Jul 28 2016, 6:25 PM · Bug Report
epriestley added a comment to T10138: Auto-retry when landing fails due to index.lock presence.

You're currently the only user we're aware of who experiences this -- have you tried changing your IDE so it, e.g., only polls git while in the foreground?

Jul 28 2016, 6:13 PM · Arcanist, Feature Request
epriestley merged T11387: When arc failed to amend the commit with the message, the message is lost into T10138: Auto-retry when landing fails due to index.lock presence.
Jul 28 2016, 6:10 PM · Arcanist, Feature Request
epriestley merged task T11387: When arc failed to amend the commit with the message, the message is lost into T10138: Auto-retry when landing fails due to index.lock presence.
Jul 28 2016, 6:10 PM · Bug Report
epriestley closed T8126: Issue with using the filter "Blocked: Show Tasks Not Blocked By Other Tasks" in Queries as Resolved.

See also T4788 for some other followup work.

Jul 28 2016, 6:03 PM · Maniphest
epriestley closed T8126: Issue with using the filter "Blocked: Show Tasks Not Blocked By Other Tasks" in Queries, a subtask of T10034: Plan the future of Maniphest task relationships, as Resolved.
Jul 28 2016, 6:03 PM · Maniphest
epriestley added a revision to T4788: Allow "Edit Dependencies" both ways (blocking and depending): Unknown Object (Differential Revision).
Jul 28 2016, 5:51 PM · Prioritized, FreeBSD, User Delight, Wikimedia, Maniphest
epriestley added a revision to T8126: Issue with using the filter "Blocked: Show Tasks Not Blocked By Other Tasks" in Queries: Unknown Object (Differential Revision).
Jul 28 2016, 5:50 PM · Maniphest
epriestley added a comment to T8126: Issue with using the filter "Blocked: Show Tasks Not Blocked By Other Tasks" in Queries.

Because of the intermediary join to the edge table I wasn't actually able to get it working without HAVING either, but D16340 should fix the underlying issue here.

Jul 28 2016, 5:31 PM · Maniphest
epriestley added a revision to T8126: Issue with using the filter "Blocked: Show Tasks Not Blocked By Other Tasks" in Queries: Unknown Object (Differential Revision).
Jul 28 2016, 5:21 PM · Maniphest
epriestley added a comment to T8126: Issue with using the filter "Blocked: Show Tasks Not Blocked By Other Tasks" in Queries.

I believe the best way to construct these queries is like this:

Jul 28 2016, 4:04 PM · Maniphest
epriestley added a comment to T8126: Issue with using the filter "Blocked: Show Tasks Not Blocked By Other Tasks" in Queries.

I'm planning to make these changes:

Jul 28 2016, 3:56 PM · Maniphest
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Unknown Object (Differential Revision).
Jul 28 2016, 2:55 PM · Design, Calendar
epriestley added a comment to T11388: Running "arc diff" on this instance, with a restricted owners package fails (after "arc patch").

A subproblem here is perhaps that Owners should have a "Can Create Packages" policy.

Jul 28 2016, 11:21 AM · Bug Report
epriestley closed T11390: Conduit API for repos as Invalid.
Jul 28 2016, 11:19 AM