Page MenuHomePhabricator
Feed Advanced Search

Jan 7 2016

epriestley moved T4474: Improve Diffusion behavior for large files and changesets from Backlog to vNext on the Diffusion board.
Jan 7 2016, 2:28 AM · Restricted Project, Diffusion
epriestley closed T2453: Populate the blame cache when parsing commits as Wontfix.

I'm just going to close this out, since I'm not sure we really need it -- D14963, D14962, and other work adjacent to T2450 found some general performance improvements in rendering. It's possible we might pursue this (and/or a highlighting cache) in the future, but I think we're fast enough now that the huge amount of upfront work the daemons would have to do to populate these caches probably doesn't make a ton of sense.

Jan 7 2016, 2:26 AM · OS Students 2013, Diffusion
epriestley lowered the priority of T2683: Improve the performance of Diffusion browse views from High to Low.
Jan 7 2016, 2:23 AM · Diffusion
epriestley updated subscribers of T2683: Improve the performance of Diffusion browse views.
Jan 7 2016, 2:23 AM · Diffusion
epriestley merged task T8400: Details of files in diffusion browse view take long to load into T2683: Improve the performance of Diffusion browse views.
Jan 7 2016, 2:23 AM · Mercurial, Diffusion
epriestley closed T6775: Provide Remarkup Paste-like embed of Diffusion files/lines as Wontfix.

This is more than a year old now and we haven't seen other requests for it. Diffusion copy/pastes and links cleanly and I think this is sufficient in all reasonable cases I'm aware of.

Jan 7 2016, 2:20 AM · Diffusion, Remarkup
epriestley added a revision to T2450: Build a blame cache: Unknown Object (Differential Revision).
Jan 7 2016, 2:10 AM · Diffusion
epriestley added a revision to T2450: Build a blame cache: Unknown Object (Differential Revision).
Jan 7 2016, 1:56 AM · Diffusion

Jan 6 2016

epriestley added a revision to T2450: Build a blame cache: Unknown Object (Differential Revision).
Jan 6 2016, 11:40 PM · Diffusion
epriestley closed T4366: Phabricator got overloaded when browsing directories with large number of files in diffusion as Resolved by committing Restricted Diffusion Commit.
Jan 6 2016, 10:20 PM · Diffusion
epriestley created T10092: User reports Drydock not parallelizing working copy builds.
Jan 6 2016, 9:43 PM · Drydock
epriestley added a comment to T9965: Don't require newline for Differential Revision autoclose magic.

Sorry, I still don't understand your root problem.

Jan 6 2016, 9:38 PM · Feature Request
epriestley updated subscribers of T10091: Expand syntax.

I'm going to merge this into T9622, but -- oh, @chad already got it.

Jan 6 2016, 9:28 PM · Feature Request
epriestley closed T2451: Build a `diffusion.blame` Conduit method, a subtask of T2452: Implement "arc blame", as Resolved.
Jan 6 2016, 5:24 PM · Restricted Project, OS Students 2013, Arcanist
epriestley closed T2451: Build a `diffusion.blame` Conduit method as Resolved by committing Restricted Diffusion Commit.
Jan 6 2016, 5:24 PM · OS Students 2013, Diffusion
epriestley added a revision to T2450: Build a blame cache: Unknown Object (Differential Revision).
Jan 6 2016, 2:20 PM · Diffusion
epriestley added a revision to T9319: Accessing image file in Diffusion must not generate error (unhandled exception): Unknown Object (Differential Revision).
Jan 6 2016, 2:20 PM · Phacility, Diffusion, Phacility Support
epriestley added a revision to T2451: Build a `diffusion.blame` Conduit method: Unknown Object (Differential Revision).
Jan 6 2016, 1:17 PM · OS Students 2013, Diffusion
epriestley added a revision to T4366: Phabricator got overloaded when browsing directories with large number of files in diffusion: Unknown Object (Differential Revision).
Jan 6 2016, 12:15 PM · Diffusion
epriestley moved T4366: Phabricator got overloaded when browsing directories with large number of files in diffusion from Backlog to vNext on the Diffusion board.
Jan 6 2016, 11:12 AM · Diffusion
epriestley updated subscribers of T9084: Use a typeaheads for querying Object Types in Flags.

Flags currently has this unwieldy dropdown, which will only get worse over time as more applications and object types are added. It would be better to use a typeahead, like the one in global search:

Jan 6 2016, 3:25 AM · Contributor Onboarding, Flags
epriestley moved T9084: Use a typeaheads for querying Object Types in Flags from Backlog to vNext on the Flags board.
Jan 6 2016, 3:21 AM · Contributor Onboarding, Flags
epriestley triaged T9149: Flagging commits via Herald no longer generates flag note as Low priority.

I removed this because the implementation was pretty hacky (saved the rule as a text string, wasn't translatable).

Jan 6 2016, 3:21 AM · Restricted Project, Flags, Herald
epriestley moved T9149: Flagging commits via Herald no longer generates flag note from Backlog to vNext on the Flags board.
Jan 6 2016, 3:18 AM · Restricted Project, Flags, Herald
epriestley moved T10084: Flag notes should be visible in object properties from Backlog to vNext on the Flags board.
Jan 6 2016, 3:18 AM · Flags, Feature Request
epriestley updated subscribers of T10084: Flag notes should be visible in object properties.

@chad, not sure if you have design thoughts here, but I think this is broadly reasonable.

Jan 6 2016, 3:09 AM · Flags, Feature Request
epriestley renamed T10084: Flag notes should be visible in object properties from Flag notes should be visible in Maniphest UI to Flag notes should be visible in object properties.
Jan 6 2016, 2:54 AM · Flags, Feature Request
epriestley closed T10085: Phabricator should ask if it should remove a flag when the flag's owner changes a task as Wontfix.

I think it's too hard for us to guess user intent here. There's nothing a user can do which strongly signals that their flag is obsolete, since flags mean a lot of different things (in your use case, it sounds like there's no single action you take which clears the flag, just "the next action after you added the flag"). Other users (myself included) use flags for different reasons, including as long-term bookmarks. Guessing intent is also difficult because you can flag many kinds of objects, not just tasks, and we'd strongly prefer features which can be implemented globally.

Jan 6 2016, 2:50 AM · Flags, Feature Request
epriestley added a comment to T10089: Unsubscribing from a Project seems to have no effect.

Overall, the problems I currently see with watch/subscribe are:

Jan 6 2016, 2:30 AM · Projects, Bug Report
epriestley closed T10089: Unsubscribing from a Project seems to have no effect as Resolved by committing Restricted Diffusion Commit.
Jan 6 2016, 2:16 AM · Projects, Bug Report
epriestley added a comment to T10089: Unsubscribing from a Project seems to have no effect.

For the sake of completeness, the root issue you described elsewhere (unsubscribes cascading into more unsubscribes) is fixed (at least, indirectly) at HEAD, after 536d3a2, which stops self-subscribes and self-unsubscribes from publishing feed stories, mail, and notifications.

Jan 6 2016, 2:13 AM · Projects, Bug Report
epriestley claimed T10089: Unsubscribing from a Project seems to have no effect.
Jan 6 2016, 2:11 AM · Projects, Bug Report
epriestley added a revision to T10089: Unsubscribing from a Project seems to have no effect: Unknown Object (Differential Revision).
Jan 6 2016, 2:10 AM · Projects, Bug Report
epriestley added a comment to T10089: Unsubscribing from a Project seems to have no effect.

I don't currently plan to remove the option

Jan 6 2016, 1:57 AM · Projects, Bug Report
epriestley added a comment to T10089: Unsubscribing from a Project seems to have no effect.

Oh, by "remove the option" I meant "remove the option to subscribe to a project if you are not a member of the project" -- that is, "Subscribe" is disabled if you aren't a project member. I don't currently plan to remove the option, although I am leaning towards making members not be subscribed by default.

Jan 6 2016, 1:57 AM · Projects, Bug Report
epriestley added a comment to T10089: Unsubscribing from a Project seems to have no effect.

This isn't the same as T6183 or T6113, and isn't expected.

Jan 6 2016, 1:44 AM · Projects, Bug Report

Jan 5 2016

epriestley added a revision to T10088: ability to wontfix a maniphest task via an email command: Unknown Object (Differential Revision).
Jan 5 2016, 10:57 PM · Maniphest, Restricted Project, Feature Request
epriestley closed T10088: ability to wontfix a maniphest task via an email command as Resolved.

wontfix.png (1×1 px, 217 KB)

Jan 5 2016, 10:50 PM · Maniphest, Restricted Project, Feature Request
epriestley closed T8950: Mention moving hosted repositories in the "Backups and Migrations" documentation as Resolved by committing Restricted Diffusion Commit.
Jan 5 2016, 10:03 PM · Diffusion, Documentation
epriestley closed T9192: Display import status / percentage on repository front page as Resolved by committing Restricted Diffusion Commit.
Jan 5 2016, 10:03 PM · Diffusion
epriestley closed T9191: Display repository status (e.g. "importing") in search results as Resolved by committing Restricted Diffusion Commit.
Jan 5 2016, 10:02 PM · Search, Diffusion
epriestley closed T7852: A repository grep search with no results returns an Unhandled Exception ("ConduitException") as Resolved by committing Restricted Diffusion Commit.
Jan 5 2016, 9:59 PM · Diffusion
epriestley added a comment to T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas.

T4027 is another case of commits titled [JIRA-123] Blah blah blah.

Jan 5 2016, 9:53 PM · Remarkup
epriestley merged task T4027: Link commit header also to bugtraq url into T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas.
Jan 5 2016, 9:52 PM · Remarkup, Diffusion
epriestley merged T4027: Link commit header also to bugtraq url into T3278: ⛄ Build a summary mode Remarkup engine for constrained text areas.
Jan 5 2016, 9:52 PM · Remarkup
epriestley closed T4159: Exceptions occurring in Diffusion which result in PHP-FPM worker processes crashing as Invalid.

This is very old, possibly fixed by now, doesn't include reproduction steps, and other users haven't reported issues. If you have specific issues with externals and reproduction steps, feel free to file new tasks.

Jan 5 2016, 9:50 PM · Diffusion
epriestley added a revision to T8950: Mention moving hosted repositories in the "Backups and Migrations" documentation: Unknown Object (Differential Revision).
Jan 5 2016, 9:42 PM · Diffusion, Documentation
epriestley added a revision to T9192: Display import status / percentage on repository front page: Unknown Object (Differential Revision).
Jan 5 2016, 9:37 PM · Diffusion
epriestley added a revision to T9191: Display repository status (e.g. "importing") in search results: Unknown Object (Differential Revision).
Jan 5 2016, 9:29 PM · Search, Diffusion
epriestley closed T5202: "Recent Commits" should include branch in title in Diffusion as Wontfix.

This is extremely old and I think no longer relevant. The crumbs now show the current branch, and I think Diffusion got better about consistently showing and retaining branches.

Jan 5 2016, 9:23 PM · Diffusion
epriestley added a comment to T4348: Provide a workflow for "auditing a codebase" via Nuance or some new tool.

T5744 mentions another narrower and more reasonable use case (get specific badness which matches some pattern fixed), which is similar to the Mochi/i18n stuff.

Jan 5 2016, 9:19 PM · Diffusion
epriestley updated subscribers of T4348: Provide a workflow for "auditing a codebase" via Nuance or some new tool.
Jan 5 2016, 9:17 PM · Diffusion
epriestley merged task T5744: Create obvious way to create an audit from Diffusion into T4348: Provide a workflow for "auditing a codebase" via Nuance or some new tool.
Jan 5 2016, 9:17 PM · Audit, Diffusion
epriestley added a comment to T9771: Objects which are restricted because of Spaces render as "Unknown" instead of "Restricted".

T5046 has a specific case of this causing particularly questionable behavior when doing HTTP clones -- since the object is totally hidden, you don't get prompted for credentials.

Jan 5 2016, 9:14 PM · Policy, Spaces
epriestley updated the task description for T9771: Objects which are restricted because of Spaces render as "Unknown" instead of "Restricted".
Jan 5 2016, 9:13 PM · Policy, Spaces
epriestley updated subscribers of T9771: Objects which are restricted because of Spaces render as "Unknown" instead of "Restricted".
Jan 5 2016, 9:12 PM · Policy, Spaces
epriestley merged task T5046: Repositories requiring authentication does not prompt for auth details over http if "policy.allow-public" is true into T9771: Objects which are restricted because of Spaces render as "Unknown" instead of "Restricted".
Jan 5 2016, 9:12 PM · Diffusion
epriestley added a comment to T5046: Repositories requiring authentication does not prompt for auth details over http if "policy.allow-public" is true.

This is expected with Spaces, which completely hide objects (primarily as a performance consideration). I'm going to merge this into T9771 which discusses this issue more broadly.

Jan 5 2016, 9:12 PM · Diffusion
epriestley added a comment to T6655: Offer to generate a new SSH key in /diffusion/import credentials step.

T8296 is a similar case for "Add Mirror".

Jan 5 2016, 9:08 PM · Diffusion
epriestley merged task T8296: Add Link to Passphrase to "Add Mirror" Dialog for repositories and fix an overflowing dropdown into T6655: Offer to generate a new SSH key in /diffusion/import credentials step.
Jan 5 2016, 9:08 PM · Passphrase, Diffusion
epriestley updated subscribers of T6655: Offer to generate a new SSH key in /diffusion/import credentials step.
Jan 5 2016, 9:08 PM · Diffusion
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Jan 5 2016, 9:04 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Jan 5 2016, 8:29 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Jan 5 2016, 7:02 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a comment to Q262: How does unsubscribing from a Project work?.

This behavior is not expected. Please file a bug report with reproduction instructions.

Jan 5 2016, 6:08 PM · Projects
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Jan 5 2016, 5:22 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Jan 5 2016, 4:41 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley moved T7852: A repository grep search with no results returns an Unhandled Exception ("ConduitException") from Backlog to vNext on the Diffusion board.
Jan 5 2016, 2:14 PM · Diffusion
epriestley added a revision to T7852: A repository grep search with no results returns an Unhandled Exception ("ConduitException"): Unknown Object (Differential Revision).
Jan 5 2016, 2:03 PM · Diffusion
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Jan 5 2016, 1:43 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a subtask for T4245: Make repository URIs slightly prettier: T7938: Do not allow users to enter things like "/" or ".." in the "Clone/Checkout" field in repositories.
Jan 5 2016, 1:25 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a parent task for T7938: Do not allow users to enter things like "/" or ".." in the "Clone/Checkout" field in repositories: T4245: Make repository URIs slightly prettier.
Jan 5 2016, 1:25 PM · Restricted Project, Diffusion
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Jan 5 2016, 1:12 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Jan 5 2016, 12:51 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley closed T10087: fix the bug, a subtask of T10086: new test BUG , as Spite.
Jan 5 2016, 12:05 PM
epriestley closed T10087: fix the bug as Spite.
Jan 5 2016, 12:05 PM
epriestley closed T10086: new test BUG as Spite.
Jan 5 2016, 12:05 PM
epriestley added a comment to Q260: Application E-Mail Addresses (Answer 295).

step1.png (851×1 px, 155 KB)

Jan 5 2016, 10:31 AM
joshuaspence changed the status of T10083: Test from Resolved to Spite.
Jan 5 2016, 7:15 AM · Bug Report, Differential, Diffusion
joshuaspence added a comment to T10004: ApplicationEditor Errata.

OK, I managed to reproduce it on this install, see T10083. Specifically see T10083#151963 in which I attempted to close the task as resolved.

Jan 5 2016, 7:14 AM · ApplicationEditor
joshuaspence added a comment to T10083: Test.

sdfgdsfgSdfadsgfsdfgsef

Jan 5 2016, 7:14 AM · Bug Report, Differential, Diffusion
joshuaspence closed T10083: Test as Resolved.

Three out of four's not bad.

Jan 5 2016, 7:14 AM · Bug Report, Differential, Diffusion
joshuaspence added a comment to T10083: Test.

Fourth time's a charm

Jan 5 2016, 7:13 AM · Bug Report, Differential, Diffusion
joshuaspence reopened T10083: Test as "Open".
Jan 5 2016, 7:13 AM · Bug Report, Differential, Diffusion
joshuaspence closed T10083: Test as Resolved.

Third time lucky?

Jan 5 2016, 7:13 AM · Bug Report, Differential, Diffusion
joshuaspence added a comment to T10083: Test.

Attempting to close the task again.

Jan 5 2016, 7:13 AM · Bug Report, Differential, Diffusion
joshuaspence added a comment to T10004: ApplicationEditor Errata.

OK, I managed to reproduce it on this install, see T10083. Specifically see T10083#151963 in which I attempted to close the task as resolved.

Jan 5 2016, 7:12 AM · ApplicationEditor
joshuaspence added a comment to T10083: Test.

Attempting to close this task.

Jan 5 2016, 7:12 AM · Bug Report, Differential, Diffusion
joshuaspence added a comment to T10083: Test.

This is another comment.

Jan 5 2016, 7:11 AM · Bug Report, Differential, Diffusion
joshuaspence added a comment to T10083: Test.

This is a comment.

Jan 5 2016, 7:11 AM · Bug Report, Differential, Diffusion
joshuaspence created T10083: Test.
Jan 5 2016, 7:11 AM · Bug Report, Differential, Diffusion
joshuaspence added a comment to T10004: ApplicationEditor Errata.

Actually, I am seeing still seeing this issue on our install on tasks which aren't affected by any Herald rule (that I know of).

Jan 5 2016, 12:54 AM · ApplicationEditor

Jan 4 2016

epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Jan 4 2016, 4:14 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley created P1915 Patches After Week 49.
Jan 4 2016, 4:07 PM
epriestley closed T8918: Header shows number of notifications and various other controls on the 2FA auth screen as Resolved by committing Restricted Diffusion Commit.
Jan 4 2016, 2:57 PM · Security, Auth
epriestley closed T8918: Header shows number of notifications and various other controls on the 2FA auth screen, a subtask of T8442: Build Space switching UI, as Resolved.
Jan 4 2016, 2:57 PM · Restricted Project, Spaces, Wikimedia, Policy
epriestley closed T9724: "ssh-exec" sometimes hangs when git cloning larger repos as Resolved.

Thanks for the report! Let us know if you run into anything else.

Jan 4 2016, 1:19 PM · Git
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Jan 4 2016, 1:18 PM
joshuaspence added a comment to T10004: ApplicationEditor Errata.

Yeah, I can't reproduce it anymore either. I definitely saw it earlier today on a different install (which is up-to-date within a couple of hours) but I don't know what was special then.

Jan 4 2016, 7:37 AM · ApplicationEditor

Jan 3 2016

epriestley added a comment to T5301: Inline Remarkup escaping.

See the documentation: sh -c `some subcommand`

Jan 3 2016, 10:53 PM · Remarkup