Page MenuHomePhabricator
Feed Advanced Search

Oct 23 2015

epriestley closed T9618: "><svg onload=alert(1)>, a subtask of T9617: "><svg onload=alert(1)>, as Spite.
Oct 23 2015, 12:43 PM
uaoleg awarded T9378: Build Projects v3 a Love token.
Oct 23 2015, 12:03 PM · Projects (v3), Prioritized
vinzent awarded Changelog a Like token.
Oct 23 2015, 9:26 AM
joshuaspence added a project to T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds: Harbormaster.
Oct 23 2015, 2:40 AM · Harbormaster (v3), Restricted Project

Oct 22 2015

20after4 awarded T9494: Standardize GarbageCollector TTLs a Mountain of Wealth token.
Oct 22 2015, 10:34 PM · Config
epriestley added a comment to T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds.

After further careful thought, I suppose introducing a "Protect Build" action might be better than rate-limiting build kills. Users protecting a build would increment a "Shield Level" counter, and users trying to kill it would decrement the "Shield Level". Once the level dropped below 0, the build would be terminated. So you could band together with 3 team mates to give all your builds a Shield Level of 4, and require a team of 5 or more attackers to steal your resources. I think this would immediately lead to a fair market for build resources.

Oct 22 2015, 8:19 PM · Harbormaster (v3), Restricted Project
epriestley added a comment to T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds.

Alternatively, we can provide a "kill enemy builds" API and a "your build got killed" webhook and let everyone sort it out for themselves. We could put an action rate limit on build kills so people would be incentivized to band together into coalitions since they wouldn't individually have enough power to kill everyone else's builds or defend their own builds.

Oct 22 2015, 8:07 PM · Harbormaster (v3), Restricted Project
epriestley added a comment to T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds.

(And the build-level buttons would only affect plans you could individually affect -- the build-level "Abort" just means "click every step-level abort I have permission to click".)

Oct 22 2015, 8:04 PM · Harbormaster (v3), Restricted Project
epriestley added a comment to T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds.

why is she running so many builds, that's ridiculous, I should stop these so that my builds have a chance to use the build servers

Oct 22 2015, 8:03 PM · Harbormaster (v3), Restricted Project
epriestley closed T9222: Arc upgrade returns success message when it failed as Resolved by committing Restricted Diffusion Commit.
Oct 22 2015, 7:55 PM · Restricted Project, Arcanist
epriestley added a member for Blessed Committers: industry.
Oct 22 2015, 7:50 PM
epriestley added a revision to T9222: Arc upgrade returns success message when it failed: Unknown Object (Differential Revision).
Oct 22 2015, 7:27 PM · Restricted Project, Arcanist
epriestley claimed T9222: Arc upgrade returns success message when it failed.
Oct 22 2015, 6:19 PM · Restricted Project, Arcanist
epriestley added a project to T7441: Support OAuth providers in the cluster: Prioritized.
Oct 22 2015, 6:07 PM · Auth, Phacility
epriestley added a comment to T7441: Support OAuth providers in the cluster.

The original driver here was a very complex one (requiring instance-level, non-registration OAuth links to services) but that never went through.

Oct 22 2015, 6:07 PM · Auth, Phacility
epriestley added a revision to T9613: Unable to delete user from phacility web interface. Am prompted with a command : Unknown Object (Differential Revision).
Oct 22 2015, 5:08 PM · Phacility Support
epriestley closed T9613: Unable to delete user from phacility web interface. Am prompted with a command as Resolved.

Resolved via email.

Oct 22 2015, 4:58 PM · Phacility Support
epriestley added a comment to T9613: Unable to delete user from phacility web interface. Am prompted with a command .

If you definitely want to delete the user (usually, it's better to just disable users), can you shoot us an email at support@phacility.com with your instance name and the user you want deleted?

Oct 22 2015, 4:47 PM · Phacility Support
epriestley added a comment to T9612: Unable to scroll after clicking on inline comment link in Chrome 46.

Yeah, I have the same guess as @chad on this.

Oct 22 2015, 1:57 PM · Differential, Google Chrome
epriestley added a comment to T9612: Unable to scroll after clicking on inline comment link in Chrome 46.

This does not reproduce for me with Chrome 46 on Windows 7.

Oct 22 2015, 1:52 PM · Differential, Google Chrome
epriestley added a comment to T9612: Unable to scroll after clicking on inline comment link in Chrome 46.

I also can't reproduce this with a similar setup (OSX / Macbook / Chrome 46).

Oct 22 2015, 1:32 PM · Differential, Google Chrome
epriestley added a comment to T9612: Unable to scroll after clicking on inline comment link in Chrome 46.

See T7740 / https://code.google.com/p/chromium/issues/detail?id=473657 for a previous adventure with scrolling Chrome anchors.

Oct 22 2015, 1:11 PM · Differential, Google Chrome
joshuaspence added a comment to T9597: Diffusion user guide: for sshd to work.

Ah

Oct 22 2015, 11:18 AM · Diffusion, Documentation
epriestley added a project to T9222: Arc upgrade returns success message when it failed: Restricted Project.
Oct 22 2015, 7:23 AM · Restricted Project, Arcanist
epriestley merged task T9611: arc upgrade doesn't check for git failures into T9222: Arc upgrade returns success message when it failed.
Oct 22 2015, 7:23 AM · Restricted Project
epriestley updated subscribers of T9222: Arc upgrade returns success message when it failed.
Oct 22 2015, 7:23 AM · Restricted Project, Arcanist
epriestley added a comment to T9610: You can `bin/auth recover` a mailing list administrator, and get a confusing error when you do.
  • Mailing list users can currently be made into administrators. We should probably prevent this, because it seems silly. (Making a daemon an administrator is still silly, but doesn't seem completely unreasonable.)
    • Regardless, users can be marked as mailing lists and also as administrators in the database.
    • bin/auth recover will let you recover users who can not establish web login sessions as long as they are administrators, but should not.
    • When you recover such a user, a misleading error message is shown (session invalid). Instead, recovery should fail explicitly and/or the session error message should point at the root cause more directly.
Oct 22 2015, 1:05 AM · Auth
epriestley created T9610: You can `bin/auth recover` a mailing list administrator, and get a confusing error when you do.
Oct 22 2015, 1:00 AM · Auth
epriestley edited P1872 import_from_csv.php.
Oct 22 2015, 12:52 AM

Oct 21 2015

epriestley added a comment to T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).

I think this is generally reasonable, but this is the tricky part:

Oct 21 2015, 10:32 PM · Restricted Project, Harbormaster
epriestley added a comment to T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).

Oh, you need application/json or other weird stuff.

Oct 21 2015, 7:41 PM · Restricted Project, Harbormaster
epriestley added a comment to T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).

Does adding variables with ?var=value to the URL definitely not work?

Oct 21 2015, 7:40 PM · Restricted Project, Harbormaster
aravindh awarded T731: Allow revisions to have alternate acceptance conditions a Like token.
Oct 21 2015, 7:07 PM · Restricted Project, Restricted Project, Differential
epriestley added a member for Blessed Committers: jparise.
Oct 21 2015, 4:22 PM
epriestley added a comment to T9564: Search Herald rules by name.

T9352 has an early approach for parameterizing builds via Herald which might let you collapse some of those rules.

Oct 21 2015, 11:57 AM · Herald

Oct 20 2015

epriestley added a revision to T182: Commit into repository directly from differential: Unknown Object (Differential Revision).
Oct 20 2015, 11:31 PM · Haskell.org, Restricted Project, Differential
epriestley added a comment to T9605: Running prod daemons fails on test files.

If you've forked, you can also just move stuff into src/ourcustomstuff/ and use arc liberate, arc unit, etc., at top level. This may have an overall lower maintenance cost than splitting a library out given that you're already bearing the cost of maintaining a fork. Only src/extensions/ has magic behavior.

Oct 20 2015, 11:01 PM · Daemons, Restricted Project
epriestley added a comment to T9605: Running prod daemons fails on test files.

We always load everything in src/extensions/ when starting up, which is why this is loading.

Oct 20 2015, 10:50 PM · Daemons, Restricted Project
epriestley merged task T9607: separate client-uri and client-port options for aphlict into T7097: Following documentation on Aphlict+nginx results in empty client-port for Aphlict.
Oct 20 2015, 10:38 PM · Aphlict
epriestley updated subscribers of T7097: Following documentation on Aphlict+nginx results in empty client-port for Aphlict.
Oct 20 2015, 10:38 PM · FreeBSD, Restricted Project, Documentation, Aphlict
epriestley added a comment to T9606: "Calendar" tab on user profiles is pretty junky.

Calendar's still a prototype and we have a few unfinished pieces like this, but we can keep this around as a reminder until we finish it up.

Oct 20 2015, 10:37 PM · Calendar
epriestley added a subtask for T7925: Calendar v1 Errata: T9606: "Calendar" tab on user profiles is pretty junky.
Oct 20 2015, 10:37 PM · Calendar
epriestley added a parent task for T9606: "Calendar" tab on user profiles is pretty junky: T7925: Calendar v1 Errata.
Oct 20 2015, 10:37 PM · Calendar
epriestley added a project to T9606: "Calendar" tab on user profiles is pretty junky: Calendar.
Oct 20 2015, 10:37 PM · Calendar
epriestley added a comment to T9597: Diffusion user guide: for sshd to work.

I don't think that would impact the outcome here. ssh-auth would still fail: I believe the problem is that php is in /usr/local/bin (or maybe /usr/games), so ssh-auth can't execute without that in path.

Oct 20 2015, 8:25 PM · Diffusion, Documentation
epriestley added a comment to T9604: Creating an imported repository via Conduit results in filesystem error.

This endpoint is very old and has a lot of problems, including not being cluster-aware. In the Phacility cluster, the web host and repository hosts are separated. repository.create can not create cluster-aware repositories.

Oct 20 2015, 8:24 PM · Restricted Project, Phacility Support, Diffusion, Conduit
joshuaspence added a project to T9597: Diffusion user guide: for sshd to work: Diffusion.
Oct 20 2015, 8:19 PM · Diffusion, Documentation
joshuaspence added a comment to T9597: Diffusion user guide: for sshd to work.

For what it's worth, I don't use phabricator-ssh-hook.sh at all, I find it to be much simpler. Instead o use the following SSH configuration (which also allows me to run both administrative and VCS SSH over pirt 22):

Oct 20 2015, 8:19 PM · Diffusion, Documentation
epriestley added a member for Blessed Committers: gd.
Oct 20 2015, 4:38 PM
epriestley closed T9532: No symbols found even if they are presented in DB as Resolved.

I deployed rP4c1463eb to this server and the reproduction steps above now work correctly, so I think D14311 fixed things. Let us know if I missed anything.

Oct 20 2015, 4:06 PM · Symbols, Diffusion
epriestley added a revision to T9532: No symbols found even if they are presented in DB: Unknown Object (Differential Revision).
Oct 20 2015, 3:54 PM · Symbols, Diffusion
epriestley added a comment to T9532: No symbols found even if they are presented in DB.

Thanks, that's very helpful.

Oct 20 2015, 3:52 PM · Symbols, Diffusion
epriestley added a comment to T9603: PHD daemons regularly stopping/starting.

Alright. In the short term, you can bin/worker cancel --id <id> any tasks with a bunch of failures to stop that specific task from retrying. Presumably a handful of problem tasks are causing the majority/entirety of the issue.

Oct 20 2015, 3:49 PM · Daemons
epriestley added a comment to T9603: PHD daemons regularly stopping/starting.

Have you used bin/remove destroy to delete any diffs or revisions?

Oct 20 2015, 3:30 PM · Daemons
epriestley closed T5896: Mercurial fails to parse (A or B or ... or Z) revsets with more than about 300 items as Resolved.

The Mercurial upstream fixed this but we need to retain the (1 or 2) or (3 or 4) code for backward compatibility anyway, so I don't plan to remove it until we run into a real problem it causes other than "it is icky".

Oct 20 2015, 2:21 PM · Diffusion, Mercurial, Daemons
epriestley closed T3141: Improve general stability/sanity of Diffusion file content queries, a subtask of T2442: Show images in Diffusion diffs, as Invalid.
Oct 20 2015, 2:12 PM · Wikimedia, Diffusion
epriestley closed T3141: Improve general stability/sanity of Diffusion file content queries as Invalid.

I don't remember what the original context was here, but T9319 is likely a reasonable proxy for it.

Oct 20 2015, 2:12 PM · Diffusion
epriestley closed T3141: Improve general stability/sanity of Diffusion file content queries, a subtask of T4474: Improve Diffusion behavior for large files and changesets, as Invalid.
Oct 20 2015, 2:12 PM · Restricted Project, Diffusion
epriestley moved T4245: Make repository URIs slightly prettier from Backlog to vNext on the Diffusion board.
Oct 20 2015, 2:08 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley closed T8365: Initialization Error as Invalid.

This does not appear to describe a reproducible issue. See:

Oct 20 2015, 2:06 PM · Diffusion
epriestley moved T7938: Do not allow users to enter things like "/" or ".." in the "Clone/Checkout" field in repositories from Backlog to vNext on the Diffusion board.
Oct 20 2015, 2:05 PM · Restricted Project, Diffusion
epriestley added a comment to T7938: Do not allow users to enter things like "/" or ".." in the "Clone/Checkout" field in repositories.

See also T4245.

Oct 20 2015, 2:05 PM · Restricted Project, Diffusion
epriestley renamed T7938: Do not allow users to enter things like "/" or ".." in the "Clone/Checkout" field in repositories from git clone (HTTP) failed while I set 'Clone/Checkout' values to Do not allow users to enter things like "/" or ".." in the "Clone/Checkout" field in repositories.
Oct 20 2015, 2:05 PM · Restricted Project, Diffusion
epriestley closed T8423: Importing an external repository (branches not identified) as Wontfix.

Subversion does not have top-level branches or tags; these features are purely conventional.

Oct 20 2015, 2:01 PM · Diffusion
epriestley added a comment to T9523: Make search autocomplete show repository names.
  • rCALLSIGN autocompletes.
    • r substring, where "substring" is a substring of the repository name, jumps to matching results.
Oct 20 2015, 1:59 PM · Restricted Project, Diffusion, Search
epriestley placed T9523: Make search autocomplete show repository names up for grabs.
Oct 20 2015, 1:58 PM · Restricted Project, Diffusion, Search
epriestley updated subscribers of T9523: Make search autocomplete show repository names.
Oct 20 2015, 1:58 PM · Restricted Project, Diffusion, Search
epriestley merged task T8624: Typeahead for repository requires the 'r' to autocomplete callsigns into T9523: Make search autocomplete show repository names.
Oct 20 2015, 1:58 PM · Typeahead, Diffusion
epriestley closed T9118: Modifying "Default View/Edit" Policies for Diffusion do not appear to retain their values as Resolved by committing Restricted Diffusion Commit.
Oct 20 2015, 1:56 PM · Policy, Diffusion
epriestley added a revision to T9118: Modifying "Default View/Edit" Policies for Diffusion do not appear to retain their values: Unknown Object (Differential Revision).
Oct 20 2015, 1:55 PM · Policy, Diffusion
epriestley added a comment to T9118: Modifying "Default View/Edit" Policies for Diffusion do not appear to retain their values.

Sorry, this fell through the cracks -- feel free to make noise about anything policy-related like this if I don't pick it up in a couple of days.

Oct 20 2015, 1:50 PM · Policy, Diffusion
epriestley claimed T9118: Modifying "Default View/Edit" Policies for Diffusion do not appear to retain their values.
Oct 20 2015, 1:50 PM · Policy, Diffusion
epriestley added a comment to T9192: Display import status / percentage on repository front page.

Maybe rename the edit page "advanced" or something, and let anyone with "can view" see it?

Oct 20 2015, 1:38 PM · Diffusion
epriestley added a comment to T9191: Display repository status (e.g. "importing") in search results.

See also T9192.

Oct 20 2015, 1:36 PM · Search, Diffusion
epriestley triaged T9191: Display repository status (e.g. "importing") in search results as Wishlist priority.
Oct 20 2015, 1:36 PM · Search, Diffusion
epriestley moved T9191: Display repository status (e.g. "importing") in search results from Backlog to vNext on the Diffusion board.
Oct 20 2015, 1:36 PM · Search, Diffusion
epriestley triaged T9192: Display import status / percentage on repository front page as Wishlist priority.
Oct 20 2015, 1:36 PM · Diffusion
epriestley moved T9192: Display import status / percentage on repository front page from Backlog to vNext on the Diffusion board.
Oct 20 2015, 1:35 PM · Diffusion
epriestley added a comment to T9191: Display repository status (e.g. "importing") in search results.

I think this is a very low-impact change, but not an unreasonable one (the data is already available on the object, I think, and we do already show "Inactive", which is a somewhat similar state). This would make the list view marginally more useful in a tiny number of cases.

Oct 20 2015, 1:35 PM · Search, Diffusion
epriestley added a comment to T9524: Show aggregate subdirectory coverage in Diffusion browse views.

Oh, sorry, I'm just moving stuff around on some boards so I can feel accomplished.

Oct 20 2015, 1:34 PM · Diffusion, Restricted Project
epriestley moved T8950: Mention moving hosted repositories in the "Backups and Migrations" documentation from Backlog to vNext on the Diffusion board.
Oct 20 2015, 1:25 PM · Diffusion, Documentation
epriestley moved T9319: Accessing image file in Diffusion must not generate error (unhandled exception) from Backlog to vNext on the Diffusion board.
Oct 20 2015, 1:25 PM · Phacility, Diffusion, Phacility Support
epriestley added a comment to T9532: No symbols found even if they are presented in DB.

Do we actually have a reproduction case for this? I'm not sure where I'm supposed to click getLinterName to reproduce this.

Oct 20 2015, 1:25 PM · Symbols, Diffusion
epriestley triaged T9532: No symbols found even if they are presented in DB as Normal priority.
Oct 20 2015, 1:24 PM · Symbols, Diffusion
epriestley moved T9524: Show aggregate subdirectory coverage in Diffusion browse views from Backlog to vNext on the Diffusion board.
Oct 20 2015, 1:24 PM · Diffusion, Restricted Project
epriestley moved T9532: No symbols found even if they are presented in DB from Backlog to vNext on the Diffusion board.
Oct 20 2015, 1:24 PM · Symbols, Diffusion
epriestley moved T9554: Trigger "import" heuristics for imported repositories from Backlog to vNext on the Diffusion board.
Oct 20 2015, 1:24 PM · Diffusion, Restricted Project, Restricted Project
epriestley moved T9562: Show only the first N branches/tags on commits in Diffusion, with a "Show all..." link from Backlog to vNext on the Diffusion board.
Oct 20 2015, 1:24 PM · Diffusion (v3), Restricted Project
epriestley triaged T9562: Show only the first N branches/tags on commits in Diffusion, with a "Show all..." link as Normal priority.
Oct 20 2015, 1:24 PM · Diffusion (v3), Restricted Project
epriestley added a comment to T9590: Subversion directory anchoring rules are unclear and underpowered.

It looks like it still has trouble properly rooting the files. Maybe a good way forward here is to always use their absolute path in the repo instead of trying to tie them to some subdir?

Oct 20 2015, 1:23 PM · Differential, Subversion
epriestley closed T9595: Changing phd.user seems poorly documented and overall a bad sysadmin experience as Wontfix.

I'd like to see more users encounter difficulty here before pursuing any of this.

Oct 20 2015, 1:21 PM · Documentation, Installing & Upgrading, Setup
epriestley closed T9597: Diffusion user guide: for sshd to work as Wontfix.

We explicitly do not cover setting up init scripts. See T4181.

Oct 20 2015, 1:15 PM · Diffusion, Documentation
epriestley closed T9585: not able to delete tasks from phd queue as Invalid.

Okay. This report doesn't appear to describe a reproducible problem. See:

Oct 20 2015, 12:57 PM · Daemons
joshuaspence created T9601: Herald rule not working as expected.
Oct 20 2015, 2:49 AM · Herald

Oct 19 2015

epriestley placed T9171: old maniphest_custom docs hang around, posisble confusing googlers up for grabs.

Ugh, it's too hacky. I'm just going to put a manual redirect in place for now instead.

Oct 19 2015, 6:28 PM · Diviner
epriestley claimed T9171: old maniphest_custom docs hang around, posisble confusing googlers.

I'm just going to put a redirect map in the book for now. This isn't a great long-term solution but I want to move forward on D13941 in some form.

Oct 19 2015, 6:24 PM · Diviner
epriestley closed T9599: You have an unresolved setup issue... none left, just 3 ignored as Resolved by committing Restricted Diffusion Commit.
Oct 19 2015, 6:14 PM · Setup, Installing & Upgrading
epriestley added a comment to T9599: You have an unresolved setup issue... none left, just 3 ignored.

APC and APCu are different. Basically:

Oct 19 2015, 5:08 PM · Setup, Installing & Upgrading
epriestley added a revision to T9599: You have an unresolved setup issue... none left, just 3 ignored: Unknown Object (Differential Revision).
Oct 19 2015, 4:57 PM · Setup, Installing & Upgrading
epriestley added a comment to T9599: You have an unresolved setup issue... none left, just 3 ignored.

But you say the message was preferable to the consequences of the possible fix without APC?

Oct 19 2015, 4:44 PM · Setup, Installing & Upgrading