Page MenuHomePhabricator

No symbols found even if they are presented in DB
Closed, ResolvedPublic

Event Timeline

vhbit updated the task description. (Show Details)
vhbit added a project: Diffusion.
vhbit added a subscriber: vhbit.

https://secure.phabricator.com/diffusion/symbol/getLinterName/?lang=php&repositories=PHID-REPO-08d9fc47cf397db6ce83%2C[object%20Object]&jump=true

[object%20Object] should not be there. See (2).

https://secure.phabricator.com/diffusion/symbol/getLinterName/?lang=php&repositories=PHID-REPO-08d9fc47cf397db6ce83&jump=true

That's actually the PHID for rPHU, so it's correct in not finding anything. Using the PHID for rARC works as expected:
https://secure.phabricator.com/diffusion/symbol/getLinterName/?lang=php&repositories=PHID-REPO-7549473b706cf5093dbf

So I guess the issue with (1) is that the PHID for rARC is somehow replaced with [object%20Object].

This partially works, i.e. symbols are shown, but! the last result is from rP:
https://secure.phabricator.com/diffusion/symbol/getLinterName/?lang=php&repositories=rARC&jump=true

I think repositories field only expects PHIDs, so it ignores this content; It then falls back to searching in all repositories, which sorts of makes sense.

So probably the only issue here is that [object%20Object] thing.

epriestley triaged this task as Normal priority.Oct 20 2015, 1:24 PM
epriestley moved this task from Backlog to vNext on the Diffusion board.
epriestley added a subscriber: epriestley.

Do we actually have a reproduction case for this? I'm not sure where I'm supposed to click getLinterName to reproduce this.

For example:

  1. Open https://secure.phabricator.com/diffusion/P/browse/master/src/applications/arcanist/conduit/ArcanistConduitAPIMethod.php
  2. Cmd+click on ConduitAPIMethod
  3. Get "No matching symbol could be found in any indexed repository."
epriestley claimed this task.

I deployed rP4c1463eb to this server and the reproduction steps above now work correctly, so I think D14311 fixed things. Let us know if I missed anything.