Page MenuHomePhabricator
Create Task
Maniphest T3141

Improve general stability/sanity of Diffusion file content queries
Closed, InvalidPublic
Actions

Description

Highlighted code is broken in Diffusion.

To re-produce, navigate and view any file with highlighting enabled, e.g. https://secure.phabricator.com/diffusion/P/browse/master/.gitignore?view=highlighted

Disabling highlights works okay.

This happened after I ran the update script a few moments ago; also observed it on phabricator for phabricator.

Revisions and Commits

Restricted Differential Revision
rP Phabricator
Restricted Differential RevisionrP5877026e817f Fix highlighted code in Diffusion

Related Objects
Search...

Event Timeline

kai added a project: Diffusion.May 8 2013, 7:16 PM
kai attached 1 file(s): Restricted File.
kai added a subscriber: kai.
epriestley claimed this task.May 8 2013, 7:21 PM

Thanks, I'll take a look. This is probably a side effect of D5824. (+@btrahan)

I have a meeting at 3PM PST (about 2 hours from now) but I'll try to get a patch out before then. I believe @btrahan is currently in a meeting.

epriestley triaged this task as High priority.May 8 2013, 7:21 PM
epriestley added a subscriber: btrahan.
epriestley edited this Maniphest Task.May 8 2013, 7:37 PM
btrahan added a comment.May 8 2013, 9:49 PM

Sorry about this, my testing was insufficient. FWIW this works with my defaults -- which has both blaming and highlight enabling -- and seems to fail when only highlighting is enabled.

btrahan edited this Maniphest Task.May 8 2013, 9:57 PM
btrahan added a comment.May 8 2013, 9:58 PM

Added an alternative fix. This one basically updates the business logic to make the correct request.

epriestley edited this Maniphest Task.May 9 2013, 1:13 AM
epriestley lowered the priority of this task from High to Normal.May 9 2013, 2:02 AM

Depri since the immediate issue is resolved, but I'm going to try to drive a more solid fix here.

epriestley renamed this task from Highlighted code is broken to Improve general stability/sanity of Diffusion file content queries.May 13 2013, 1:51 AM
epriestley edited this Maniphest Task.Feb 26 2014, 9:13 PM
joshuaspence added a subscriber: joshuaspence.May 30 2015, 12:21 PM
chad changed the visibility from "All Users" to "Public (No Login Required)".Jul 3 2015, 5:22 AM
epriestley closed this task as Invalid.Oct 20 2015, 2:12 PM

I don't remember what the original context was here, but T9319 is likely a reasonable proxy for it.

Phabricator · Built by Phacility