Page MenuHomePhabricator
Create Task
Maniphest T9118

Modifying "Default View/Edit" Policies for Diffusion do not appear to retain their values
Closed, ResolvedPublic
Actions

Description

Previously I had set custom policies for Default View/Edit on Diffusion. Navigating back to the page the values for those fields show a snot populated. When selecting "Custom Policy" it does not bring up the values I had set previously. Changing/saving again, and restarting services (get warning about the phd daemons out of sync) and the values are still not remembered.

I'm currently on the latest stable revisions:
libphutil: 80b79a9f2f33ba9c8c988d952e21c82d90165573
arcanist: 1e5059f16a3b35d2b765d247c0e847c8679c9bd5
phabricator: 2eab1c1943c511f0df4bb1b9f78dadf45c8ef160

When navigating to the edit policies page:

values.png (704×1 px, 82 KB)

When selecting "Custom Policy" again:
editing.png (642×2 px, 88 KB)

Revisions and Commits

rP Phabricator
D14310rP22b9b76079be Fix control state for custom application policies with template types

Related Objects

Event Timeline

cspeckmim created this task.Aug 9 2015, 2:47 PM
cspeckmim raised the priority of this task from to Needs Triage.
cspeckmim updated the task description. (Show Details)
cspeckmim updated the task description. (Show Details)
cspeckmim updated the task description. (Show Details)
cspeckmim added a subscriber: cspeckmim.
chad added projects: Diffusion, Policy.Aug 9 2015, 2:50 PM
Herald added a subscriber: eadler. · View Herald TranscriptAug 9 2015, 2:50 PM
chad added a subscriber: chad.Aug 9 2015, 2:51 PM

Anything in the error logs?

cspeckmim added a comment.Aug 9 2015, 2:59 PM

Ach! I hadn't thought to look!

I checked MySQL, nginx, php-fpm, phd, and even aphlict logs. The only thing that had errors was phd and that's related to something else entirely (looks like someone removed a repo and didn't tell phab, so it's still trying to pull from it).

chad added a comment.Aug 9 2015, 3:02 PM

With 2 minutes of testing, I can't reproduce anything obvious (I'm also on master, but that not old enough to really matter).

chad added a comment.Aug 9 2015, 3:03 PM

What specifically are you setting these to (project, all users, custom?)

chad added a subscriber: epriestley.Aug 9 2015, 3:07 PM

Ah ok Custom Policy got it to trigger as blank on the edit screen for me.

cspeckmim added a comment.Aug 9 2015, 3:10 PM

Yes sorry it wasn't clear

  1. Set Default View/Edit Policy to "Custom Policy"
  2. Configure some custom policy and save
  3. Refresh/edit page for Diffusion Policy settings
  4. The value for Default View/Edit Policy is empty, and selecting "Custom Policy" starts a new blank policy instead of showing what was configured earlier.
joshuaspence added a subscriber: joshuaspence.Aug 9 2015, 9:03 PM
epriestley claimed this task.Oct 20 2015, 1:50 PM
epriestley triaged this task as Normal priority.

Sorry, this fell through the cracks -- feel free to make noise about anything policy-related like this if I don't pick it up in a couple of days.

epriestley added a revision: D14310: Fix control state for custom application policies with template types.Oct 20 2015, 1:55 PM
epriestley closed this task as Resolved by committing rP22b9b76079be: Fix control state for custom application policies with template types.Oct 20 2015, 1:56 PM
epriestley added a commit: rP22b9b76079be: Fix control state for custom application policies with template types.
cspeckmim added a comment.Oct 20 2015, 2:39 PM

Ah thanks for the fix! I was going to try taking a swing at this soon, but I'll keep in mind about policy-related things and noise.

Phabricator · Built by Phacility