Page MenuHomePhabricator

arc upgrade doesn't check for git failures
Closed, DuplicatePublic

Description

From ArcanistUpgradeWorkflow:

try {
  phutil_passthru('git pull --rebase');
} catch (Exception $ex) {
  phutil_passthru('git rebase --abort');
  throw $ex;
}

Nothing's checking the return value of phutil_passthru (the exit status of the git pull). So even if there's an error, the "now up to date" message is still printed.

Event Timeline

jboning created this task.Oct 22 2015, 3:20 AM
jboning updated the task description. (Show Details)
jboning added subscribers: jboning, angie.
jhurwitz added a project: Restricted Project.Oct 22 2015, 3:35 AM
jhurwitz added a subscriber: jhurwitz.
angie moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Oct 22 2015, 5:51 PM
angie moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.