Page MenuHomePhabricator
Feed Advanced Search

Oct 14 2015

epriestley added a comment to T9529: Upload coverage to a diff.

It's supposed to be sent with the call to the external build system, but that doesn't seem to work either -- the build target phid received is always ''.

Oct 14 2015, 10:27 AM · Restricted Project, Restricted Project, Conduit, Differential, Harbormaster
joshuaspence created T9563: Unable to subscribe to Phame blog.
Oct 14 2015, 10:00 AM · Phame
joshuaspence updated the task description for T9529: Upload coverage to a diff.
Oct 14 2015, 8:34 AM · Restricted Project, Restricted Project, Conduit, Differential, Harbormaster
joshuaspence updated the task description for T9529: Upload coverage to a diff.
Oct 14 2015, 8:34 AM · Restricted Project, Restricted Project, Conduit, Differential, Harbormaster
joshuaspence added projects to T9529: Upload coverage to a diff: Harbormaster, Differential, Conduit.
Oct 14 2015, 8:33 AM · Restricted Project, Restricted Project, Conduit, Differential, Harbormaster
joshuaspence edited projects for T9527: Confusing "... shifted this object from the S1 Public space to...", added: Transactions; removed Spaces.
Oct 14 2015, 8:32 AM · Transactions
joshuaspence added a comment to T7478: Inbound email is wrapped when sent from Gmail.

Would this be possible for #prioritization? I would work on it myself, but don't have any ideas for an appropriate fix.

Oct 14 2015, 5:54 AM · Mail

Oct 13 2015

epriestley added a comment to T9562: Show only the first N branches/tags on commits in Diffusion, with a "Show all..." link.

I'd be inclined to show N branches, for some small value of N like 3 or 5 or 10, with a link to "Show 1,695 more branches which contain this commit...".

Oct 13 2015, 11:25 PM · Diffusion (v3), Restricted Project
epriestley added a revision to T182: Commit into repository directly from differential: Unknown Object (Differential Revision).
Oct 13 2015, 10:37 PM · Haskell.org, Restricted Project, Differential
epriestley added a comment to T9505: Show landing branch information in Differential revision detail.

Actually I think we can go even deeper (T3462).

Oct 13 2015, 10:03 PM · Differential
epriestley added a revision to T182: Commit into repository directly from differential: Unknown Object (Differential Revision).
Oct 13 2015, 4:39 PM · Haskell.org, Restricted Project, Differential
epriestley added a comment to T9558: Unhandled Exception on adding a Phabricator user to a Maniphest custom field.

This has been fixed in master and cherry-picked into stable (as rPc0a52201). You should be able to update to pick up the fix.

Oct 13 2015, 3:43 PM · Custom Fields, Maniphest
epriestley closed T9558: Unhandled Exception on adding a Phabricator user to a Maniphest custom field as Resolved by committing Restricted Diffusion Commit.
Oct 13 2015, 3:41 PM · Custom Fields, Maniphest
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

Unfortunately, no part of that sounds well-aligned with our thinking about the roles for these applications or our roadmap for the products. If your development workflow routinely has changes which are too large for Differential to reasonably accommodate (20K+ lines?), it is far outside of my experience in software development and Phabricator is probably not a good tool to use for this workflow.

Oct 13 2015, 3:39 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Arcanist, Differential
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Oct 13 2015, 2:52 PM
epriestley claimed T9558: Unhandled Exception on adding a Phabricator user to a Maniphest custom field.
Oct 13 2015, 2:51 PM · Custom Fields, Maniphest
epriestley added a revision to T9558: Unhandled Exception on adding a Phabricator user to a Maniphest custom field: Unknown Object (Differential Revision).
Oct 13 2015, 2:51 PM · Custom Fields, Maniphest
epriestley closed T9557: aa as Spite.
Oct 13 2015, 11:30 AM · Blessed Reviewers, Phabricator
epriestley updated subscribers of T9530: Release Server / Workflow app / Future of Releeph .

Not sure if any of this is relevant to T8297, but everyone loves walls of text!

Oct 13 2015, 10:55 AM · Restricted Project, Harbormaster
epriestley added a comment to T8297: Differential Revision's repository is reassigned when the commit is pushed to a separate repository.

I think that change is tentatively within the realm of reason, but I have some concerns.

Oct 13 2015, 10:54 AM · Diffusion
epriestley removed subtasks for T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch: T9452: Cloudsme, T9469: Redirect loop after fresh installation, T9478: Working with harbormaster.sendmessage, T9500: Active dashboards not shown with "Active" search filter, T9512: "Change Password" should prompt users to "Reset Password" if no password has been set, T9511: asdasda, T9510: sadasdasd.
Oct 13 2015, 12:59 AM · Restricted Project, Typeahead, Audit
epriestley removed a parent task for T9469: Redirect loop after fresh installation: T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch.
Oct 13 2015, 12:59 AM · Installing & Upgrading
epriestley removed a parent task for T9478: Working with harbormaster.sendmessage: T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch.
Oct 13 2015, 12:59 AM · Arcanist, Herald, Harbormaster
epriestley removed a parent task for T9500: Active dashboards not shown with "Active" search filter: T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch.
Oct 13 2015, 12:59 AM · Dashboards
epriestley removed a parent task for T9452: Cloudsme: T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch.
Oct 13 2015, 12:59 AM · Roadmap
epriestley removed a parent task for T9510: sadasdasd: T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch.
Oct 13 2015, 12:59 AM
epriestley removed a parent task for T9512: "Change Password" should prompt users to "Reset Password" if no password has been set: T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch.
Oct 13 2015, 12:59 AM · Restricted Project, Auth
epriestley removed a parent task for T9511: asdasda: T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch.
Oct 13 2015, 12:59 AM
epriestley closed T7375: Replace `hg locate` with `hg files` if `hg` is 3.2 or newer as Resolved by committing Restricted Diffusion Commit.
Oct 13 2015, 12:53 AM · Diffusion, Mercurial
epriestley updated the task description for T9554: Trigger "import" heuristics for imported repositories.
Oct 13 2015, 12:45 AM · Diffusion, Restricted Project, Restricted Project
epriestley created T9554: Trigger "import" heuristics for imported repositories.
Oct 13 2015, 12:45 AM · Diffusion, Restricted Project, Restricted Project
epriestley added a comment to T9553: www.googleapis.com refuses GET with Content-Length.

You have a version of cURL which has a bug with Content-Length (see T8654 for discussion), but your version of libphutil should include a workaround, so I'm not sure what's up. I can't reproduce this problem on this server.

Oct 13 2015, 12:35 AM · libphutil
epriestley added a comment to T9551: Strip strange characters out of project hashtags, or support parsing strange hashtag characters in other contexts.

At HEAD:

Oct 13 2015, 12:05 AM · Prioritized, Projects

Oct 12 2015

epriestley added a revision to T9551: Strip strange characters out of project hashtags, or support parsing strange hashtag characters in other contexts: Unknown Object (Differential Revision).
Oct 12 2015, 11:55 PM · Prioritized, Projects
epriestley added a comment to T9553: www.googleapis.com refuses GET with Content-Length.

Can you show me the output of these commands on the server?

Oct 12 2015, 11:50 PM · libphutil
epriestley added a revision to T9551: Strip strange characters out of project hashtags, or support parsing strange hashtag characters in other contexts: Unknown Object (Differential Revision).
Oct 12 2015, 11:08 PM · Prioritized, Projects
epriestley added a revision to T182: Commit into repository directly from differential: Unknown Object (Differential Revision).
Oct 12 2015, 10:48 PM · Haskell.org, Restricted Project, Differential
epriestley added a revision to T182: Commit into repository directly from differential: Unknown Object (Differential Revision).
Oct 12 2015, 9:12 PM · Haskell.org, Restricted Project, Differential
epriestley added a revision to T9519: Design the Drydock Blueprint selection mechanism: Restricted Differential Revision.
Oct 12 2015, 9:12 PM · Drydock
epriestley moved T9551: Strip strange characters out of project hashtags, or support parsing strange hashtag characters in other contexts from Backlog to The Queue on the Prioritized board.
Oct 12 2015, 6:58 PM · Prioritized, Projects
epriestley claimed T9551: Strip strange characters out of project hashtags, or support parsing strange hashtag characters in other contexts.
Oct 12 2015, 6:57 PM · Prioritized, Projects
epriestley merged task T7305: project hashtags should work better re: spaces into T9551: Strip strange characters out of project hashtags, or support parsing strange hashtag characters in other contexts.
Oct 12 2015, 6:57 PM · Projects
epriestley updated subscribers of T9551: Strip strange characters out of project hashtags, or support parsing strange hashtag characters in other contexts.
Oct 12 2015, 6:57 PM · Prioritized, Projects
epriestley merged task T9480: Nicer slugs for project tags into T9551: Strip strange characters out of project hashtags, or support parsing strange hashtag characters in other contexts.
Oct 12 2015, 6:57 PM · Projects
epriestley merged task T7341: Colons ":" in project names create unusable hashtags into T9551: Strip strange characters out of project hashtags, or support parsing strange hashtag characters in other contexts.
Oct 12 2015, 6:57 PM · Projects
epriestley added a comment to T9551: Strip strange characters out of project hashtags, or support parsing strange hashtag characters in other contexts.

Other known demons are spaces (T7305), colons (T7341), and sort-of-but-not-really hyphens (T9480).

Oct 12 2015, 6:17 PM · Prioritized, Projects
epriestley added a comment to T182: Commit into repository directly from differential.

Blueprint selection (which got more details in T9519) is now in a rough-but-functional state so I expect the rest of this to move forward shortly.

Oct 12 2015, 1:56 PM · Haskell.org, Restricted Project, Differential
epriestley added a revision to T9519: Design the Drydock Blueprint selection mechanism: Unknown Object (Differential Revision).
Oct 12 2015, 1:26 PM · Drydock
epriestley closed T9550: Atom editor not present in the default uri.allowed-editor-protocols config as Wontfix.

You can change the configuration. This protocol is not prevalent enough to motivate us to include it by default in the upstream.

Oct 12 2015, 1:17 PM · Config

Oct 11 2015

CaptSpot awarded T1139: Internationalize Phabricator a Like token.
Oct 11 2015, 3:16 PM · Localization
CaptSpot awarded T3569: Make Phrequent somewhat usable a Like token.
Oct 11 2015, 2:16 PM · Phrequent
epriestley updated subscribers of T5791: Write Herald rules for outbound mail.
Oct 11 2015, 11:47 AM · Restricted Project, Restricted Project, FreeBSD, Mail
epriestley merged task T9549: No special header about repository and/or projects on emails sent from diffusion new commit into T5791: Write Herald rules for outbound mail.
Oct 11 2015, 11:47 AM · Diffusion

Oct 10 2015

epriestley added a comment to T9548: Support Mercurial's bundle2 wire protocol.

Particularly, the command server wire protocol is completely different from the HTTP/SSH wire protocol (and pretty reasonable overall, although it's solving a much simpler problem).

Oct 10 2015, 6:04 PM · Diffusion, Mercurial
epriestley added a comment to T9548: Support Mercurial's bundle2 wire protocol.

We have some CommandServer stuff too, although I don't think it has ever been reachable from the UI. I don't remember if the original use case was improving arc performance or improving import/parser performance.

Oct 10 2015, 6:01 PM · Diffusion, Mercurial
epriestley added a comment to T9548: Support Mercurial's bundle2 wire protocol.

So we probably need to special case the unbundle command, decode the response, build additional parts from stderr, and then insert them into the response.

Oct 10 2015, 5:23 PM · Diffusion, Mercurial
epriestley added a comment to T9548: Support Mercurial's bundle2 wire protocol.

I suspect it's worthwhile for us to support bundle2 eventually. As far as I can tell from my investigations in T9450:

Oct 10 2015, 5:18 PM · Diffusion, Mercurial
epriestley added a comment to T9535: Option to CC or use a mailing list for project reviewers.

Technically, we could implement "To", "Cc", "Any Recipient", and maybe "Sending application" or "Object type" outbound Herald fields today so you could write some variant of this:

Oct 10 2015, 3:43 PM · Restricted Project, Differential
epriestley closed T9450: "abort: not a Mercurial bundle" with Mercurial 3.5>= as Resolved by committing Restricted Diffusion Commit.
Oct 10 2015, 2:15 PM · Mercurial
epriestley updated the task description for T9546: Phame "Oblivious" skin a few rough edges.
Oct 10 2015, 1:55 PM · Phame
epriestley edited the content of 2015 Week 41 (Early October).
Oct 10 2015, 1:55 PM
epriestley updated the task description for T9546: Phame "Oblivious" skin a few rough edges.
Oct 10 2015, 1:52 PM · Phame
epriestley added a comment to T9360: Unbeta Phame.

Well, I don't expect to actually fix any of this for like 20-30 years, I'm just filing it.

Oct 10 2015, 1:48 PM · Phame
johnny-bit awarded T9545: Implement a "No Skin" skin for Phame a Love token.
Oct 10 2015, 1:47 PM · Phame
epriestley added a comment to T9547: Phame previews are totally unstyled.

The actual skin would also be bad for a Medium-alike with a huge image of a tree or a house or whatever at the top since you couldn't preview it meaningfully.

Oct 10 2015, 1:47 PM · Phame
epriestley created T9547: Phame previews are totally unstyled.
Oct 10 2015, 1:45 PM · Phame
epriestley created T9546: Phame "Oblivious" skin a few rough edges.
Oct 10 2015, 1:44 PM · Phame
epriestley created T9545: Implement a "No Skin" skin for Phame.
Oct 10 2015, 1:38 PM · Phame
epriestley added a comment to T9360: Unbeta Phame.

I'm trying out Phame for providing companion notes to the Changelog so I'm going to file some stuff I hit. This is probably mostly stuff that we would have naturally fixed anyway, but some of it isn't totally obvious.

Oct 10 2015, 1:36 PM · Phame
epriestley moved T9051: Add subscribers/CCs to Phame Blog from Backlog to Unbeta (v1) on the Phame board.
Oct 10 2015, 1:34 PM · Phame
epriestley moved T9360: Unbeta Phame from Backlog to Unbeta (v1) on the Phame board.
Oct 10 2015, 1:34 PM · Phame
epriestley moved T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential from Preflight to The Queue on the Prioritized board.
Oct 10 2015, 1:31 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley moved T182: Commit into repository directly from differential from Preflight to The Queue on the Prioritized board.
Oct 10 2015, 1:30 PM · Haskell.org, Restricted Project, Differential
epriestley moved T9273: Replace PhabricatorMarkupInterface with a better-suited API/abstraction from Preflight to The Queue on the Prioritized board.
Oct 10 2015, 1:30 PM · Prioritized, Remarkup
epriestley moved T9352: Write some custom Herald glue for driving builds through Owners from The Queue to Paused on the Prioritized board.
Oct 10 2015, 1:30 PM · Harbormaster, Herald, Owners, Prioritized
epriestley moved T9252: Unprototype Drydock (v1) from Preflight to Paused on the Prioritized board.
Oct 10 2015, 1:30 PM · Prioritized, Drydock
epriestley moved T9123: Build Phabricator in Harbormaster (v2) from Preflight to Paused on the Prioritized board.
Oct 10 2015, 1:30 PM · Prioritized, Harbormaster
epriestley moved T9303: Improve Phacility Onboarding/NUX from The Queue to Paused on the Prioritized board.
Oct 10 2015, 1:30 PM · Phacility
epriestley edited the content of Changelog.
Oct 10 2015, 11:48 AM
epriestley edited the content of 2015 Week 41 (Early October).
Oct 10 2015, 11:47 AM
epriestley created 2015 Week 41 (Early October).
Oct 10 2015, 11:47 AM

Oct 9 2015

epriestley added a comment to T9530: Release Server / Workflow app / Future of Releeph .

Yeah, that seems reasonable to me. You can already "Close Branch" today which is effectively the same action as "Freeze Release". I'm broadly comfortable with moving Harbormaster in the direction of having richer application awareness and interactions, although we'll have to think a bit about what happens when you "Freeze Release" in a build plan and run it on a commit (does it fail? get skipped? configurable?).

Oct 9 2015, 9:18 PM · Restricted Project, Harbormaster
epriestley added a revision to T9519: Design the Drydock Blueprint selection mechanism: Unknown Object (Differential Revision).
Oct 9 2015, 9:01 PM · Drydock
epriestley added a comment to T9530: Release Server / Workflow app / Future of Releeph .
  • Go to a Branch/Release page.
    • Click the "New Pull Request" button.
    • That goes into the queue for the Branch/Release.
    • Whoever owns the Branch/Release can approve/reject it.
    • That's the end of the workflow today since Harbormaster didn't exist and none of T182 was planned. Last I knew, Facebook completed the rest of the workflow with custom arc do-a-bunch-of-git-stuff extensions.
Oct 9 2015, 7:20 PM · Restricted Project, Harbormaster
20after4 awarded T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges a Love token.
Oct 9 2015, 7:20 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley added a comment to T9530: Release Server / Workflow app / Future of Releeph .

(The pull requests are just useless outside of the Facebook workflow because they can't merge and the "you can do hundreds of them really quickly" aspect isn't useful at less-than-Facebook scales.)

Oct 9 2015, 7:16 PM · Restricted Project, Harbormaster
epriestley added a comment to T9530: Release Server / Workflow app / Future of Releeph .

"Pull Requests" are the existing "Pull Requests" in Releeph. They're literally just pull requests. Releeph today is like 90% about implementing pull requests and then 10% about surfacing pertinent details about those requests prominently so chuckr and peers can bulk process hundreds of them per day.

Oct 9 2015, 7:15 PM · Restricted Project, Harbormaster
epriestley added a comment to T9530: Release Server / Workflow app / Future of Releeph .

Specifically, here are three workflows with different levels of mutability that I'd like to support:

Oct 9 2015, 7:13 PM · Restricted Project, Harbormaster
epriestley added a comment to T9543: In "arc land", recursively resolve tracking branches until we reach one in a remote.

(In this case I think your behavior is the more natural one and I'd probably want to tell the hypothetical future users wanting the other behavior to go build a custom version of "land" via T5055 with one million flags, and they may not really exist, I just want to have some sort of contingency plan in mind before making the change.)

Oct 9 2015, 7:03 PM · Arcanist
epriestley added a comment to T9530: Release Server / Workflow app / Future of Releeph .

Release will be as immutable as possible

Oct 9 2015, 6:55 PM · Restricted Project, Harbormaster
epriestley added a comment to T9530: Release Server / Workflow app / Future of Releeph .

A culvert is just a big drainpipe.

Oct 9 2015, 6:32 PM · Restricted Project, Harbormaster
epriestley added a comment to T7899: DifferentialDiff->description is "text255?" but should be "text".

Per the title, the issue is that the description column on DifferentialDiff is declared as text255? for historical reasons that have been lost to the ages, but should just be text.

Oct 9 2015, 6:04 PM · Differential, Mercurial, Arcanist
epriestley updated subscribers of T7899: DifferentialDiff->description is "text255?" but should be "text".
Oct 9 2015, 5:57 PM · Differential, Mercurial, Arcanist
epriestley merged task T8432: "arc diff --update" fails with "502 Bad Gatway" on nginx if revision comment's first line is 256 chars or longer into T7899: DifferentialDiff->description is "text255?" but should be "text".
Oct 9 2015, 5:57 PM · Differential
epriestley added a comment to T3320: Improve prefilling for "Create Task" form.

@jshirley, the project detail page should have a "Hashtags" field which lists the tags that will work. "/" should never be part of a hashtag. The value that will work is probably something like "team_oncall" by default, but you can customize that by adding or changing the hashtag.

Oct 9 2015, 5:57 PM · Maniphest
epriestley added a comment to T9543: In "arc land", recursively resolve tracking branches until we reach one in a remote.

Anyway, pretty much same story here as T9537 -- I want to sort out T3855 better first, then we can tackle refinements here.

Oct 9 2015, 5:54 PM · Arcanist
epriestley added a comment to T9543: In "arc land", recursively resolve tracking branches until we reach one in a remote.

I guess that won't quite do what you want since you're legitimately tracking a local branch which tracks a different remote branch in this case. But maybe you're partially doing this only because T9537 doesn't work?

Oct 9 2015, 5:53 PM · Arcanist
epriestley added a comment to T9543: In "arc land", recursively resolve tracking branches until we reach one in a remote.

I think we probably solve this incidentally by doing T3855, T9537, making --onto mean in the remote, and defaulting it to the tracked branch (although I think it already does?). The only problem with this is that land-example wont get updated but from T9537 maybe you're completely fine with that?

Oct 9 2015, 5:49 PM · Arcanist
epriestley added a subtask for T9543: In "arc land", recursively resolve tracking branches until we reach one in a remote: T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.
Oct 9 2015, 5:48 PM · Arcanist
epriestley added a parent task for T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same: T9543: In "arc land", recursively resolve tracking branches until we reach one in a remote.
Oct 9 2015, 5:48 PM · Restricted Project, Arcanist