Page MenuHomePhabricator
Create Task
Maniphest T7375

Replace `hg locate` with `hg files` if `hg` is 3.2 or newer
Closed, ResolvedPublic
Actions

Description

In T4387, we moved some hg grep calls to hg locate. However, hg locate is deprecated as of Merucrial 3.2 (2014-11-01, roughly a month after we moved to use it).

The replacement is hg files, which is new as of 3.2.

So we need to:

  • Use hg locate on hg < 3.2.
  • Use hg files on hg >= 3.2
  • (hg files may have slightly different syntax?)

Revisions and Commits

rP Phabricator
D14253rP812c41a18abd Conditionally use `hg files` vs. `hg locate` depending on version of Mercurial

Related Objects

Event Timeline

epriestley created this task.Feb 25 2015, 4:13 PM
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added projects: Mercurial, Diffusion.
epriestley added a subscriber: epriestley.
cspeckmim added a subscriber: cspeckmim.Feb 25 2015, 4:14 PM
epriestley lowered the priority of this task from Normal to Low.Feb 25 2015, 4:15 PM

Specifically, this isn't causing any problems yet (hg locate still works in modern hg at the time of writing), but at some point hg locate is presumably going to vanish and then we will have a problem.

richardvanvelzen added a subscriber: richardvanvelzen.Feb 28 2015, 11:30 AM
cspeckmim added a revision: D14253: Conditionally use `hg files` vs. `hg locate` depending on version of Mercurial.Oct 11 2015, 6:59 PM
epriestley closed this task as Resolved by committing rP812c41a18abd: Conditionally use `hg files` vs. `hg locate` depending on version of Mercurial.Oct 13 2015, 12:53 AM
epriestley added a commit: rP812c41a18abd: Conditionally use `hg files` vs. `hg locate` depending on version of Mercurial.
Phabricator · Built by Phacility