Page MenuHomePhabricator
Feed Advanced Search

Oct 9 2015

epriestley added a comment to T9542: Herald actions should include ability to "mark with named flag" or similar.

(And the project description can be used to document what the project means, how to respond to it, etc. And you can search for revisions with those projects, etc.)

Oct 9 2015, 5:32 PM · Restricted Project
epriestley added a comment to T9542: Herald actions should include ability to "mark with named flag" or similar.

Flags are personal bookmarks (other users can not see your flags), so I think they aren't compatible with your goal. You want everyone looking at a revision to be able to see the note, right?

Oct 9 2015, 5:31 PM · Restricted Project
epriestley merged task T9082: `arc land` creates unnecessary local `master` branch in Git into T9537: Support for landing without local tracking branch.
Oct 9 2015, 5:28 PM · Arcanist
epriestley updated subscribers of T9537: Support for landing without local tracking branch.
Oct 9 2015, 5:28 PM · Arcanist
epriestley added a comment to T9082: `arc land` creates unnecessary local `master` branch in Git.

I'm going to merge this into T9537, which has more discussion and an additional use case that I find slightly more compelling as a motivator (numerous targets in the remote).

Oct 9 2015, 5:28 PM · Arcanist
epriestley added a subtask for T9537: Support for landing without local tracking branch: T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.
Oct 9 2015, 5:26 PM · Arcanist
epriestley added a parent task for T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same: T9537: Support for landing without local tracking branch.
Oct 9 2015, 5:26 PM · Restricted Project, Arcanist
epriestley added a comment to T3960: Add capability to hide lint messages when viewing a diff.

Can you show me a screenshot of an example that demonstrates this problem? It's hard for me to imagine what sort of warnings are valuable enough to raise but not valuable enough to fix.

Oct 9 2015, 5:24 PM · Restricted Project, Differential
epriestley added a comment to T9537: Support for landing without local tracking branch.

Given that, I think the fundamental feature request here is for arc land to target a temporary local branch that is used just for staging and pushing the final commit, rather than targeting an existing local branch.

Oct 9 2015, 4:18 PM · Arcanist
epriestley closed T9536: Creating revision is failling with "*** APIError: ERR-CONDUIT-CORE: #1048: Column 'originalTitle' cannot be null" as Wontfix.

I'd recommend looking at exactly what arc does and following that, rather than trying to construct calls from scratch.

Oct 9 2015, 11:21 AM · Differential, Conduit
epriestley added a comment to T9536: Creating revision is failling with "*** APIError: ERR-CONDUIT-CORE: #1048: Column 'originalTitle' cannot be null".

Why are you trying to create revisions with a direct API call? Can you describe the broader problem you're facing? There may be a better solution. See:

Oct 9 2015, 4:05 AM · Differential, Conduit
epriestley added a comment to T9530: Release Server / Workflow app / Future of Releeph .

The name "Pipeline" brings "Data Pipeline" to mind for me, possibly because AWS has a product called "AWS Data Pipeline", although it looks like no one else particularly likes "Releeph" either.

Oct 9 2015, 3:40 AM · Restricted Project, Harbormaster
epriestley closed T9538: HTML Emails which contain figlet and cowsay content should render respective code blocks in fixed-width font as Resolved by committing Restricted Diffusion Commit.
Oct 9 2015, 3:03 AM · Mail
epriestley added a revision to T9538: HTML Emails which contain figlet and cowsay content should render respective code blocks in fixed-width font: Unknown Object (Differential Revision).
Oct 9 2015, 3:02 AM · Mail
epriestley added a revision to T9408: Upgrading: `dot` (Graphviz) support removed, changes to `figlet` and `cowsay`: Unknown Object (Differential Revision).
Oct 9 2015, 3:01 AM · Remarkup, Security, Installing & Upgrading
epriestley added a comment to T9408: Upgrading: `dot` (Graphviz) support removed, changes to `figlet` and `cowsay`.

Yeah -- at least in HTML mail, the cows aren't getting properly linebreak'd either. I don't think that's new but it should be pretty easy to fix.

Oct 9 2015, 2:56 AM · Remarkup, Security, Installing & Upgrading
joshuaspence updated the task description for T1116: Function __phutil_autoload should probably not throw an exception if it is the only registered autoload function.
Oct 9 2015, 1:51 AM · libphutil

Oct 8 2015

epriestley added a comment to T8298: Fix Windows Escaping.

That seems tentatively fine, although it may only solve some of the problems here and may create new problems.

Oct 8 2015, 9:44 PM · Windows
epriestley added a comment to T9537: Support for landing without local tracking branch.

This may all sort of be moot since there might be a relatively unambiguous approach to T9082 and this which uses a rule like: if the target does not exist locally, but does exist in the remote, use a separate workflow.

Oct 8 2015, 9:42 PM · Arcanist
joshuaspence added a comment to T9530: Release Server / Workflow app / Future of Releeph .

Well, it is essentially releasing into a non-production environment. We may then want to promote the artifact from the test environment to production.

Oct 8 2015, 9:40 PM · Restricted Project, Harbormaster
epriestley added a comment to T9537: Support for landing without local tracking branch.

Yeah, they're a bit different. There's some nuance here, but basically T8620 is talking about landing from a detached HEAD, and T9082 is talking about landing without creating or interacting with a local target branch (usually "master"). This is potentially talking about both, I think, although more on the T9082 side.

Oct 8 2015, 9:36 PM · Arcanist
epriestley added a comment to T9537: Support for landing without local tracking branch.

I think this is about the same as T9082, does that sound right? (Is that a report from another team member on your team? This workflow seems completely unorthodox to me, although maybe it is less bizarre than I imagine.)

Oct 8 2015, 9:26 PM · Arcanist
epriestley added a comment to T8298: Fix Windows Escaping.

I'm pretty sure that if execx() an editor like vim or nano, whether you use bypass_shell or not, it just executes it uselessly in the background and hangs forever. That is, the behavior of these two programs is very different on Linux, and I believe it will be very different on Windows no matter what bypass_shell is set to:

Oct 8 2015, 9:17 PM · Windows
epriestley added a comment to T8298: Fix Windows Escaping.

How does that obsolete PhutilExecPassthru?

Oct 8 2015, 8:20 PM · Windows
epriestley added a comment to T8298: Fix Windows Escaping.

D1938 is the actual origin, I think.

Oct 8 2015, 7:41 PM · Windows
epriestley added a comment to T8298: Fix Windows Escaping.

Oh, that diff just moved it, so it's actually older than that.

Oct 8 2015, 7:40 PM · Windows
epriestley added a comment to T8298: Fix Windows Escaping.

Possibly. We've used it in PhutilExecPassthru since D6774.

Oct 8 2015, 7:40 PM · Windows
epriestley added a comment to T8298: Fix Windows Escaping.

D14246 / D11396 / T6966 are about a specific Windows issue where the command name is treated differently from other arguments. That is, these commands mean different things:

Oct 8 2015, 7:36 PM · Windows
epriestley added a comment to T731: Allow revisions to have alternate acceptance conditions.

whether upstream wants to wait until it can tackle the generalized problem, or whether you'd be okay chipping away at smaller use cases first,

Oct 8 2015, 7:23 PM · Restricted Project, Restricted Project, Differential
epriestley added a comment to T9535: Option to CC or use a mailing list for project reviewers.

Ideally, just use a mail client with filters that are powerful enough to do full header matching.

Oct 8 2015, 6:26 PM · Restricted Project, Differential
epriestley added a comment to T9535: Option to CC or use a mailing list for project reviewers.

providing an option to send email to a mailing list address associated with a project

Oct 8 2015, 5:49 PM · Restricted Project, Differential
epriestley edited P1863 large_lines.diff.
Oct 8 2015, 5:47 PM
joshuaspence added a comment to T9533: Auto-create Maniphest tasks for concerns raised through Audit..

Yeah I don't know why you would want to duplicate Audit details to Maniphest. Do these commits have a single merge commit which could be audited instead?

Oct 8 2015, 5:46 PM · Maniphest, Audit, Herald
epriestley edited P1863 large_lines.diff.
Oct 8 2015, 5:46 PM
joshuaspence added a project to T9532: No symbols found even if they are presented in DB: Symbols.
Oct 8 2015, 5:44 PM · Symbols, Diffusion
joshuaspence added a project to T9530: Release Server / Workflow app / Future of Releeph : Releeph.
Oct 8 2015, 5:43 PM · Restricted Project, Harbormaster
epriestley edited P1863 large_lines.diff.
Oct 8 2015, 5:42 PM
epriestley edited P1863 large_lines.diff.
Oct 8 2015, 5:42 PM
joshuaspence added a comment to T9530: Release Server / Workflow app / Future of Releeph .

To clarify on my terminology, my eventual goal is to have the following environments:

Oct 8 2015, 5:33 PM · Restricted Project, Harbormaster
joshuaspence added a comment to T9530: Release Server / Workflow app / Future of Releeph .

The cost is probably small at the moment because we are only talking about an application server, but in the future I'd expect a QA environment to consist of:

Oct 8 2015, 5:30 PM · Restricted Project, Harbormaster
epriestley added a comment to T9530: Release Server / Workflow app / Future of Releeph .

Haha, no problem. I just mean:

Oct 8 2015, 5:13 PM · Restricted Project, Harbormaster
joshuaspence updated Q168: Can you enforce username based on email address? from to Enforce username based on email address.
Oct 8 2015, 3:32 PM · Auth
joshuaspence awarded Q167: How do you migrate Phabricator to a new domain? a Like token.
Oct 8 2015, 3:29 PM · Installing & Upgrading
joshuaspence updated the question details for Q167: How do you migrate Phabricator to a new domain?.
Oct 8 2015, 3:28 PM · Installing & Upgrading
joshuaspence added a comment to T9530: Release Server / Workflow app / Future of Releeph .

Sorry, I don't quite follow... (It's early and I'm still somewhat jetlagged... I'm in Vegas for AWS re:Invent at the moment).

Oct 8 2015, 3:25 PM · Restricted Project, Harbormaster
epriestley added a comment to T9530: Release Server / Workflow app / Future of Releeph .

Is there an unavoidable cost to keeping QA environments up for multiple days?

Oct 8 2015, 3:21 PM · Restricted Project, Harbormaster
joshuaspence added a comment to T9530: Release Server / Workflow app / Future of Releeph .

I have a somewhat similar (although much more complex) use case. Basically, I want to eventually have the ability to spin up a QA environment from a diff. Currently we have developers do this manually, which means that the instances sit dormant for hours to days until the QA person is able to test it. Instead, I want to build a "Spin me up a QA environment from this diff" button into Differential. Roughly, I expect this to work as follows:

Oct 8 2015, 2:54 PM · Restricted Project, Harbormaster
joshuaspence added a comment to T9530: Release Server / Workflow app / Future of Releeph .

+1 on "Pipeline" instead of "Releeph".

Oct 8 2015, 2:33 PM · Restricted Project, Harbormaster
epriestley added a comment to T9519: Design the Drydock Blueprint selection mechanism.

Yeah, this is still feeling pretty reasonable to me after thinking about it for a day or two.

Oct 8 2015, 11:27 AM · Drydock
epriestley added a parent task for T9132: Build an ApplicationEditor abstraction: T9527: Confusing "... shifted this object from the S1 Public space to...".
Oct 8 2015, 11:03 AM · Restricted Project, ApplicationEditor, Transactions
epriestley added a subtask for T9527: Confusing "... shifted this object from the S1 Public space to...": T9132: Build an ApplicationEditor abstraction.
Oct 8 2015, 11:03 AM · Transactions
epriestley added a comment to T9527: Confusing "... shifted this object from the S1 Public space to...".

This is definitely confusing and something we should fix. (We may get it from T9132 cheaply.)

Oct 8 2015, 11:03 AM · Transactions
joshuaspence added a project to T9528: PhabricatorTaskmasterDaemon exiting with error 255 repeatedly: Phurl.
Oct 8 2015, 5:10 AM · Phurl, Daemons
joshuaspence added a project to T9514: Garbage Collect Old Differential Files: Differential.
Oct 8 2015, 5:06 AM · Differential
epriestley moved T9519: Design the Drydock Blueprint selection mechanism from Backlog to v1 on the Drydock board.
Oct 8 2015, 2:31 AM · Drydock

Oct 7 2015

epriestley added a comment to T9530: Release Server / Workflow app / Future of Releeph .

I also sort of vaguely want to just rename Releeph to "Release". I don't actually know the origin of the name but I don't think it makes sense? It's just a word that sounds like "Release" but has an "f" in it? Why isn't it "Relieph"?

Oct 7 2015, 11:54 PM · Restricted Project, Harbormaster
epriestley added a comment to T9530: Release Server / Workflow app / Future of Releeph .

(I can also make a Community Skunkworks space or something for nefarious plotting if scope expands here, but I think there's good alignment with my vision for Releeph, triggers like Pipeline, your actual requirements, Harbormaster/Drydock starting to get useful in general, and plans for letting Phabricator do repository writes in T182.)

Oct 7 2015, 11:48 PM · Restricted Project, Harbormaster
epriestley added a comment to T9530: Release Server / Workflow app / Future of Releeph .

Oh, I actually meant "Releeph Branch" not "Releeph Product", I think. Products are like "The iPhone App", branches are like "The iPhone App, 2012 Week 29". Branches could be renamed to "Releases" reasonably.

Oct 7 2015, 11:45 PM · Restricted Project, Harbormaster
epriestley added a comment to T9530: Release Server / Workflow app / Future of Releeph .

There is a similar problem elsewhere of roughly "which of Debian Jessie, Debian Kraken, and Debian Longhorn is this bug fixed in?", where releases are mutable, and our stable "releases" are also mutable, and Facebook's www deploy is mutable, and Releeph currently spends most of its effort on making products mutable. But it makes sense that a large class of releases might reasonably be modeled as immutable, especially if they have meaningful build steps.

Oct 7 2015, 10:55 PM · Restricted Project, Harbormaster
epriestley added a comment to T9530: Release Server / Workflow app / Future of Releeph .

Broadly, here's where I think the closest mappings to roadmap/starmap stuff are:

Oct 7 2015, 10:51 PM · Restricted Project, Harbormaster
epriestley added a comment to T9530: Release Server / Workflow app / Future of Releeph .

In your situation, are releases mutable or immutable? That is, if you create release 3.11 and discover a bug in it, do you merge/cherry-pick the fix into 3.11 or do you throw 3.11 away and create 3.12?

Oct 7 2015, 10:36 PM · Restricted Project, Harbormaster
epriestley added a comment to T9529: Upload coverage to a diff.

Specifically, I think your ultimate call parameters should look something like this, if you are purely reporting coverage and not test results:

Oct 7 2015, 9:57 PM · Restricted Project, Restricted Project, Conduit, Differential, Harbormaster
epriestley added a comment to T9524: Show aggregate subdirectory coverage in Diffusion browse views.

Yeah. If we did the bar UI, I think the length of the bar is just "U + C" (divided by the longest bar shown on the page, I guess? Or like log-base-something of that so the absolute length of the bar always has about the same meaning?) with something like "C / (U + C)" percent of it colored in.

Oct 7 2015, 9:48 PM · Diffusion, Restricted Project
epriestley added a comment to T9529: Upload coverage to a diff.

See also:

Oct 7 2015, 9:44 PM · Restricted Project, Restricted Project, Conduit, Differential, Harbormaster
epriestley added a comment to T9529: Upload coverage to a diff.

Yes, you can use harbormaster.sendmessage to report coverage information and unit test results. The API call has fairly thorough documentation on the console page:

Oct 7 2015, 9:43 PM · Restricted Project, Restricted Project, Conduit, Differential, Harbormaster
epriestley added a comment to T9524: Show aggregate subdirectory coverage in Diffusion browse views.

I'm tentatively OK with upstreaming that if we can find a way to present the data that communicates both the coverage percentage and total line size of each directory. In the screenshot above, the current directory might be nearly uncovered if async_diff/ has 95% of the code, or well on the way to coverage if submit_queue/ has most of the code, right?

Oct 7 2015, 9:38 PM · Diffusion, Restricted Project
epriestley closed T9528: PhabricatorTaskmasterDaemon exiting with error 255 repeatedly as Resolved.

Phurl is a prototype application. See:

Oct 7 2015, 9:28 PM · Phurl, Daemons
joshuaspence added a parent task for T5155: Evaluate support for AWS IAM Roles in S3 Client: T9526: Support IAM credentials for Elasticsearch.
Oct 7 2015, 5:13 PM · Files
joshuaspence added a subtask for T9526: Support IAM credentials for Elasticsearch: T5155: Evaluate support for AWS IAM Roles in S3 Client.
Oct 7 2015, 5:13 PM · Search, Elasticsearch
joshuaspence created T9526: Support IAM credentials for Elasticsearch.
Oct 7 2015, 5:13 PM · Search, Elasticsearch
epriestley awarded T9525: Provide a reasonable general use logo a Evil Spooky Haunted Tree token.
Oct 7 2015, 4:27 PM · Public & Media Relations
epriestley added a comment to T9525: Provide a reasonable general use logo.

Well, that was easy.

Oct 7 2015, 4:27 PM · Public & Media Relations
epriestley added a comment to T9525: Provide a reasonable general use logo.

Oh! How could I forget about this unique, distinctive logo?

Oct 7 2015, 4:24 PM · Public & Media Relations
epriestley updated subscribers of T9525: Provide a reasonable general use logo.

I don't think we actually have a vector version of this -- the original was through 99designs in 2011 before we had a real company and I was much more interested in getting a logo idea than a production-quality set of assets, as I figured I could always go trace the thing in Illustrator later given my boundless innate artistic talent:

Oct 7 2015, 4:22 PM · Public & Media Relations
epriestley added a comment to T9524: Show aggregate subdirectory coverage in Diffusion browse views.

Short answer is: yes, eventually, but it's not something I plan to prioritize in the near term.

Oct 7 2015, 3:55 PM · Diffusion, Restricted Project
joshuaspence added a project to T9499: Revision repository is not updated when it is changed in the UI: Differential.
Oct 7 2015, 3:08 PM · Differential, Conduit
joshuaspence edited projects for T9522: CSS rule "word-break: break-word" breaks line numbers on innline pastes and table headers on phriction documents, added: PHUI; removed Celerity, Paste, Phriction.
Oct 7 2015, 3:00 PM · PHUI
joshuaspence added a project to T9523: Make search autocomplete show repository names: Diffusion.
Oct 7 2015, 2:59 PM · Restricted Project, Diffusion, Search
epriestley added a comment to T9190: Unhandled Exception ("FilesystemException") - File system entity `/var/repo/PHABES/' does not exist..

I can't reproduce this:

Oct 7 2015, 1:31 PM · Daemons, Diffusion
epriestley added a comment to T9524: Show aggregate subdirectory coverage in Diffusion browse views.

D14243 should fix this. You can cherry-pick it safely if you don't want to upgrade yet, although cherry-picking changes to the Celerity map may be tricky.

Oct 7 2015, 12:42 PM · Diffusion, Restricted Project
epriestley added a revision to T9524: Show aggregate subdirectory coverage in Diffusion browse views: Unknown Object (Differential Revision).
Oct 7 2015, 12:37 PM · Diffusion, Restricted Project
epriestley claimed T9524: Show aggregate subdirectory coverage in Diffusion browse views.
Oct 7 2015, 12:25 PM · Diffusion, Restricted Project

Oct 6 2015

epriestley added a comment to T9450: "abort: not a Mercurial bundle" with Mercurial 3.5>=.

I can get this working over HTTP by just removing the special casing around the "unbundle" command. However, doing this prevents hg from emitting errors from commit hooks.

Oct 6 2015, 5:21 PM · Mercurial
epriestley added a comment to T9519: Design the Drydock Blueprint selection mechanism.

Yeah, that makes sense. Neither Travis nor CircleCI appear to support Windows at all, nor does Codeship, nor did ship.io before shutting down. And all of them just build off GitHub. So I think these are all very low-complexity build systems from the Harbormaster / Drydock / Jenkins / Bamboo perspective, but it makes sense that a lot of consumer web software doesn't need more than "build master off GitHub on linux".

Oct 6 2015, 2:37 PM · Drydock
epriestley added a comment to T9519: Design the Drydock Blueprint selection mechanism.

Broadly, since I'd expect humans to sometimes run all the things that Harbormaster runs (to test, debug, profile, extend, etc., them), I'm assuming that this per-platform complexity should usually be pushed into projects so you can give humans one build process instead of separate per-platform build processes.

Oct 6 2015, 2:15 PM · Drydock
epriestley added a comment to T9519: Design the Drydock Blueprint selection mechanism.

So both the ".sln" file and Harbormaster have essentially separate copies of the same platform-to-build-steps ruleset? Why isn't it "Protobuild.exe --generate" for Harbormaster, too?

Oct 6 2015, 1:28 PM · Drydock
epriestley added a comment to T9519: Design the Drydock Blueprint selection mechanism.

If you were telling a human how to do the MonoGame builds, you'd pretty much point them at a wiki document with like 10 different sections, each of which had different steps and build commands on it and discussion about platform specifics? And they'd go through 10 similar-looking but ultimately separate build processes?

Oct 6 2015, 1:24 PM · Drydock
epriestley closed T9513: ERR-UNSUPPORTED-VCS when viewing Subversion commit in Diffusion as Resolved.
Oct 6 2015, 1:11 PM · Subversion, Diffusion
epriestley added a comment to T9519: Design the Drydock Blueprint selection mechanism.

Can you walk me through why you have so many build plans? I understand that you might need one per, say, technology stack or team, but I don't understand why you'd ever have 100 unless you had a very large number of teams/projects, in which case I'd imagine it would be very rare to want to reconfigure any meaningful fraction of them at once.

Oct 6 2015, 1:11 PM · Drydock
epriestley added a revision to T9123: Build Phabricator in Harbormaster (v2): Unknown Object (Differential Revision).
Oct 6 2015, 1:02 PM · Prioritized, Harbormaster
epriestley updated the task description for T9519: Design the Drydock Blueprint selection mechanism.
Oct 6 2015, 11:25 AM · Drydock
epriestley created T9519: Design the Drydock Blueprint selection mechanism.
Oct 6 2015, 11:24 AM · Drydock
epriestley edited the content of 2012-08 August.
Oct 6 2015, 10:43 AM
epriestley added a comment to T182: Commit into repository directly from differential.

Defining the v0 of this in greater detail -- largely just me thinking out loud:

Oct 6 2015, 4:32 AM · Haskell.org, Restricted Project, Differential
epriestley created T9515: Build a "quorum" mechanism and associated UI.
Oct 6 2015, 2:26 AM · Restricted Project, Notifications, Phacility, Auth
epriestley added a comment to T182: Commit into repository directly from differential.

We are also likely to build some sort of consensus framework (primarily to solve problems in T7639 / T7148) which provides generic support for "N of M users must approve this". This is a cleaner fit for having peers reset your MFA than putting a second weird review step on the merge pipeline, but maybe applicable at some point down the line.

Oct 6 2015, 1:20 AM · Haskell.org, Restricted Project, Differential
epriestley added a comment to T182: Commit into repository directly from differential.

I think we're ready to start laying in some of the groundwork for this. Per T9252, we now have hosted builds of commits and revisions in the upstream. This code still needs additional work and is missing a lot of generality, but the fundamentals seem to be in reasonable shape and I think we're on the path to stability.

Oct 6 2015, 1:14 AM · Haskell.org, Restricted Project, Differential
epriestley added a comment to T9123: Build Phabricator in Harbormaster (v2).

Per T9252, we're now building all the repositories and all Community revisions, so the meat of this is working. There are still a lot of pieces that need refinement or generalization, though, or aren't even theoretically useful to installs other than this one for various reasons.

Oct 6 2015, 12:35 AM · Prioritized, Harbormaster
epriestley added a comment to T9252: Unprototype Drydock (v1).

We are now building all of the repositories, and all revisions submitted by members of Community.

Oct 6 2015, 12:33 AM · Prioritized, Drydock

Oct 5 2015

epriestley closed T9514: Garbage Collect Old Differential Files as Wontfix.

I'm not aware of any actual problem faced by installs today that the proposed feature is the best solution to -- nor can I imagine such a problem, even hypothetically -- so I don't plan to pursue it.

Oct 5 2015, 11:57 PM · Differential