Page MenuHomePhabricator
Feed Advanced Search

Jun 25 2015

epriestley added a parent task for T8670: Harbormaster autoplan targets do not always complete: T8657: Harbormaster v1 Errata.
Jun 25 2015, 12:53 PM · Harbormaster
epriestley moved T8657: Harbormaster v1 Errata from Backlog to v1 on the Harbormaster board.
Jun 25 2015, 12:53 PM · Harbormaster
epriestley updated subscribers of T8670: Harbormaster autoplan targets do not always complete.

@joshuaspence is hitting this reliably. I think this is the root cause:

Jun 25 2015, 12:52 PM · Harbormaster
epriestley added a comment to T8614: Provide Assistive/Accessible UI options in User Settings.

They're cached: when you update a Postprocessor without touching CSS, that doesn't dirty the caches, so this server still has a cached version of my old colors. It'll fix itself eventually, but I can look at making it smarter.

Jun 25 2015, 12:42 PM · PHUI
epriestley added a comment to T8673: Maniphest Task Edit Edge Transactions should create metadata based on edit type (add or remove) .

But I do not understand the reasoning for having such arcane and basically useless metadata for maniphest transactions.

Jun 25 2015, 12:11 PM · Projects, Maniphest, Wikimedia, Transactions
epriestley closed T8673: Maniphest Task Edit Edge Transactions should create metadata based on edit type (add or remove) as Wontfix.

This change isn't useful for the upstream, and isn't the direction we intend to pursue. See discussion here:

Jun 25 2015, 11:47 AM · Projects, Maniphest, Wikimedia, Transactions
epriestley updated subscribers of T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.
Jun 25 2015, 11:34 AM · Restricted Project, Auth, Conduit
epriestley merged task T8669: Conduit can't transfer diffs that have invalid UTF8 characters, because json_encode returns FALSE into T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.
Jun 25 2015, 11:34 AM · Diffusion, Conduit
epriestley added a comment to T1279: Show per-reviewer status in Differential revision reviewer list.

You can "Edit Revision" and remove the user as a reviewer to override their block (you can move them to CC at the same time to avoid kicking them off the revision entirely). This is a strong action, but overriding their rejection is also strong.

Jun 25 2015, 11:34 AM · Restricted Project, Differential
joshuaspence created T8674: ArcanistClassNameLiteralXHPASTLinterRule can produce incorrect results.
Jun 25 2015, 11:23 AM · Lint

Jun 24 2015

joshuaspence created T8664: Coverage is reported for all file types.
Jun 24 2015, 11:55 PM · Unit, Arcanist
joshuaspence created T8663: PhpunitTestEngine doesn't support running all tests.
Jun 24 2015, 11:50 PM · Unit, Arcanist
20after4 awarded T4222: Permit Celerity to serve resources in external libphutil modules a Love token.
Jun 24 2015, 11:50 PM · Phabricator, Celerity
epriestley closed T8654: arc seems to be broken with curl 7.43 as Resolved.

Thanks. If this workaround doesn't work for anyone, let me know.

Jun 24 2015, 11:29 PM · Arcanist
epriestley renamed T8650: DifferentialTransactionEditor may race HarbormasterBuildWorker from Error on `arc diff` to HeraldDifferentialRevisionAdapter::newLegacyAdapter() error from `arc diff`.
Jun 24 2015, 11:23 PM · Restricted Project, Harbormaster (v3), Differential
epriestley reopened T8650: DifferentialTransactionEditor may race HarbormasterBuildWorker as "Open".

I just hit this again and am not sure what's causing it.

Jun 24 2015, 11:22 PM · Restricted Project, Harbormaster (v3), Differential
epriestley added a comment to T8654: arc seems to be broken with curl 7.43.

I think that patch fixes this, can someone who has a repro verify that it works for them? You can apply it with arc patch D13417 in libphutil/.

Jun 24 2015, 11:15 PM · Arcanist
epriestley added a revision to T8654: arc seems to be broken with curl 7.43: Unknown Object (Differential Revision).
Jun 24 2015, 11:13 PM · Arcanist
epriestley added a revision to T8654: arc seems to be broken with curl 7.43: Unknown Object (Differential Revision).
Jun 24 2015, 11:12 PM · Arcanist
epriestley added a comment to T8654: arc seems to be broken with curl 7.43.

It looks like this has been reported to the cURL upstream in slightly different form already:

Jun 24 2015, 11:04 PM · Arcanist
epriestley added a comment to T8661: Unclear distinction between Herald rule and Owners package.

Yeah, they're functionally identical.

Jun 24 2015, 10:35 PM · Owners, Herald
epriestley updated subscribers of T8654: arc seems to be broken with curl 7.43.
Jun 24 2015, 9:26 PM · Arcanist
epriestley merged task T8662: Latest curl 7.43 breaks arcanist<-->phabricator integration. into T8654: arc seems to be broken with curl 7.43.
Jun 24 2015, 9:25 PM · Arcanist
joshuaspence created T8661: Unclear distinction between Herald rule and Owners package.
Jun 24 2015, 9:08 PM · Owners, Herald
epriestley created T8657: Harbormaster v1 Errata.
Jun 24 2015, 5:59 PM · Harbormaster
epriestley added a comment to T8656: Parse ANSI-style color strings in build output.

See also T7449.

Jun 24 2015, 3:10 PM · Haskell.org, Restricted Project, Harbormaster
staticshock awarded T5105: Ensure that `ArcanistTextLinter` respects `.editorconfig` settings a Yellow Medal token.
Jun 24 2015, 2:52 PM · Arcanist
epriestley closed T8377: Build the core "Spaces" Application as Resolved.

Seems like the core is in at least roughly in a good place, now.

Jun 24 2015, 1:21 PM · Spaces, Wikimedia, Policy
epriestley closed T8377: Build the core "Spaces" Application, a subtask of T8376: Develop Spaces (v1), as Resolved.
Jun 24 2015, 1:21 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley added a revision to T8493: Integrate Spaces into more applications: Unknown Object (Differential Revision).
Jun 24 2015, 1:18 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley updated the task description for T8493: Integrate Spaces into more applications.
Jun 24 2015, 1:16 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley created T8655: DrydockLease SearchEngine needs new view wrapper in redesign-2015.
Jun 24 2015, 1:09 PM
epriestley closed T8652: Setting up a staging area shouldn't require Arcanist users to have credentials to access it as Invalid.
IMPORTANT: This feature is new, experimental, and not supported. Use it at your own risk.
Jun 24 2015, 11:29 AM
epriestley raised the priority of T8654: arc seems to be broken with curl 7.43 from High to Needs Triage.
Jun 24 2015, 11:28 AM · Arcanist
epriestley closed T8650: DifferentialTransactionEditor may race HarbormasterBuildWorker as Resolved by committing Restricted Diffusion Commit.
Jun 24 2015, 12:12 AM · Restricted Project, Harbormaster (v3), Differential

Jun 23 2015

CodeMouse92 awarded T7931: Create Calendar triggers which notify users before meetings a Like token.
Jun 23 2015, 9:19 PM · Calendar
epriestley added a comment to T8637: Maniphest batch editor can affect far too many tasks.

(This is a bulk edit test.)

Jun 23 2015, 8:43 PM · High Support Impact, Support Impact, Maniphest
epriestley renamed T5166: Expand the BulkJob tool from Write a piece of UI to let users view the progress of long-running background tasks to Expand the BulkJob tool.
Jun 23 2015, 8:42 PM · Restricted Project, Phacility, Daemons
epriestley added a comment to T5166: Expand the BulkJob tool.

This now exists after T8637, but has various missing features and hasn't been adapted for other use cases mentioned here yet.

Jun 23 2015, 8:41 PM · Restricted Project, Phacility, Daemons
epriestley closed T8637: Maniphest batch editor can affect far too many tasks as Resolved.
Jun 23 2015, 8:41 PM · High Support Impact, Support Impact, Maniphest
epriestley closed T8637: Maniphest batch editor can affect far too many tasks, a subtask of T5166: Expand the BulkJob tool, as Resolved.
Jun 23 2015, 8:41 PM · Restricted Project, Phacility, Daemons
cameronsparr awarded T4214: Allow installs to change or supplement the "Phabricator" icon a Like token.
Jun 23 2015, 8:28 PM · Design
epriestley added a revision to T8096: Improve Harbormaster UI/UX (v1): Unknown Object (Differential Revision).
Jun 23 2015, 7:38 PM · Harbormaster
epriestley added a revision to T8096: Improve Harbormaster UI/UX (v1): Unknown Object (Differential Revision).
Jun 23 2015, 6:35 PM · Harbormaster
epriestley added a revision to T8096: Improve Harbormaster UI/UX (v1): Unknown Object (Differential Revision).
Jun 23 2015, 6:31 PM · Harbormaster
epriestley added a revision to T8096: Improve Harbormaster UI/UX (v1): Unknown Object (Differential Revision).
Jun 23 2015, 6:02 PM · Harbormaster
ivh awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Jun 23 2015, 5:30 PM · Workboards (v3), Restricted Project
epriestley closed T8095: Let Harbormaster own Lint and Unit results as Resolved by committing Restricted Diffusion Commit.
Jun 23 2015, 5:24 PM · Harbormaster
epriestley closed T8095: Let Harbormaster own Lint and Unit results, a subtask of T7045: Allow linters to be skipped, as Resolved.
Jun 23 2015, 5:24 PM · Differential, Lint
epriestley closed T8095: Let Harbormaster own Lint and Unit results, a subtask of T7739: Redesign Lint/Unit properties , as Resolved.
Jun 23 2015, 5:24 PM · Restricted Project, Harbormaster, Differential
epriestley edited the content of Consulting.
Jun 23 2015, 5:07 PM
epriestley closed T8486: Implement mentions in Pholio as Resolved by committing Restricted Diffusion Commit.
Jun 23 2015, 5:06 PM · Pholio
epriestley edited the content of Consulting.
Jun 23 2015, 4:19 PM
epriestley edited the content of Roadmap.
Jun 23 2015, 4:14 PM
epriestley edited the content of Welcome.
Jun 23 2015, 3:56 PM
epriestley edited the content of Welcome.
Jun 23 2015, 3:55 PM
epriestley created Consulting.
Jun 23 2015, 3:54 PM
epriestley added a revision to T8095: Let Harbormaster own Lint and Unit results: Unknown Object (Differential Revision).
Jun 23 2015, 2:23 PM · Harbormaster
tycho.tatitscheff awarded T8320: Bring Owners out of the dark ages a Manufacturing Defect? token.
Jun 23 2015, 11:44 AM · Prioritized, Owners
epriestley changed the visibility for T2443: Make "arc cover" more powerful.
Jun 23 2015, 11:06 AM · Restricted Project, Owners, Differential, Arcanist
epriestley added a comment to T8637: Maniphest batch editor can affect far too many tasks.

I have this working functionally, but the UI is still an atrocious mess. Probably have something ready tomorrow.

Jun 23 2015, 1:17 AM · High Support Impact, Support Impact, Maniphest

Jun 22 2015

epriestley added a comment to T8644: Herald template / recipe book / examples / quick-create tool.

See also some discussion in T7804.

Jun 22 2015, 11:18 PM · Restricted Project, Herald
epriestley added a comment to T8089: Unprototype Harbormaster (v1).

Development Log

Jun 22 2015, 9:21 PM · Prioritized, Harbormaster
epriestley added a comment to Image Macro "howaboutno".

bfJxyvo.jpg (476×471 px, 45 KB)bfJxyvo.jpg (476×471 px, 45 KB)bfJxyvo.jpg (476×471 px, 45 KB)bfJxyvo.jpg (476×471 px, 45 KB)bfJxyvo.jpg (476×471 px, 45 KB)

Jun 22 2015, 9:16 PM
epriestley added a comment to Image Macro "howaboutno".

bfJxyvo.jpg (476×471 px, 45 KB)

Jun 22 2015, 9:14 PM
epriestley added a comment to T8376: Develop Spaces (v1).

Development Log

Jun 22 2015, 8:06 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley closed T8615: Write a guide for troubleshooting repository imports as Resolved by committing Restricted Diffusion Commit.
Jun 22 2015, 7:26 PM · Diffusion, Documentation
epriestley closed T6787: Clarify UI for Objects with a non-default Policy as Resolved by committing Restricted Diffusion Commit.
Jun 22 2015, 6:47 PM · Design, Policy, Wikimedia
epriestley closed T5135: Allow to change defaults for Passphrase "Visible To" and "Editable By" policies as Resolved by committing Restricted Diffusion Commit.
Jun 22 2015, 6:28 PM · Passphrase
epriestley closed T5135: Allow to change defaults for Passphrase "Visible To" and "Editable By" policies, a subtask of T6787: Clarify UI for Objects with a non-default Policy, as Resolved.
Jun 22 2015, 6:28 PM · Design, Policy, Wikimedia
epriestley added a comment to T5791: Write Herald rules for outbound mail.

Concrete stuff here is probably something like this (this might not be the optimal order):

Jun 22 2015, 6:16 PM · Restricted Project, Restricted Project, FreeBSD, Mail
epriestley added a comment to T8640: Add option to set default ordering of files in diff review.

iPhone developers will also understand the annoyance of seeing the massive and often irrelevant project.pbxproj appear before source files in the diff.

Jun 22 2015, 5:57 PM
epriestley added a revision to T8637: Maniphest batch editor can affect far too many tasks: Unknown Object (Differential Revision).
Jun 22 2015, 5:55 PM · High Support Impact, Support Impact, Maniphest
epriestley closed T8640: Add option to set default ordering of files in diff review as Wontfix.

This would be complex to implement (sorting isn't, per se, but proper implementation which consistently extends to Differential, Diffusion, Owners, arc, etc.) and this use case doesn't seem very strong (the behavior is obvious, there's a table of contents and a scrollbar, there's no particular reason not to review tests first, etc.).

Jun 22 2015, 5:42 PM
epriestley added a revision to T8637: Maniphest batch editor can affect far too many tasks: Unknown Object (Differential Revision).
Jun 22 2015, 4:44 PM · High Support Impact, Support Impact, Maniphest
epriestley raised the priority of T8637: Maniphest batch editor can affect far too many tasks from Normal to High.
Jun 22 2015, 3:21 PM · High Support Impact, Support Impact, Maniphest
epriestley added a comment to T8637: Maniphest batch editor can affect far too many tasks.

After mulling this over for a bit while dealing with other stuff, I'm pretty convinced that the general purpose infrastructure in T5166 is the way forward here, so my plan is to move forward with that.

Jun 22 2015, 3:21 PM · High Support Impact, Support Impact, Maniphest
epriestley claimed T8637: Maniphest batch editor can affect far too many tasks.
Jun 22 2015, 2:56 PM · High Support Impact, Support Impact, Maniphest
epriestley renamed T8636: Update "Configuring Inbound Email" to describe application email configuration in greater detail from Ability to assign projects on inbound mail issues through headers to Update "Configuring Inbound Email" to describe application email configuration in greater detail.
Jun 22 2015, 2:49 PM · Documentation, Mail
epriestley updated the task description for T8637: Maniphest batch editor can affect far too many tasks.
Jun 22 2015, 1:23 PM · High Support Impact, Support Impact, Maniphest
epriestley added a revision to T8637: Maniphest batch editor can affect far too many tasks: Unknown Object (Differential Revision).
Jun 22 2015, 1:21 PM · High Support Impact, Support Impact, Maniphest
epriestley renamed T8637: Maniphest batch editor can affect far too many tasks from Create a log for Maniphest batch edits to Maniphest batch editor can affect far too many tasks.
Jun 22 2015, 1:20 PM · High Support Impact, Support Impact, Maniphest
epriestley added a revision to T8637: Maniphest batch editor can affect far too many tasks: Unknown Object (Differential Revision).
Jun 22 2015, 1:06 PM · High Support Impact, Support Impact, Maniphest
epriestley added a comment to T8637: Maniphest batch editor can affect far too many tasks.

This appears to work to undo a status change batch edit:

Jun 22 2015, 12:56 PM · High Support Impact, Support Impact, Maniphest
epriestley added a subtask for T5166: Expand the BulkJob tool: T8637: Maniphest batch editor can affect far too many tasks.
Jun 22 2015, 12:36 PM · Restricted Project, Phacility, Daemons
epriestley added a parent task for T8637: Maniphest batch editor can affect far too many tasks: T5166: Expand the BulkJob tool.
Jun 22 2015, 12:36 PM · High Support Impact, Support Impact, Maniphest
epriestley added projects to T8637: Maniphest batch editor can affect far too many tasks: Support Impact, High Support Impact.
Jun 22 2015, 12:35 PM · High Support Impact, Support Impact, Maniphest
epriestley created T8637: Maniphest batch editor can affect far too many tasks.
Jun 22 2015, 12:34 PM · High Support Impact, Support Impact, Maniphest
epriestley added a comment to T8636: Update "Configuring Inbound Email" to describe application email configuration in greater detail.
  • Define a recipient address for each team in Applications → Maniphest → Help/Options → Edit Application Emails. For example, frontend-bugs@phabricator.mycompany.com and backend-bugs@phabricator.mycompany.com. For example, here are five different receiving addresses:
Jun 22 2015, 11:56 AM · Documentation, Mail
epriestley added a revision to T6787: Clarify UI for Objects with a non-default Policy: Unknown Object (Differential Revision).
Jun 22 2015, 3:28 AM · Design, Policy, Wikimedia
epriestley added a revision to T8493: Integrate Spaces into more applications: Unknown Object (Differential Revision).
Jun 22 2015, 2:51 AM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T5135: Allow to change defaults for Passphrase "Visible To" and "Editable By" policies: Unknown Object (Differential Revision).
Jun 22 2015, 2:43 AM · Passphrase
epriestley closed T5398: Add ability to secret questions and other password reset info along with password in Passphrase as Resolved.

There's now a generic "note" credential type which lets you store a big chunk of secret text.

Jun 22 2015, 2:39 AM · Passphrase
epriestley added a revision to T8096: Improve Harbormaster UI/UX (v1): Unknown Object (Differential Revision).
Jun 22 2015, 2:18 AM · Harbormaster

Jun 21 2015

joshuaspence created T8635: Show history of changes to Herald rules.
Jun 21 2015, 11:34 PM · Restricted Project, Herald
joshuaspence added a comment to T8095: Let Harbormaster own Lint and Unit results.

I imagine that work on these ticket will see the DifferentialDiffProperty table killed off or substantially changed. This will break the work that I had done on T784, so I will abandon those diffs.

Jun 21 2015, 10:56 PM · Harbormaster
joshuaspence added a comment to T8549: Feedback on 2015 Redesign.

The background on the "Needs Revision" state in Differential looks odd to me. I feel that this would actually look better without a background color.

Jun 21 2015, 9:45 PM · Design
epriestley added a revision to T8096: Improve Harbormaster UI/UX (v1): Unknown Object (Differential Revision).
Jun 21 2015, 8:47 PM · Harbormaster
epriestley added a revision to T8095: Let Harbormaster own Lint and Unit results: Restricted Differential Revision.
Jun 21 2015, 6:33 PM · Harbormaster
epriestley added a revision to T8095: Let Harbormaster own Lint and Unit results: Restricted Differential Revision.
Jun 21 2015, 5:57 PM · Harbormaster