Page MenuHomePhabricator
Create Task
Maniphest T8095

Let Harbormaster own Lint and Unit results
Closed, ResolvedPublic
Actions

Description

Currently, lint and unit results are owned partially by Differential and partially by Harbormaster. Instead, Harbormaster (which can be a much more general datastore) should own these results and Differential should read them from Harbormaster.

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit

Related Objects
Search...

Event Timeline

epriestley created this task.May 6 2015, 3:26 PM
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Harbormaster.
epriestley added a subtask: T5138: Show unit and lint status messages at each diff.
epriestley added a parent task: T7739: Redesign Lint/Unit properties .
epriestley added a parent task: T7045: Allow linters to be skipped.
epriestley mentioned this in T8089: Unprototype Harbormaster (v1).
epriestley added a subscriber: epriestley.
epriestley moved this task from Backlog to v1 on the Harbormaster board.May 6 2015, 3:28 PM
epriestley added a parent task: T8097: Allow external systems to report results into Harbormaster.May 6 2015, 4:11 PM
cburroughs added a subscriber: cburroughs.May 6 2015, 6:57 PM
joshuaspence added a subscriber: joshuaspence.May 6 2015, 8:38 PM
epriestley closed subtask T5138: Show unit and lint status messages at each diff as Resolved.Jun 16 2015, 3:53 PM
epriestley added a revision: Restricted Differential Revision.Jun 17 2015, 2:30 PM
epriestley added a revision: Restricted Differential Revision.Jun 18 2015, 5:33 PM
epriestley added a revision: Restricted Differential Revision.Jun 18 2015, 6:02 PM
epriestley added a commit: Restricted Diffusion Commit.Jun 21 2015, 4:00 PM
epriestley added a commit: Restricted Diffusion Commit.Jun 21 2015, 4:02 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a revision: Restricted Differential Revision.Jun 21 2015, 5:14 PM
epriestley added a revision: Restricted Differential Revision.Jun 21 2015, 5:39 PM
epriestley added a revision: Restricted Differential Revision.Jun 21 2015, 5:42 PM
epriestley added a revision: Restricted Differential Revision.Jun 21 2015, 5:57 PM
epriestley added a revision: Restricted Differential Revision.Jun 21 2015, 6:33 PM
joshuaspence added a comment.Jun 21 2015, 10:56 PM

I imagine that work on these ticket will see the DifferentialDiffProperty table killed off or substantially changed. This will break the work that I had done on T784, so I will abandon those diffs.

epriestley added a revision: Restricted Differential Revision.Jun 23 2015, 2:23 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Jun 23 2015, 5:23 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
joshuaspence mentioned this in T8744: Code coverage reporting broken.Jul 3 2015, 7:34 AM
epriestley mentioned this in T9334: Improve documentation for differential.setdiffproperty.Sep 3 2015, 4:51 PM
Phabricator · Built by Phacility