Let Harbormaster own Lint and Unit results
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	epriestley
	May 6 2015, 3:26 PM

Description

Currently, lint and unit results are owned partially by Differential and partially by Harbormaster. Instead, Harbormaster (which can be a much more general datastore) should own these results and Differential should read them from Harbormaster.

Revisions and Commits

rARC Arcanist
	D13381	rARCb697a3b80bdc Try to ship lint and unit results to Harbormaster autotargets
rP Phabricator
	D13401	rPde30e15b7ec8 Make Differential load lint/unit data from Harbormaster
	D13380	rP41b3f9236a77 Allow lint and unit results to be reported via `harbormaster.sendmessage`
	D13379	rP831c18e6be3b Remove weird "Differential Results Table" view
	D13378	rPb72deb332ca7 Render unit results as Harbormaster unit messages
	D13377	rPe618b672d233 Render lint results as Harbormaster lint messages
	D13345	rP76194a0dc1dd Add "Autoplans" to Harbormaster
	D13344	rP081300c7f861 Modernize some Harbormaster Controller/Policy infrastructure
	D13329	rP7ad4c9c056d1 Replace Harbormaster "BuildItem" with Lint/Unit messages

Related Objects
Search...

Status	Assigned	Task
Resolved	epriestley	T8089 Unprototype Harbormaster (v1)
Resolved	epriestley	T8097 Allow external systems to report results into Harbormaster
Wontfix	chad	T7739 Redesign Lint/Unit properties
Open	joshuaspence	T7045 Allow linters to be skipped
Resolved	None	T8095 Let Harbormaster own Lint and Unit results
Resolved	epriestley	T5138 Show unit and lint status messages at each diff

Event Timeline

epriestley created this task.May 6 2015, 3:26 PM

epriestley raised the priority of this task from to Normal.

epriestley updated the task description. (Show Details)

epriestley added a project: Harbormaster.

epriestley added a subtask: T5138: Show unit and lint status messages at each diff.

epriestley added a parent task: T7739: Redesign Lint/Unit properties .

epriestley added a parent task: T7045: Allow linters to be skipped.

epriestley mentioned this in T8089: Unprototype Harbormaster (v1).

epriestley added a subscriber: epriestley.

epriestley moved this task from Backlog to v1 on the Harbormaster board.May 6 2015, 3:28 PM

epriestley added a parent task: T8097: Allow external systems to report results into Harbormaster.May 6 2015, 4:11 PM

cburroughs added a subscriber: cburroughs.May 6 2015, 6:57 PM

joshuaspence added a subscriber: joshuaspence.May 6 2015, 8:38 PM

epriestley mentioned this in D9113: Implement a very rough version of saving lint from Harbormaster.May 13 2015, 2:00 PM

epriestley closed subtask T5138: Show unit and lint status messages at each diff as Resolved.Jun 16 2015, 3:53 PM

epriestley added a revision: D13329: Replace Harbormaster "BuildItem" with Lint/Unit messages.Jun 17 2015, 2:30 PM

epriestley added a revision: D13344: Modernize some Harbormaster Controller/Policy infrastructure.Jun 18 2015, 5:33 PM

epriestley added a revision: D13345: Add "Autoplans" to Harbormaster.Jun 18 2015, 6:02 PM

epriestley added a commit: rP7ad4c9c056d1: Replace Harbormaster "BuildItem" with Lint/Unit messages.Jun 21 2015, 4:00 PM

epriestley added a commit: rP081300c7f861: Modernize some Harbormaster Controller/Policy infrastructure.Jun 21 2015, 4:02 PM

epriestley added a commit: rP76194a0dc1dd: Add "Autoplans" to Harbormaster.

epriestley added a revision: D13377: Render lint results as Harbormaster lint messages.Jun 21 2015, 5:14 PM

epriestley added a revision: D13378: Render unit results as Harbormaster unit messages.Jun 21 2015, 5:39 PM

epriestley added a revision: D13379: Remove weird "Differential Results Table" view.Jun 21 2015, 5:42 PM

epriestley added a revision: D13380: Allow lint and unit results to be reported via `harbormaster.sendmessage`.Jun 21 2015, 5:57 PM

epriestley added a revision: D13381: Try to ship lint and unit results to Harbormaster autotargets.Jun 21 2015, 6:33 PM

I imagine that work on these ticket will see the DifferentialDiffProperty table killed off or substantially changed. This will break the work that I had done on T784, so I will abandon those diffs.

joshuaspence mentioned this in D11535: Allow differential changesets to be marked as generated via diff properties.Jun 21 2015, 10:56 PM

joshuaspence mentioned this in D11536: Submit the `arc:generated` property with `arc diff`.

joshuaspence mentioned this in D11537: Allow `ArcanistGeneratedLinter` to respect `generated-paths`.

joshuaspence mentioned this in D11538: Remove deprecated generated paths configuration.

epriestley added a revision: D13401: Make Differential load lint/unit data from Harbormaster.Jun 23 2015, 2:23 PM

epriestley closed this task as Resolved by committing rPde30e15b7ec8: Make Differential load lint/unit data from Harbormaster.Jun 23 2015, 5:23 PM

epriestley added a commit: rARCb697a3b80bdc: Try to ship lint and unit results to Harbormaster autotargets.

epriestley added a commit: rPe618b672d233: Render lint results as Harbormaster lint messages.

epriestley added a commit: rPb72deb332ca7: Render unit results as Harbormaster unit messages.

epriestley added a commit: rP831c18e6be3b: Remove weird "Differential Results Table" view.

epriestley added a commit: rP41b3f9236a77: Allow lint and unit results to be reported via `harbormaster.sendmessage`.

epriestley added a commit: rPde30e15b7ec8: Make Differential load lint/unit data from Harbormaster.