Harbormaster autoplan targets do not always complete
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hach-que
	Jun 25 2015, 7:40 AM

Description

See:

Revisions and Commits

rARC Arcanist
	D13436	rARC29839e8c72c5 Don't fail lint builds for "advice"; make lint/unit upload failures louder
rP Phabricator
	D13435	rP5f99d79c5d17 Fix type spec for 'coverage'

Related Objects
Search...

Status	Assigned	Task
Resolved	epriestley	T8089 Unprototype Harbormaster (v1)
Resolved	None	T8657 Harbormaster v1 Errata
Resolved	epriestley	T8670 Harbormaster autoplan targets do not always complete

Event Timeline

hach-que created this task.Jun 25 2015, 7:40 AM

hach-que assigned this task to epriestley.

hach-que raised the priority of this task from to Needs Triage.

hach-que updated the task description. (Show Details)

hach-que added a project: Harbormaster.

hach-que added a subscriber: hach-que.

Looks like this has happened on this install a few times as well:

@joshuaspence is hitting this reliably. I think this is the root cause:

2015/06/25 12:17:43 [error] 10137#0: *266327 FastCGI sent in stderr: "PHP message: [2015-06-25 12:17:43] EXCEPTION: (PhutilTypeCheckException) Parameter has invalid type. Expected type 'optional string', got type 'map<string, string>'. at [<phutil>/src/parser/PhutilTypeSpec.php:74]
PHP message: arcanist(head=master, ref.master=b697a3b80bdc), phabricator(head=redesign-2015, ref.master=0fd0f171f10f, ref.redesign-2015=1a5f986d73dd), phutil(head=master, ref.master=74c9cb3a266e)
PHP message:   #0 <#2> PhutilTypeSpec::check(array) called at [<phutil>/src/parser/PhutilTypeSpec.php:169]
PHP message:   #1 <#2> PhutilTypeSpec::checkMap(array, array) called at [<phabricator>/src/applications/harbormaster/storage/build/HarbormasterBuildUnitMessage.php:41]
PHP message:   #2 <#2> HarbormasterBuildUnitMessage::newFromDictionary(HarbormasterBuildTarget, array) called at [<phabricator>/src/applications/harbormaster/conduit/HarbormasterSendMessageConduitAPIMethod.php:58]
PHP message:   #3 <#2> HarbormasterSendMessageConduitAPIMethod::execute(ConduitAPIRequest) called at [<phabricator>/src/applications/conduit/method/ConduitAPIMethod.php:90]
PHP message:   #4 <#2> ConduitAPIMethod::executeMethod(ConduitAPIRequest) called at [<phabricator>/src/applications/conduit/call/ConduitCall.php:135]
PHP message:   #5 <#2> ConduitCall::executeMethod() called at [<phabricator>/src/applications/conduit/call/ConduitCall.php:85]
PHP message:   #6 <#2> ConduitCall::execute() called at [<phabricator>/src/applications/conduit/controller/PhabricatorConduitAPIController.php:91]
PHP message:   #7 phlog(PhutilTypeCheckException) called at [<phabricator>/src/applications/conduit/controller/PhabricatorConduitAPIController.php:111]
PHP message:   #8 PhabricatorConduitAPIController::processRequest() called at [<phabricator>/src/aphront/AphrontController.php:33]
PHP message:   #9 AphrontController::handleRequest(AphrontRequest) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:226]
PHP message:   #10 AphrontApplicationCon

Basically, bad server-side spec for "coverage".

epriestley added a parent task: T8657: Harbormaster v1 Errata.Jun 25 2015, 12:53 PM

epriestley added a revision: Unknown Object (Differential Revision).Jun 25 2015, 1:17 PM