Page MenuHomePhabricator
Feed Advanced Search

Dec 18 2017

epriestley closed T7789: Support Git Large File Storage as Resolved.

T10604 and T4369 do not impact LFS (broadly, they apply only to POST requests, and LFS uses PUT to upload data).

Dec 18 2017, 5:47 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley removed subtasks for T7789: Support Git Large File Storage: T10604: Allow application code to stream request data, T4369: Phabricator HTTP repository hosting has fairly severe scalability limits.
Dec 18 2017, 5:45 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley removed a parent task for T4369: Phabricator HTTP repository hosting has fairly severe scalability limits: T7789: Support Git Large File Storage.
Dec 18 2017, 5:45 PM · Diffusion (v3), Restricted Project
epriestley removed a parent task for T10604: Allow application code to stream request data: T7789: Support Git Large File Storage.
Dec 18 2017, 5:45 PM · Diffusion (v3), Restricted Project
epriestley triaged T13032: Upgrading: Git LFS as Normal priority.
Dec 18 2017, 5:36 PM · Diffusion, Git, Installing & Upgrading
epriestley renamed T13019: Build Status is integrated into Diffusion in a hacky way from Build Status got dropped from Commit Details View to Build Status is integrated into Diffusion in a hacky way.
Dec 18 2017, 5:21 PM · Diffusion, Harbormaster
epriestley renamed T13018: Support Discourse's specific dialect of OpenGraph metadata tags to enrich Discourse "OneBox" previews from Open Graph metadata for beautiful rendering of Phabricator URLs to Support Discourse's specific dialect of OpenGraph metadata tags to enrich Discourse "OneBox" previews.
Dec 18 2017, 5:20 PM
epriestley added a comment to T13031: Prevent "enormous" commits from being pushed to hosted repositories in Diffusion by default.

Adjacently, some other parts of the UI currently use the word "enormous" (see https://discourse.phabricator-community.org/t/herald-enormous-check/822). They should be rewritten to use different language (like "Very Large"). We should use the term "Enormous" to mean only "too large to process completely", while the other UI uses it to mean "large enough to partially collapse for viewer convenience".

Dec 18 2017, 4:48 PM · Herald, Security, Diffusion
epriestley triaged T13031: Prevent "enormous" commits from being pushed to hosted repositories in Diffusion by default as Normal priority.
Dec 18 2017, 4:45 PM · Herald, Security, Diffusion
epriestley added a comment to T8644: Herald template / recipe book / examples / quick-create tool.

Also, while it's on my mind, all repositories should probably have this rule today:

Dec 18 2017, 4:37 PM · Restricted Project, Herald
epriestley added a comment to T8644: Herald template / recipe book / examples / quick-create tool.

See T7789 and D18827. Block Git LFS in some repositories:

Dec 18 2017, 4:32 PM · Restricted Project, Herald
epriestley added a comment to T8644: Herald template / recipe book / examples / quick-create tool.

See PHI242. SR Latch:

Dec 18 2017, 4:31 PM · Restricted Project, Herald

Dec 16 2017

liuxinyu970226 awarded T5051: Burn down charts for Milestones a Like token.
Dec 16 2017, 11:30 AM · Restricted Project, Projects, Wikimedia

Dec 14 2017

• gabriel.magana added a comment to T4104: Implement "suggest profile edit" for recommending profile pictures, phone numbers, etc., to users.

Seriously folks, why make this design decision? I have a user with a long history in my Phabricator install that now cannot get into his account and cannot remember what email address he used to create the account. Under a normal system scenario where I'm Admin, I can just go into his account, tell him which address he used, chastise him for forgetting and not keeping notes and that's it.

Dec 14 2017, 5:22 PM · Profile

Dec 13 2017

epriestley edited the content of Changelog.
Dec 13 2017, 9:31 PM
epriestley created 2017 Week 49 (Mid December).
Dec 13 2017, 3:15 PM
epriestley renamed T13030: Accessing a submodule path directly in Diffusion has less than optimal UX from `git cat-file -t <commit>:<submodule>` fails to Accessing a submodule path directly in Diffusion has less than optimal UX.
Dec 13 2017, 3:10 PM · Git, Diffusion
epriestley lowered the priority of T13030: Accessing a submodule path directly in Diffusion has less than optimal UX from Normal to Wishlist.

D18831 should upgrade this from "horrible fatal" to "reasonable-but-not-ideal normal page". This could still be improved (providing the user more information and taking them into the submodule redirect workflow) but it's normally difficult to end up here without trying.

Dec 13 2017, 3:09 PM · Git, Diffusion
epriestley added a revision to T13030: Accessing a submodule path directly in Diffusion has less than optimal UX: Unknown Object (Differential Revision).
Dec 13 2017, 3:08 PM · Git, Diffusion
epriestley added a comment to T7789: Support Git Large File Storage.

We have an outstanding support issue (PHI204) about timeouts with large files.

Dec 13 2017, 2:49 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Dec 13 2017, 2:49 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

No.

Dec 13 2017, 2:20 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
mpadourek added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

@epriestley Are there any more concrete plans for this "nonblocking" builds? That is something we would like to utilise for one of our projects. Actually quite important as waiting for builds there is slowing us down quite a bit now.

Dec 13 2017, 2:18 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a comment to T7789: Support Git Large File Storage.

Per above, pushes to staging areas did not push LFS in the past. We should figure out what the state of the world is now and try to resolve it in the upstream, and document anything we can't work around or resolve.

Dec 13 2017, 2:14 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T7789: Support Git Large File Storage.

@Grimeh, above, reports that this doesn't work over HTTP. I believe it does, but we should verify this.

Dec 13 2017, 2:08 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Dec 13 2017, 2:04 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Dec 13 2017, 1:59 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Dec 13 2017, 1:46 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Dec 13 2017, 1:43 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley triaged T13029: Provide some way for administrators to remove/reset a user's profile image as Wishlist priority.

As @avivey suggests, the remaining cache can be cleared with:

Dec 13 2017, 1:30 PM · Abuse, People
epriestley added a comment to T10215: Provide tools to combat and recover from abuse.

Anecdotally, Disqus uses Akismet and the hit rate isn't great (I've observed both a high false positive rate, and a high false negative rate).

Dec 13 2017, 1:26 PM · Abuse
epriestley archived Bug Report (Needs Information).
Dec 13 2017, 1:14 PM
epriestley archived Bug Report.
Dec 13 2017, 1:14 PM
epriestley archived Feature Request (Needs Information).
Dec 13 2017, 1:14 PM
epriestley archived Feature Request.
Dec 13 2017, 1:14 PM
epriestley edited projects for T13029: Provide some way for administrators to remove/reset a user's profile image, added: Abuse; removed Feature Request, Policy.
Dec 13 2017, 1:13 PM · Abuse, People
epriestley added a subtask for T10215: Provide tools to combat and recover from abuse: T13029: Provide some way for administrators to remove/reset a user's profile image.
Dec 13 2017, 1:13 PM · Abuse
epriestley added a parent task for T13029: Provide some way for administrators to remove/reset a user's profile image: T10215: Provide tools to combat and recover from abuse.
Dec 13 2017, 1:13 PM · Abuse, People
epriestley added projects to T13030: Accessing a submodule path directly in Diffusion has less than optimal UX: Diffusion, Git.
Dec 13 2017, 1:13 PM · Git, Diffusion
20after4 added a comment to T4369: Phabricator HTTP repository hosting has fairly severe scalability limits.

I don't see any easy way to cheat through $_FILES, though. We could remove it, but we have a nonzero number of users who compile their own copy of Linux and use a window manager that doesn't support drag and drop and disable Javascript and don't believe a monitor should ever have more than 256 colors, so that would leave them out to dry. The conversion also isn't trivial, so even if we want to move in this direction eventually I think it's a significant scope expansion over just building a synthetic $_FILES.

Dec 13 2017, 11:50 AM · Diffusion (v3), Restricted Project

Dec 12 2017

epriestley merged T9915: Audit Changes TOC fail redirecting to right subdirectory when clicking on fa-folder-open icon and produces an unhandled exception into T13030: Accessing a submodule path directly in Diffusion has less than optimal UX.
Dec 12 2017, 8:54 PM · Git, Diffusion
epriestley merged task T9915: Audit Changes TOC fail redirecting to right subdirectory when clicking on fa-folder-open icon and produces an unhandled exception into T13030: Accessing a submodule path directly in Diffusion has less than optimal UX.
Dec 12 2017, 8:54 PM · Restricted Project, Diffusion, Bug Report
epriestley triaged T13030: Accessing a submodule path directly in Diffusion has less than optimal UX as Normal priority.
Dec 12 2017, 8:54 PM · Git, Diffusion
spawnlt awarded T12314: Support formal task subtypes (like "bug" vs "feature") a Party Time token.
Dec 12 2017, 10:26 AM · EditEngine, Maniphest, Custom Fields, Feature Request
spawnlt awarded T12588: create subtask side menu to allow creation of subtasks of different types to the parent task a Party Time token.
Dec 12 2017, 10:20 AM · Feature Request

Dec 9 2017

avivey added a comment to T13029: Provide some way for administrators to remove/reset a user's profile image.

You need to clear some caches too - ./bin/cache purge - but I'm not sure which; And then hard-refresh the in the browser.

Dec 9 2017, 11:36 PM · Abuse, People
aklapper added a project to T13029: Provide some way for administrators to remove/reset a user's profile image: Feature Request.
Dec 9 2017, 8:02 PM · Abuse, People
aklapper created T13029: Provide some way for administrators to remove/reset a user's profile image.
Dec 9 2017, 8:01 PM · Abuse, People
aklapper added a comment to T10221: upgrading to ubuntu 15.10 breaks google authentication.

Support for Ubuntu 15.10 ended on 2016-07-28.
Did this problem also happen with any later, still supported Ubuntu version (like 16.04) or can this task be closed as obsolete?

Dec 9 2017, 7:48 PM · Auth, Bug Report

Dec 8 2017

epriestley added a member for Blessed Committers: timhirsh.
Dec 8 2017, 4:45 PM

Dec 7 2017

lpriestley added a revision to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one: Unknown Object (Differential Revision).
Dec 7 2017, 10:18 PM · Dashboards
friesenschrauber awarded T13018: Support Discourse's specific dialect of OpenGraph metadata tags to enrich Discourse "OneBox" previews a Love token.
Dec 7 2017, 5:41 PM
avivey created P2081 DebugAuthProvider .
Dec 7 2017, 1:56 PM
avivey created P2080 CopyPHIDAction.php.
Dec 7 2017, 12:47 PM

Dec 6 2017

TanmayaA awarded T11557: Provide a way to define a deadline / launch date for a task a Like token.
Dec 6 2017, 10:48 AM · Feature Request

Dec 5 2017

epriestley closed T13027: When revisions autopromote out of "Draft", Herald rules blocked by "Draft" do not trigger until the next edit, a subtask of T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential, as Resolved.
Dec 5 2017, 8:14 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley closed T13027: When revisions autopromote out of "Draft", Herald rules blocked by "Draft" do not trigger until the next edit as Resolved by committing Restricted Diffusion Commit.
Dec 5 2017, 8:14 PM · Herald, Differential
nickhutchinson awarded T3498: Allow ignore whitespace in Audit/Diffusion diffs a Like token.
Dec 5 2017, 7:59 PM · Diffusion
lpriestley created T13028: Crumbs on a page that shows options for an ambiguous commit identifier should link to the repository.
Dec 5 2017, 7:39 PM · Diffusion
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Dec 5 2017, 3:57 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T13027: When revisions autopromote out of "Draft", Herald rules blocked by "Draft" do not trigger until the next edit: Unknown Object (Differential Revision).
Dec 5 2017, 3:57 PM · Herald, Differential

Dec 3 2017

lpriestley added a revision to T13001: Ambiguous commits should prompt you to select from options: Unknown Object (Differential Revision).
Dec 3 2017, 8:26 PM · Diffusion

Dec 1 2017

epriestley edited the content of Changelog.
Dec 1 2017, 9:29 PM
epriestley created 2017 Week 48 (Early December).
Dec 1 2017, 9:28 PM
epriestley triaged T13027: When revisions autopromote out of "Draft", Herald rules blocked by "Draft" do not trigger until the next edit as Normal priority.
Dec 1 2017, 7:32 PM · Herald, Differential

Nov 30 2017

lpriestley added a revision to T13019: Build Status is integrated into Diffusion in a hacky way: Unknown Object (Differential Revision).
Nov 30 2017, 9:56 PM · Diffusion, Harbormaster
epriestley closed T10233: arc error message unclear for accepted revision in "plan change" state as Resolved by committing Restricted Diffusion Commit.
Nov 30 2017, 9:51 PM · Restricted Project, Bug Report
epriestley added a revision to T10405: Phabricator should generally work properly even if "gd" is not installed: Unknown Object (Differential Revision).
Nov 30 2017, 9:47 PM · Setup, Restricted Project
epriestley renamed T10405: Phabricator should generally work properly even if "gd" is not installed from New Project flow assumes gd is installed to Phabricator should generally work properly even if "gd" is not installed.
Nov 30 2017, 9:46 PM · Setup, Restricted Project
epriestley closed T12592: User awaiting approval has no image as Resolved.

This should be fixed by changes in T13024.

Nov 30 2017, 9:43 PM · Bug Report, Auth
epriestley closed T12657: Add Authentication Factor fails silently for users without a verified email address as Resolved.

This should be fixed by changes in T13024.

Nov 30 2017, 9:43 PM · Auth, Bug Report
epriestley merged T12570: Installs without `gd` are unable to reach the setup warning telling them to install `gd` into T10405: Phabricator should generally work properly even if "gd" is not installed.
Nov 30 2017, 9:42 PM · Setup, Restricted Project
epriestley merged task T12570: Installs without `gd` are unable to reach the setup warning telling them to install `gd` into T10405: Phabricator should generally work properly even if "gd" is not installed.
Nov 30 2017, 9:42 PM · Setup, Bug Report
epriestley added a revision to T12855: In PHP7, "Throwable" and "Error" are exciting new exception classes: Unknown Object (Differential Revision).
Nov 30 2017, 7:29 PM · Infrastructure
epriestley added a member for Community: dho.
Nov 30 2017, 7:15 PM
epriestley added a revision to T10233: arc error message unclear for accepted revision in "plan change" state: Unknown Object (Differential Revision).
Nov 30 2017, 4:26 PM · Restricted Project, Bug Report
epriestley added a revision to T10233: arc error message unclear for accepted revision in "plan change" state: Unknown Object (Differential Revision).
Nov 30 2017, 3:53 PM · Restricted Project, Bug Report
kugel- added a comment to T4333: `arc land` should provide a mechanism to land revisions by other authors while preserving authorship meta-data.

Also, in case of "arc land --merge", the merge commit is falsely authored by the revision author.

Nov 30 2017, 3:41 PM · Arcanist
kugel- added a comment to T4333: `arc land` should provide a mechanism to land revisions by other authors while preserving authorship meta-data.

arc land still prints a warning in this scenario. Is there a way to disable that through .arcconfig? arc land itself doesn't seem to have an option to skip the warning.

Nov 30 2017, 3:37 PM · Arcanist
epriestley added a revision to T10268: "Batch Edit" from workboards uses "?ids=X,Y,Z" which can exceed "Location" header or URL byte limits for large task sets: Unknown Object (Differential Revision).
Nov 30 2017, 3:28 PM · Customer Impact, Workboards, Maniphest
epriestley added a revision to T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support: Unknown Object (Differential Revision).
Nov 30 2017, 3:28 PM · Transactions, ApplicationEditor
epriestley renamed T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support from Update batch editor to Update bulk editor.
Nov 30 2017, 3:23 PM · Transactions, ApplicationEditor
epriestley added a revision to T10005: Implement an ApplicationEditor-based Bulk Editor: Unknown Object (Differential Revision).
Nov 30 2017, 1:40 PM · ApplicationEditor
epriestley added a revision to T13025: Turn bulk editor into a generic piece of EditEngine infrastructure with Custom Field support: Unknown Object (Differential Revision).
Nov 30 2017, 1:40 PM · Transactions, ApplicationEditor
epriestley added a revision to T11286: make it possible to remove tasks from a batch edit tasks workflow: Unknown Object (Differential Revision).
Nov 30 2017, 1:40 PM · Maniphest, Feature Request
epriestley added a revision to T10152: Allow uri.allowed-protocols to be configured in the Phacility cluster: Unknown Object (Differential Revision).
Nov 30 2017, 12:34 PM · Phacility
epriestley added a revision to T11413: Support renaming Phacility instances: Unknown Object (Differential Revision).
Nov 30 2017, 12:34 PM · Phacility

Nov 29 2017

epriestley added a comment to T9805: XHProf will not build on PHP7.

(I'm also open to improvements to the XHProf UI in Phabricator if you plan to use that to store and review profiles. Many obvious features like tagging and API access which would make it more usable for handling profiles of projects other than Phabricator itself are likely very easy to implement. But I'm not sure there's tons of room for real integrations, even if you used everything else in Phabricator, and you may imagine tooling which can't realistically exist in the scope of Phabricator.)

Nov 29 2017, 9:05 PM · XHProf
epriestley added a comment to T9805: XHProf will not build on PHP7.

For general context:

Nov 29 2017, 8:58 PM · XHProf
epriestley added a comment to T10233: arc error message unclear for accepted revision in "plan change" state.

In PHI231, a more experienced user went through this workflow:

Nov 29 2017, 7:24 PM · Restricted Project, Bug Report
20after4 updated subscribers of T9805: XHProf will not build on PHP7.
Nov 29 2017, 6:50 PM · XHProf
20after4 added a watcher for Calendar: 20after4.
Nov 29 2017, 6:31 AM

Nov 28 2017

lpriestley added a comment to T12544: Cannot add invitees to all future instances of a recurring event.

@epriestley what do you think of creating another column in the calendar_eventinvitee table, something like a bool futureStatus so that when we get a list of invitees back, we can check for that flag. I think this would mean a lot of date comparisons (seems inefficient), and I'm not quite sure when to populate event stubs. For example, if the futureStatus flag is set to true for instance 10, and there are stubs for instances 15 and 20, when would 15 and 20 get converted to have the updated status?

Nov 28 2017, 11:16 PM · Calendar, Bug Report
lpriestley added a revision to T13026: Stubs of recurring Calendar events should inherit the host's RSVP status: Unknown Object (Differential Revision).
Nov 28 2017, 9:03 PM · Calendar
lpriestley created T13026: Stubs of recurring Calendar events should inherit the host's RSVP status.
Nov 28 2017, 8:56 PM · Calendar
epriestley added a comment to T11860: Bot email addresses can't be edited.

Another variation of this is that "Mailing List" users' addresses also can't be edited from the web UI.

Nov 28 2017, 7:20 PM · Setup, People
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Nov 28 2017, 7:09 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Nov 28 2017, 6:45 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
mcote updated subscribers of Changelog.
Nov 28 2017, 6:13 PM
ox added a comment to T8918: Header shows number of notifications and various other controls on the 2FA auth screen.

Thank you very much!

Nov 28 2017, 6:11 PM · Security, Auth