Page MenuHomePhabricator
Feed Advanced Search

Aug 4 2017

dp_blockparty added a comment to T8787: Add support for U2F MFA once browser implementations improve and compatible hardware is more widely available.

I'd love to see support for U2F keys, as well.

Aug 4 2017, 2:29 AM · Haskell.org, Auth

Aug 3 2017

epriestley added a revision to T12904: Support Pact Errata: Restricted Differential Revision.
Aug 3 2017, 9:37 PM · Phacility, Support
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Aug 3 2017, 7:39 PM · Phacility, Support
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Aug 3 2017, 7:20 PM · Phacility, Support
epriestley added a revision to T12904: Support Pact Errata: Unknown Object (Differential Revision).
Aug 3 2017, 6:41 PM · Phacility, Support
epriestley merged T12950: Regenerating thumbnails for memes is difficult into T5258: Memes use older image transform code without modern error handling.
Aug 3 2017, 5:40 PM · Restricted Project, Files, Macros
epriestley merged task T12950: Regenerating thumbnails for memes is difficult into T5258: Memes use older image transform code without modern error handling.
Aug 3 2017, 5:40 PM · Feature Request, Macros
epriestley added a comment to T12950: Regenerating thumbnails for memes is difficult.

I'm just going to merge this into T5258. There are two separate issues here:

Aug 3 2017, 5:40 PM · Feature Request, Macros
chad added a comment to T12950: Regenerating thumbnails for memes is difficult.

This bug does exist on this server, but unclear why. Maybe related to size of image, but probably best solution is some command-line tool to regenerate all file transforms? I don't think making PHIDs easy to find inside the app is very user friendly.

Aug 3 2017, 5:31 PM · Feature Request, Macros
chad added a comment to T10252: Username autocompletion doesn't work with some non-US keyboard layouts.

fwiw, I can't reproduce this on OSX chrome any more. going to go test windows in german.... wish me glück.

Aug 3 2017, 4:42 PM · Restricted Project, Bug Report
epriestley renamed T12948: Remove the `bin/files purge` workflow from `bin/files purge` can run out of memory for large files to Remove the `bin/files purge` workflow.
Aug 3 2017, 2:53 PM · Bug Report, Files
epriestley added a comment to T12951: File transform regeneration should not rely on passing a query string to a CDN'able resource.

I retargeted this; I think the proposed solution is not the best solution we can find to the problem.

Aug 3 2017, 2:53 PM · Bug Report, Files, Setup
epriestley renamed T12951: File transform regeneration should not rely on passing a query string to a CDN'able resource from CloudFront documentation should recommend forwarding query string to File transform regeneration should not rely on passing a query string to a CDN'able resource.
Aug 3 2017, 2:52 PM · Bug Report, Files, Setup
hach-que added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

Doesn't look like the repository will even attempt to clone over HTTPS:

Aug 3 2017, 7:31 AM · Feature Request

Aug 2 2017

epriestley added a revision to T12928: Tokens in the form "v0.1" are not handled well by the MySQL FULLTEXT index: Unknown Object (Differential Revision).
Aug 2 2017, 11:03 PM · Customer Impact, Search
joshuaspence added a comment to T12950: Regenerating thumbnails for memes is difficult.
In T12950#230520, @chad wrote:

Why did they need regenerating in the first place?

Aug 2 2017, 9:40 PM · Feature Request, Macros
chad added a comment to T12950: Regenerating thumbnails for memes is difficult.

Why did they need regenerating in the first place?

Aug 2 2017, 9:38 PM · Feature Request, Macros
joshuaspence created T12951: File transform regeneration should not rely on passing a query string to a CDN'able resource.
Aug 2 2017, 9:24 PM · Bug Report, Files, Setup
joshuaspence created T12950: Regenerating thumbnails for memes is difficult.
Aug 2 2017, 9:12 PM · Feature Request, Macros
epriestley added a comment to T5523: Make bulk moves easier on Workboards.

See Planning for information on progress and priorities.

Aug 2 2017, 6:02 PM · Restricted Project, Workboards
brianespinosa added a comment to T5523: Make bulk moves easier on Workboards.

Any progress on this issue? Agreed with @dariusz that this is my number one pet peeve. This is a pretty large omission from bulk editing capabilities for a column. I can set a task to move to a different column when I am commenting in a task. I'd expect the ability to do the same bulk process on a column of tasks, even if I could only move those tasks within the same workboard. Dragging and dropping tasks individually is extremely time consuming when I have to move tasks between columns.

Aug 2 2017, 5:24 PM · Restricted Project, Workboards
chad edited projects for T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one, added: Profile Menu Item; removed Workboards.
Aug 2 2017, 5:19 PM · Dashboards
brianespinosa awarded T5523: Make bulk moves easier on Workboards a Like token.
Aug 2 2017, 5:18 PM · Restricted Project, Workboards
epriestley added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

This is an unusually low-tech solution but I can't think of any reasons why it won't work.

Aug 2 2017, 4:46 PM · Dashboards
chad added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

I'm obviously low on AM brian power today.

Aug 2 2017, 4:45 PM · Dashboards
epriestley renamed T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one from If a ProfileMenu has Link items, and one or more have request URI as the link target, highlight the first one to If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.
Aug 2 2017, 4:43 PM · Dashboards
rfreebern added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

Heh, that was going to be my suggestion in the original discourse post, but I figured it was too simplistic. Glad to hear we're on the same page. Thanks everyone!

Aug 2 2017, 4:42 PM · Dashboards
epriestley renamed T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one from Build a Workboard Query MenuItem? to If a ProfileMenu has Link items, and one or more have request URI as the link target, highlight the first one.
Aug 2 2017, 4:40 PM · Dashboards
chad added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

That sounds much easier than all the solutions I came up with.

Aug 2 2017, 4:39 PM · Dashboards
epriestley added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

Is there any reason that the rule "if any menu items have the same link target as the request URI, highlight the first one" wouldn't work?

Aug 2 2017, 4:37 PM · Dashboards
chad added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

Or maybe there is a simple way to get the link to highlight, I couldn't think of one though.

Aug 2 2017, 4:33 PM · Dashboards
chad added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.

A link doesn't stay highlighted if clicked on. Like dashboards, I can understand wanting multiple board views from the sidebar.

Aug 2 2017, 4:33 PM · Dashboards
epriestley added a comment to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.
  • What's the root problem?
  • Why can't they use links?
  • How is this different from T12374?
Aug 2 2017, 4:31 PM · Dashboards
chad triaged T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one as Wishlist priority.
Aug 2 2017, 4:22 PM · Dashboards
chad created T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one.
Aug 2 2017, 4:22 PM · Dashboards
chad closed T6797: Phabricator user group as Resolved.

Closing in favor of Discourse as the main user hangout spot for now.

Aug 2 2017, 4:22 PM · Public & Media Relations
epriestley triaged T12947: Hard to detect typos in *.edit endpoints as Wishlist priority.
Aug 2 2017, 2:58 PM · Conduit, ApplicationEditor
epriestley triaged T12948: Remove the `bin/files purge` workflow as Wishlist priority.

We should probably just remove this workflow, it's not clear to me that there's ever any reason for anyone to run bin/files purge in the modern codebase.

Aug 2 2017, 2:53 PM · Bug Report, Files
hach-que added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

Oh, I didn't even expect that option to be configurable on Phacility given it's a security related setting. I'll turn it on and do some speed tests next week to see if I get any measurable difference in cloning.

Aug 2 2017, 2:04 PM · Feature Request
bazilio91 awarded T12813: Integrate Harbormaster with GoCD a Love token.
Aug 2 2017, 12:57 PM · Harbormaster, Feature Request
epriestley added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

Have you enabled diffusion.allow-http-auth?

Aug 2 2017, 12:19 PM · Feature Request
joshuaspence created T12948: Remove the `bin/files purge` workflow.
Aug 2 2017, 12:08 PM · Bug Report, Files
avivey created T12947: Hard to detect typos in *.edit endpoints.
Aug 2 2017, 5:21 AM · Conduit, ApplicationEditor
hach-que added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

When you click Clone in the Phacility UI on a repository, it doesn't show any HTTPS URLs. It's possible it works if you copy the URL from the address bar, but the UI in Phacility itself doesn't give any kind of indication that it will work.

Aug 2 2017, 5:07 AM · Feature Request

Aug 1 2017

ivo added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

In the past there used to be a Browse button at the repository homepage in Diffusion. Clicking on it would show the file tree for the current branch and some extra buttons. You could then click Search to grep the file contents of the current branch.

Aug 1 2017, 6:45 PM · Diffusion, Design
chad added a comment to T10598: Options to display Real Name instead of username everywhere.

Feel free to use our Discourse for general admin questions (as opposed to our working tasks). Thank you!

Aug 1 2017, 6:16 PM · Feature Request
jessjohnson added a comment to T10598: Options to display Real Name instead of username everywhere.

@ofbeaton Thanks for the tips. Sounds better than the approach we are using to slightly modify the code base.

Aug 1 2017, 6:10 PM · Feature Request
epriestley added a comment to T12932: GC old Differential changesets into File storage.

Just keeping an eye on this: growth on these shards is slow and both are still below the 80% caution threshold, so I'm punting this for another week.

Aug 1 2017, 4:03 PM · Files, Differential, Phacility, Ops
epriestley closed T12946: When users `bin/remove destroy` a repository, emit a reminder message about paths on disk as Resolved by committing Restricted Diffusion Commit.
Aug 1 2017, 3:57 PM · Diffusion
epriestley added a revision to T12946: When users `bin/remove destroy` a repository, emit a reminder message about paths on disk: Unknown Object (Differential Revision).
Aug 1 2017, 3:53 PM · Diffusion
epriestley closed T12942: Add a "Binary Versions" page to Config as Resolved by committing Restricted Diffusion Commit.
Aug 1 2017, 2:14 PM · Config
NDKilla awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Aug 1 2017, 12:11 PM · Workboards (v3), Restricted Project
ofbeaton awarded T12718: Local email validation with apostrophe a Like token.
Aug 1 2017, 5:23 AM · Bug Report
ofbeaton added a comment to T10598: Options to display Real Name instead of username everywhere.

@jessjohnson We use puppet to deploy phabricator stable from a copy on a local file server, then have it run a shell script that applies our patches using git apply on .patch files. Lastly we restart services.

Aug 1 2017, 5:18 AM · Feature Request
jessjohnson added a comment to T10598: Options to display Real Name instead of username everywhere.

@ofbeaton Just curious what's your strategy on applying patches as part of your deployment for phabricator? Do you use a find/replace strategy? Apply diffs?

Aug 1 2017, 3:03 AM · Feature Request

Jul 31 2017

epriestley created T12946: When users `bin/remove destroy` a repository, emit a reminder message about paths on disk.
Jul 31 2017, 9:07 PM · Diffusion
avivey awarded T12942: Add a "Binary Versions" page to Config a 100 token.
Jul 31 2017, 7:50 PM · Config
epriestley added a revision to T12942: Add a "Binary Versions" page to Config: Unknown Object (Differential Revision).
Jul 31 2017, 7:23 PM · Config
epriestley added a revision to T12942: Add a "Binary Versions" page to Config: Unknown Object (Differential Revision).
Jul 31 2017, 7:19 PM · Config
epriestley closed T12945: "Mismatched origin" error on pulls may show credentials when origins have HTTP credentials as Resolved by committing Restricted Diffusion Commit.
Jul 31 2017, 4:43 PM · Diffusion
epriestley added a revision to T12945: "Mismatched origin" error on pulls may show credentials when origins have HTTP credentials: Unknown Object (Differential Revision).
Jul 31 2017, 4:42 PM · Diffusion
epriestley added a project to T12945: "Mismatched origin" error on pulls may show credentials when origins have HTTP credentials: Diffusion.
Jul 31 2017, 2:07 PM · Diffusion
epriestley created T12945: "Mismatched origin" error on pulls may show credentials when origins have HTTP credentials.
Jul 31 2017, 2:07 PM · Diffusion
joshuaspence added a revision to T12919: Healthcheck endpoint for alternate file domain: Unknown Object (Differential Revision).
Jul 31 2017, 11:13 AM · Files
joshuaspence added a comment to T10214: Daemons try and fail to publish transactions for newly created diffs.

I'm seeing these errors failing regularly:

Jul 31 2017, 10:17 AM · Bug Report
joshuaspence added a revision to T8591: Undefined index in changeset parser: Unknown Object (Differential Revision).
Jul 31 2017, 7:56 AM · Differential
joshuaspence reopened T8591: Undefined index in changeset parser as "Open".

I've got a reproduction case for this now: https://secure.phabricator.com/differential/diff/44008/

Jul 31 2017, 7:49 AM · Differential

Jul 30 2017

joshuaspence added a revision to T11480: Stop sending misbehaving user nonsense to the error log: Unknown Object (Differential Revision).
Jul 30 2017, 10:05 PM
epriestley closed T12943: titulo de ejemplo as Invalid.
Jul 30 2017, 1:55 PM
epriestley closed T12944: titulo de ejemplo as Invalid.
Jul 30 2017, 1:55 PM
• sanacl created T12944: titulo de ejemplo.
Jul 30 2017, 1:49 PM
• sanacl created T12943: titulo de ejemplo.
Jul 30 2017, 1:47 PM

Jul 29 2017

epriestley added a comment to T11456: Don't lose user in NUX flow because of Timezone issues.

Most browsers can only give us a timezone offset, like "UTC-7", not a locale name like "America/Los_Angeles". We already attempt to read this value (D15962, T3025#176547) but when I wrote that stuff it was only available in Chrome and not necessarily reliable. We do try to guess the default zone selection based on the information we get from the browser, but currently ask the user to confirm it in all cases.

Jul 29 2017, 12:40 PM · Design, Phacility, NUX
avivey added a comment to T11456: Don't lose user in NUX flow because of Timezone issues.

I was thinking that the first time they log in, we just take the browser timezone and set the user config to that.

Jul 29 2017, 3:46 AM · Design, Phacility, NUX
kfsone added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

@epriestly I'd lost that connection, so reachability, it might appear.

Jul 29 2017, 2:15 AM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

@kfsone Are you aware of arc diff --only (briefly mentioned above -- "just generate a diff to look at in the web UI, without other slow/complicated steps")? How do you picture arc selfreview differing from arc diff --only?

Jul 29 2017, 2:03 AM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential

Jul 28 2017

kfsone added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

@epriestley I think you under-estimate the potential and value of your own product.

Jul 28 2017, 10:55 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley edited the content of Changelog.
Jul 28 2017, 10:24 PM
epriestley created 2017 Week 30 (Very Late July).
Jul 28 2017, 10:17 PM
epriestley added a comment to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs.

The simplest way to approach this is probably to do double writes: start writing the new tables, switch readers over, stop writing the old tables.

Jul 28 2017, 9:46 PM · Customer Impact, Diffusion, Bug Report
epriestley renamed T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs from "The ref "master" is ambiguous in this repository" in rP to Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs.
Jul 28 2017, 6:37 PM · Customer Impact, Diffusion, Bug Report
epriestley added a comment to T12942: Add a "Binary Versions" page to Config.

This could also just go on the existing page at the bottom. We tell people to copy/paste it when submitting bug reports, but it's probably fine if they're including more information, especially since there is a nice walled garden moat around my personally having to deal with it.

Jul 28 2017, 6:20 PM · Config
epriestley added a comment to T12942: Add a "Binary Versions" page to Config.

See also PHI22.

Jul 28 2017, 6:18 PM · Config
epriestley created T12942: Add a "Binary Versions" page to Config.
Jul 28 2017, 6:15 PM · Config
chad changed the status of T12939: Ponder seems to ignore all email settings from Duplicate to Resolved by committing Restricted Diffusion Commit.
Jul 28 2017, 1:57 PM · Bug Report, Ponder
epriestley added a comment to T2383: Run PHP environment checks from CLI.

T12941 is a third case of a user with no mysql or mysqli.

Jul 28 2017, 10:55 AM · Setup
epriestley merged T12941: missing mysql extension incredibly difficult to debug into T2383: Run PHP environment checks from CLI.
Jul 28 2017, 10:54 AM · Setup
epriestley merged task T12941: missing mysql extension incredibly difficult to debug into T2383: Run PHP environment checks from CLI.
Jul 28 2017, 10:54 AM
allixsenos updated the task description for T12941: missing mysql extension incredibly difficult to debug.
Jul 28 2017, 9:05 AM
allixsenos renamed T12941: missing mysql extension incredibly difficult to debug from wrong php cli version incredibly difficult to debug to missing mysql extension incredibly difficult to debug.
Jul 28 2017, 8:31 AM
allixsenos created T12941: missing mysql extension incredibly difficult to debug.
Jul 28 2017, 8:30 AM
chad closed T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way as Resolved by committing Restricted Diffusion Commit.
Jul 28 2017, 2:24 AM · Firefox, Bug Report

Jul 27 2017

chad added a comment to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.

Let me know if that diff works.

Jul 27 2017, 10:14 PM · Firefox, Bug Report
chad added a revision to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way: Unknown Object (Differential Revision).
Jul 27 2017, 10:14 PM · Firefox, Bug Report
chad added a comment to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.

I honestly can't get the cool looking macos dropdown on firefox no matter what I try.

Jul 27 2017, 10:07 PM · Firefox, Bug Report
chad added a revision to T12939: Ponder seems to ignore all email settings: Unknown Object (Differential Revision).
Jul 27 2017, 9:32 PM · Bug Report, Ponder
epriestley added a comment to T12940: Account Setup Issues shown to users before signing TOS.

The particulars in T8918 are slightly different, but the root issue (showing too much stuff to users with partial sessions) is the same.

Jul 27 2017, 9:24 PM
epriestley merged T12940: Account Setup Issues shown to users before signing TOS into T8918: Header shows number of notifications and various other controls on the 2FA auth screen.
Jul 27 2017, 9:23 PM · Security, Auth
epriestley merged task T12940: Account Setup Issues shown to users before signing TOS into T8918: Header shows number of notifications and various other controls on the 2FA auth screen.
Jul 27 2017, 9:23 PM
isfs added a comment to T12629: Start daemons that should be running but aren't.

Agreed. I haven't experienced the problem since I upgraded, so I think it was related to an earlier fix, even if it wasn't the identified fix (which should have already been in my install when I did have the problems). There's nothing that needs to be addressed here.

Jul 27 2017, 9:22 PM · Daemons, Feature Request