Oh maybe I forgetful. Anything can track progress.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jun 6 2017
Because they track progress.
Why would you want to set those up as milestones instead of subprojects?
@epriestley do you still feel strongly to not do this? I presume it's just gated and easy to ship.
(None of this impacts anything outside the ops realm in any way, except that some of the admin/ops-flavored UIs are changing a little.)
There will be a final written exam on June 19th.
Just to clarify, it's ok that I'm not following, nor understand any of this, correct?
Oh. My. God.
(Slightly related: I killed the test-nat instance this morning since it doesn't help actually test the NAT).
Er, that was rCORE085cd7e4 but I typed D instead of T.
I inched us forward on getting EC2 and Almanac to agree with one another, but need T12414 to make much more headway:
I can't reproduce this. Here's what I tried:
It doesn't try to run evil.exe until I edit the cell (the csv version, and the modified xlsx I saved myself try to start on opening).
Here's a version with =cmd|'/C evil.exe'!A0 if that produces different results:
Actually, Excel 2016 is vulnerable. The test case is incomplete. The cell needs to be =cmd|'/C evil.exe'!A0 to trigger the issue.
By modifying the value in both the xlsx and csv files, I was able to blindly click yes on lots of warning prompts and start calc.exe. But I am not sure that modifying the value in the xlsx file is giving the same result as the export would (something may have been stripped off in the meantime...)
It seems an up to date patched Excel 2016 is not vulnerable.
Saving this file as csv also doesn't trigger the bug in Excel 2016 - on reopening, Excel misdetects the format as SYLK, warns about the extension not matching, then warns that an error occured during loading, and finally when you agree to continue loading as "a different format", it opens without running calc.exe or prompting to update cells.
Some of the syntax has changed slightly from the above, but I think the overall plan remains basically correct.
phage remote status --pools db,repo and such work now, using Conduit credentials from the bastion to query admin. We can swap that stuff later if we want to switch to EC2.
As far as pulling this state from EC2, it's really easy to fetch the list of hosts that have a given tag: http://docs.aws.amazon.com/cli/latest/reference/ec2/describe-instances.html
Jun 5 2017
Come up with a plan for where phage --pool repo is going to get the host list from.
Good to hear, thanks!
Checked on Excel 2016 and it didn't run calc.exe or prompt for "update cells". Also checked on Excel for mac~
Oh, I see what you're saying. Yeah, whatever logical naming scheme we come up with, we should block that pattern for display names.
If anyone actually has bona fide Excel.exe installed, you could try opening this file to double check that we're not currently vulnerable:
I think I disagree with this but I want to be sure about what you're saying.
If we stop generating internal IDs from instance names, I think we should pick a generation scheme such that they can not ever collide
If we stop generating internal IDs from instance names, I think we should pick a generation scheme such that they can not ever collide -- backups/ErrantAnalyticalGiraffe/ on disk should never exist and be a different instance than ErrantAnalyticalGiraffe.phacility.com in the web (technically these namespaces are different today because you can not use uppercase letters in an instance name, but that feels very flimsy as a dividing line).
FWIW, I'm heavily in favor of the "display rename" approach, and allocating logical ids like ErrantAnalyticalGiraffe. Breaking the coupling between instance display name and its backing resources is a band-aid that will only get more painful to remove after we launch private instances.
Another adjacent piece of work here is automating provisioning (e.g., through autoscale groups or bin/provision) but I think we should mostly leave that for the future too since we're theoretically bringing up only one new host (or maybe two, natXXX + repoXXX). Many of the other changes here give us tools toward that anyway, and it would probably be better to pursue that as part of a future change that involves launching a larger number of new hosts (e.g., chassis swap on the whole tier).
I plan to take these steps specifically:
@amckinley, I'd like to try to do this as part of T12798. Here's my rough understanding of what we need to do:
To summarize where we've ended up:
The general shape of the change is reasonable. However:
Thanks for updating your report with reproduction instructions, they were very helpful in reproducing and fixing the bug.
@epriestley I know you've said no on accepting a patch for this one, but we've found that without the "author" field sent to Buildkite it's not very useful.
I have added some more details. Let me know if you need any more.
Ok sorry, I will improve the report.
Specifically we need steps to reproduce the issue. I don't know what "the pages" means, or where you expect an edit page to be found. We have lots of applications and fields that URIs could be in.
Please read and follow Contributing Bug Reports, we don't accept incomplete bug reports.
Jun 4 2017
Nevermind, found another task. Thanks!
Does this reproduct against an up to date version of Phabricator?
Jun 3 2017
Slightest of issues with the repository indexing mentioned above:
luca:~/phabricator$ ./bin/search index --type repository --force Usage Exception: Type "repository" matches multiple indexable objects. Use a more specific string. Matching object types are: PhabricatorRepository, PhabricatorRepositoryCommit. luca:~/phabricator$
Jun 2 2017
D18069 appears to fix this, but I want to understand where it blames to and possibly pursue a more graceful fix since D18069 feels a little flimsy.
Arguments against:
Thank you for the helpful summary. The Discouraged creative solution worked for me. I expect this will be a one off, if it is not I'll try and setup some ignored phrases.
If you want to type sequences like O2 without triggering remarkup, you can:
I was trying to type the phrases "visible within O2's network" and "the O2 SIM card" but something is interpreting the company name as markup. I could type "visible within O2's network" but that seems a little odd. Is there a better solution for this off edge case?
We haven't received more information on this, so we don't know how to reproduce it and can't move forward. Feel free to file a new issue in the future with complete reproduction steps, per above.
We don't know how to reproduce this, so we can't move forward, and haven't received more information in several days.
We don't know how to reproduce this, and haven't received more information in several days.
This appears to have been resolved by D18042. I'm letting the mail stuff fall by the wayside for now.
I can't reproduce this at HEAD, so presuming this was resolved by rP7b290b94a7.
Same here with a german umlaut ("ä") in the file name.