Page MenuHomePhabricator
Feed Advanced Search

Jun 6 2017

chad added a comment to T12144: Ability to reorder milestones on a project's workboard.

Oh maybe I forgetful. Anything can track progress.

Jun 6 2017, 6:37 PM · Projects, Feature Request
chad added a comment to T12144: Ability to reorder milestones on a project's workboard.

Because they track progress.

Jun 6 2017, 6:36 PM · Projects, Feature Request
epriestley added a comment to T12144: Ability to reorder milestones on a project's workboard.

Why would you want to set those up as milestones instead of subprojects?

Jun 6 2017, 6:36 PM · Projects, Feature Request
chad added a comment to T12144: Ability to reorder milestones on a project's workboard.

@epriestley do you still feel strongly to not do this? I presume it's just gated and easy to ship.

Jun 6 2017, 6:34 PM · Projects, Feature Request
epriestley added a comment to T12798: Decommission cluster host `repo012`.

(None of this impacts anything outside the ops realm in any way, except that some of the admin/ops-flavored UIs are changing a little.)

Jun 6 2017, 4:32 PM · Ops, Phacility
epriestley added a comment to T12798: Decommission cluster host `repo012`.

There will be a final written exam on June 19th.

Jun 6 2017, 4:29 PM · Ops, Phacility
chad added a comment to T12798: Decommission cluster host `repo012`.

Just to clarify, it's ok that I'm not following, nor understand any of this, correct?

Jun 6 2017, 4:22 PM · Ops, Phacility
amckinley added a comment to T12798: Decommission cluster host `repo012`.

Oh. My. God.

Jun 6 2017, 3:49 PM · Ops, Phacility
epriestley added a comment to T12798: Decommission cluster host `repo012`.

Jun 6 2017, 3:43 PM · Ops, Phacility
amckinley added a comment to T12798: Decommission cluster host `repo012`.

(Slightly related: I killed the test-nat instance this morning since it doesn't help actually test the NAT).

Jun 6 2017, 3:41 PM · Ops, Phacility
epriestley added a revision to T11670: Automate more of the migration process for moving instances across shards in the Phacility cluster: Restricted Differential Revision.
Jun 6 2017, 3:27 PM · Ops, Phacility
epriestley added a revision to T11670: Automate more of the migration process for moving instances across shards in the Phacility cluster: Unknown Object (Differential Revision).
Jun 6 2017, 1:22 PM · Ops, Phacility
epriestley added a revision to T11670: Automate more of the migration process for moving instances across shards in the Phacility cluster: Unknown Object (Differential Revision).
Jun 6 2017, 12:39 PM · Ops, Phacility
epriestley added a comment to T12798: Decommission cluster host `repo012`.

Er, that was rCORE085cd7e4 but I typed D instead of T.

Jun 6 2017, 11:20 AM · Ops, Phacility
epriestley added a comment to T12798: Decommission cluster host `repo012`.

I inched us forward on getting EC2 and Almanac to agree with one another, but need T12414 to make much more headway:

Jun 6 2017, 11:20 AM · Ops, Phacility
epriestley edited projects for T12802: Schemata error after updating, added: Bug Report (Needs Information); removed Bug Report.

I can't reproduce this. Here's what I tried:

Jun 6 2017, 10:28 AM · Bug Report (Needs Information)
davidgiga1993 created T12802: Schemata error after updating.
Jun 6 2017, 6:30 AM · Bug Report (Needs Information)
jasonrumney added a comment to T12800: When Excel opens a CSV file, it just runs whatever arbitrary code might be in the file.

It doesn't try to run evil.exe until I edit the cell (the csv version, and the modified xlsx I saved myself try to start on opening).

Jun 6 2017, 3:45 AM · Security
epriestley added a comment to T12800: When Excel opens a CSV file, it just runs whatever arbitrary code might be in the file.

Here's a version with =cmd|'/C evil.exe'!A0 if that produces different results:

Jun 6 2017, 3:35 AM · Security
jasonrumney added a comment to T12800: When Excel opens a CSV file, it just runs whatever arbitrary code might be in the file.

Actually, Excel 2016 is vulnerable. The test case is incomplete. The cell needs to be =cmd|'/C evil.exe'!A0 to trigger the issue.
By modifying the value in both the xlsx and csv files, I was able to blindly click yes on lots of warning prompts and start calc.exe. But I am not sure that modifying the value in the xlsx file is giving the same result as the export would (something may have been stripped off in the meantime...)

Jun 6 2017, 3:33 AM · Security
jasonrumney added a comment to T12800: When Excel opens a CSV file, it just runs whatever arbitrary code might be in the file.

It seems an up to date patched Excel 2016 is not vulnerable.

Jun 6 2017, 3:10 AM · Security
jasonrumney added a comment to T12800: When Excel opens a CSV file, it just runs whatever arbitrary code might be in the file.

Saving this file as csv also doesn't trigger the bug in Excel 2016 - on reopening, Excel misdetects the format as SYLK, warns about the extension not matching, then warns that an error occured during loading, and finally when you agree to continue loading as "a different format", it opens without running calc.exe or prompting to update cells.

Jun 6 2017, 3:04 AM · Security
epriestley added a comment to T11670: Automate more of the migration process for moving instances across shards in the Phacility cluster.

Some of the syntax has changed slightly from the above, but I think the overall plan remains basically correct.

Jun 6 2017, 1:19 AM · Ops, Phacility
epriestley added a comment to T12798: Decommission cluster host `repo012`.

phage remote status --pools db,repo and such work now, using Conduit credentials from the bastion to query admin. We can swap that stuff later if we want to switch to EC2.

Jun 6 2017, 1:03 AM · Ops, Phacility
amckinley added a comment to T12798: Decommission cluster host `repo012`.

As far as pulling this state from EC2, it's really easy to fetch the list of hosts that have a given tag: http://docs.aws.amazon.com/cli/latest/reference/ec2/describe-instances.html

Jun 6 2017, 12:09 AM · Ops, Phacility

Jun 5 2017

epriestley added a comment to T12798: Decommission cluster host `repo012`.

Come up with a plan for where phage --pool repo is going to get the host list from.

Jun 5 2017, 11:53 PM · Ops, Phacility
epriestley added a revision to T12798: Decommission cluster host `repo012`: Restricted Differential Revision.
Jun 5 2017, 11:15 PM · Ops, Phacility
epriestley created T12801: Simplify Almanac services in the Phacility production cluster.
Jun 5 2017, 11:07 PM · Almanac, Ops, Phacility
epriestley added a comment to T12800: When Excel opens a CSV file, it just runs whatever arbitrary code might be in the file.

Good to hear, thanks!

Jun 5 2017, 10:16 PM · Security
cspeckmim added a comment to T12800: When Excel opens a CSV file, it just runs whatever arbitrary code might be in the file.

Checked on Excel 2016 and it didn't run calc.exe or prompt for "update cells". Also checked on Excel for mac~

Jun 5 2017, 9:27 PM · Security
epriestley added a revision to T12798: Decommission cluster host `repo012`: Unknown Object (Differential Revision).
Jun 5 2017, 9:05 PM · Ops, Phacility
epriestley added a revision to T11413: Support renaming Phacility instances: Unknown Object (Differential Revision).
Jun 5 2017, 9:05 PM · Phacility
amckinley added a comment to T11413: Support renaming Phacility instances.

Oh, I see what you're saying. Yeah, whatever logical naming scheme we come up with, we should block that pattern for display names.

Jun 5 2017, 8:53 PM · Phacility
epriestley added a comment to T12800: When Excel opens a CSV file, it just runs whatever arbitrary code might be in the file.

If anyone actually has bona fide Excel.exe installed, you could try opening this file to double check that we're not currently vulnerable:

Jun 5 2017, 8:35 PM · Security
epriestley created T12800: When Excel opens a CSV file, it just runs whatever arbitrary code might be in the file.
Jun 5 2017, 8:31 PM · Security
epriestley added a comment to T11413: Support renaming Phacility instances.

I think I disagree with this but I want to be sure about what you're saying.

Jun 5 2017, 8:04 PM · Phacility
amckinley added a comment to T11413: Support renaming Phacility instances.

If we stop generating internal IDs from instance names, I think we should pick a generation scheme such that they can not ever collide

Jun 5 2017, 7:49 PM · Phacility
epriestley created T12799: Consider an "API Utilities" application.
Jun 5 2017, 7:36 PM · Conduit
epriestley added a comment to T11413: Support renaming Phacility instances.

If we stop generating internal IDs from instance names, I think we should pick a generation scheme such that they can not ever collide -- backups/ErrantAnalyticalGiraffe/ on disk should never exist and be a different instance than ErrantAnalyticalGiraffe.phacility.com in the web (technically these namespaces are different today because you can not use uppercase letters in an instance name, but that feels very flimsy as a dividing line).

Jun 5 2017, 7:25 PM · Phacility
amckinley added a comment to T11413: Support renaming Phacility instances.

FWIW, I'm heavily in favor of the "display rename" approach, and allocating logical ids like ErrantAnalyticalGiraffe. Breaking the coupling between instance display name and its backing resources is a band-aid that will only get more painful to remove after we launch private instances.

Jun 5 2017, 7:00 PM · Phacility
epriestley added a comment to T12798: Decommission cluster host `repo012`.

Another adjacent piece of work here is automating provisioning (e.g., through autoscale groups or bin/provision) but I think we should mostly leave that for the future too since we're theoretically bringing up only one new host (or maybe two, natXXX + repoXXX). Many of the other changes here give us tools toward that anyway, and it would probably be better to pursue that as part of a future change that involves launching a larger number of new hosts (e.g., chassis swap on the whole tier).

Jun 5 2017, 6:57 PM · Ops, Phacility
epriestley added a project to T12798: Decommission cluster host `repo012`: Ops.
Jun 5 2017, 6:51 PM · Ops, Phacility
epriestley added a comment to T12798: Decommission cluster host `repo012`.

I plan to take these steps specifically:

Jun 5 2017, 6:49 PM · Ops, Phacility
epriestley updated subscribers of T11336: Provide a stable address range for Phacility outbound requests.

@amckinley, I'd like to try to do this as part of T12798. Here's my rough understanding of what we need to do:

Jun 5 2017, 6:26 PM · Customer Impact
epriestley created T12798: Decommission cluster host `repo012`.
Jun 5 2017, 6:15 PM · Ops, Phacility
epriestley updated the task description for T12797: jeux.
Jun 5 2017, 5:02 PM · Feature Request
epriestley closed T12797: jeux as Invalid.
Jun 5 2017, 5:02 PM · Feature Request
• david.lebert.60 created T12797: jeux.
Jun 5 2017, 4:57 PM · Feature Request
epriestley created an object: C148: Host "repo012" Explodes, Killing All Aboard.
Jun 5 2017, 4:54 PM
• david.lebert.60 removed a watcher for Phacility High Command: • david.lebert.60.
Jun 5 2017, 4:52 PM
• david.lebert.60 added a watcher for Phacility High Command: • david.lebert.60.
Jun 5 2017, 4:52 PM
epriestley closed T12796: Ambiguous URL rejection broke existing remarkup blocks with: [[ <ambigous URI> ... ]] as Resolved by committing Restricted Diffusion Commit.
Jun 5 2017, 4:41 PM · Remarkup, Bug Report
epriestley added a comment to T12251: Add author information when creating a build in Buildkite.

To summarize where we've ended up:

Jun 5 2017, 4:04 PM · Harbormaster, Feature Request
epriestley added a comment to T12251: Add author information when creating a build in Buildkite.

The general shape of the change is reasonable. However:

Jun 5 2017, 3:45 PM · Harbormaster, Feature Request
epriestley awarded Bug Meister to recipient: jbeck.
Jun 5 2017, 12:52 PM
epriestley edited projects for T12796: Ambiguous URL rejection broke existing remarkup blocks with: [[ <ambigous URI> ... ]] , added: Bug Report, Remarkup; removed Bug Report (Needs Information).
Jun 5 2017, 12:52 PM · Remarkup, Bug Report
epriestley renamed T12796: Ambiguous URL rejection broke existing remarkup blocks with: [[ <ambigous URI> ... ]] from Ambiguous URL rejection broke some phriction pages to Ambiguous URL rejection broke existing remarkup blocks with: [[ <ambigous URI> ... ]] .
Jun 5 2017, 12:51 PM · Remarkup, Bug Report
epriestley added a comment to T12796: Ambiguous URL rejection broke existing remarkup blocks with: [[ <ambigous URI> ... ]] .

Thanks for updating your report with reproduction instructions, they were very helpful in reproducing and fixing the bug.

Jun 5 2017, 12:51 PM · Remarkup, Bug Report
epriestley added a revision to T12796: Ambiguous URL rejection broke existing remarkup blocks with: [[ <ambigous URI> ... ]] : Unknown Object (Differential Revision).
Jun 5 2017, 12:48 PM · Remarkup, Bug Report
epriestley claimed T12796: Ambiguous URL rejection broke existing remarkup blocks with: [[ <ambigous URI> ... ]] .
Jun 5 2017, 12:39 PM · Remarkup, Bug Report
toolmantim added a comment to T12251: Add author information when creating a build in Buildkite.

@epriestley I know you've said no on accepting a patch for this one, but we've found that without the "author" field sent to Buildkite it's not very useful.

Jun 5 2017, 9:52 AM · Harbormaster, Feature Request
toolmantim added a revision to T12251: Add author information when creating a build in Buildkite: Unknown Object (Differential Revision).
Jun 5 2017, 9:46 AM · Harbormaster, Feature Request
jbeck renamed T12796: Ambiguous URL rejection broke existing remarkup blocks with: [[ <ambigous URI> ... ]] from Ambiguous URL rejection broke some pages to Ambiguous URL rejection broke some phriction pages.
Jun 5 2017, 6:39 AM · Remarkup, Bug Report
jbeck added a comment to T12796: Ambiguous URL rejection broke existing remarkup blocks with: [[ <ambigous URI> ... ]] .

I have added some more details. Let me know if you need any more.

Jun 5 2017, 6:28 AM · Remarkup, Bug Report
jbeck updated the task description for T12796: Ambiguous URL rejection broke existing remarkup blocks with: [[ <ambigous URI> ... ]] .
Jun 5 2017, 6:28 AM · Remarkup, Bug Report
jbeck added a comment to T12796: Ambiguous URL rejection broke existing remarkup blocks with: [[ <ambigous URI> ... ]] .

Ok sorry, I will improve the report.

Jun 5 2017, 6:22 AM · Remarkup, Bug Report
chad edited projects for T12796: Ambiguous URL rejection broke existing remarkup blocks with: [[ <ambigous URI> ... ]] , added: Bug Report (Needs Information); removed Bug Report.
Jun 5 2017, 6:21 AM · Remarkup, Bug Report
chad added a comment to T12796: Ambiguous URL rejection broke existing remarkup blocks with: [[ <ambigous URI> ... ]] .

Specifically we need steps to reproduce the issue. I don't know what "the pages" means, or where you expect an edit page to be found. We have lots of applications and fields that URIs could be in.

Jun 5 2017, 6:21 AM · Remarkup, Bug Report
chad added a comment to T12796: Ambiguous URL rejection broke existing remarkup blocks with: [[ <ambigous URI> ... ]] .

Please read and follow Contributing Bug Reports, we don't accept incomplete bug reports.

Jun 5 2017, 6:11 AM · Remarkup, Bug Report
jbeck created T12796: Ambiguous URL rejection broke existing remarkup blocks with: [[ <ambigous URI> ... ]] .
Jun 5 2017, 6:00 AM · Remarkup, Bug Report

Jun 4 2017

chad created T12795: Move PHUICircleView to PHUIButtonView.
Jun 4 2017, 10:59 PM · PHUI
chad updated the image for Design from F1064783: profile to F4988944: profile.
Jun 4 2017, 8:38 PM
chad added a comment to T12794: [Buildkite] Correct user identity not provided to Buildkite.

Nevermind, found another task. Thanks!

Jun 4 2017, 12:53 AM · Bug Report
chad merged task T12794: [Buildkite] Correct user identity not provided to Buildkite into T12251: Add author information when creating a build in Buildkite.
Jun 4 2017, 12:53 AM · Bug Report
chad merged T12794: [Buildkite] Correct user identity not provided to Buildkite into T12251: Add author information when creating a build in Buildkite.
Jun 4 2017, 12:53 AM · Harbormaster, Feature Request
chad added a comment to T12794: [Buildkite] Correct user identity not provided to Buildkite.

Does this reproduct against an up to date version of Phabricator?

Jun 4 2017, 12:53 AM · Bug Report
KevinGrandon created T12794: [Buildkite] Correct user identity not provided to Buildkite.
Jun 4 2017, 12:40 AM · Bug Report

Jun 3 2017

• sshannin added a comment to T12493: Upgrading: Fulltext Search Services.

Slightest of issues with the repository indexing mentioned above:

luca:~/phabricator$ ./bin/search index --type repository --force
Usage Exception: Type "repository" matches multiple indexable objects. Use a more specific string. Matching object types are: PhabricatorRepository, PhabricatorRepositoryCommit.
luca:~/phabricator$
Jun 3 2017, 3:52 PM · Elasticsearch, Search, Guides
epriestley added a revision to T12733: (2017 Week 20) Inline Comments Errata / Feedback: Unknown Object (Differential Revision).
Jun 3 2017, 1:25 PM · Inline Comments, Installing & Upgrading, Differential
aurelijus awarded T12785: Arc unit command fails with PHPUnit 6 a Like token.
Jun 3 2017, 5:52 AM · Arcanist, Bug Report

Jun 2 2017

epriestley added a comment to T12793: Unable to move Phriction documents.

D18069 appears to fix this, but I want to understand where it blames to and possibly pursue a more graceful fix since D18069 feels a little flimsy.

Jun 2 2017, 11:28 PM · Customer Impact, Bug Report, Phriction
epriestley added a revision to T12793: Unable to move Phriction documents: Unknown Object (Differential Revision).
Jun 2 2017, 11:14 PM · Customer Impact, Bug Report, Phriction
epriestley added a comment to T12792: Consider an option to disable all popup notifications.

Arguments against:

Jun 2 2017, 11:03 PM · Feature Request, Customer Impact, Notifications
epriestley claimed T12793: Unable to move Phriction documents.
Jun 2 2017, 10:50 PM · Customer Impact, Bug Report, Phriction
chad created T12793: Unable to move Phriction documents.
Jun 2 2017, 10:44 PM · Customer Impact, Bug Report, Phriction
epriestley created T12792: Consider an option to disable all popup notifications.
Jun 2 2017, 10:40 PM · Feature Request, Customer Impact, Notifications
epriestley edited the content of Changelog.
Jun 2 2017, 8:20 PM
epriestley created 2017 Week 22 (Very Early June).
Jun 2 2017, 8:19 PM
TafThorne added a comment to T5301: Inline Remarkup escaping.

Thank you for the helpful summary. The Discouraged creative solution worked for me. I expect this will be a one off, if it is not I'll try and setup some ignored phrases.

Jun 2 2017, 3:35 PM · Remarkup
epriestley added a comment to T5301: Inline Remarkup escaping.

If you want to type sequences like O2 without triggering remarkup, you can:

Jun 2 2017, 3:17 PM · Remarkup
TafThorne added a comment to T5301: Inline Remarkup escaping.

I was trying to type the phrases "visible within O2's network" and "the O2 SIM card" but something is interpreting the company name as markup. I could type "visible within O2's network" but that seems a little odd. Is there a better solution for this off edge case?

Jun 2 2017, 2:26 PM · Remarkup
fanis created T12791: Ctrl+Enter in inline fullscreen editor leaves overlay visible after form submission .
Jun 2 2017, 1:31 PM · Bug Report
epriestley closed T12748: Duplicated comments on JIRA when differential revisions are linked to JIRA issues, a subtask of T5422: Does Phabricator integrate with JIRA?, as Invalid.
Jun 2 2017, 11:21 AM · Guides, Doorkeeper
epriestley closed T12748: Duplicated comments on JIRA when differential revisions are linked to JIRA issues as Invalid.

We haven't received more information on this, so we don't know how to reproduce it and can't move forward. Feel free to file a new issue in the future with complete reproduction steps, per above.

Jun 2 2017, 11:21 AM · Bug Report (Needs Information), Doorkeeper
epriestley closed T12764: Git clone suddenly timeouts on accounts with newly uploaded ssh keys as Invalid.

We don't know how to reproduce this, so we can't move forward, and haven't received more information in several days.

Jun 2 2017, 11:19 AM · Bug Report (Needs Information)
epriestley closed T12773: User image is found broken on migrating to the latest version of Phabricator. as Invalid.

We don't know how to reproduce this, and haven't received more information in several days.

Jun 2 2017, 11:18 AM · Bug Report (Needs Information)
epriestley closed T12776: Pholio's "replace" transaction does not attach files properly after refactoring as Resolved.

This appears to have been resolved by D18042. I'm letting the mail stuff fall by the wayside for now.

Jun 2 2017, 11:17 AM · Bug Report, Pholio
epriestley closed T12786: New Revisions of Images in Pholio Mocks are not visible for other users.... as Invalid.

I can't reproduce this at HEAD, so presuming this was resolved by rP7b290b94a7.

Jun 2 2017, 11:16 AM · Pholio, Bug Report
epriestley added a revision to T12733: (2017 Week 20) Inline Comments Errata / Feedback: Unknown Object (Differential Revision).
Jun 2 2017, 11:12 AM · Inline Comments, Installing & Upgrading, Differential
• 1stone added a comment to T8747: "Path Does Not Exist" error caused by not standard characters.

Same here with a german umlaut ("ä") in the file name.

Jun 2 2017, 11:04 AM · Diffusion