Page MenuHomePhabricator
Feed Advanced Search

Dec 29 2016

epriestley added a comment to T11114: Move Differential to EditEngine.

So should Arcanist be modified to just call differential.revision.edit directly then?

Dec 29 2016, 3:50 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley moved T11738: Improve the heuristic which guesses which function/method/class line best provides context for diff snippets from Future Work to Far Future Work on the Differential board.
Dec 29 2016, 3:41 PM · Differential, Feature Request
epriestley moved T11738: Improve the heuristic which guesses which function/method/class line best provides context for diff snippets from Backlog to Future Work on the Differential board.
Dec 29 2016, 3:41 PM · Differential, Feature Request
epriestley moved T12010: Untangle the Gordian Knot of iterating on Differential/Diffusion/Arcanist from Backlog to v3 (Infrastructure) on the Differential board.
Dec 29 2016, 3:41 PM · Diffusion (v3), Arcanist, Differential
epriestley moved T12027: Replace "Next Step" Differential advice with comprehensive instructions on "Land Revision" from Backlog to Future Work on the Differential board.
Dec 29 2016, 3:41 PM · Differential
epriestley moved T12026: Replace "apply patch" Differential advice with comprehensive instructions on "Download Raw Diff" from Backlog to Future Work on the Differential board.
Dec 29 2016, 3:41 PM · Differential
epriestley moved T12033: Large diffs can still repeatedly fail to insert from Backlog to Future Work on the Differential board.
Dec 29 2016, 3:40 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report
rphl edited the content of Community Resources.
Dec 29 2016, 3:40 PM
allixsenos updated the task description for T12051: "Autoclose: Disabled" could provide a stronger hint that it means "You, the user, have disabled Autoclose by adjusting a setting.".
Dec 29 2016, 11:34 AM · Diffusion
allixsenos created T12051: "Autoclose: Disabled" could provide a stronger hint that it means "You, the user, have disabled Autoclose by adjusting a setting.".
Dec 29 2016, 11:34 AM · Diffusion
joshuaspence added a comment to T11114: Move Differential to EditEngine.

From D17067:

Dec 29 2016, 10:42 AM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
joshuaspence added projects to T11343: Generate default "Depends on" line in commit message when multiple diffs are stacked: Arcanist, Differential.
Dec 29 2016, 7:08 AM · Differential, Arcanist, Feature Request
trananhdung171 added a watcher for Community: trananhdung171.
Dec 29 2016, 6:51 AM
rayzyar awarded T2443: Make "arc cover" more powerful a The World Burns token.
Dec 29 2016, 3:48 AM · Restricted Project, Owners, Differential, Arcanist
chad added a comment to T12050: Ask a question: Only Herald-compliant file paths are shown in Mail or Diffusion .

As I mentioned over email, you'll have to update Phabricator before asking for help. That version looks at least 18-24 months old and there have been significant changes.

Dec 29 2016, 3:22 AM · Diffusion, Feature Request
ivan.wang added a comment to T12050: Ask a question: Only Herald-compliant file paths are shown in Mail or Diffusion .

thanks

Dec 29 2016, 3:22 AM · Diffusion, Feature Request
chad added a comment to T12050: Ask a question: Only Herald-compliant file paths are shown in Mail or Diffusion .

Please read Support Resources for where we take questions about Phabricator. This doesn't appear to be a feature request.

Dec 29 2016, 3:20 AM · Diffusion, Feature Request
chad closed T12050: Ask a question: Only Herald-compliant file paths are shown in Mail or Diffusion as Invalid.
Dec 29 2016, 3:19 AM · Diffusion, Feature Request
ivan.wang created T12050: Ask a question: Only Herald-compliant file paths are shown in Mail or Diffusion .
Dec 29 2016, 3:11 AM · Diffusion, Feature Request

Dec 28 2016

epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 28 2016, 10:37 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
eadler added a comment to T12049: Give EditEngine universal support for "Haunted Mode".

FWIW #Twitter has multiple users of this feature and we'd likely get complaints if it broke

Dec 28 2016, 10:25 PM · EditEngine, Differential
epriestley updated the answer wiki for Q544: Error with cURL PHP extension when running arc.
Dec 28 2016, 10:09 PM
epriestley closed Q544: Error with cURL PHP extension when running arc as resolved.
Dec 28 2016, 10:08 PM
epriestley added a comment to Q544: Error with cURL PHP extension when running arc.

You have installed multiple versions of PHP, some of which have cURL and some of which do not.

Dec 28 2016, 10:08 PM
eambutu added a comment to Q544: Error with cURL PHP extension when running arc.

Huh, when I run that, it shows PHP Version => 7.1.0. Why would this be different? I even uninstalled php7 from my computer.

Dec 28 2016, 10:03 PM
epriestley added a comment to Q544: Error with cURL PHP extension when running arc.

How about this?

Dec 28 2016, 9:54 PM
eambutu added a comment to Q544: Error with cURL PHP extension when running arc.

It returns "YES"

Dec 28 2016, 9:53 PM
epriestley added a comment to Q544: Error with cURL PHP extension when running arc.

Okay, how about this?

Dec 28 2016, 9:51 PM
eambutu added a comment to Q544: Error with cURL PHP extension when running arc.

Here:

Dec 28 2016, 9:49 PM
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 28 2016, 9:42 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a comment to Q544: Error with cURL PHP extension when running arc.

Can you show us the output of this command?

Dec 28 2016, 9:40 PM
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 28 2016, 9:23 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
eambutu updated Q544: Error with cURL PHP extension when running arc from to Error with cURL PHP extension when running arc.
Dec 28 2016, 9:18 PM
mpickering added a comment to T12038: Harbormaster scheduling should be more predictable.

Thanks for these suggestions. We only had one CI machine so these kinds of concerns about parallelism are not important for us. I enabled the options that you suggested.

Dec 28 2016, 9:09 PM · Harbormaster, Haskell.org, Feature Request
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 28 2016, 8:53 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T11114: Move Differential to EditEngine: Unknown Object (Differential Revision).
Dec 28 2016, 6:44 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a revision to T12049: Give EditEngine universal support for "Haunted Mode": Unknown Object (Differential Revision).
Dec 28 2016, 5:46 PM · EditEngine, Differential
chad added a comment to T12049: Give EditEngine universal support for "Haunted Mode".

I do use it, but not in conjunction with preview.

Dec 28 2016, 5:08 PM · EditEngine, Differential
epriestley added a comment to T12049: Give EditEngine universal support for "Haunted Mode".

Oh, there's no preference for this right now. I'll probably just keep "Z" for the moment.

Dec 28 2016, 5:07 PM · EditEngine, Differential
epriestley created T12049: Give EditEngine universal support for "Haunted Mode".
Dec 28 2016, 5:01 PM · EditEngine, Differential
johnny-bit updated Q543: Projects/subprojects "general" view from to Projects/subprojects "general" view.
Dec 28 2016, 4:49 PM
epriestley renamed T8475: Clean up remnants of old Differential hunk storage from Migrate Differential to modern hunk storage to Clean up remnants of old Differential hunk storage.
Dec 28 2016, 4:34 PM · Infrastructure, Restricted Project, Differential
epriestley closed T12032: Make sure Chrome 55 anchor issue does not impact Differential as Resolved.

We haven't received more information about this in about a week and can't reproduce it, so we can't move forward. I'm going to close this until we get new information.

Dec 28 2016, 4:31 PM · Bug Report (Needs Information), Phacility, Google Chrome, Differential
epriestley merged T12047: Harbormaster Build Plans HTTP Request add varibale phabricator url into T10517: Make Harbormaster build variables extensible.
Dec 28 2016, 4:30 PM · Harbormaster, Restricted Project, Feature Request
epriestley merged task T12047: Harbormaster Build Plans HTTP Request add varibale phabricator url into T10517: Make Harbormaster build variables extensible.
Dec 28 2016, 4:30 PM · Harbormaster, Feature Request
epriestley added a comment to T12047: Harbormaster Build Plans HTTP Request add varibale phabricator url.

I'm going to merge this into T10517 which discusses making build variables extensible. See that task for some more discussion of similar issues.

Dec 28 2016, 4:30 PM · Harbormaster, Feature Request
epriestley closed T12044: Upgrading phabricator resulted in excess tables/table data as Resolved.

Yes, this is consistent with running bin/storage upgrade from master, then switching to stable.

Dec 28 2016, 4:27 PM · Bug Report (Needs Information)
epriestley added a comment to T12046: PHPMailer RCE [CVE-2016-10033 and CVE-2016-10045].

From a cursory read of CVE-2016-10045, it seems like PHP may be written in such a way that mail() can not be invoked safely. Silly PHP!

Dec 28 2016, 8:11 AM · Mail, Security
eadler renamed T12046: PHPMailer RCE [CVE-2016-10033 and CVE-2016-10045] from PHPMailer RCE [CVE-2016-10033] to PHPMailer RCE [CVE-2016-10033 and CVE-2016-10045].
Dec 28 2016, 7:24 AM · Mail, Security
eadler added a comment to T12046: PHPMailer RCE [CVE-2016-10033 and CVE-2016-10045].

updated advisory; https://legalhackers.com/advisories/PHPMailer-Exploit-Remote-Code-Exec-CVE-2016-10045-Vuln-Patch-Bypass.html
I don't think this changes the plan you suggest, just linking for completeness.

Dec 28 2016, 7:16 AM · Mail, Security
dragoon20 added a comment to T12047: Harbormaster Build Plans HTTP Request add varibale phabricator url.

@epriestley Yes I need to make changes, I didn't say it is impossible.

Dec 28 2016, 4:07 AM · Harbormaster, Feature Request

Dec 27 2016

enckse added a comment to T12048: Ability to "globally mark" objects.

Cool, thanks!

Dec 27 2016, 10:54 PM · Feature Request
chad added a comment to T12048: Ability to "globally mark" objects.

T10855 talks about being able to update dashboard panels with content (which you install). T8145 covers broadcasting alerts, T8629 covers getting users alerted to individual things, M1473 covers upcoming changes to home/dashboards which will allow admins to globally install items onto home.

Dec 27 2016, 10:53 PM · Feature Request
chad merged T12048: Ability to "globally mark" objects into T10855: Allow external systems to edit the content of dashboard panels so they can publish information.
Dec 27 2016, 10:47 PM · Dashboards, Restricted Project, Conduit, Feature Request
chad merged task T12048: Ability to "globally mark" objects into T10855: Allow external systems to edit the content of dashboard panels so they can publish information.
Dec 27 2016, 10:47 PM · Feature Request
enckse created T12048: Ability to "globally mark" objects.
Dec 27 2016, 10:35 PM · Feature Request
epriestley added a comment to T12047: Harbormaster Build Plans HTTP Request add varibale phabricator url.

If this was available as a variable, wouldn't you have to make all those changes to Harbormaster build plans anyway? Why is it impossible to change the plans to use a constant, but possible to change them to use a variable?

Dec 27 2016, 8:02 PM · Harbormaster, Feature Request
dragoon20 added a comment to T12047: Harbormaster Build Plans HTTP Request add varibale phabricator url.

@epriestley In our current usage, we used a lot of herald rules that points to multiple harbormaster for building differential and commits.

Dec 27 2016, 7:59 PM · Harbormaster, Feature Request
epriestley edited the content of 2016 Week 52 (Very Late December).
Dec 27 2016, 7:54 PM
epriestley edited the content of 2016 Week 52 (Very Late December).
Dec 27 2016, 7:54 PM
epriestley created 2016 Week 52 (Very Late December).
Dec 27 2016, 6:42 PM
epriestley added a comment to T12047: Harbormaster Build Plans HTTP Request add varibale phabricator url.

Why does this need to be a variable? That is, why can't you just hard-code the value in place of having a variable?

Dec 27 2016, 5:56 PM · Harbormaster, Feature Request
dragoon20 created T12047: Harbormaster Build Plans HTTP Request add varibale phabricator url.
Dec 27 2016, 8:07 AM · Harbormaster, Feature Request

Dec 26 2016

chad added a comment to T12044: Upgrading phabricator resulted in excess tables/table data.

Offhand, It seems your database is on master, and code is on stable.

Dec 26 2016, 8:32 PM · Bug Report (Needs Information)
bcooksley added a project to T5000: Using Differential with plain Git, without requiring Arc: KDE.
Dec 26 2016, 8:31 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Arcanist, Differential
eFrane added a comment to T12044: Upgrading phabricator resulted in excess tables/table data.
~/phabricator$ git status
On branch stable
Your branch is up-to-date with 'origin/stable'.
nothing to commit, working directory clean
Dec 26 2016, 6:41 PM · Bug Report (Needs Information)
epriestley lowered the priority of T12046: PHPMailer RCE [CVE-2016-10033 and CVE-2016-10045] from High to Low.

This appears to be the fix:

Dec 26 2016, 4:51 PM · Mail, Security
epriestley added a comment to T1837: Implement correct send-as-user behavior..

Note that there is a Sender-related RCE in PHPMailer until Dec 2016, see T12046 for discussion.

Dec 26 2016, 4:37 PM · llvm, Restricted Project, Mail
epriestley created T12046: PHPMailer RCE [CVE-2016-10033 and CVE-2016-10045].
Dec 26 2016, 4:14 PM · Mail, Security
epriestley closed T12045: Commandeered revisions do not show original author as "Authored By" as Wontfix.

Although this wording is a little unclear, commandeering makes you the author. A more precise wording would be something like "The current author for this revision is X. It was created on Y." but that's clunky and only smooths out this particular case.

Dec 26 2016, 4:08 PM · Bug Report
plonk created T12045: Commandeered revisions do not show original author as "Authored By".
Dec 26 2016, 3:31 PM · Bug Report
• pradeepQ987 added a member for Android: • pradeepQ987.
Dec 26 2016, 1:22 PM

Dec 25 2016

Luke081515.2 closed Q542: Terminate current sessions as resolved.
Dec 25 2016, 11:35 AM · Auth
Luke081515.2 added a comment to Q542: Terminate current sessions.

ah, found it. My fault before was, that I only digged into DB phabricator_auth, but i found it now at phabricator_user, table phabricator_session.

Dec 25 2016, 11:35 AM · Auth
chad added a comment to Q542: Terminate current sessions.

No idea, where have you looked so far?

Dec 25 2016, 12:55 AM · Auth
Luke081515.2 added a comment to Q542: Terminate current sessions.

In which table can I find them?

Dec 25 2016, 12:53 AM · Auth

Dec 24 2016

epriestley added a comment to T12044: Upgrading phabricator resulted in excess tables/table data.

Can you show us the output of these commands?

Dec 24 2016, 6:13 PM · Bug Report (Needs Information)
chad added a comment to Q542: Terminate current sessions.

Delete them from the database.

Dec 24 2016, 4:47 PM · Auth
chad edited projects for T12044: Upgrading phabricator resulted in excess tables/table data, added: Bug Report (Needs Information); removed Bug Report.
Dec 24 2016, 4:46 PM · Bug Report (Needs Information)
chad added a comment to T12044: Upgrading phabricator resulted in excess tables/table data.

I have no idea how to reproduce this error. I'd guess something along the lines of take a new version of Phabricator and apply an old upgrade script, but that's really just a guess.

Dec 24 2016, 4:43 PM · Bug Report (Needs Information)
Luke081515.2 updated Q542: Terminate current sessions from to Terminate current sessions.
Dec 24 2016, 4:38 PM · Auth
hpuwang added Q498: Why Phabricator does not load CSS (Answer 492).
Dec 24 2016, 11:02 AM
eFrane updated the task description for T12044: Upgrading phabricator resulted in excess tables/table data.
Dec 24 2016, 10:51 AM · Bug Report (Needs Information)
eFrane created T12044: Upgrading phabricator resulted in excess tables/table data.
Dec 24 2016, 10:41 AM · Bug Report (Needs Information)

Dec 23 2016

mpickering added a project to T5987: "Wait for Previous Commits to Build" step is really spammy: Haskell.org.
Dec 23 2016, 11:20 PM · Haskell.org, Harbormaster, Phabricator
epriestley renamed T12038: Harbormaster scheduling should be more predictable from Harbourmaster scheduling should be more predictable. to Harbormaster scheduling should be more predictable.
Dec 23 2016, 10:19 PM · Harbormaster, Haskell.org, Feature Request
epriestley added a comment to T12038: Harbormaster scheduling should be more predictable.

See some discussion starting here:

Dec 23 2016, 10:19 PM · Harbormaster, Haskell.org, Feature Request
epriestley added a comment to T12043: Link task number and title for easier referencing via copy & paste.

Yes. I think we had a similar element at some point, but removed it in a design update some time ago because it felt visually busy/redundant, particularly across other object types. If you do a lot of copy/pasting into Google Docs, the utility might overwhelm the visual repetition, though.

Dec 23 2016, 10:07 PM · Feature Request
gwicke added a comment to T12043: Link task number and title for easier referencing via copy & paste.

@epriestley, thanks for the examples. The second variant would offer the best ergonomics for copy / pasting, but of course it would also change the rendering of the heading.

Dec 23 2016, 10:03 PM · Feature Request
epriestley added a comment to T12043: Link task number and title for easier referencing via copy & paste.

This will link both:

Dec 23 2016, 9:59 PM · Feature Request
gwicke added a comment to T12043: Link task number and title for easier referencing via copy & paste.

Concretely, since this is presumably about the WMF install and you already maintain patches, this is the one-line edit required to make the change you're asking for:

Dec 23 2016, 9:54 PM · Feature Request
epriestley closed T12043: Link task number and title for easier referencing via copy & paste as Wontfix.

Concretely, since this is presumably about the WMF install and you already maintain patches, this is the one-line edit required to make the change you're asking for:

Dec 23 2016, 9:45 PM · Feature Request
gwicke added a comment to T12043: Link task number and title for easier referencing via copy & paste.

@epriestley: Plain HTML copy / paste works with most WYSIWYG editors, both online and offline. It is also a lot more discoverable, as people are used to it just working.

Dec 23 2016, 9:25 PM · Feature Request
epriestley added a comment to T12043: Link task number and title for easier referencing via copy & paste.

One vague idea is that it may be possible to use a Google Docs plugin. The "Google Apps Script" development environment was a bit of a test in patience the last time I used it, but basically you can write "Add-Ons" and publish them to the "Google Apps Store", and then users can install them. This is sort of the starting point:

Dec 23 2016, 9:19 PM · Feature Request
chad added a comment to T12043: Link task number and title for easier referencing via copy & paste.

Or if it's helpful, I could link something else like the header/title.

Dec 23 2016, 9:12 PM · Feature Request
chad added a comment to T12043: Link task number and title for easier referencing via copy & paste.

It's not a big deal for me since I use Chrome to re-link the crumb. It's two clicks in the URL bar, or two clicks in the crumbs. But I think Safari it's 3 clicks...

Dec 23 2016, 9:06 PM · Feature Request
gwicke added a comment to T12043: Link task number and title for easier referencing via copy & paste.

I frequently link to phabricator tasks on wiki pages or in google docs. The current workflow to get a linked task number or title is rather cumbersome:

Dec 23 2016, 8:47 PM · Feature Request
epriestley closed T12039: Emails from Diffusion contain space or new line character in link making them not clickable as Resolved.

After D17103, at HEAD of master:

Dec 23 2016, 7:57 PM · Bug Report
epriestley closed T12040: Make version reporting more clear when running a fork as Resolved by committing Restricted Diffusion Commit.
Dec 23 2016, 7:42 PM · Support, Documentation
epriestley closed T12040: Make version reporting more clear when running a fork, a subtask of T12039: Emails from Diffusion contain space or new line character in link making them not clickable, as Resolved.
Dec 23 2016, 7:42 PM · Bug Report