Page MenuHomePhabricator
Feed Advanced Search

Aug 26 2016

chad added a comment to Q473: Arcanist 404 when installing certificate.

That doesn't look like a Phabricator 404 page.

Aug 26 2016, 1:39 PM
simevo created T11538: the conduit API is awkward to use when one must send arrays.
Aug 26 2016, 1:36 PM · Bug Report
avivey merged T11536: Conduit update of int-fields fails into T10456: Conduit interprets all arguments from curl requests as strings.
Aug 26 2016, 1:26 PM · Restricted Project, Conduit, Bug Report
avivey merged task T11536: Conduit update of int-fields fails into T10456: Conduit interprets all arguments from curl requests as strings.
Aug 26 2016, 1:26 PM · Bug Report
epriestley added a revision to T11524: Import-time diff generation fails for particular commits in cluster mode: Unknown Object (Differential Revision).
Aug 26 2016, 12:36 PM · Phacility, Clusters, Daemons, Diffusion
epriestley added a revision to T11537: Survive import of artificially manufactured Git commits with 64-bit timestamps: Unknown Object (Differential Revision).
Aug 26 2016, 12:24 PM · Diffusion
epriestley added a comment to T11537: Survive import of artificially manufactured Git commits with 64-bit timestamps.

Introducing an epoch64 type ends up being pretty messy:

Aug 26 2016, 12:13 PM · Diffusion
gracicot updated Q473: Arcanist 404 when installing certificate from to Arcanist 404 when installing certificate.
Aug 26 2016, 12:12 PM
epriestley added a comment to T11537: Survive import of artificially manufactured Git commits with 64-bit timestamps.

Perhaps a better solution is to introduce an epoch64 datatype and store these timestamps faithfully, since they're at least sort of possible to write and do have a relatively unambiguous meaning. Introducing a new type instead of changing the meaning of the existing epoch would let us accommodate this without requiring tons and tons of migrations or exposing us to a lot of weird fallout.

Aug 26 2016, 12:01 PM · Diffusion
epriestley added a comment to T11537: Survive import of artificially manufactured Git commits with 64-bit timestamps.
$ git cat-file commit HEAD > message.original
$ nano message.original # Adjust timestamps to crazy values.
$ git hash-object -t commit --stdin -w < message.original
23c3584bd6030c4f8b9ad9ce5419d218990b75a5
$ git reset --hard 23c3584bd6030c4f8b9ad9ce5419d218990b75a5
HEAD is now at 23c3584 Time travel! Spooky!
$ git show
commit 23c3584bd6030c4f8b9ad9ce5419d218990b75a5
Author: epriestley <git@epriestley.com>
Date:   Mon Jul 22 06:20:00 48622 -0700
Aug 26 2016, 11:59 AM · Diffusion
epriestley added a comment to T11537: Survive import of artificially manufactured Git commits with 64-bit timestamps.

After some effort, I'm unable to figure out how to generate these commits using vanilla git. I can't figure out how get them with --date or GIT_COMMITTER_DATE to git commit: dates after 2100 are treated like the current date.

Aug 26 2016, 11:53 AM · Diffusion
epriestley created T11537: Survive import of artificially manufactured Git commits with 64-bit timestamps.
Aug 26 2016, 11:39 AM · Diffusion
epriestley moved T4369: Phabricator HTTP repository hosting has fairly severe scalability limits from Backlog to v3 on the Diffusion board.
Aug 26 2016, 11:10 AM · Diffusion (v3), Restricted Project
oskari.petas2 added a comment to T10004: ApplicationEditor Errata.

I'd be interested in the Refine the workboard/form interaction idea.

Aug 26 2016, 10:50 AM · ApplicationEditor
jacob_matt created T11536: Conduit update of int-fields fails.
Aug 26 2016, 9:07 AM · Bug Report
scott.horsley awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Aug 26 2016, 3:32 AM · Workboards (v3), Restricted Project
chad added a comment to T1895: Disable live previews .

Full screen disables live previews in any remarkup box.

Aug 26 2016, 2:40 AM · User Preferences
gslin added a comment to T1895: Disable live previews .

I think this task should be reopened, because there is no way to disable live preview in desktop currently.

Aug 26 2016, 2:38 AM · User Preferences
samking added a comment to T11535: Make it possible for arc land to disable upstream branch tracking.

Developers want to push their local branches to GitHub for a variety of reasons:

  • so that if their computer dies, their work doesn't disappear
  • so that they can work across multiple machines (eg, if they have a separate computer at home vs at work, or if they have a cloud development environment separate from their local workstation)
  • to show their work to other people before sending out a Phabricator revision (which they could still do with Phabricator, but some folks feel like they should only use Phabricator once something is ready for formal review)
  • because at a previous organization, they always pushed their branches, so they're in the habit of doing it
Aug 26 2016, 1:57 AM · Arcanist, Restricted Project
epriestley added a comment to T11535: Make it possible for arc land to disable upstream branch tracking.

Why are you tracking branches you don't want to land onto?

Aug 26 2016, 1:28 AM · Arcanist, Restricted Project
epriestley added a comment to T11524: Import-time diff generation fails for particular commits in cluster mode.

The particular issue is that that the change removed a file containing the bytes ... 0xE5 0x76 .... The 0xE5 is probably an å in Latin 1.

Aug 26 2016, 1:25 AM · Phacility, Clusters, Daemons, Diffusion
epriestley added a comment to T11524: Import-time diff generation fails for particular commits in cluster mode.

I extracted the response body prior to encoding as a serialized()'d object so I can narrow down what's causing the encoding to fail and it looks reasonable, looking like it's almost certainly a UTF8 issue now.

Aug 26 2016, 1:12 AM · Phacility, Clusters, Daemons, Diffusion
epriestley added a comment to T11524: Import-time diff generation fails for particular commits in cluster mode.

Not too surprisingly, the response is empty. AphrontResponse->encodeJSONForHTTPResponse() uses json_encode() and does not detect UTF8-related encoding failures, so the chance that this is a UTF8 issue is pretty high. We should also probably fix that so fail earlier and more explicitly (and don't emit HTTP 200).

Aug 26 2016, 1:04 AM · Phacility, Clusters, Daemons, Diffusion
hach-que closed T11531: Support http.cookiefile for Diffusion mirrors as Invalid.

Oh, so for the hell of it I tried using the cookie data (it's in a username=token format) as the basic HTTP authentication credentials, and it appears to work! I have no idea why Google tries to get you to set up cookies when basic HTTP authentication works just fine.... :/

Aug 26 2016, 1:02 AM · Feature Request
epriestley added a comment to T11524: Import-time diff generation fails for particular commits in cluster mode.

The next step I want to take is figuring out what the actual problematic response body looks like, but that's slightly tricky right now because there's no way to make Conduit calls from the CLI.

Aug 26 2016, 1:00 AM · Phacility, Clusters, Daemons, Diffusion
hach-que added a comment to T11531: Support http.cookiefile for Diffusion mirrors.

There isn't really an alternative technology choice here however - not only does AWS not have an equivalent service integration of this functionality, but using AWS for this would require using EC2 for compute, which would drastically increase (e.g. double costs) elsewhere. Azure is a pile of junk in my experience, which is why I'm avoiding that service as well.

Aug 26 2016, 12:51 AM · Feature Request
samking created T11535: Make it possible for arc land to disable upstream branch tracking.
Aug 26 2016, 12:47 AM · Arcanist, Restricted Project
epriestley added a comment to T11531: Support http.cookiefile for Diffusion mirrors.

I want to avoid implementing things in Phabricator just because there's a low barrier to entry to ask us and we're responsive -- over time, this tends to punish us for being responsive by cluttering our codebase with cruft to work around weird decisions that other companies are making in their products.

Aug 26 2016, 12:47 AM · Feature Request
hach-que added a comment to T11531: Support http.cookiefile for Diffusion mirrors.

I have no idea what the technical reasons are for Google's implementation to be like this. I don't have a support contract with them (they start at US$200 a month), so I have no way of asking for them to do something different. The options for setting up a repository in their system looks like this:

Aug 26 2016, 12:22 AM · Feature Request
avivey added a comment to T10746: Aborted build in Harbormaster still shows as building in Diffusion.

I've seen this happening here too (B13428)

Aug 26 2016, 12:06 AM · Restricted Project, Harbormaster, Bug Report
avivey merged task T11528: Revision build status doesn't status when one of the build step was failed into T10746: Aborted build in Harbormaster still shows as building in Diffusion.
Aug 26 2016, 12:04 AM · Bug Report
avivey merged T11528: Revision build status doesn't status when one of the build step was failed into T10746: Aborted build in Harbormaster still shows as building in Diffusion.
Aug 26 2016, 12:04 AM · Restricted Project, Harbormaster, Bug Report

Aug 25 2016

epriestley added a comment to T11534: Repository clustering does not respect disabled bindings?.

From IRC, this might be a false positive / not the root cause since destroying the binding didn't fix the problem, but I can run through things locally.

Aug 25 2016, 11:51 PM · Almanac, Clusters
epriestley created T11534: Repository clustering does not respect disabled bindings?.
Aug 25 2016, 11:10 PM · Almanac, Clusters
epriestley added a revision to T9235: Add a warning about "always_populate_raw_post_data" being misconfigured: Unknown Object (Differential Revision).
Aug 25 2016, 10:49 PM · Contributor Onboarding, Setup
epriestley claimed T9235: Add a warning about "always_populate_raw_post_data" being misconfigured.

I was ultimately able to reproduce this, but it took some work and the instructions above definitely weren't sufficeient:

Aug 25 2016, 10:38 PM · Contributor Onboarding, Setup
epriestley added a comment to T9235: Add a warning about "always_populate_raw_post_data" being misconfigured.

Alright, let me see if I can get anywhere with this.

Aug 25 2016, 10:14 PM · Contributor Onboarding, Setup
venky added a comment to T11481: Allow customization of forms for Workboards.

A potentially less controversial fix for the 2-step entry issue might be to add a keyboard shortcut that will add a task to the last used column.

Aug 25 2016, 9:06 PM · Workboards, Feature Request
jcox added a comment to T9235: Add a warning about "always_populate_raw_post_data" being misconfigured.

I've tried a whole bunch of different post requests (after setting those config values and restarting apache) but I haven't been able to get that garbage yet.

Aug 25 2016, 8:40 PM · Contributor Onboarding, Setup
jcox closed T9117: Remove unused edges after Ponder comes out of beta as Resolved by committing Restricted Diffusion Commit.
Aug 25 2016, 8:01 PM · Contributor Onboarding, Ponder
jcox closed T9117: Remove unused edges after Ponder comes out of beta, a subtask of T6920: Move Voting in Ponder to "Helpfuls", as Resolved.
Aug 25 2016, 8:01 PM · Ponder
bgamari added a comment to T4587: Generate SSH keys for users.

GHC would also find support for importing keys from Github useful; we are currently working on rolling out a Diffusion-hosted staging area for use with Harbormaster but the need for contributors to submit their key to yet another Phab feels like unnecessary friction.

Aug 25 2016, 7:12 PM · Passphrase, Auth
chad closed T5315: Remove the "welcome.html" configuration option when Dashboards is available, a subtask of T11533: Upgrading: Changes to Default Homepage, as Resolved.
Aug 25 2016, 7:08 PM · NUX, Dashboards, Installing & Upgrading
chad closed T5315: Remove the "welcome.html" configuration option when Dashboards is available as Resolved by committing Restricted Diffusion Commit.
Aug 25 2016, 7:08 PM · Dashboards (v2)
chad added a revision to T5315: Remove the "welcome.html" configuration option when Dashboards is available: Unknown Object (Differential Revision).
Aug 25 2016, 7:07 PM · Dashboards (v2)
epriestley added a subtask for T11533: Upgrading: Changes to Default Homepage: T5315: Remove the "welcome.html" configuration option when Dashboards is available.
Aug 25 2016, 7:05 PM · NUX, Dashboards, Installing & Upgrading
epriestley added a parent task for T5315: Remove the "welcome.html" configuration option when Dashboards is available: T11533: Upgrading: Changes to Default Homepage.
Aug 25 2016, 7:05 PM · Dashboards (v2)
chad added a revision to T11533: Upgrading: Changes to Default Homepage: Unknown Object (Differential Revision).
Aug 25 2016, 7:01 PM · NUX, Dashboards, Installing & Upgrading
jcox added a revision to T9117: Remove unused edges after Ponder comes out of beta: Unknown Object (Differential Revision).
Aug 25 2016, 6:57 PM · Contributor Onboarding, Ponder
epriestley created T11533: Upgrading: Changes to Default Homepage.
Aug 25 2016, 6:22 PM · NUX, Dashboards, Installing & Upgrading
avivey added a comment to Q472: What is Differential's position on collaborative branches? (Answer 441).

I think that if you use Dependencies in revisions, arc patch will pull the dependencies as well as separate commits; Then you can do something like this:

Aug 25 2016, 5:43 PM
jcox added a revision to T8628: Modernize AphrontControllers to implement handleRequest: Unknown Object (Differential Revision).
Aug 25 2016, 5:37 PM · Contributor Onboarding, Modernization, Badge Awarded, Aphront
bjshively added a comment to T5214: Add Conduit API methods for workboards.

Just want to +1 that this would be a very useful feature for us. I think our usecase is similar: We have a lot of teams (especially ops teams) using phab workboards and columns extensively. Rather than try to shoe horn different types of reporting, etc. into phab they are relying on external systems/tools, but it is pretty painful to extract data on what column tasks currently live in.

Aug 25 2016, 5:33 PM · Restricted Project, Conduit, Maniphest, Workboards
epriestley moved T10679: When phurl.short-uri is configured, use it in the UI from Backlog to Basic on the Contributor Onboarding board.
Aug 25 2016, 5:11 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley reassigned T10679: When phurl.short-uri is configured, use it in the UI from lpriestley to jcox.

Phurl is a URL shortener. This is an amazing unique type of application which I personally invented in 2015.

Aug 25 2016, 5:10 PM · Contributor Onboarding, Restricted Project, Phurl
jcox closed T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'] as Resolved by committing Restricted Diffusion Commit.
Aug 25 2016, 5:06 PM · Contributor Onboarding, Setup
yelirekim added a comment to T11518: Make arc feature much more fancy and fun.

It relies on a server side API call so you'll have to actually extend your server install in order for it to work.

Aug 25 2016, 5:02 PM · Restricted Project, Feature Request
epriestley added a comment to T4190: Rebuild remarkup image proxying.

I've also never used seamless so I'm not sure how support looks in practice, but this isn't immediately reassuring:

Aug 25 2016, 5:00 PM · Contributor Onboarding, Remarkup
avivey added a comment to T11518: Make arc feature much more fancy and fun.

Can you share the code? :)

Aug 25 2016, 4:59 PM · Restricted Project, Feature Request
epriestley added a comment to T4190: Rebuild remarkup image proxying.

I think that only prevents referrer leaking -- it doesn't deal with the other issues in T4190#60441 (or request amplification attacks), right?

Aug 25 2016, 4:58 PM · Contributor Onboarding, Remarkup
eadler added a comment to T4190: Rebuild remarkup image proxying.

Can we avoid the need for this entirely using the approach outlined in T11126 (using CSP or <iframe seamless referrerpolicy="no-referrer">)?

Aug 25 2016, 4:57 PM · Contributor Onboarding, Remarkup
jcox added a revision to T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR']: Unknown Object (Differential Revision).
Aug 25 2016, 4:32 PM · Contributor Onboarding, Setup
chad added a revision to T11132: New Phabricator NUX: Unknown Object (Differential Revision).
Aug 25 2016, 4:29 PM · Design, Phacility, NUX
epriestley added a comment to T4190: Rebuild remarkup image proxying.

The vaguely related T5378 is also in the queue somewhere. It may not really intersect with this, but if we do end up trying to auto-embed any URI that ends in .jpg again it probably will. I'm not sure we should, but just a heads up for context.

Aug 25 2016, 4:29 PM · Contributor Onboarding, Remarkup
epriestley moved T4190: Rebuild remarkup image proxying from Backlog to Intermediate on the Contributor Onboarding board.
Aug 25 2016, 4:25 PM · Contributor Onboarding, Remarkup
epriestley reassigned T4190: Rebuild remarkup image proxying from epriestley to jcox.

The general shape of what we're trying to do here is that when a user writes the URL of an image in a comment (e.g., http://funny.lol/silly-dog.jpg, perhaps with some magic *$!symbols$*!) it would be nice to just show the image. Today, they'd have to download and re-upload it, which is somewhat cumbersome.

Aug 25 2016, 4:25 PM · Contributor Onboarding, Remarkup
yelirekim assigned T11518: Make arc feature much more fancy and fun to jcox.
In T11518#191391, @chad wrote:

which devs don't? it's the designers, isn't it.

Aug 25 2016, 4:01 PM · Restricted Project, Feature Request
yelirekim awarded T11518: Make arc feature much more fancy and fun a Pirate Logo token.
Aug 25 2016, 3:57 PM · Restricted Project, Feature Request
jcox closed T9692: Warn but continue when installing bot certificates with `arc install-certificate` as Resolved by committing Restricted Diffusion Commit.
Aug 25 2016, 3:34 PM · Contributor Onboarding, User Preferences, Arcanist
epriestley added a project to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): Contributor Onboarding.
Aug 25 2016, 3:30 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Wikimedia, Remarkup
epriestley moved T10673: Convert Phurl to use EditEngine from Backlog to Intermediate on the Contributor Onboarding board.
Aug 25 2016, 3:28 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley reassigned T10673: Convert Phurl to use EditEngine from lpriestley to jcox.
Aug 25 2016, 3:28 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley added a comment to T10673: Convert Phurl to use EditEngine.

EditEngine is a slightly different way to build forms that look the same as other forms, introduced circa January 2016. Some applications have moved to it, while others have not yet. It seems pretty reasonable and stable, though, so we're in the process of moving everything over.

Aug 25 2016, 3:28 PM · Contributor Onboarding, Restricted Project, Phurl
tycho.tatitscheff awarded T9692: Warn but continue when installing bot certificates with `arc install-certificate` a Love token.
Aug 25 2016, 3:17 PM · Contributor Onboarding, User Preferences, Arcanist
jcox added a revision to T9692: Warn but continue when installing bot certificates with `arc install-certificate`: Unknown Object (Differential Revision).
Aug 25 2016, 3:02 PM · Contributor Onboarding, User Preferences, Arcanist
epriestley moved T11532: Replace paste language selection dropdown with a typeahead from Backlog to Basic on the Contributor Onboarding board.
Aug 25 2016, 3:00 PM · Paste, Contributor Onboarding
epriestley assigned T11532: Replace paste language selection dropdown with a typeahead to jcox.
Aug 25 2016, 3:00 PM · Paste, Contributor Onboarding
epriestley added a comment to T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'].

First, let's sort of limit the direct damage this misconfiguration causes by changing this line in PhabricatorUserLog->initializeNewLog():

Aug 25 2016, 2:43 PM · Contributor Onboarding, Setup
kristo.mario added a comment to T11529: Send emails/notifications containing the link to the action on the object which triggered it.

Thanks, I guessed it's complex.

Aug 25 2016, 2:42 PM · Feature Request
• scheat added a watcher for Celerity: • scheat.
Aug 25 2016, 2:38 PM
epriestley renamed T11532: Replace paste language selection dropdown with a typeahead from Replace paste dropdown with a typeahead to Replace paste language selection dropdown with a typeahead.
Aug 25 2016, 2:34 PM · Paste, Contributor Onboarding
epriestley added a project to T10681: Add Phurl Conduit API methods : Contributor Onboarding.
Aug 25 2016, 2:33 PM · Contributor Onboarding, Restricted Project, Conduit, Phurl
epriestley added a project to T10673: Convert Phurl to use EditEngine: Contributor Onboarding.
Aug 25 2016, 2:32 PM · Contributor Onboarding, Restricted Project, Phurl
epriestley added a comment to T11529: Send emails/notifications containing the link to the action on the object which triggered it.

T7643#175911 has some discussion of this.

Aug 25 2016, 2:31 PM · Feature Request
epriestley added a comment to T11531: Support http.cookiefile for Diffusion mirrors.

Is there a valid technical reason for Google to work like this?

Aug 25 2016, 2:25 PM · Feature Request
epriestley created T11532: Replace paste language selection dropdown with a typeahead.
Aug 25 2016, 2:24 PM · Paste, Contributor Onboarding
epriestley added a comment to T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'].

Ah, nice! I'll write up some guidance on adding a setup check for this shortly.

Aug 25 2016, 2:22 PM · Contributor Onboarding, Setup
jcox added a comment to T8850: Add a setup warning to make sure users haven't wiped out $_SERVER['REMOTE_ADDR'].

Alright I was finally able to reproduce it. Calling unset($_SERVER['REMOTE_ADDR']); in the preamble didn't actually end up causing it, which is a bit strange. The only way I could get this to occur was to explicitly set $_SERVER['REMOTE_ADDR'] = null; in the preamble.

Aug 25 2016, 1:47 PM · Contributor Onboarding, Setup
jcox closed T10999: Expand MFA checks to all email operations as Resolved by committing Restricted Diffusion Commit.
Aug 25 2016, 1:01 PM · Contributor Onboarding, Security
lgazo awarded T10745: Emails are sent out about restricted changes a Like token.
Aug 25 2016, 12:05 PM · Restricted Project, Bug Report
kristo.mario added a comment to T11529: Send emails/notifications containing the link to the action on the object which triggered it.

Yes, gmail hides duplicate content and that I too see as a usability problem for Phriction where the diff is not the thing you want to see but I recon that on Maniphest you want to be lead to the section of the task which caused the notification.

Aug 25 2016, 11:23 AM · Feature Request
siepkes awarded T11518: Make arc feature much more fancy and fun a Like token.
Aug 25 2016, 10:24 AM · Restricted Project, Feature Request
ChaitanyaPramod merged T8419: `arc patch` attempts to cherry-pick already landed dependencies into T4977: arc patch fails even when cherry pick appears successful.
Aug 25 2016, 10:18 AM · Arcanist
ChaitanyaPramod merged task T8419: `arc patch` attempts to cherry-pick already landed dependencies into T4977: arc patch fails even when cherry pick appears successful.
Aug 25 2016, 10:18 AM · Restricted Project, Arcanist
ChaitanyaPramod added a comment to T4977: arc patch fails even when cherry pick appears successful.

Would love some attention on this 😇

Aug 25 2016, 10:17 AM · Arcanist
ChaitanyaPramod added a comment to T8419: `arc patch` attempts to cherry-pick already landed dependencies.

Seems to be duplicate of T4977

Aug 25 2016, 10:09 AM · Restricted Project, Arcanist
venky added a comment to T11530: Conduit query for Differential revisions mentioning a project.

Herald firing on other things: T10109

Aug 25 2016, 9:48 AM · Herald, Conduit, Differential, Feature Request
hach-que added a comment to T11529: Send emails/notifications containing the link to the action on the object which triggered it.

This would be a usability loss for us though - frequently one of the issues we have with Phriction emails is that they take you to the comparison instead of the wiki page (usually because of how Google Mail hides duplicate content). Changing the behaviour of Maniphest to do that as well would make our lives more difficult.

Aug 25 2016, 9:34 AM · Feature Request
hach-que created T11531: Support http.cookiefile for Diffusion mirrors.
Aug 25 2016, 9:29 AM · Feature Request
venky updated the task description for T11530: Conduit query for Differential revisions mentioning a project.
Aug 25 2016, 9:21 AM · Herald, Conduit, Differential, Feature Request