Page MenuHomePhabricator
Feed Advanced Search

Aug 17 2018

epriestley added a comment to T13186: Upgrading: Legacy "Can Edit <Field>" policies in Maniphest; requireCapabilities() in TransactionEditor.

I'm going to push this out to next week since D19586 probably has a few minor issues with it and it's close to the release cut. It adds a lot of new policy checks which weren't explicit before, so I'd guess it may cause a few improper policy errors on things which are actually allowed. I caught a bunch of them (like "Mute Thread") but probably didn't get every single one.

Aug 17 2018, 3:32 PM · Security, Policy, ApplicationEditor, Guides, Installing & Upgrading
epriestley updated the task description for T13186: Upgrading: Legacy "Can Edit <Field>" policies in Maniphest; requireCapabilities() in TransactionEditor.
Aug 17 2018, 3:30 PM · Security, Policy, ApplicationEditor, Guides, Installing & Upgrading

Aug 16 2018

20after4 awarded T13186: Upgrading: Legacy "Can Edit <Field>" policies in Maniphest; requireCapabilities() in TransactionEditor a Love token.
Aug 16 2018, 9:36 PM · Security, Policy, ApplicationEditor, Guides, Installing & Upgrading
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Aug 16 2018, 9:12 PM · Plans
epriestley triaged T13187: Plans: 2018 Week 34 Bonus Content as Normal priority.
Aug 16 2018, 9:12 PM · Plans
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 16 2018, 8:54 PM · Plans
epriestley added a comment to T10003: Upgrading: Maniphest field-level policies ("Can Prioritize Tasks", etc.) have been deprecated and will be removed.

These are actually removed in 2018 Week 33. See T13186 for a small amount of followup and discussion, although there isn't too much new information beyond what's here.

Aug 16 2018, 6:18 PM · Policy, Maniphest, Installing & Upgrading
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 16 2018, 6:09 PM · Plans
epriestley closed T10003: Upgrading: Maniphest field-level policies ("Can Prioritize Tasks", etc.) have been deprecated and will be removed as Resolved by committing Restricted Diffusion Commit.
Aug 16 2018, 5:51 PM · Policy, Maniphest, Installing & Upgrading
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 16 2018, 5:12 PM · Plans
epriestley triaged T13186: Upgrading: Legacy "Can Edit <Field>" policies in Maniphest; requireCapabilities() in TransactionEditor as Low priority.
Aug 16 2018, 4:01 PM · Security, Policy, ApplicationEditor, Guides, Installing & Upgrading
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Aug 16 2018, 2:59 PM · Plans
epriestley changed the visibility for T3272: Route ExecFuture stdout/stderr through the filesystem on Windows.
Aug 16 2018, 2:39 AM · Windows, Arcanist

Aug 15 2018

epriestley closed T9459: arc upgrade on Windows doesn't understand it's a git repo as Resolved by committing Restricted Diffusion Commit.
Aug 15 2018, 11:57 PM · Arcanist, Windows
epriestley updated the task description for T13183: AWS is rebooting instances in late August 2018.
Aug 15 2018, 6:43 PM · Ops, Phacility
epriestley added a revision to T9459: arc upgrade on Windows doesn't understand it's a git repo: Unknown Object (Differential Revision).
Aug 15 2018, 5:44 PM · Arcanist, Windows
epriestley edited P2108 Masterwork From Distant Lands.
Aug 15 2018, 5:33 PM
epriestley added a comment to T13062: Trying to manage anything in Gsuite is kind of not great?.

Oh, right, "meetings". I've heard of those!

Aug 15 2018, 4:56 PM · Phacility, Ops
epriestley updated the task description for T13183: AWS is rebooting instances in late August 2018.
Aug 15 2018, 4:56 PM · Ops, Phacility
20after4 added a comment to T13062: Trying to manage anything in Gsuite is kind of not great?.
Aug 15 2018, 3:04 AM · Phacility, Ops

Aug 14 2018

epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 14 2018, 11:08 PM · Plans
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 14 2018, 9:49 PM · Plans
epriestley added a comment to T13176: Differential now has a "/D123/new/" link.

This is also showing up in initial email, which is silly and pointless.

Aug 14 2018, 9:40 PM · Differential
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 14 2018, 9:37 PM · Plans
DragonBe edited the content of Organizations Using Phabricator.
Aug 14 2018, 9:35 PM
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 14 2018, 8:30 PM · Plans
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Restricted Differential Revision.
Aug 14 2018, 8:22 PM · Plans
epriestley added a revision to T10003: Upgrading: Maniphest field-level policies ("Can Prioritize Tasks", etc.) have been deprecated and will be removed: Unknown Object (Differential Revision).
Aug 14 2018, 5:52 PM · Policy, Maniphest, Installing & Upgrading
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 14 2018, 5:52 PM · Plans
epriestley added a comment to T12877: Should not allow searching for users if "Can Browse User Directory" is not allowed.

I'm touching some adjacent code for a "Disable User" permission in T13164.

Aug 14 2018, 3:49 PM · People, Security

Aug 13 2018

amckinley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: Unknown Object (Differential Revision).
Aug 13 2018, 11:42 PM · Customer Impact, Diffusion (v3)
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 13 2018, 10:40 PM · Plans
amckinley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: Unknown Object (Differential Revision).
Aug 13 2018, 10:36 PM · Customer Impact, Diffusion (v3)
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 13 2018, 10:10 PM · Plans
amckinley closed T13185: AWS Reboots Part 2, Electric Boogaloo as Resolved.

Hahah you beat me to it!

Aug 13 2018, 9:25 PM · Phacility, Ops
amckinley claimed T13183: AWS is rebooting instances in late August 2018.
Aug 13 2018, 9:25 PM · Ops, Phacility
epriestley added a comment to T13185: AWS Reboots Part 2, Electric Boogaloo.

I think T13183 is the exact same hosts. :)

Aug 13 2018, 9:24 PM · Phacility, Ops
amckinley added a comment to T13185: AWS Reboots Part 2, Electric Boogaloo.

Same as T13183?

Aug 13 2018, 9:24 PM · Phacility, Ops
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 13 2018, 9:13 PM · Plans
epriestley added a comment to T13185: AWS Reboots Part 2, Electric Boogaloo.

Same as T13183?

Aug 13 2018, 8:45 PM · Phacility, Ops
amckinley triaged T13185: AWS Reboots Part 2, Electric Boogaloo as Normal priority.
Aug 13 2018, 7:47 PM · Phacility, Ops
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Aug 13 2018, 6:46 PM · Plans
epriestley closed T13184: "Add Interface" > "Cancel" in Almanac takes you nowhere, instead of back to the device as Resolved by committing Restricted Diffusion Commit.
Aug 13 2018, 6:39 PM · Almanac
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 13 2018, 6:37 PM · Plans
epriestley updated the task description for T13183: AWS is rebooting instances in late August 2018.
Aug 13 2018, 6:14 PM · Ops, Phacility
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Aug 13 2018, 5:01 PM · Plans
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 13 2018, 4:55 PM · Plans
epriestley added a comment to T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive.

The root use case here was a desire for a better sense of how often certain rules were firing, and we improved the push logs instead to address this more directly (D19555, D19556, D19557).

Aug 13 2018, 4:53 PM · Diffusion, Herald
epriestley added a revision to T13184: "Add Interface" > "Cancel" in Almanac takes you nowhere, instead of back to the device: Unknown Object (Differential Revision).
Aug 13 2018, 4:32 PM · Almanac
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 13 2018, 4:29 PM · Plans
epriestley updated the task description for T13183: AWS is rebooting instances in late August 2018.
Aug 13 2018, 4:19 PM · Ops, Phacility
epriestley triaged T13184: "Add Interface" > "Cancel" in Almanac takes you nowhere, instead of back to the device as Low priority.
Aug 13 2018, 4:18 PM · Almanac
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Aug 13 2018, 4:00 PM · Plans
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 13 2018, 3:48 PM · Plans
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Aug 13 2018, 3:11 PM · Plans
epriestley renamed T13164: Plans: 2018 Week 31 - 33 Bonus Content from Plans: 2018 Week 31 - 32 Bonus Content to Plans: 2018 Week 31 - 33 Bonus Content.
Aug 13 2018, 3:11 PM · Plans
epriestley updated the task description for T13183: AWS is rebooting instances in late August 2018.
Aug 13 2018, 3:09 PM · Ops, Phacility
epriestley triaged T13183: AWS is rebooting instances in late August 2018 as Low priority.
Aug 13 2018, 2:30 PM · Ops, Phacility

Aug 11 2018

epriestley added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

I did rebuild-identities on every instance

Aug 11 2018, 1:56 PM · Customer Impact, Diffusion (v3)
epriestley added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

The "activity" migration went to production just now. I expect all production instances just bailed out, since I ran rebuild-identities some time ago, but I'll verify that:

Aug 11 2018, 1:53 PM · Customer Impact, Diffusion (v3)

Aug 10 2018

epriestley edited the content of Changelog.
Aug 10 2018, 9:56 PM
epriestley created 2018 Week 32 (Mid August).
Aug 10 2018, 9:54 PM
epriestley closed T12534: Differential still appears in "responsible users" query after resigning as a reviewer as Resolved.

I believe this was fixed by D17558 and discussed in T11050.

Aug 10 2018, 8:00 PM · Bug Report (Needs Information), Differential
epriestley added a comment to T13156: Plans: Improve Phacility UI for managing instance managers and cards.

Somewhat related:

Aug 10 2018, 6:10 PM · Plans, Phacility
epriestley edited projects for T8389: Allow arbitrary email addresses to be CC'd on Phacility billing emails, added: Phacility, Phortune; removed Customer Impact.
Aug 10 2018, 6:09 PM · Phortune, Phacility
epriestley moved T12171: Node is now very exciting to install on Ubuntu 14? from Backlog to Do Eventually on the Phacility board.
Aug 10 2018, 6:08 PM · Ops, Phacility, Aphlict
epriestley moved T12990: Support pact language around Autopay is misleading at best from Backlog to Near Future on the Phacility board.
Aug 10 2018, 6:06 PM · Phacility, Support
epriestley moved T12999: Replace cluster magnetic volumes with SSD volumes from Backlog to Near Future on the Phacility board.
Aug 10 2018, 6:06 PM · Phacility, Ops
epriestley moved T13062: Trying to manage anything in Gsuite is kind of not great? from Backlog to Do Eventually on the Phacility board.
Aug 10 2018, 6:06 PM · Phacility, Ops
epriestley moved T13121: Remove "-q" from SSH commands executed by `bin/remote` and similar cluster commands from Backlog to Near Future on the Phacility board.
Aug 10 2018, 6:06 PM · Phacility, Ops
epriestley moved T13146: Phacility account import tool fails to recognize usernames with differing case, e.g. "Alice" vs "alice" from Backlog to Do Eventually on the Phacility board.
Aug 10 2018, 6:06 PM · Phacility
epriestley moved T11760: Phacility Cluster: Ad-Hoc Query Log from Near Future to Eternal on the Phacility board.
Aug 10 2018, 6:06 PM · Phacility
epriestley moved T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction from Backlog to Near Future on the Phacility board.
Aug 10 2018, 6:06 PM · Plans, Ops, Infrastructure, Phacility
epriestley moved T13100: PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values from Backlog to Do Eventually on the Phacility board.
Aug 10 2018, 6:06 PM · Phacility
epriestley moved T13111: Periodically run `git prune` on Git working copies from Backlog to Do Eventually on the Phacility board.
Aug 10 2018, 6:06 PM · Phacility, Diffusion
epriestley renamed T13156: Plans: Improve Phacility UI for managing instance managers and cards from Improve Phacility UI for managing instance managers and cards to Plans: Improve Phacility UI for managing instance managers and cards.
Aug 10 2018, 6:06 PM · Plans, Phacility
epriestley moved T13156: Plans: Improve Phacility UI for managing instance managers and cards from Backlog to Near Future on the Phacility board.
Aug 10 2018, 6:05 PM · Plans, Phacility
epriestley moved T13178: Plans: Support Pact Competitive Update from Backlog to Near Future on the Phacility board.
Aug 10 2018, 6:05 PM · Plans, Support, Phacility
epriestley moved T13179: sshd with "ForceUser" does not compile on High Sierra from Backlog to Do Eventually on the Phacility board.
Aug 10 2018, 6:05 PM · Setup, Phacility
epriestley added a comment to T12171: Node is now very exciting to install on Ubuntu 14?.

T13182 was a resurgence of this exact issue, but I'm currently banking on the fix being a move to Ubuntu 16 with T13076 before this breaks again, given that it was stable for ~18 months.

Aug 10 2018, 5:26 PM · Ops, Phacility, Aphlict
epriestley closed T13182: Something in the Ubuntu environment changed, affecting node / "ws" as Resolved.

That appears to have fixed it, so this was just T12171-redux.

Aug 10 2018, 5:26 PM · Phacility, Ops
epriestley added a comment to T13182: Something in the Ubuntu environment changed, affecting node / "ws".
[secure004] Error: You need to install the Node.js "ws" module for websocket support. See "Notifications User Guide: Setup and Configuration" in the documentation for instructions. SyntaxError: Use of const in strict mode.
Aug 10 2018, 4:54 PM · Phacility, Ops
epriestley triaged T13182: Something in the Ubuntu environment changed, affecting node / "ws" as Low priority.
Aug 10 2018, 4:50 PM · Phacility, Ops

Aug 9 2018

epriestley closed T12397: `bin/ssh-auth` cache includes paths which may be (or may become) stale as Resolved by committing Restricted Diffusion Commit.
Aug 9 2018, 8:33 PM · Bug Report
epriestley added a comment to T8971: Auto-fix patch is wrong when multiple issue affect the same line.

It feels like the basis of the problem is that linting was written well without autofix in mind and then the feature was added later.

Aug 9 2018, 8:26 PM · Restricted Project, Arcanist
amckinley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: Unknown Object (Differential Revision).
Aug 9 2018, 7:32 PM · Customer Impact, Diffusion (v3)
amckinley created U41 Rebuild Repository Identities.
Aug 9 2018, 7:05 PM
cmoore added a comment to T8971: Auto-fix patch is wrong when multiple issue affect the same line.

It feels like the basis of the problem is that linting was written well without autofix in mind and then the feature was added later. It wasn't designed in from the beginning and that results in limitations where compromises were/are necessary. Unfortunately, this means users sometimes end up with unexpected or unintuitive behaviors. I think we're all just trying to find ways to mitigate them.

Aug 9 2018, 3:20 PM · Restricted Project, Arcanist
avivey added a comment to T13178: Plans: Support Pact Competitive Update.

A related score-board might be to show mana-rich tasks.

Aug 9 2018, 3:17 AM · Plans, Support, Phacility
epriestley awarded T13180: AWS is rebooting sbuild001.phacility.net on August 15, 2018 a Party Time token.
Aug 9 2018, 12:07 AM · Phacility, Ops
epriestley added a comment to T13121: Remove "-q" from SSH commands executed by `bin/remote` and similar cluster commands.

One specific thing we hit in the context of T13180: sbuild001 stopped and started with a new public IP, and the Almanac device record needed to be updated with the new address.

Aug 9 2018, 12:05 AM · Phacility, Ops
amckinley closed T13180: AWS is rebooting sbuild001.phacility.net on August 15, 2018 as Resolved.

This was more fun than expected. Notes for future historians:

Aug 9 2018, 12:04 AM · Phacility, Ops

Aug 8 2018

amckinley added a comment to T13180: AWS is rebooting sbuild001.phacility.net on August 15, 2018.

Doing this now.

Aug 8 2018, 10:58 PM · Phacility, Ops
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Restricted Differential Revision.
Aug 8 2018, 6:30 PM · Plans
epriestley added a comment to T13164: Plans: 2018 Week 31 - 33 Bonus Content.

See PHI790, which reports an inconsistency in reporting between APCu and APC that possibly points at a more significant issue.

Aug 8 2018, 6:24 PM · Plans
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Aug 8 2018, 6:07 PM · Plans
epriestley added a comment to T8971: Auto-fix patch is wrong when multiple issue affect the same line.

re-archetect the patch application to operate per linter or per issue rather than after completing all analysis

Aug 8 2018, 5:57 PM · Restricted Project, Arcanist
epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Aug 8 2018, 5:21 PM · Plans
epriestley added a revision to T12397: `bin/ssh-auth` cache includes paths which may be (or may become) stale: Unknown Object (Differential Revision).
Aug 8 2018, 5:21 PM · Bug Report
cmoore added a comment to T8971: Auto-fix patch is wrong when multiple issue affect the same line.

Here's an example:

Aug 8 2018, 5:01 PM · Restricted Project, Arcanist