Page MenuHomePhabricator

cmoore (Chad Moore)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Aug 7 2018, 9:55 PM (298 w, 12 h)
Availability
Available

Recent Activity

Aug 29 2018

cmoore added a comment to T8971: Auto-fix patch is wrong when multiple issue affect the same line.

I'm going to try to rewrite our linters to emit minimal fixes and try that
out. I do think that will make the conflicts nearly nonexistent.

I think adding the "requirements of a custom linter" and possibly also
adding verification of original text matching the byte range for fix
application should still be addressed, though.

Aug 29 2018, 2:54 PM · Restricted Project, Arcanist

Aug 9 2018

cmoore added a comment to T8971: Auto-fix patch is wrong when multiple issue affect the same line.

It feels like the basis of the problem is that linting was written well without autofix in mind and then the feature was added later. It wasn't designed in from the beginning and that results in limitations where compromises were/are necessary. Unfortunately, this means users sometimes end up with unexpected or unintuitive behaviors. I think we're all just trying to find ways to mitigate them.

Aug 9 2018, 3:20 PM · Restricted Project, Arcanist

Aug 8 2018

cmoore added a comment to T8971: Auto-fix patch is wrong when multiple issue affect the same line.

Here's an example:

Aug 8 2018, 5:01 PM · Restricted Project, Arcanist
cmoore added a comment to T8971: Auto-fix patch is wrong when multiple issue affect the same line.

This appears to still be open.

Aug 8 2018, 3:50 PM · Restricted Project, Arcanist