Page MenuHomePhabricator

Implement "Phabricator Stories"
Closed, ResolvedPublic

Assigned To
Authored By
epriestley
Mar 22 2017, 7:38 PM
Tags
None
Referenced Files
F4252697: stories_ui.png
Mar 22 2017, 7:45 PM
F4252533: Face-You-Make-Robert-Downey-Jr.jpg
Mar 22 2017, 7:41 PM
Tokens
"Dat Boi" token, awarded by jcox."Dat Boi" token, awarded by phil.

Description

I don't understand what this feature is or how it would work, but users are adamant that they want it:

https://www.facebook.com/epriestley/posts/10103819872786169
https://twitter.com/philltopia/status/844631650956828672

Event Timeline

I think pictures are part of a "story"? We can have users upload pictures and take pictures with phones. There doesn't seem to be a native CLI way to get Macbooks to take photos but we can make users brew install imagesnap, it seems, and then arc could update stories.

The UI should probably look like this (not 100% final/polished yet):

stories_ui.png (1×1 px, 287 KB)

I view this as a really effective mechanism to ensure timely code review. Don't review my diff within 24 hours? Poof, code is deleted.

you expect Fb to cherry-pick it?

Do you even have Cat Facts internally yet?

That would be revealing whether or not FB has already been internally A/B testing precisely this on engineers.

I think this would be easy as a menu-item, really. Main issue is what criteria to pick for the stories.

@epriestley: Evidently imagesnap no longer works on macOS 10.11 "El Capitan":

http://apple.stackexchange.com/a/270968

I found this Python script which works out of the box, barring a pesky exception:

http://stackoverflow.com/a/4903076/7572003

Does anyone actually use the "Stories" feature in one of the other things that implements it (Excel, Settings.app, Disk Recovery Utility, etc)? Why is it compelling?

Why do users view other users' stories instead of spending that time looking at /r/prequelmemes? (Or: does no one actually read stories, and this is purely about publishing?)

Why do stories vanish after 24 hours if they're being used to produce a photo album of a fun camping trip with your friends like the Snapchat blog post suggests? (Or: are they actually all just sex stuff? Snapchat is like 95% sex stuff and 5% brand advertisements, right?)

If there's any good content in this feature at all, why do I never see it reposted to Reddit or Facebook or Twitter? Are Reddit and Twitter just for old people now?

I got the python script working by changing "w" to "wb" like a comment suggested, but I'm only getting all-black bitmaps out of it.

In my view, Stories products encourage out-of-band collaboration where the original product falls short. For example Instagram has a "best self forward" impression that causes users to artificially constrain posting. Instagram Stories combats this with its ephemerality and whimsy. It's a "back door" without having to fix the root problems in the main product.

By that logic, Phabricator Stories should encourage code discussions in places where formal code reviews are failing — perhaps they are too slow, or people are afraid to have appropriately honest discussions because everything is permanent, or the bar for getting something into a review is high and that artificially constrains the conversations we could be having about code that never gets committed. I'm sure there are other things we could improve.

In this framework, Stories should be about code, not photos. But we could also introduce filters to make your code look better than it really is.

@epriestley: Yeah, I think the brightness level is off. I got a very dark picture as well, although it wasn't all-black.

Hmm, I could definitely see "Philters" in the near future! Imagine the sponsorship opportunities to add Branded Comments™ via Phabricator® Philters™.

I 😍 love staying in touch with my favorite brands. 🎁

@phillco - Is this for like, seeing code reviews that haven't had active participation in while? So users could see what's not being reviewed and lend a hand? Under the assumption that the "most-qualified" stakeholders (or Owners?) are already reviewers/subscribers of a code change but aren't being active, how effective would others' review be?

It sounds like the idea is to make "active work" be more discoverable. It sounds interesting, but not sure what immediate benefits are.

If there's any good content in this feature at all, why do I never see it reposted to Reddit or Facebook or Twitter? Are Reddit and Twitter just for old people now?

Yes, Reddit and Twitter are just for old people now. And Facebook was already the dominion of the elderly, but this is stating the obvious.

epriestley claimed this task.

I don't really see a pathway to turn this into a particularly useful and/or hilarious feature that has enough of a payoff to justify the legwork.