Page MenuHomePhabricator

[ARCUNIT] Set the ConfigurationManager of ConfigurationDrivenUnitTestEngines
ClosedPublic

Authored by tmcjilton on Jun 5 2018, 8:30 PM.
Tags
None
Referenced Files
F14166722: D19465.id46560.diff
Sat, Dec 7, 6:34 AM
Unknown Object (File)
Mon, Dec 2, 7:36 PM
Unknown Object (File)
Sat, Nov 30, 4:04 PM
Unknown Object (File)
Thu, Nov 21, 7:50 PM
Unknown Object (File)
Thu, Nov 21, 2:52 PM
Unknown Object (File)
Tue, Nov 19, 4:27 PM
Unknown Object (File)
Nov 3 2024, 10:15 AM
Unknown Object (File)
Oct 15 2024, 10:05 PM
Subscribers

Details

Summary

The Configuration Manager is supported by ArcanistUnitTestEngine but not support by the ArcanistConfigurationDrivenUnitTestEngine.

Added the configuration manager as one of the initially set properties of an ArcUnitTestEngine created by the ArcanistConfigurationDrivenTestEngine

Test Plan

Ran arc unit against a project without the change, verified the Configuration was none. Added this change and ran again and verified it was set

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Thanks! I added a CLA exemption for you and added you to Community (granting you sweeping janitorial powers) and Blessed Committers (so you should be able to land this yourself). See that project's detail page for instructions, and yell if you run into issues.

This revision is now accepted and ready to land.Jun 5 2018, 8:46 PM

(For future archaeology, see also PHI694.)

This revision was automatically updated to reflect the committed changes.