Differential D12620

Add GoFmt linter
Needs ReviewPublic
Actions

Authored by eMxyzptlk on Apr 30 2015, 5:43 AM.

Tags

None

Referenced Files

	F15461580: D12620.id.diff
	Tue, Apr 1, 9:22 AM

	F15459943: D12620.diff
	Mon, Mar 31, 6:35 PM

	F15452302: D12620.id30302.diff
	Sat, Mar 29, 3:42 AM

	F15444072: D12620.diff
	Thu, Mar 27, 7:43 AM

	F15440834: D12620.id.diff
	Wed, Mar 26, 2:53 PM

	F15401414: D12620.diff
	Mon, Mar 17, 5:32 PM

	F15381353: D12620.diff
	Fri, Mar 14, 7:13 AM

	F15331738: D12620.diff
	Fri, Mar 7, 1:15 PM

Subscribers

Tokens

"Like" token, awarded by jcox."Like" token, awarded by sectioneightinc.

Details

Reviewers

None

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6867: Add linter and unit test engine for Go(lang)

Summary

Unlike GoLint or GoVet, Gofmt formats Go programs. It uses tabs (width= 8) for indentation and blanks for alignment.

Refs T6867

Test Plan

All of the unit tests are derived from real Go files that were formatted by gofmt.

Diff Detail

Repository

Branch

gofmt-linter

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/lint/linter/__tests__/gofmt/big-program-with-many-issues.lint-test:5	TXT2	Tab Literal
Error	src/lint/linter/__tests__/gofmt/extra-new-line.lint-test:7	TXT2	Tab Literal
Error	src/lint/linter/__tests__/gofmt/space-instead-of-tab.lint-test:16	TXT2	Tab Literal

Unit

Tests Passed

Build Status

Buildable 5604
Build 5623: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

eMxyzptlk updated this revision to Diff 30302.Apr 30 2015, 5:43 AM

eMxyzptlk retitled this revision from to Add GoFmt linter.

eMxyzptlk updated this object.

eMxyzptlk edited the test plan for this revision. (Show Details)

eMxyzptlk added a reviewer: Blessed Reviewers.

eMxyzptlk added a task: T6867: Add linter and unit test engine for Go(lang).

eMxyzptlk added subscribers: sectioneight, joshuaspence, epriestley, ox.

Herald edited edge metadata. · View Herald TranscriptApr 30 2015, 5:43 AM

• sectioneightinc awarded a token.Apr 30 2015, 5:49 AM

eMxyzptlk updated this object.Apr 30 2015, 5:54 AM

eMxyzptlk edited edge metadata.

eMxyzptlk mentioned this in Z1336: General Chat.Apr 30 2015, 8:31 PM

• ryansking added a subscriber: • ryansking.Jul 29 2015, 6:34 PM

epriestley mentioned this in T10038: Plan the mid-term pathway for unit-test/linter bindings.Dec 22 2015, 12:59 PM

otto.bretz added a subscriber: otto.bretz.Jan 19 2016, 3:09 PM

jcox awarded a token.May 3 2017, 3:18 PM

jcox added a subscriber: jcox.

hskiba added a subscriber: hskiba.Jan 14 2021, 9:39 AM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

4 lines

lint/

linter/

ArcanistGoFmtLinter.php

106 lines

__tests__/

ArcanistGoFmtLinterTestCase.php

7 lines

gofmt/

big-program-with-many-issues.lint-test

32 lines

extra-new-line.lint-test

18 lines

space-instead-of-tab.lint-test

17 lines

Diff 30302

src/__phutil_library_map__.php

Loading...

src/lint/linter/ArcanistGoFmtLinter.php

Loading...

src/lint/linter/tests/ArcanistGoFmtLinterTestCase.php

Loading...

src/lint/linter/tests/gofmt/big-program-with-many-issues.lint-test

Loading...

src/lint/linter/tests/gofmt/extra-new-line.lint-test

Loading...

src/lint/linter/tests/gofmt/space-instead-of-tab.lint-test

Loading...