Page MenuHomePhabricator

Set project's ObjectName to its PHID when it doesn't have a hashtag
ClosedPublic

Authored by jcox on May 1 2017, 1:19 PM.
Tags
None
Referenced Files
F18343313: D17807.diff
Tue, Aug 26, 7:40 AM
F18219143: D17807.id.diff
Tue, Aug 19, 11:04 AM
F18083255: D17807.diff
Tue, Aug 5, 9:27 AM
F17891544: D17807.id.diff
Tue, Jul 29, 4:02 AM
F17831014: D17807.diff
Jul 26 2025, 11:36 AM
F17675190: D17807.diff
Jul 13 2025, 8:24 AM
Unknown Object (File)
Jun 20 2025, 3:19 AM
Unknown Object (File)
May 29 2025, 9:18 AM
Subscribers

Details

Summary

Fixes T12659. Previously this would lead to an error when trying to run arc diff on a revision that had a milestone as a reviewer (or any non-octothorpe'd Object Name)

Test Plan

Followed repro steps in T12659 and didn't get the error described. Also clicked around and didn't notice any obvious regressions in projects or differential

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable