Page MenuHomePhabricator

Set project's ObjectName to its PHID when it doesn't have a hashtag
ClosedPublic

Authored by jcox on May 1 2017, 1:19 PM.
Tags
None
Referenced Files
F17675190: D17807.diff
Sun, Jul 13, 8:24 AM
Unknown Object (File)
Jun 20 2025, 3:19 AM
Unknown Object (File)
May 29 2025, 9:18 AM
Unknown Object (File)
May 7 2025, 9:38 AM
Unknown Object (File)
Apr 25 2025, 6:12 AM
Unknown Object (File)
Apr 23 2025, 11:13 PM
Unknown Object (File)
Apr 12 2025, 1:50 PM
Unknown Object (File)
Apr 11 2025, 4:08 PM
Subscribers

Details

Summary

Fixes T12659. Previously this would lead to an error when trying to run arc diff on a revision that had a milestone as a reviewer (or any non-octothorpe'd Object Name)

Test Plan

Followed repro steps in T12659 and didn't get the error described. Also clicked around and didn't notice any obvious regressions in projects or differential

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable