Page MenuHomePhabricator

Pass exception to PhutilProxyException
ClosedPublic

Authored by jcox on Feb 10 2017, 5:30 PM.
Tags
None
Referenced Files
F14136608: D17335.id.diff
Mon, Dec 2, 8:53 PM
Unknown Object (File)
Fri, Nov 29, 5:33 PM
Unknown Object (File)
Tue, Nov 26, 7:03 AM
Unknown Object (File)
Mon, Nov 25, 7:23 PM
Unknown Object (File)
Fri, Nov 22, 1:24 PM
Unknown Object (File)
Mon, Nov 18, 4:11 AM
Unknown Object (File)
Sat, Nov 16, 10:20 PM
Unknown Object (File)
Thu, Nov 14, 12:11 AM
Subscribers

Details

Summary

Fixes T12243. That error occured due to network flakiness with some mounted filesystems so I'm not sure how best to simulate it. But you can look and see that the PhutilProxyException does indeed expect an exception as its second arg.

Test Plan

Look at method signature... look at callsite... now back at the method. Smile and nod.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable