Page MenuHomePhabricator
Feed Advanced Search

Sep 25 2017

avivey updated the diff for D18583: Make PHUITwoColumnView a little more printable.

Check if I'm set up currectly re:staging...

Sep 25 2017, 6:55 PM

Sep 23 2017

avivey added a comment to T4348: Provide a workflow for "auditing a codebase" via Nuance or some new tool.

For record-keeping, this was asked again in https://discourse.phabricator-community.org/t/469

Sep 23 2017, 8:38 PM · Diffusion

Sep 14 2017

avivey added a comment to T9821: Allow Harbormaster build plans to run on branch push instead of per-commit.

(Mentioned in https://discourse.phabricator-community.org/t/run-herald-rule-for-each-push/299)

Sep 14 2017, 11:27 AM · Restricted Project, Harbormaster

Sep 10 2017

avivey added a comment to D18583: Make PHUITwoColumnView a little more printable.

I'd guess your origin is a GitHub fork or something?

Sep 10 2017, 4:16 AM

Sep 9 2017

avivey added a comment to D18583: Make PHUITwoColumnView a little more printable.

The build failure looks like some setup issue - it failed to start.

Sep 9 2017, 4:07 AM
avivey updated the test plan for D18583: Make PHUITwoColumnView a little more printable.
Sep 9 2017, 3:54 AM
avivey created D18583: Make PHUITwoColumnView a little more printable.
Sep 9 2017, 3:53 AM

Sep 4 2017

avivey added a comment to T12923: Settings Forms, EditEngine instructions are visually confusing.

If that suggestion looks valid, I'd be happy to implement it (I'm thinking "Add RemarkupCaption into Control, render above actual field", and maybe "migrate Caption field to use that too").

Sep 4 2017, 9:13 PM · Design
avivey renamed T12923: Settings Forms, EditEngine instructions are visually confusing from Settings Forms instructions are visually confusing to Settings Forms, EditEngine instructions are visually confusing.
Sep 4 2017, 9:09 PM · Design

Aug 28 2017

avivey accepted D18481: Widen blame age line in blame view.
Aug 28 2017, 6:31 PM

Aug 27 2017

avivey awarded T12963: Aggregate similar stories in Feed, Notifications and Timelines a 100 token.
Aug 27 2017, 8:03 PM · Transactions
avivey added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

I could totally be imagining that.

Aug 27 2017, 4:30 AM · Diffusion, Design
avivey added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

If it matters, my laptop is actually 13" with 1080, but it's only because the store said they don't have a smaller version.

Aug 27 2017, 4:26 AM · Diffusion, Design

Aug 26 2017

avivey updated the task description for T6008: Editing files and contributing changes via web.
Aug 26 2017, 9:08 PM · Restricted Project, Wikimedia, Diffusion, Differential

Aug 25 2017

avivey accepted D18472: Some header tag icons are too small.

¯\_(ツ)_/¯

Aug 25 2017, 2:19 AM
avivey accepted D18471: Dont send an email when someone views a Phame post.

I'm assuming this is called for each xaction type?

Aug 25 2017, 1:57 AM
avivey added a comment to Blog Post: Advanced Internet Usage (Experts ONLY!).

not editing, just got here from email + clicked "view history".

Aug 25 2017, 1:46 AM

Aug 22 2017

avivey awarded D18448: Update Diffusion File UI for single column a Love token.
Aug 22 2017, 12:14 AM

Aug 20 2017

avivey added a comment to D18342: Update Settings to use full side-navigation.

Is this "normal side navigation" used anywhere else? It looks a little strange:

image.png (443×432 px, 24 KB)

Aug 20 2017, 7:53 AM

Aug 11 2017

avivey added a comment to T12961: [CVE-2017-1000117, et al] Git, Mercurial and Subversion could all execute arbitrary commands when interacting with malicious SSH URIs (`ssh://-...`).

Thanks for the writeup :)

Aug 11 2017, 7:04 PM · Subversion, Mercurial, Git, Security
avivey added a comment to T12961: [CVE-2017-1000117, et al] Git, Mercurial and Subversion could all execute arbitrary commands when interacting with malicious SSH URIs (`ssh://-...`).

So, all three major VCS had the exact same CVE, which was "we invoke ssh command line, don't sanitize input, and don't specify -- anywhere"?

Aug 11 2017, 2:53 AM · Subversion, Mercurial, Git, Security

Aug 10 2017

avivey awarded D18383: Fix a hang in fancy date picker for Ye Olde Time Years a Pterodactyl token.
Aug 10 2017, 5:44 PM
avivey created T12960: fancy date picker breaks browser if year < 1970.
Aug 10 2017, 8:19 AM · Bug Report

Aug 6 2017

avivey updated the task description for T10038: Plan the mid-term pathway for unit-test/linter bindings.
Aug 6 2017, 6:51 PM · Lint, Arcanist

Aug 2 2017

avivey created T12947: Hard to detect typos in *.edit endpoints.
Aug 2 2017, 5:21 AM · Conduit, ApplicationEditor

Jul 31 2017

avivey accepted D18305: Consolidate binary (hg, git, svn) analysis code into one place.

😀

Jul 31 2017, 8:46 PM
avivey added a comment to D18305: Consolidate binary (hg, git, svn) analysis code into one place.

Also Pygmentize and nodejs?

Jul 31 2017, 7:52 PM
avivey awarded T12942: Add a "Binary Versions" page to Config a 100 token.
Jul 31 2017, 7:50 PM · Config

Jul 29 2017

avivey added a comment to T11456: Don't lose user in NUX flow because of Timezone issues.

I was thinking that the first time they log in, we just take the browser timezone and set the user config to that.

Jul 29 2017, 3:46 AM · Design, Phacility, NUX

Jul 27 2017

avivey added reviewers for D18283: Improve Amazon SES code error handling behavior further: epriestley, chad, amckinley.
Jul 27 2017, 9:22 PM
avivey created T12940: Account Setup Issues shown to users before signing TOS.
Jul 27 2017, 9:21 PM
avivey added inline comments to D18283: Improve Amazon SES code error handling behavior further.
Jul 27 2017, 8:51 AM
avivey created D18283: Improve Amazon SES code error handling behavior further.
Jul 27 2017, 7:34 AM
tmakarios awarded T12933: Legalpad "Updated" date is wrong a Like token.
Jul 27 2017, 12:57 AM · Restricted Project, Bug Report

Jul 25 2017

avivey closed T12690: phpcs linter report No such linter standard as Invalid.
Jul 25 2017, 2:54 AM

Jul 24 2017

avivey added a comment to T12933: Legalpad "Updated" date is wrong.

ok, that explains the Versions field - it appears only to increase when updating the Body and not the Preamble.

Jul 24 2017, 11:45 PM · Restricted Project, Bug Report
avivey created T12933: Legalpad "Updated" date is wrong.
Jul 24 2017, 11:34 PM · Restricted Project, Bug Report

Jul 22 2017

avivey renamed T12923: Settings Forms, EditEngine instructions are visually confusing from Forms instructions are visually confusing to Settings Forms instructions are visually confusing.
Jul 22 2017, 12:56 AM · Design

Jul 21 2017

avivey committed rP27a243cd882f: Link to docs from metamta.mail-adapter config (authored by avivey).
Link to docs from metamta.mail-adapter config
Jul 21 2017, 12:51 AM
avivey closed D18259: Link to docs from metamta.mail-adapter config by committing rP27a243cd882f: Link to docs from metamta.mail-adapter config.
Jul 21 2017, 12:51 AM
avivey added a comment to D18259: Link to docs from metamta.mail-adapter config.

Ok, so that was one hack too many :)

Jul 21 2017, 12:51 AM
avivey updated the diff for D18259: Link to docs from metamta.mail-adapter config.

Renamed the upstream to check sanity

Jul 21 2017, 12:50 AM
avivey added a comment to D18259: Link to docs from metamta.mail-adapter config.

Did I go to far over the bend for this?

Jul 21 2017, 12:47 AM
avivey added a comment to D18259: Link to docs from metamta.mail-adapter config.

Yeah, I renamed origin to upstream, and (it's the only remote right now).

Jul 21 2017, 12:46 AM
avivey added a comment to D18259: Link to docs from metamta.mail-adapter config.
REPOSITORY
To identify the repository associated with this working copy, arc followed this process:
Jul 21 2017, 12:43 AM
avivey added a comment to D18259: Link to docs from metamta.mail-adapter config.

I got a SKIP STAGING Unable to determine repository for this change. warning, which I think was supposed to say "unable to determine staging repository...", which I'm not sure why, because it knows it's rP?

Jul 21 2017, 12:40 AM
avivey created D18259: Link to docs from metamta.mail-adapter config.
Jul 21 2017, 12:38 AM

Jul 18 2017

avivey accepted D18236: More adjustments to bug reporting document.
Jul 18 2017, 6:31 PM
avivey committed rPd1f144b214df: Fix Search Application Config (authored by avivey).
Fix Search Application Config
Jul 18 2017, 5:45 PM
avivey closed D18230: Fix Search Application Config by committing rPd1f144b214df: Fix Search Application Config.
Jul 18 2017, 5:45 PM
avivey closed T12924: Applications -> Search -> Configure is fataling as Resolved by committing rPd1f144b214df: Fix Search Application Config.
Jul 18 2017, 5:45 PM · Bug Report

Jul 17 2017

avivey created D18230: Fix Search Application Config.
Jul 17 2017, 11:43 PM
avivey added a revision to T12924: Applications -> Search -> Configure is fataling: D18230: Fix Search Application Config.
Jul 17 2017, 11:43 PM · Bug Report
avivey accepted D18229: Update Bug Report diviner document.

It might also make sense to update U15 to point to the new thing.

Jul 17 2017, 11:29 PM
avivey created T12924: Applications -> Search -> Configure is fataling.
Jul 17 2017, 8:47 PM · Bug Report
avivey created T12923: Settings Forms, EditEngine instructions are visually confusing.
Jul 17 2017, 12:25 AM · Design

Jul 14 2017

avivey closed Q636: GUI editor for Phriction as resolved.
Jul 14 2017, 3:03 PM

Jul 13 2017

avivey added Q636: GUI editor for Phriction (Answer 558).
Jul 13 2017, 10:19 PM

Jul 12 2017

avivey added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

Also, have you tried looking around the git community? I was always under the impression that SSH should be faster than HTTPS cloning, or possibly using the same protocol.

Jul 12 2017, 7:09 PM · Feature Request

Jul 8 2017

avivey added a comment to T10183: Allow Herald to add a comment to a Maniphest task.

Methinks that the Rube Goldberg solution for this would be to get unittest.skip to have another argument with a task number, and then validate with lint/runtime that it look like T1234. And then maybe grep the body of the ticket for the filename.

Jul 8 2017, 4:03 AM · Herald, Feature Request

Jul 5 2017

avivey added a comment to T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors.

Don't most places consider "Can Edit" to be weaker than "Can View"?

Jul 5 2017, 10:04 PM · Phame, Policy, Bug Report
avivey closed T12897: Ambiguous URL rejection broke commit importing as Invalid.
Jul 5 2017, 3:16 AM · Bug Report
avivey added a comment to T12897: Ambiguous URL rejection broke commit importing.

Is that a bad url that's contained in the commit message? Is the commit message literally Change the recognised url from showcase://?ITEM_ID to showcase://item/ITEM_ID where ITEMID is the ID of the showcase item?

Jul 5 2017, 3:14 AM · Bug Report

Jul 4 2017

avivey added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

So probably, the actionables here are "Allow HTTPS in Phacility"?

Jul 4 2017, 3:49 AM · Feature Request
avivey added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

It looks like it's the same speed?

Jul 4 2017, 2:46 AM · Feature Request

Jul 3 2017

avivey updated the task description for T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs.
Jul 3 2017, 6:14 PM · Arcanist, Bug Report

Jul 2 2017

avivey closed T12889: Phabricator Setup Error as Invalid.

We don't maintain that instance. Please contact llvm.org directly for it.

Jul 2 2017, 5:43 PM · Bug Report

Jun 30 2017

avivey added a comment to T12856: Evaluate various "infrastructure-as-code" products.

costanzapopcorn

Jun 30 2017, 11:35 PM · Ops, Phacility

Jun 29 2017

avivey closed T11539: Phabricator Mercurial Repo “too many files open” error as Resolved.

Probably resolved.

Jun 29 2017, 4:32 AM · Bug Report
avivey added a comment to T12876: Improve initial arc land experience when destination repo is empty.

in T6722#197239 I had the same problem with "land revision from Web UI" :)

Jun 29 2017, 4:26 AM · Arcanist

Jun 28 2017

avivey added a comment to T12877: Should not allow searching for users if "Can Browse User Directory" is not allowed.

I can't think of any solution to this short of full policy + complex policy rules such as "users that share project/space/payment account/instance with this user", which is complex (and probably slow to compute, or requires lots of extra stuff to maintain).

Jun 28 2017, 6:40 PM · People, Security
avivey added Q630: I'd like to use the snazzy eye icon for a mattermost webhook, but it's served rather indirectly. (Answer 553).
Jun 28 2017, 1:07 AM

Jun 27 2017

avivey created T12877: Should not allow searching for users if "Can Browse User Directory" is not allowed.
Jun 27 2017, 9:13 PM · People, Security

Jun 24 2017

avivey edited the content of Organizations Using Phabricator.
Jun 24 2017, 6:45 PM

Jun 22 2017

avivey added a subtask for T9287: Working with many repositories: T12866: Batch repository editing or repository groups for shared access control settings.
Jun 22 2017, 7:26 PM · Restricted Project, Restricted Project, Diffusion
avivey added a parent task for T12866: Batch repository editing or repository groups for shared access control settings: T9287: Working with many repositories.
Jun 22 2017, 7:26 PM · Diffusion, Feature Request
avivey closed T12863: adasdasdasdasd as Spite.
Jun 22 2017, 6:46 AM · Feature Request (Needs Information), Bug Report

Jun 21 2017

avivey added inline comments to D18143: New icons for repositories.
Jun 21 2017, 9:29 PM

Jun 20 2017

avivey committed rPHU900873b4a4c5: Modernize editor selector (authored by avivey).
Modernize editor selector
Jun 20 2017, 12:18 AM
avivey closed D18141: Modernize editor selector by committing rPHU900873b4a4c5: Modernize editor selector.
Jun 20 2017, 12:18 AM

Jun 19 2017

avivey created D18141: Modernize editor selector.
Jun 19 2017, 10:53 PM

Jun 18 2017

avivey awarded D18133: Remove dialog from "Mark All Read" notifications a Baby Tequila token.
Jun 18 2017, 6:32 PM
avivey accepted D18130: Use visibility hidden on remarkup checkboxes.
Jun 18 2017, 7:53 AM

Jun 17 2017

avivey added a project to T12850: Checklists with dangling checkboxes overflow onto subsequent text: Remarkup.
Jun 17 2017, 2:14 AM · Remarkup, Bug Report
avivey renamed T12849: No way to have an empty row in a remarkup table from Remarkup parser ignores blank table rows to No way to have an empty row in a remarkup table.
Jun 17 2017, 1:47 AM · Remarkup, Bug Report
avivey moved T12849: No way to have an empty row in a remarkup table from Backlog to Tables on the Remarkup board.
Jun 17 2017, 1:46 AM · Remarkup, Bug Report

Jun 15 2017

avivey updated subscribers of Q627: What is the SSH fingerprint of vault.phacility.com?.

@chad, @epriestley - I think this is a reasonable question.

Jun 15 2017, 9:30 PM · Phacility
avivey renamed T11138: mail is not delivered if metamta.placeholder-to-recipient is null from metamta.placeholder-to-recipient doesn't upgrade CCs to To as it says so. [With more info] to mail is not delivered if metamta.placeholder-to-recipient is null.
Jun 15 2017, 9:23 PM · Mail, Bug Report
avivey added a comment to T11138: mail is not delivered if metamta.placeholder-to-recipient is null.

I'm not sure I understand something:

Jun 15 2017, 8:57 PM · Mail, Bug Report
janitorial awarded T12840: (maybe) bring back commit graphs in history a Burninate token.
Jun 15 2017, 8:16 PM · Design, Diffusion

Jun 13 2017

avivey added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

(I've extracted the graph issue to T12840)

Jun 13 2017, 9:42 PM · Diffusion, Design
avivey created T12840: (maybe) bring back commit graphs in history.
Jun 13 2017, 9:41 PM · Design, Diffusion
avivey added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

Equally valuable as "what branches contain that commit" is "what commits are in the branches we care about". For us, the answer to this is the commit graph -- it's a succinct, easy to understand representation of our branches and their relationships.

I get that if you only have one primary branch, there's not much value in the commit graph. Similarly, if you're not linearising history, your commit graph will be so messy as to be meaningless. But if you do have the requirement to actively maintain several releases of some B2B software package and have a well defined branching strategy for your team to make this happen, then the commit graph is meaningful and unexpected merges will stick out.

Jun 13 2017, 6:57 PM · Diffusion, Design
avivey added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

I think we have it documented somewhere that "we have developers who refuse to learn git" is considered a bad reason to ask for a feature, and you should maybe consider solving this issue with some workflow changes.
Note also that in your link, epriestley says

In projects which do not linearize history with arc land + squash merges, I believe this feature is virtually useless because many commits are merges and visualizing the repository isn't very informative (the history has so many parent/child relationships that none of them convey much of anything).

Jun 13 2017, 7:43 AM · Diffusion, Design

Jun 12 2017

avivey added a comment to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery.

Two questions pick at me:

  1. Which editor did the user use to add the ZWS in? Any editor I remember does something to warn you about it.
  2. Why are there Unicode characters for "goat" (🐐) and for "cooked rice" (🍚)?
Jun 12 2017, 10:27 PM · Differential
avivey added a comment to T12831: Update compare page with more features.

T929 is probably the earliest request for this feature :)

Jun 12 2017, 9:49 PM · Design, Diffusion

Jun 11 2017

avivey added a comment to T12825: Allow setting of an image per repository.

Maybe every object should allow a cover image then?

Jun 11 2017, 9:40 PM · Design, Diffusion
avivey added a comment to T12822: Replace Differential ZWS "oncopy" behavior with a grand Javascript sorcery.

I think that ArcanistTextLinter actually checks for ASCII right now, so it should be easy to enable for this case. See also D6050, which discusses selecting encoding for it.

Jun 11 2017, 7:19 PM · Differential
avivey changed the visibility for D6050: Adds an option to ArcanistTextLinter to permit non-ASCII charsets..
Jun 11 2017, 7:19 PM
avivey added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

also, T8407 maybe fits here? I think it's mostly a UI issue now.

Jun 11 2017, 7:16 PM · Diffusion, Design