Paths

Table of Contentst

Improve Amazon SES code error handling behavior further
Needs ReviewPublic
Actions

Authored by avivey on Jul 27 2017, 7:34 AM.

Tags

None

Referenced Files

	F15457034: D18283.id43970.diff
	Sun, Mar 30, 1:53 PM

	F15455445: D18283.id.diff
	Sun, Mar 30, 12:26 AM

	F15451672: D18283.diff
	Fri, Mar 28, 11:17 PM

	F15434684: D18283.id43970.diff
	Tue, Mar 25, 4:55 AM

	F15412521: D18283.id43970.diff
	Wed, Mar 19, 1:26 PM

	F15396261: D18283.diff
	Sun, Mar 16, 1:02 PM

	F15379375: D18283.id43970.diff
	Thu, Mar 13, 8:37 PM

	Unknown Object (File)
	Feb 21 2025, 2:34 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley
chad
amckinley

Group Reviewers

Blessed Reviewers

Summary

If SES gives an error message, pull it into the exception.

Test Plan

Send computer back in time, ./bin/worker execute, see useful message.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 17812
Build 23922: Run Core Tests
Build 23921: arc lint + arc unit

Event Timeline

avivey created this revision.Jul 27 2017, 7:34 AM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 27 2017, 7:34 AM

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster completed remote builds in B17812: Diff 43970.Jul 27 2017, 7:35 AM

avivey added inline comments.Jul 27 2017, 8:51 AM

externals/amazon-ses/ses.php
520–522	Can this blow up if the XML isn't built correctly?

avivey added reviewers: epriestley, chad, amckinley.Jul 27 2017, 9:22 PM

amckinley resigned from this revision.Apr 24 2018, 4:40 PM

Herald added a subscriber: Korvin. · View Herald TranscriptApr 24 2018, 4:40 PM

Revision Contents
Changeset List

Path

Size

externals/

amazon-ses/

ses.php

43 lines

Diff 43970

View Options

externals/amazon-ses/ses.php

Improve Amazon SES code error handling behavior furtherNeeds ReviewPublicActions